87704 2012-05-28 23:58:29 -0700 [GTK] Add return value information to WebKitWebView::load-failed signal documentation 2012-05-29 01:08:37 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot oldest_to_newest 635648 0 cgarcia 2012-05-28 23:58:29 -0700 It's missing 635649 1 144462 cgarcia 2012-05-28 23:59:54 -0700 Created attachment 144462 Patch 635652 2 webkit.review.bot 2012-05-29 00:02:50 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 635695 3 cgarcia 2012-05-29 01:08:37 -0700 Committed r118732: <http://trac.webkit.org/changeset/118732> 144462 2012-05-28 23:59:54 -0700 2012-05-29 00:34:51 -0700 Patch wk2-load-failed-return.diff text/plain 1420 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyYzcyOTVhLi43MDUwYTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMDUtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEFkZCByZXR1cm4gdmFsdWUgaW5mb3JtYXRpb24gdG8gV2ViS2l0 V2ViVmlldzo6bG9hZC1mYWlsZWQgc2lnbmFsIGRvY3VtZW50YXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NzA0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJWaWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KToKKwog MjAxMi0wNS0yNSAgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGplc3VzLnBhbGVuY2lhQG9wZW5i b3NzYS5vcmc+CiAKICAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyB0byBzdXBwb3J0IGxh eW91dFRlc3RDb250cm9sbGVyLnNldEphdmFTY3JpcHRQcm9maWxpbmdFbmFibGVkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4 IDc3ZWY2YzEuLjRjMmFjM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCkBAIC01MDksNiArNTA5LDkgQEAgc3RhdGljIHZvaWQg d2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0NsYXNzKiB3ZWJWaWV3Q2xh c3MpCiAgICAgICoKICAgICAgKiBCeSBkZWZhdWx0LCBpZiB0aGUgc2lnbmFsIGlzIG5vdCBoYW5k bGVkLCBhIHN0b2NrIGVycm9yIHBhZ2Ugd2lsbCBiZSBkaXNwbGF5ZWQuCiAgICAgICogWW91IG5l ZWQgdG8gaGFuZGxlIHRoZSBzaWduYWwgaWYgeW91IHdhbnQgdG8gcHJvdmlkZSB5b3VyIG93biBl cnJvciBwYWdlLgorICAgICAqCisgICAgICogUmV0dXJuczogJVRSVUUgdG8gc3RvcCBvdGhlciBo YW5kbGVycyBmcm9tIGJlaW5nIGludm9rZWQgZm9yIHRoZSBldmVudC4KKyAgICAgKiAgICAlRkFM U0UgdG8gcHJvcGFnYXRlIHRoZSBldmVudCBmdXJ0aGVyLgogICAgICAqLwogICAgIHNpZ25hbHNb TE9BRF9GQUlMRURdID0KICAgICAgICAgZ19zaWduYWxfbmV3KCJsb2FkLWZhaWxlZCIsCg==