87696 2012-05-28 23:22:19 -0700 [FileAPI] Miss FileList test 2012-05-29 21:43:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 li.yin webkit-unassigned abarth ap haraken jianli webkit.review.bot oldest_to_newest 635609 0 li.yin 2012-05-28 23:22:19 -0700 The FileList related test cases are missed, it's necessary to add the attribute test in LayoutTests. 635617 1 144455 li.yin 2012-05-28 23:32:25 -0700 Created attachment 144455 Patch 635693 2 144455 kinuko 2012-05-29 01:07:00 -0700 Comment on attachment 144455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144455&action=review Nice to see tests for this! (Drive-by comment, I'm not a reviewer) > LayoutTests/fast/files/file-list-test.html:16 > + debug("files.length: " + files.length); Might be nicer to use shouldBe() family to make expected values clearer? 635703 3 144455 haraken 2012-05-29 01:17:14 -0700 Comment on attachment 144455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144455&action=review The change looks OK. > LayoutTests/fast/files/file-list-test.html:17 > + debug("files.item(0): " + files.item(0)); Nit: Maybe we want to pass more than two files for testing? > LayoutTests/fast/files/file-list-test.html:32 > +function runTests() > +{ > + eventSender.beginDragWithFiles(['resources/UTF8.txt']); > + eventSender.mouseMoveTo(10, 10); > + eventSender.mouseUp(); > +} > + > +if (window.eventSender) { > + layoutTestController.dumpAsText(); > + window.onload = runTests; > +} I guess you can simplify the code. - You do not need to call layoutTestController.dumpAsText(). - You can write the <script> after </body>, by which you can avoid hooking window.onload. 635733 4 144477 li.yin 2012-05-29 01:49:41 -0700 Created attachment 144477 Patch 635734 5 li.yin 2012-05-29 01:51:42 -0700 (In reply to comment #2) > (From update of attachment 144455 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144455&action=review > > Nice to see tests for this! (Drive-by comment, I'm not a reviewer) > > > LayoutTests/fast/files/file-list-test.html:16 > > + debug("files.length: " + files.length); > > Might be nicer to use shouldBe() family to make expected values clearer? Okay, thanks. 635737 6 li.yin 2012-05-29 01:52:52 -0700 (In reply to comment #3) > (From update of attachment 144455 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144455&action=review > > The change looks OK. > > > LayoutTests/fast/files/file-list-test.html:17 > > + debug("files.item(0): " + files.item(0)); > > Nit: Maybe we want to pass more than two files for testing? Add two files in the List > > > LayoutTests/fast/files/file-list-test.html:32 > > +function runTests() > > +{ > > + eventSender.beginDragWithFiles(['resources/UTF8.txt']); > > + eventSender.mouseMoveTo(10, 10); > > + eventSender.mouseUp(); > > +} > > + > > +if (window.eventSender) { > > + layoutTestController.dumpAsText(); > > + window.onload = runTests; > > +} > > I guess you can simplify the code. > > - You do not need to call layoutTestController.dumpAsText(). > - You can write the <script> after </body>, by which you can avoid hooking window.onload. Simply the code, done. Thanks for your review. 635740 7 144477 haraken 2012-05-29 01:55:52 -0700 Comment on attachment 144477 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144477&action=review > LayoutTests/fast/files/file-list-test.html:7 > +<input type="file" name="file" id="file" multiple onchange="onInputFileChange(this.files)"> Nit: name="file" and id="file" are not needed. > LayoutTests/fast/files/file-list-test.html:18 > + shouldBeTrue("files.item(0) instanceof File"); Also you can test files.item(0).name and files.item(1).name to check if the correct files are stored? shouldBeEqualToString('files.item(0).name', 'resources/UTF8.txt'); shouldBeEqualToString('files.item(1).name', 'resources/UTF8-2.txt'); > LayoutTests/fast/files/file-list-test.html:20 > + finishJSTest(); You can remove this. 635917 8 144531 li.yin 2012-05-29 05:42:49 -0700 Created attachment 144531 Patch 635919 9 144532 li.yin 2012-05-29 05:46:41 -0700 Created attachment 144532 Patch 635921 10 li.yin 2012-05-29 05:50:13 -0700 (In reply to comment #7) > (From update of attachment 144477 [details]) change="onInputFileChange(this.files)"> > > Nit: name="file" and id="file" are not needed. > Done > > LayoutTests/fast/files/file-list-test.html:18 > > + shouldBeTrue("files.item(0) instanceof File"); > > Also you can test files.item(0).name and files.item(1).name to check if the correct files are stored? > > shouldBeEqualToString('files.item(0).name', 'resources/UTF8.txt'); > shouldBeEqualToString('files.item(1).name', 'resources/UTF8-2.txt'); > Done. But it should be shouldBeEqualToString('files.item(0).name', 'UTF8.txt'); File.name is merely the name of the file, without path information :) > > LayoutTests/fast/files/file-list-test.html:20 > > + finishJSTest(); > > You can remove this. Done Thanks for your review. 635929 11 144532 haraken 2012-05-29 06:09:36 -0700 Comment on attachment 144532 Patch OK! 636096 12 144532 webkit.review.bot 2012-05-29 09:18:11 -0700 Comment on attachment 144532 Patch Clearing flags on attachment: 144532 Committed r118787: <http://trac.webkit.org/changeset/118787> 636097 13 webkit.review.bot 2012-05-29 09:18:16 -0700 All reviewed patches have been landed. Closing bug. 636257 14 144532 jianli 2012-05-29 11:20:13 -0700 Comment on attachment 144532 Patch Thanks for adding test cases for FileList. Here're some minor comments that you could consider addressing them in another patch. View in context: https://bugs.webkit.org/attachment.cgi?id=144532&action=review > LayoutTests/fast/files/file-list-test.html:22 > + shouldBeNull("files.item(999)"); Could you please also add some more tests to cover the cases that 2, null, or undefined is passed as index. Please also test the scenario that no file is selected. 636386 15 ap 2012-05-29 13:28:03 -0700 EventSender.beginDragWithFiles is not supported by WebKitTestRunner. Skipped the test for WebKit2 in <http://trac.webkit.org/changeset/118825>. 636831 16 li.yin 2012-05-29 21:43:48 -0700 (In reply to comment #14) > (From update of attachment 144532 [details]) > Thanks for adding test cases for FileList. Here're some minor comments that you could consider addressing them in another patch. > > View in context: https://bugs.webkit.org/attachment.cgi?id=144532&action=review > > > LayoutTests/fast/files/file-list-test.html:22 > > + shouldBeNull("files.item(999)"); > > Could you please also add some more tests to cover the cases that 2, null, or undefined is passed as index. > There is a bug about the negative index, https://bugs.webkit.org/show_bug.cgi?id=77899 If we want to support negative index, I think the FileList.idl will be changed, and maybe the behavior will be different when the index is null, undefined.(I am not sure.) So, currently, I only cover the expected index. And it will be improved in the bug77899. > Please also test the scenario that no file is selected. 144455 2012-05-28 23:32:25 -0700 2012-05-29 01:49:30 -0700 Patch bug-87696-20120530143600.patch text/plain 2520 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjMzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGM5ODkxNzgwYmNhMmM1NGY2MDI1 NmRiZGRjZDlmZmM5NmEyZGM5YS4uMWIzMTMzMGYzN2VlM2RjNjdjMzA1OWRmZjQxZjJjYjJlZGNj YzcxNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI5ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIFtGaWxlQVBJXSBNaXNzIEZpbGVMaXN0IHRlc3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3Njk2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IHNob3VsZCBo YXZlIHRoZSB0ZXN0IHRvIHRyYWNrIHRoZSBhdHRyaWJ1dGUgb2YgRmlsZUxpc3QuCisKKyAgICAg ICAgKiBmYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0y NyAgVGFrYXNoaSBTYWthbW90byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgZmFzdC9k b20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1tZWRpYS5odG1sIGlzIHdyb25nLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0LWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi44MjY1OGU1NzYyMjc3YWFlOGI4OTU2MTgzMGYxNTE5MzM1OWFlMmI0Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwxNiBAQAorCitUZXN0IHRoZSBhdHRyaWJ1dGUgb2YgRmlsZUxpc3Qu CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitTdGFydAorZmlsZXMubGVuZ3RoOiAxCitmaWxlcy5p dGVtKDApOiBbb2JqZWN0IEZpbGVdCitmaWxlcy5pdGVtKDk5OSk6IG51bGwKK1BBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDdjMGNkNGVjODVlYzNiMWQy MmM0MzJhMzEwZGY3YzU2OTNmNmM5NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZmlsZXMvZmlsZS1saXN0LXRlc3QuaHRtbApAQCAtMCwwICsxLDM2IEBACis8IURPQ1RZUEUg aHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGlucHV0IHR5cGU9ImZpbGUi IG5hbWU9ImZpbGUiIGlkPSJmaWxlIiBvbmNoYW5nZT0ib25JbnB1dEZpbGVDaGFuZ2UodGhpcy5m aWxlcykiPgorPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3QgdGhlIGF0dHJpYnV0ZSBvZiBGaWxl TGlzdC4iKTsKKworZnVuY3Rpb24gb25JbnB1dEZpbGVDaGFuZ2UoZmlsZXMpCit7CisgICAgZGVi dWcoIlN0YXJ0Iik7CisgICAgZGVidWcoImZpbGVzLmxlbmd0aDogIiArIGZpbGVzLmxlbmd0aCk7 CisgICAgZGVidWcoImZpbGVzLml0ZW0oMCk6ICIgKyBmaWxlcy5pdGVtKDApKTsKKyAgICBkZWJ1 ZygiZmlsZXMuaXRlbSg5OTkpOiAiICsgZmlsZXMuaXRlbSg5OTkpKTsKKyAgICBmaW5pc2hKU1Rl c3QoKTsKK30KKworZnVuY3Rpb24gcnVuVGVzdHMoKQoreworICAgIGV2ZW50U2VuZGVyLmJlZ2lu RHJhZ1dpdGhGaWxlcyhbJ3Jlc291cmNlcy9VVEY4LnR4dCddKTsKKyAgICBldmVudFNlbmRlci5t b3VzZU1vdmVUbygxMCwgMTApOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKK30KKworaWYg KHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1Rl eHQoKTsKKyAgICB3aW5kb3cub25sb2FkID0gcnVuVGVzdHM7Cit9Cis8L3NjcmlwdD4KKzxzY3Jp cHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4K 144477 2012-05-29 01:49:41 -0700 2012-05-29 05:42:40 -0700 Patch bug-87696-20120530165315.patch text/plain 2401 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjMzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGM5ODkxNzgwYmNhMmM1NGY2MDI1 NmRiZGRjZDlmZmM5NmEyZGM5YS4uMWIzMTMzMGYzN2VlM2RjNjdjMzA1OWRmZjQxZjJjYjJlZGNj YzcxNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI5ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIFtGaWxlQVBJXSBNaXNzIEZpbGVMaXN0IHRlc3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3Njk2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IHNob3VsZCBo YXZlIHRoZSB0ZXN0IHRvIHRyYWNrIHRoZSBhdHRyaWJ1dGUgb2YgRmlsZUxpc3QuCisKKyAgICAg ICAgKiBmYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0y NyAgVGFrYXNoaSBTYWthbW90byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgZmFzdC9k b20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1tZWRpYS5odG1sIGlzIHdyb25nLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0LWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi44OTY3M2VmODk3YzY2ZDE4YjRjOTIzMjAwYmNlYTYwNDgyNGNiZWQxCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwxMyBAQAorCitUZXN0IHRoZSBhdHRyaWJ1dGUgb2YgRmlsZUxpc3Qu CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworU3RhcnQKK1BBU1MgZmlsZXMubGVuZ3Ro IGlzIDIKK1BBU1MgZmlsZXMuaXRlbSgwKSBpbnN0YW5jZW9mIEZpbGUgaXMgdHJ1ZQorUEFTUyBm aWxlcy5pdGVtKDk5OSkgaXMgbnVsbAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvZmls ZS1saXN0LXRlc3QuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvZmlsZS1saXN0LXRlc3Qu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi41NWRkOGUwYTE1MDZhM2NkY2Y3MzhiOWZhNzI2OTY0Yjc0MGQzNDRm Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVz dC5odG1sCkBAIC0wLDAgKzEsMzAgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+Cis8aW5wdXQgdHlwZT0iZmlsZSIgbmFtZT0iZmlsZSIgaWQ9ImZpbGUi IG11bHRpcGxlIG9uY2hhbmdlPSJvbklucHV0RmlsZUNoYW5nZSh0aGlzLmZpbGVzKSI+Cis8ZGl2 IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3Jp cHQ+CitkZXNjcmlwdGlvbigiVGVzdCB0aGUgYXR0cmlidXRlIG9mIEZpbGVMaXN0LiIpOworCitm dW5jdGlvbiBvbklucHV0RmlsZUNoYW5nZShmaWxlcykKK3sKKyAgICB3aW5kb3cuZmlsZXMgPSBm aWxlczsKKyAgICBkZWJ1ZygiU3RhcnQiKTsKKyAgICBzaG91bGRCZSgiZmlsZXMubGVuZ3RoIiwg IjIiKTsKKyAgICBzaG91bGRCZVRydWUoImZpbGVzLml0ZW0oMCkgaW5zdGFuY2VvZiBGaWxlIik7 CisgICAgc2hvdWxkQmVOdWxsKCJmaWxlcy5pdGVtKDk5OSkiKTsKKyAgICBmaW5pc2hKU1Rlc3Qo KTsKK30KKworZXZlbnRTZW5kZXIuYmVnaW5EcmFnV2l0aEZpbGVzKFsncmVzb3VyY2VzL1VURjgu dHh0JywgJ3Jlc291cmNlcy9VVEY4LTIudHh0J10pOworZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8o MTAsIDEwKTsKK2V2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8 c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8 L2h0bWw+Cg== 144531 2012-05-29 05:42:49 -0700 2012-05-29 05:46:32 -0700 Patch bug-87696-20120530204624.patch text/plain 2682 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjMzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGM5ODkxNzgwYmNhMmM1NGY2MDI1 NmRiZGRjZDlmZmM5NmEyZGM5YS4uMWIzMTMzMGYzN2VlM2RjNjdjMzA1OWRmZjQxZjJjYjJlZGNj YzcxNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI5ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIFtGaWxlQVBJXSBNaXNzIEZpbGVMaXN0IHRlc3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3Njk2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IHNob3VsZCBo YXZlIHRoZSB0ZXN0IHRvIHRyYWNrIHRoZSBhdHRyaWJ1dGUgb2YgRmlsZUxpc3QuCisKKyAgICAg ICAgKiBmYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0y NyAgVGFrYXNoaSBTYWthbW90byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgZmFzdC9k b20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1tZWRpYS5odG1sIGlzIHdyb25nLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0LWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi4wN2FjODcwZWRiMzkyOWNhNGEwMzcyNWI0ZjA2YTI4MTU4OWVlYzc3Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwxNiBAQAorCitUZXN0IHRoZSBhdHRyaWJ1dGUgb2YgRmlsZUxpc3Qu CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworU3RhcnQKK1BBU1MgZmlsZXMubGVuZ3Ro IGlzIDIKK1BBU1MgZmlsZXMuaXRlbSgwKSBpbnN0YW5jZW9mIEZpbGUgaXMgdHJ1ZQorUEFTUyBm aWxlcy5pdGVtKDApLm5hbWUgaXMgIlVURjgudHh0IgorUEFTUyBmaWxlcy5pdGVtKDEpIGluc3Rh bmNlb2YgRmlsZSBpcyB0cnVlCitQQVNTIGZpbGVzLml0ZW0oMSkubmFtZSBpcyAiVVRGOC0yLnR4 dCIKK1BBU1MgZmlsZXMuaXRlbSg5OTkpIGlzIG51bGwKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2ZpbGUt bGlzdC10ZXN0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMGM2NWE0MmU3NTY0YjY1YmNiODM0MWJjZTA0NmJm ZDY5YzE5NTZiOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvZmls ZS1saXN0LXRlc3QuaHRtbApAQCAtMCwwICsxLDMyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGlucHV0IHR5cGU9ImZpbGUiIG5hbWU9ImZpbGUi IGlkPSJmaWxlIiBtdWx0aXBsZSBvbmNoYW5nZT0ib25JbnB1dEZpbGVDaGFuZ2UodGhpcy5maWxl cykiPgorPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9k aXY+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3QgdGhlIGF0dHJpYnV0ZSBvZiBGaWxlTGlz dC4iKTsKKworZnVuY3Rpb24gb25JbnB1dEZpbGVDaGFuZ2UoZmlsZXMpCit7CisgICAgd2luZG93 LmZpbGVzID0gZmlsZXM7CisgICAgZGVidWcoIlN0YXJ0Iik7CisgICAgc2hvdWxkQmUoImZpbGVz Lmxlbmd0aCIsICIyIik7CisgICAgc2hvdWxkQmVUcnVlKCJmaWxlcy5pdGVtKDApIGluc3RhbmNl b2YgRmlsZSIpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnZmlsZXMuaXRlbSgwKS5uYW1l JywgJ1VURjgudHh0Jyk7CisgICAgc2hvdWxkQmVUcnVlKCJmaWxlcy5pdGVtKDEpIGluc3RhbmNl b2YgRmlsZSIpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnZmlsZXMuaXRlbSgxKS5uYW1l JywgJ1VURjgtMi50eHQnKTsKKyAgICBzaG91bGRCZU51bGwoImZpbGVzLml0ZW0oOTk5KSIpOwor fQorCitldmVudFNlbmRlci5iZWdpbkRyYWdXaXRoRmlsZXMoWydyZXNvdXJjZXMvVVRGOC50eHQn LCAncmVzb3VyY2VzL1VURjgtMi50eHQnXSk7CitldmVudFNlbmRlci5tb3VzZU1vdmVUbygxMCwg MTApOworZXZlbnRTZW5kZXIubW91c2VVcCgpOworCis8L3NjcmlwdD4KKzwvYm9keT4KKzxzY3Jp cHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvaHRt bD4K 144532 2012-05-29 05:46:41 -0700 2012-05-29 11:20:13 -0700 Patch bug-87696-20120530205016.patch text/plain 2660 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjMzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGM5ODkxNzgwYmNhMmM1NGY2MDI1 NmRiZGRjZDlmZmM5NmEyZGM5YS4uMWIzMTMzMGYzN2VlM2RjNjdjMzA1OWRmZjQxZjJjYjJlZGNj YzcxNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI5ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIFtGaWxlQVBJXSBNaXNzIEZpbGVMaXN0IHRlc3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3Njk2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IHNob3VsZCBo YXZlIHRoZSB0ZXN0IHRvIHRyYWNrIHRoZSBhdHRyaWJ1dGUgb2YgRmlsZUxpc3QuCisKKyAgICAg ICAgKiBmYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0y NyAgVGFrYXNoaSBTYWthbW90byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgZmFzdC9k b20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1tZWRpYS5odG1sIGlzIHdyb25nLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0LWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi4wN2FjODcwZWRiMzkyOWNhNGEwMzcyNWI0ZjA2YTI4MTU4OWVlYzc3Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9maWxlLWxpc3QtdGVzdC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwxNiBAQAorCitUZXN0IHRoZSBhdHRyaWJ1dGUgb2YgRmlsZUxpc3Qu CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworU3RhcnQKK1BBU1MgZmlsZXMubGVuZ3Ro IGlzIDIKK1BBU1MgZmlsZXMuaXRlbSgwKSBpbnN0YW5jZW9mIEZpbGUgaXMgdHJ1ZQorUEFTUyBm aWxlcy5pdGVtKDApLm5hbWUgaXMgIlVURjgudHh0IgorUEFTUyBmaWxlcy5pdGVtKDEpIGluc3Rh bmNlb2YgRmlsZSBpcyB0cnVlCitQQVNTIGZpbGVzLml0ZW0oMSkubmFtZSBpcyAiVVRGOC0yLnR4 dCIKK1BBU1MgZmlsZXMuaXRlbSg5OTkpIGlzIG51bGwKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2ZpbGVzL2ZpbGUtbGlzdC10ZXN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2ZpbGUt bGlzdC10ZXN0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDM5NGVjYTk1OWExZDczMDc5YzA1YTZmOGQwYTQ5 MzE5ODhhZmI5ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvZmls ZS1saXN0LXRlc3QuaHRtbApAQCAtMCwwICsxLDMyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGlucHV0IHR5cGU9ImZpbGUiIG11bHRpcGxlIG9u Y2hhbmdlPSJvbklucHV0RmlsZUNoYW5nZSh0aGlzLmZpbGVzKSI+Cis8ZGl2IGlkPSJkZXNjcmlw dGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlw dGlvbigiVGVzdCB0aGUgYXR0cmlidXRlIG9mIEZpbGVMaXN0LiIpOworCitmdW5jdGlvbiBvbklu cHV0RmlsZUNoYW5nZShmaWxlcykKK3sKKyAgICB3aW5kb3cuZmlsZXMgPSBmaWxlczsKKyAgICBk ZWJ1ZygiU3RhcnQiKTsKKyAgICBzaG91bGRCZSgiZmlsZXMubGVuZ3RoIiwgIjIiKTsKKyAgICBz aG91bGRCZVRydWUoImZpbGVzLml0ZW0oMCkgaW5zdGFuY2VvZiBGaWxlIik7CisgICAgc2hvdWxk QmVFcXVhbFRvU3RyaW5nKCdmaWxlcy5pdGVtKDApLm5hbWUnLCAnVVRGOC50eHQnKTsKKyAgICBz aG91bGRCZVRydWUoImZpbGVzLml0ZW0oMSkgaW5zdGFuY2VvZiBGaWxlIik7CisgICAgc2hvdWxk QmVFcXVhbFRvU3RyaW5nKCdmaWxlcy5pdGVtKDEpLm5hbWUnLCAnVVRGOC0yLnR4dCcpOworICAg IHNob3VsZEJlTnVsbCgiZmlsZXMuaXRlbSg5OTkpIik7Cit9CisKK2V2ZW50U2VuZGVyLmJlZ2lu RHJhZ1dpdGhGaWxlcyhbJ3Jlc291cmNlcy9VVEY4LnR4dCcsICdyZXNvdXJjZXMvVVRGOC0yLnR4 dCddKTsKK2V2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDEwLCAxMCk7CitldmVudFNlbmRlci5tb3Vz ZVVwKCk7CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNl cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9odG1sPgo=