87690 2012-05-28 20:02:11 -0700 [Chromium] Cannot show suggestions when using asynchronous spellchecking 2012-05-29 02:11:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hbono webkit-unassigned morrita tkent webkit.review.bot oldest_to_newest 635525 0 hbono 2012-05-28 20:02:11 -0700 Greetings, Due to Chromium Change r137831 <http://crrev.com/137831>, Chromium does not attach suggestions to markers when using asynchronous spellchecking. That is, Chromium always shows "no suggestions" when running Chromium with an "--enable-asynchronous-spellchecking" option and right-clicking a misspelled word, e.g. "thisis". To fix this issue, would it be possible to use local spellcheckers as a fallback method when a marker doss not include suggestions? Regards, Hironori Bono 635534 1 144434 hbono 2012-05-28 20:17:33 -0700 Created attachment 144434 Patch v0 Greetings Morita-san and Tamura-san, Sorry for disturbing you. Would it be possible to review this small change? Regards, Hironori Bono 635546 2 144434 morrita 2012-05-28 21:00:10 -0700 Comment on attachment 144434 Patch v0 View in context: https://bugs.webkit.org/attachment.cgi?id=144434&action=review The code looks good. Please fix typos before landing. > Source/WebKit/chromium/ChangeLog:8 > + This change uses WebSpellCheckClient::spellcheck as a follback method to s/follback/fallback > Source/WebKit/chromium/ChangeLog:11 > + afford to attach suggestions to all Spelling markers.) s/Spelling/spelling 635557 3 144440 hbono 2012-05-28 21:31:44 -0700 Created attachment 144440 Patch v1 (fixed typos) Morita-san, Many thank for your quick review and finding typos. I have uploaded a new change that fixed them. Regards, Hironori Bono 635757 4 144440 webkit.review.bot 2012-05-29 02:11:01 -0700 Comment on attachment 144440 Patch v1 (fixed typos) Clearing flags on attachment: 144440 Committed r118740: <http://trac.webkit.org/changeset/118740> 635758 5 webkit.review.bot 2012-05-29 02:11:08 -0700 All reviewed patches have been landed. Closing bug. 144434 2012-05-28 20:17:33 -0700 2012-05-29 00:36:47 -0700 Patch v0 issue87690-patch0.txt text/plain 2227 hbono SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTg3MTUpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA1LTI4ICBIaXJvbm9yaSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFVzZSBXZWJTcGVsbENoZWNrQ2xpZW50OjpzcGVsbGNoZWNrIHRvIHJldHJpZXZlIHN1 Z2dlc3Rpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODc2OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGNoYW5nZSB1c2VzIFdlYlNwZWxsQ2hlY2tDbGllbnQ6OnNwZWxsY2hlY2sgYXMgYSBm b2xsYmFjayBtZXRob2QgdG8KKyAgICAgICAgcmV0cmlldmUgc3VnZ2VzdGlvbnMgd2hlbiBhIG1h cmtlciBkb2VzIG5vdCBoYXZlIGFueSBzdWdnZXN0aW9ucy4gKEl0IGNvbnN1bWVzCisgICAgICAg IGxvdHMgb2YgQ1BVIHBvd2VyIHRvIGdldCBzdWdnZXN0aW9ucyBmb3IgbWlzc3BlbGxlZCB3b3Jk LCBpLmUuIENocm9taXVtIGNhbm5vdAorICAgICAgICBhZmZvcmQgdG8gYXR0YWNoIHN1Z2dlc3Rp b25zIHRvIGFsbCBTcGVsbGluZyBtYXJrZXJzLikKKworICAgICAgICAqIHNyYy9Db250ZXh0TWVu dUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb250ZXh0TWVudUNsaWVudEltcGw6 OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKTogUmV0cmlldmUgc3VnZ2VzdGlvbnMgaWYg bWFya2VycyBkbyBub3QgaGF2ZSBhbnkuCisKIDIwMTItMDUtMjggIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIEZyYW1lTG9hZGVyQ2xpZW50Ojpz aGFkb3dET01BbGxvd2VkKCkgdG8gYWxsb3dTaGFkb3dET00oKQpJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCShyZXZp c2lvbiAxMTg3MTQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNs aWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTAsOCArMjkwLDEzIEBAIFBsYXRmb3Jt TWVudURlc2NyaXB0aW9uIENvbnRleHRNZW51Q2xpZW4KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdWdnZXN0aW9ucy5hcHBlbmQoZGVzY3JpcHRpb25zKTsKICAgICAgICAgICAgICAgICAg ICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgICAgICBkYXRh LmRpY3Rpb25hcnlTdWdnZXN0aW9ucyA9IHN1Z2dlc3Rpb25zOwogICAgICAgICAgICAgICAgICAg ICBkYXRhLm1pc3NwZWxsZWRXb3JkID0gc2VsZWN0TWlzc3BlbGxlZFdvcmQoZGVmYXVsdE1lbnUs IHNlbGVjdGVkRnJhbWUpOworICAgICAgICAgICAgICAgICAgICBpZiAoIXN1Z2dlc3Rpb25zLmlz RW1wdHkoKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEuZGljdGlvbmFyeVN1Z2dlc3Rp b25zID0gc3VnZ2VzdGlvbnM7CisgICAgICAgICAgICAgICAgICAgIGVsc2UgaWYgKG1fd2ViVmll dy0+c3BlbGxDaGVja0NsaWVudCgpKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBpbnQgbWlz c3BlbGxlZE9mZnNldCwgbWlzc3BlbGxlZExlbmd0aDsKKyAgICAgICAgICAgICAgICAgICAgICAg IG1fd2ViVmlldy0+c3BlbGxDaGVja0NsaWVudCgpLT5zcGVsbENoZWNrKGRhdGEubWlzc3BlbGxl ZFdvcmQsIG1pc3NwZWxsZWRPZmZzZXQsIG1pc3NwZWxsZWRMZW5ndGgsICZkYXRhLmRpY3Rpb25h cnlTdWdnZXN0aW9ucyk7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZSBpZiAobV93ZWJWaWV3LT5mb2N1c2VkV2Vi Q29yZUZyYW1lKCktPmVkaXRvcigpLT5pc0NvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCgp KSB7Cg== 144440 2012-05-28 21:31:44 -0700 2012-05-29 02:11:00 -0700 Patch v1 (fixed typos) issue87690-patch1.txt text/plain 2227 hbono SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTg3MTUpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA1LTI4ICBIaXJvbm9yaSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFVzZSBXZWJTcGVsbENoZWNrQ2xpZW50OjpzcGVsbGNoZWNrIHRvIHJldHJpZXZlIHN1 Z2dlc3Rpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODc2OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGNoYW5nZSB1c2VzIFdlYlNwZWxsQ2hlY2tDbGllbnQ6OnNwZWxsY2hlY2sgYXMgYSBm YWxsYmFjayBtZXRob2QgdG8KKyAgICAgICAgcmV0cmlldmUgc3VnZ2VzdGlvbnMgd2hlbiBhIG1h cmtlciBkb2VzIG5vdCBoYXZlIGFueSBzdWdnZXN0aW9ucy4gKEl0IGNvbnN1bWVzCisgICAgICAg IGxvdHMgb2YgQ1BVIHBvd2VyIHRvIGdldCBzdWdnZXN0aW9ucyBmb3IgbWlzc3BlbGxlZCB3b3Jk LCBpLmUuIENocm9taXVtIGNhbm5vdAorICAgICAgICBhZmZvcmQgdG8gYXR0YWNoIHN1Z2dlc3Rp b25zIHRvIGFsbCBzcGVsbGluZyBtYXJrZXJzLikKKworICAgICAgICAqIHNyYy9Db250ZXh0TWVu dUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb250ZXh0TWVudUNsaWVudEltcGw6 OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKTogUmV0cmlldmUgc3VnZ2VzdGlvbnMgaWYg bWFya2VycyBkbyBub3QgaGF2ZSBhbnkuCisKIDIwMTItMDUtMjggIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIEZyYW1lTG9hZGVyQ2xpZW50Ojpz aGFkb3dET01BbGxvd2VkKCkgdG8gYWxsb3dTaGFkb3dET00oKQpJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCShyZXZp c2lvbiAxMTg3MTQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNs aWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTAsOCArMjkwLDEzIEBAIFBsYXRmb3Jt TWVudURlc2NyaXB0aW9uIENvbnRleHRNZW51Q2xpZW4KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdWdnZXN0aW9ucy5hcHBlbmQoZGVzY3JpcHRpb25zKTsKICAgICAgICAgICAgICAgICAg ICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgICAgICBkYXRh LmRpY3Rpb25hcnlTdWdnZXN0aW9ucyA9IHN1Z2dlc3Rpb25zOwogICAgICAgICAgICAgICAgICAg ICBkYXRhLm1pc3NwZWxsZWRXb3JkID0gc2VsZWN0TWlzc3BlbGxlZFdvcmQoZGVmYXVsdE1lbnUs IHNlbGVjdGVkRnJhbWUpOworICAgICAgICAgICAgICAgICAgICBpZiAoIXN1Z2dlc3Rpb25zLmlz RW1wdHkoKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEuZGljdGlvbmFyeVN1Z2dlc3Rp b25zID0gc3VnZ2VzdGlvbnM7CisgICAgICAgICAgICAgICAgICAgIGVsc2UgaWYgKG1fd2ViVmll dy0+c3BlbGxDaGVja0NsaWVudCgpKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBpbnQgbWlz c3BlbGxlZE9mZnNldCwgbWlzc3BlbGxlZExlbmd0aDsKKyAgICAgICAgICAgICAgICAgICAgICAg IG1fd2ViVmlldy0+c3BlbGxDaGVja0NsaWVudCgpLT5zcGVsbENoZWNrKGRhdGEubWlzc3BlbGxl ZFdvcmQsIG1pc3NwZWxsZWRPZmZzZXQsIG1pc3NwZWxsZWRMZW5ndGgsICZkYXRhLmRpY3Rpb25h cnlTdWdnZXN0aW9ucyk7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZSBpZiAobV93ZWJWaWV3LT5mb2N1c2VkV2Vi Q29yZUZyYW1lKCktPmVkaXRvcigpLT5pc0NvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCgp KSB7Cg==