87684 2012-05-28 17:08:14 -0700 Implement post-landing feedback for WebKitCSSTransformValue::customCSSText(). 2012-05-29 20:30:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson cmarcelo darin dglazkov macpherson menard webkit.review.bot oldest_to_newest 635464 0 macpherson 2012-05-28 17:08:14 -0700 Implement post-landing feedback for WebKitCSSTransformValue::customCSSText(). 635465 1 144411 macpherson 2012-05-28 17:11:06 -0700 Created attachment 144411 Patch 635676 2 144411 cmarcelo 2012-05-29 00:44:28 -0700 Comment on attachment 144411 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review > Source/WebCore/css/WebKitCSSTransformValue.cpp:36 > +const char* const transformName[22] = { I think the idea was to get rid of this "22" as well, and use "const char* const transformName[] = { ...". I also think it is a good idea to point out that this needs to be synchronized with TransformOperationType enum. 636132 3 144411 darin 2012-05-29 09:46:19 -0700 Comment on attachment 144411 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review >> Source/WebCore/css/WebKitCSSTransformValue.cpp:36 >> +const char* const transformName[22] = { > > I think the idea was to get rid of this "22" as well, and use "const char* const transformName[] = { ...". > > I also think it is a good idea to point out that this needs to be synchronized with TransformOperationType enum. Agreed on both points. 636562 4 144640 macpherson 2012-05-29 16:48:43 -0700 Created attachment 144640 Patch 636616 5 144640 darin 2012-05-29 17:28:35 -0700 Comment on attachment 144640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144640&action=review > Source/WebCore/css/WebKitCSSTransformValue.cpp:36 > +// These names must be kept in sync with TransformOperationType. Normally to keep something in sync we need comments on both things, otherwise someone changes one without updating the other. 636776 6 144640 webkit.review.bot 2012-05-29 20:30:41 -0700 Comment on attachment 144640 Patch Clearing flags on attachment: 144640 Committed r118885: <http://trac.webkit.org/changeset/118885> 636777 7 webkit.review.bot 2012-05-29 20:30:46 -0700 All reviewed patches have been landed. Closing bug. 144411 2012-05-28 17:11:06 -0700 2012-05-29 16:48:35 -0700 Patch bug-87684-20120529101104.patch text/plain 2079 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmE5M2IxMDIwMDc2YzE0 NTgyZTFiNmZiY2VlMDE2NzIxZWRjYmM2Yi4uMmFjZjU1NWIwNTVkOTllYzgzMWEyMGFmMGZlYTNh NzQ1ZjgzNDFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTI4ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1l bnQgcG9zdC1sYW5kaW5nIGZlZWRiYWNrIGZvciBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZTo6Y3Vz dG9tQ1NTVGV4dCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODc2ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEYXJpbiBwcm92aWRlZCBzb21lIHN0eWxlIHN1Z2dlc3Rpbmcgb24gaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NDYyIGFmdGVyIGl0IGxhbmRlZC4KKyAgICAg ICAgVGhpcyBwYXRjaCBpbmNvcnBvcmF0ZXMgdGhvc2Ugc3VnZ2VzdGlvbnMsIG5hbWVseSB1c2lu ZyAwIGluc3RlYWQgb2YgZW1wdHkgc3RyaW5nIGZvciBVbmtub3duVHJhbnNmb3JtT3BlcmF0aW9u CisgICAgICAgIGFuZCBXVEZfQVJSQVlfTEVOR1RIIGluc3RlYWQgb2YgaGFyZCBjb2RpbmcgdGhl IGFycmF5IGxlbmd0aC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRyYW5zZm9ybSB0 ZXN0cy4KKworICAgICAgICAqIGNzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5jcHA6CisgICAg ICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OldlYktpdENTU1RyYW5zZm9ybVZhbHVl OjpjdXN0b21Dc3NUZXh0KToKKwogMjAxMi0wNS0yOCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29u QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZCBzdXBwb3J0IGZvciBsYXllcnMg d2l0aCBzY2FsZSBpbnZhcmlhbnQgc2l6ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L1dlYktpdENTU1RyYW5zZm9ybVZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRD U1NUcmFuc2Zvcm1WYWx1ZS5jcHAKaW5kZXggODU4MDIyNjc1MjFmODAyNTJjNmEyNWIxM2M4YTQ2 NjUxNWNhMmIwNS4uMDQ0NGZiMDNiZWQxZDNiOTNhNTlhN2Q3Y2I3NmZhNDlhYzJmYzMyNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU1RyYW5zZm9ybVZhbHVlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUuY3BwCkBAIC0z Myw5ICszMyw4IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY29uc3QgaW50IHRyYW5zZm9y bU5hbWVTaXplID0gMjI7Ci1jb25zdCBjaGFyKiBjb25zdCB0cmFuc2Zvcm1OYW1lW3RyYW5zZm9y bU5hbWVTaXplXSA9IHsKLSAgICAgIiIsCitjb25zdCBjaGFyKiBjb25zdCB0cmFuc2Zvcm1OYW1l WzIyXSA9IHsKKyAgICAgMCwKICAgICAgInRyYW5zbGF0ZSIsCiAgICAgICJ0cmFuc2xhdGVYIiwK ICAgICAgInRyYW5zbGF0ZVkiLApAQCAtNjksNyArNjgsNyBAQCBTdHJpbmcgV2ViS2l0Q1NTVHJh bnNmb3JtVmFsdWU6OmN1c3RvbUNzc1RleHQoKSBjb25zdAogewogICAgIFN0cmluZ0J1aWxkZXIg cmVzdWx0OwogICAgIGlmIChtX3R5cGUgIT0gVW5rbm93blRyYW5zZm9ybU9wZXJhdGlvbikgewot ICAgICAgICBBU1NFUlQobV90eXBlIDwgdHJhbnNmb3JtTmFtZVNpemUpOworICAgICAgICBBU1NF UlQoc3RhdGljX2Nhc3Q8c2l6ZV90PihtX3R5cGUpIDwgV1RGX0FSUkFZX0xFTkdUSCh0cmFuc2Zv cm1OYW1lKSk7CiAgICAgICAgIHJlc3VsdC5hcHBlbmQodHJhbnNmb3JtTmFtZVttX3R5cGVdKTsK ICAgICAgICAgcmVzdWx0LmFwcGVuZCgnKCcpOwogICAgICAgICByZXN1bHQuYXBwZW5kKENTU1Zh bHVlTGlzdDo6Y3VzdG9tQ3NzVGV4dCgpKTsK 144640 2012-05-29 16:48:43 -0700 2012-05-29 20:30:41 -0700 Patch bug-87684-20120530094841.patch text/plain 2117 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFkOTc1MDEyYmU5ODhh OWVjYjk4ZWM1MGYxNmU5ZTNjNzliN2IyYy4uMWI4ZWMyYmE1ZGNhZTYwMDQ4MjU3MDUxY2UyMDA2 NDBiY2ZlZDNjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTI4ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1l bnQgcG9zdC1sYW5kaW5nIGZlZWRiYWNrIGZvciBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZTo6Y3Vz dG9tQ1NTVGV4dCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODc2ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEYXJpbiBwcm92aWRlZCBzb21lIHN0eWxlIHN1Z2dlc3Rpbmcgb24gaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NDYyIGFmdGVyIGl0IGxhbmRlZC4KKyAgICAg ICAgVGhpcyBwYXRjaCBpbmNvcnBvcmF0ZXMgdGhvc2Ugc3VnZ2VzdGlvbnMsIG5hbWVseSB1c2lu ZyAwIGluc3RlYWQgb2YgZW1wdHkgc3RyaW5nIGZvciBVbmtub3duVHJhbnNmb3JtT3BlcmF0aW9u CisgICAgICAgIGFuZCBXVEZfQVJSQVlfTEVOR1RIIGluc3RlYWQgb2YgaGFyZCBjb2RpbmcgdGhl IGFycmF5IGxlbmd0aC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRyYW5zZm9ybSB0 ZXN0cy4KKworICAgICAgICAqIGNzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5jcHA6CisgICAg ICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OldlYktpdENTU1RyYW5zZm9ybVZhbHVl OjpjdXN0b21Dc3NUZXh0KToKKwogMjAxMi0wNS0yOSAgVmljdG9yIENhcmJ1bmUgIDx2aWN0b3JA cm9zZWR1Lm9yZz4KIAogICAgICAgICBEaXNwbGF5IGN1ZXMgaW4gdGhlIGNvbnRyb2xzIGFyZWEK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUuY3BwCmluZGV4 IDg1ODAyMjY3NTIxZjgwMjUyYzZhMjViMTNjOGE0NjY1MTVjYTJiMDUuLmY4NTMxOTAxNTI1Mjg1 YmNiNWQ1YTFmMGMwYTA4NTE4OWQ4MjY5OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1dl YktpdENTU1RyYW5zZm9ybVZhbHVlLmNwcApAQCAtMzMsOSArMzMsOSBAQAogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKLWNvbnN0IGludCB0cmFuc2Zvcm1OYW1lU2l6ZSA9IDIyOwotY29uc3QgY2hh ciogY29uc3QgdHJhbnNmb3JtTmFtZVt0cmFuc2Zvcm1OYW1lU2l6ZV0gPSB7Ci0gICAgICIiLAor Ly8gVGhlc2UgbmFtZXMgbXVzdCBiZSBrZXB0IGluIHN5bmMgd2l0aCBUcmFuc2Zvcm1PcGVyYXRp b25UeXBlLgorY29uc3QgY2hhciogY29uc3QgdHJhbnNmb3JtTmFtZVtdID0geworICAgICAwLAog ICAgICAidHJhbnNsYXRlIiwKICAgICAgInRyYW5zbGF0ZVgiLAogICAgICAidHJhbnNsYXRlWSIs CkBAIC02OSw3ICs2OSw3IEBAIFN0cmluZyBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZTo6Y3VzdG9t Q3NzVGV4dCgpIGNvbnN0CiB7CiAgICAgU3RyaW5nQnVpbGRlciByZXN1bHQ7CiAgICAgaWYgKG1f dHlwZSAhPSBVbmtub3duVHJhbnNmb3JtT3BlcmF0aW9uKSB7Ci0gICAgICAgIEFTU0VSVChtX3R5 cGUgPCB0cmFuc2Zvcm1OYW1lU2l6ZSk7CisgICAgICAgIEFTU0VSVChzdGF0aWNfY2FzdDxzaXpl X3Q+KG1fdHlwZSkgPCBXVEZfQVJSQVlfTEVOR1RIKHRyYW5zZm9ybU5hbWUpKTsKICAgICAgICAg cmVzdWx0LmFwcGVuZCh0cmFuc2Zvcm1OYW1lW21fdHlwZV0pOwogICAgICAgICByZXN1bHQuYXBw ZW5kKCcoJyk7CiAgICAgICAgIHJlc3VsdC5hcHBlbmQoQ1NTVmFsdWVMaXN0OjpjdXN0b21Dc3NU ZXh0KCkpOwo=