87681 2012-05-28 15:59:55 -0700 [Regression] Text layout issues with complex characters 2012-07-03 03:29:30 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr eric thorton webkit.review.bot zimmermann oldest_to_newest 635447 0 144407 pdr 2012-05-28 15:59:55 -0700 Created attachment 144407 Minimized testcase Looks like text layout with complex characters has regressed. Adding a tspan with a complex character to <text> causes other tspans to be laid out incorrectly. See attached minimized testcase. Original bug: crbug.com/129980 661991 1 150543 pdr 2012-07-02 23:17:44 -0700 Created attachment 150543 Fix text positioning with non-bmp characters. 662096 2 150543 zimmermann 2012-07-03 03:21:25 -0700 Comment on attachment 150543 Fix text positioning with non-bmp characters. Good catch, r=me. 662101 3 150543 webkit.review.bot 2012-07-03 03:29:26 -0700 Comment on attachment 150543 Fix text positioning with non-bmp characters. Clearing flags on attachment: 150543 Committed r121756: <http://trac.webkit.org/changeset/121756> 662102 4 webkit.review.bot 2012-07-03 03:29:30 -0700 All reviewed patches have been landed. Closing bug. 144407 2012-05-28 15:59:55 -0700 2012-05-28 15:59:55 -0700 Minimized testcase test.svg image/svg+xml 858 pdr PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSI0MDAiIGhlaWdo dD0iNDAwIj4KPHRleHQgeD0iMzAiIHk9IjMwIj5Cb3RoIGxpbmVzIG9mIGNoYXJhY3RlcnMgc2hv dWxkIGxvb2sgdGhlIHNhbWU8L3RleHQ+Cjx0ZXh0IHg9IjMwIiB5PSI1MCI+ZXhjZXB0IHRoZSBm aXJzdCBoYXMgYW4gRSBhbmQgdGhlIHNlY29uZCBhIFEuPC90ZXh0PgogIDx0ZXh0PgogICAgPHRz cGFuIHg9IjE2NS45MyIgeT0iMTAwIj4mIzExOTg2NDs8L3RzcGFuPgogICAgPHRzcGFuIHg9IjIx LjQzMDE0MSIgeT0iMTAwIj5hPC90c3Bhbj4KICAgIDx0c3BhbiB4PSIyNi45ODE0NzQiIHk9IjEw MCI+cjwvdHNwYW4+CiAgICA8dHNwYW4geD0iMzAuOTU3NDI4IiB5PSIxMDAiPmc8L3RzcGFuPgog ICAgPHRzcGFuIHg9IjM3LjIwODkyNyIgeT0iMTAwIj5tPC90c3Bhbj4KICAgIDx0c3BhbiB4PSI0 Ni45MzYyNiIgeT0iMTAwIj5pPC90c3Bhbj4KICAgIDx0c3BhbiB4PSI1MC40MTIwOTQiIHk9IjEw MCI+bjwvdHNwYW4+CiAgPC90ZXh0PgogIDx0ZXh0PgogICAgPHRzcGFuIHg9IjE2NS45MyIgeT0i MTUwIj5RPC90c3Bhbj4KICAgIDx0c3BhbiB4PSIyMS40MzAxNDEiIHk9IjE1MCI+YTwvdHNwYW4+ CiAgICA8dHNwYW4geD0iMjYuOTgxNDc0IiB5PSIxNTAiPnI8L3RzcGFuPgogICAgPHRzcGFuIHg9 IjMwLjk1NzQyOCIgeT0iMTUwIj5nPC90c3Bhbj4KICAgIDx0c3BhbiB4PSIzNy4yMDg5MjciIHk9 IjE1MCI+bTwvdHNwYW4+CiAgICA8dHNwYW4geD0iNDYuOTM2MjYiIHk9IjE1MCI+aTwvdHNwYW4+ CiAgICA8dHNwYW4geD0iNTAuNDEyMDk0IiB5PSIxNTAiPm48L3RzcGFuPgogIDwvdGV4dD4KPC9z dmc+ 150543 2012-07-02 23:17:44 -0700 2012-07-03 03:29:26 -0700 Fix text positioning with non-bmp characters. 87681.1.patch text/plain 5420 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTczMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA3LTAyICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IHRleHQgcG9zaXRpb25pbmcg d2l0aCBub24tYm1wIGNoYXJhY3RlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NzY4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFByZXZpb3VzbHkgd2hlbiBjb25zdHJ1Y3RpbmcgbWV0cmljcyBmb3Ig dHNwYW5zIHdpdGggbm9uLWJtcCBjaGFyYWN0ZXJzLAorICAgICAgICBlYWNoIG5vbi1ibXAgY2hh cmFjdGVyIHRyZWF0ZWQgYXMgYSBza2lwcGVkIGNoYXJhY3RlciBpbiB0aGUgc2FtZSB3YXkgdGhh dAorICAgICAgICBzcGFjZXMgYXJlIGlnbm9yZWQuCisgICAgICAgIFRoaXMgbWFkZSBzZW5zZSBi ZWNhdXNlIHRoZSBpbml0aWFsIFNWR0NoYXJhY3RlckRhdGFNYXAgZm9yIDx0ZXh0PiBpcworICAg ICAgICBpbmRleGVkIGJ5IGNoYXJhY3RlciBpbmRleCAobm90IHN0cmluZyBsZW5ndGgpIHNvIHRo ZSBoaWdoIHBvcnRpb24gb2YgYQorICAgICAgICBub24tYm1wIGNoYXJhY3RlciB3YXMgdHJlYXRl ZCBhcyBhIHNraXBwZWQgc3BhY2UuIFVuZm9ydHVuYXRlbHksIHRoaXMKKyAgICAgICAgbGVkIHRv IGEgYnVnIGJlY2F1c2Ugc2tpcHBlZCBzcGFjZXMgbGVhZCB0byBhbiBvZmZzZXQgaW4gdGhlIHBv c2l0aW9uaW5nCisgICAgICAgIHZhbHVlcyBsaXN0IGJ1dCBub24tYm1wIGNoYXJhY3RlcnMgZG8g bm90LgorCisgICAgICAgIFRoaXMgY2hhbmdlIHN3aXRjaGVzIHRoZSBjb2RlIHRvIHVzZSBhIG5l dyBvZmZzZXQgZm9yIG5vbi1ibXAgY2hhcmFjdGVycywKKyAgICAgICAgc3Vycm9nYXRlUGFpckNo YXJhY3RlcnMsIHdoaWNoIGRvZXMgbm90IGFmZmVjdCB0aGUgcG9zaXRpb25pbmcgdmFsdWVzIGxp c3QuCisKKyAgICAgICAgVGVzdHM6IHN2Zy90ZXh0L25vbi1ibXAtdHNwYW5zLWV4cGVjdGVkLnN2 ZworICAgICAgICAgICAgICAgc3ZnL3RleHQvbm9uLWJtcC10c3BhbnMuc3ZnCisKKyAgICAgICAg KiByZW5kZXJpbmcvc3ZnL1NWR1RleHRNZXRyaWNzQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTVkdUZXh0TWV0cmljc0J1aWxkZXI6Om1lYXN1cmVUZXh0UmVuZGVyZXIpOgorCiAyMDEy LTA3LTAyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAg ICBbVGV4dHVyZU1hcHBlcl0gVGhlIFRleHR1cmVNYXBwZXIgc2hvdWxkIHN1cHBvcnQgZWRnZS1k aXN0YW5jZSBhbnRpLWFudGlhbGlhc2luZwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9TVkdUZXh0TWV0cmljc0J1aWxkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dE1ldHJpY3NCdWlsZGVyLmNwcAkocmV2aXNpb24gMTIx NTg5KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0TWV0cmljc0J1aWxk ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsNiArMTU1LDcgQEAgdm9pZCBTVkdUZXh0TWV0 cmljc0J1aWxkZXI6Om1lYXN1cmVUZXh0UgogCiAgICAgaW5pdGlhbGl6ZU1lYXN1cmVtZW50V2l0 aFRleHRSZW5kZXJlcih0ZXh0KTsKICAgICBib29sIHByZXNlcnZlV2hpdGVTcGFjZSA9IHRleHQt PnN0eWxlKCktPndoaXRlU3BhY2UoKSA9PSBQUkU7CisgICAgaW50IHN1cnJvZ2F0ZVBhaXJDaGFy YWN0ZXJzID0gMDsKIAogICAgIHdoaWxlIChhZHZhbmNlKCkpIHsKICAgICAgICAgY29uc3QgVUNo YXIqIGN1cnJlbnRDaGFyYWN0ZXIgPSBtX3J1bi5kYXRhKG1fdGV4dFBvc2l0aW9uKTsKQEAgLTE2 OCw3ICsxNjksNyBAQCB2b2lkIFNWR1RleHRNZXRyaWNzQnVpbGRlcjo6bWVhc3VyZVRleHRSCiAK ICAgICAgICAgaWYgKGRhdGEtPnByb2Nlc3NSZW5kZXJlcikgewogICAgICAgICAgICAgaWYgKGRh dGEtPmFsbENoYXJhY3RlcnNNYXApIHsKLSAgICAgICAgICAgICAgICBjb25zdCBTVkdDaGFyYWN0 ZXJEYXRhTWFwOjpjb25zdF9pdGVyYXRvciBpdCA9IGRhdGEtPmFsbENoYXJhY3RlcnNNYXAtPmZp bmQoZGF0YS0+dmFsdWVMaXN0UG9zaXRpb24gKyBtX3RleHRQb3NpdGlvbiAtIGRhdGEtPnNraXBw ZWRDaGFyYWN0ZXJzICsgMSk7CisgICAgICAgICAgICAgICAgY29uc3QgU1ZHQ2hhcmFjdGVyRGF0 YU1hcDo6Y29uc3RfaXRlcmF0b3IgaXQgPSBkYXRhLT5hbGxDaGFyYWN0ZXJzTWFwLT5maW5kKGRh dGEtPnZhbHVlTGlzdFBvc2l0aW9uICsgbV90ZXh0UG9zaXRpb24gLSBkYXRhLT5za2lwcGVkQ2hh cmFjdGVycyAtIHN1cnJvZ2F0ZVBhaXJDaGFyYWN0ZXJzICsgMSk7CiAgICAgICAgICAgICAgICAg aWYgKGl0ICE9IGRhdGEtPmFsbENoYXJhY3RlcnNNYXAtPmVuZCgpKQogICAgICAgICAgICAgICAg ICAgICBhdHRyaWJ1dGVzLT5jaGFyYWN0ZXJEYXRhTWFwKCkuc2V0KG1fdGV4dFBvc2l0aW9uICsg MSwgaXQtPnNlY29uZCk7CiAgICAgICAgICAgICB9CkBAIC0xNzYsNyArMTc3LDcgQEAgdm9pZCBT VkdUZXh0TWV0cmljc0J1aWxkZXI6Om1lYXN1cmVUZXh0UgogICAgICAgICB9CiAKICAgICAgICAg aWYgKGRhdGEtPmFsbENoYXJhY3RlcnNNYXAgJiYgY3VycmVudENoYXJhY3RlclN0YXJ0c1N1cnJv Z2F0ZVBhaXIoKSkKLSAgICAgICAgICAgIGRhdGEtPnNraXBwZWRDaGFyYWN0ZXJzICs9IG1fY3Vy cmVudE1ldHJpY3MubGVuZ3RoKCkgLSAxOworICAgICAgICAgICAgc3Vycm9nYXRlUGFpckNoYXJh Y3RlcnMrKzsKIAogICAgICAgICBkYXRhLT5sYXN0Q2hhcmFjdGVyID0gY3VycmVudENoYXJhY3Rl cjsKICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjE3MzApCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNy0wMiAgUGhpbGlw IFJvZ2VycyAgPHBkckBnb29nbGUuY29tPgorCisgICAgICAgIEZpeCB0ZXh0IHBvc2l0aW9uaW5n IHdpdGggbm9uLWJtcCBjaGFyYWN0ZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODc2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHN2Zy90ZXh0L25vbi1ibXAtdHNwYW5zLWV4cGVjdGVkLnN2Zzog QWRkZWQuCisgICAgICAgICogc3ZnL3RleHQvbm9uLWJtcC10c3BhbnMuc3ZnOiBBZGRlZC4KKwog MjAxMi0wNy0wMiAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIExheW91dCBUZXN0IGluc3BlY3Rvci90aW1lbGluZS90aW1lbGluZS1yZWNlaXZlLXJlc3Bv bnNlLWV2ZW50Lmh0bWwgaXMgZmFpbGluZwpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL3RleHQvbm9u LWJtcC10c3BhbnMtZXhwZWN0ZWQuc3ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy90 ZXh0L25vbi1ibXAtdHNwYW5zLWV4cGVjdGVkLnN2ZwkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL3N2Zy90ZXh0L25vbi1ibXAtdHNwYW5zLWV4cGVjdGVkLnN2ZwkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwxNCBAQAorPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdp ZHRoPSI4MDAiPgorICAgIDwhLS0gVGVzdCBmb3IgV0s4NzY4MSB3aGVyZSBub24tQk1QIGNoYXJh Y3RlcnMgYnJva2UgcG9zaXRpb25pbmcgaW4gc2libGluZyB0c3BhbnMuIC0tPgorICAgIDx0ZXh0 IHg9IjMwIiB5PSIzMCI+VGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGVyZSBhcmUgdGhyZWUgcm93cyBv ZiAyIGdyZWVuIENzIGVhY2ggd2l0aDwvdGV4dD4KKyAgICA8dGV4dCB4PSIzMCIgeT0iNTAiPnRo ZSBmaXJzdCByb3cgY3Vyc2l2ZSwgdGhlIHNlY29uZCBwbGFpbiwgYW5kIHRoZSB0aGlyZCBjdXJz aXZlLjwvdGV4dD4KKyAgICA8dGV4dCBmaWxsPSJncmVlbiI+CisgICAgICAgIDx0c3BhbiB4PSIx MDAiIHk9IjEwMCI+JiN4MWQ0OWU7JiN4MWQ0OWU7PC90c3Bhbj4KKyAgICA8L3RleHQ+CisgICAg PHRleHQgZmlsbD0iZ3JlZW4iPgorICAgICAgICA8dHNwYW4geD0iMTAwIiB5PSIxNTAiPkNDPC90 c3Bhbj4KKyAgICA8L3RleHQ+CisgICAgPHRleHQgZmlsbD0iZ3JlZW4iPgorICAgICAgICA8dHNw YW4geD0iMTAwIiB5PSIyMDAiPiYjeDFkNDllOyYjeDFkNDllOzwvdHNwYW4+CisgICAgPC90ZXh0 PgorPC9zdmc+CkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvdGV4dC9ub24tYm1wLXRzcGFucy5zdmcK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL3RleHQvbm9uLWJtcC10c3BhbnMuc3ZnCShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3ZnL3RleHQvbm9uLWJtcC10c3BhbnMuc3ZnCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9y Zy8yMDAwL3N2ZyIgd2lkdGg9IjgwMCI+CisgICAgPCEtLSBUZXN0IGZvciBXSzg3NjgxIHdoZXJl IG5vbi1CTVAgY2hhcmFjdGVycyBicm9rZSBwb3NpdGlvbmluZyBpbiBzaWJsaW5nIHRzcGFucy4g LS0+CisgICAgPHRleHQgeD0iMzAiIHk9IjMwIj5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGFy ZSB0aHJlZSByb3dzIG9mIDIgZ3JlZW4gQ3MgZWFjaCB3aXRoPC90ZXh0PgorICAgIDx0ZXh0IHg9 IjMwIiB5PSI1MCI+dGhlIGZpcnN0IHJvdyBjdXJzaXZlLCB0aGUgc2Vjb25kIHBsYWluLCBhbmQg dGhlIHRoaXJkIGN1cnNpdmUuPC90ZXh0PgorICAgIDx0ZXh0IGZpbGw9ImdyZWVuIj4KKyAgICAg ICAgPHRzcGFuIHg9IjEwMCIgeT0iMTAwIj4mI3gxZDQ5ZTsmI3gxZDQ5ZTs8L3RzcGFuPgorICAg ICAgICA8dHNwYW4geD0iMTAwIiB5PSIxNTAiPkNDPC90c3Bhbj4KKyAgICAgICAgPHRzcGFuIHg9 IjEwMCIgeT0iMjAwIj4mI3gxZDQ5ZTsmI3gxZDQ5ZTs8L3RzcGFuPgorICAgIDwvdGV4dD4KKzwv c3ZnPgo=