87668 2012-05-28 08:12:13 -0700 [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues 2012-06-04 02:28:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov ap gustavo rakuco rniwa webkit.review.bot oldest_to_newest 635230 0 mikhail.pozdnyakov 2012-05-28 08:12:13 -0700 LayoutTests/fast/html/tab-order.html has a link inside the test description which may be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set) and lead to test failing. So think it would be nice to set to false "WebKitTabToLinksPreferenceKey" LayoutTestController setting before the test execution to avoid the mentioned problem and to be consistent with other tests (take for instance fast/events/tab-focus-anchor.html). 635237 1 144368 mikhail.pozdnyakov 2012-05-28 08:17:47 -0700 Created attachment 144368 patch 635289 2 144368 rakuco 2012-05-28 09:29:41 -0700 Comment on attachment 144368 patch View in context: https://bugs.webkit.org/attachment.cgi?id=144368&action=review > LayoutTests/ChangeLog:3 > + [DRT] LayoutTests/fast/html/tab-order.html should set to false "WebKitTabToLinksPreferenceKey" LayoutTestController setting The 'DRT' prefix here seems unnecessary. It'd be good to include your explanation in the ChangeLog. 635307 3 144382 mikhail.pozdnyakov 2012-05-28 10:24:17 -0700 Created attachment 144382 patch v2 (corrected changelog) 635308 4 mikhail.pozdnyakov 2012-05-28 10:26:21 -0700 (In reply to comment #2) > (From update of attachment 144368 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144368&action=review > > > LayoutTests/ChangeLog:3 > > + [DRT] LayoutTests/fast/html/tab-order.html should set to false "WebKitTabToLinksPreferenceKey" LayoutTestController setting > > The 'DRT' prefix here seems unnecessary. It'd be good to include your explanation in the ChangeLog. Done. 636120 5 144382 gustavo 2012-05-29 09:40:19 -0700 Comment on attachment 144382 patch v2 (corrected changelog) Why don't other ports need this? Should this setting be set to a better default when restoring state to sane defaults in EFL's DRT instead? 636956 6 mikhail.pozdnyakov 2012-05-30 00:23:49 -0700 (In reply to comment #5) > (From update of attachment 144382 [details]) > Why don't other ports need this? Should this setting be set to a better default when restoring state to sane defaults in EFL's DRT instead? The WebKit EFL problem can be solved if WebKitTabToLinksPreferenceKey is reset to false each time. However think it's sane to set it also inside the test since this setting is crucial for the test and its necessity is known beforehand (I mean this is not the same as uncleaned cache or forgotten user script -- those things must be handled in DRT) BTW other tests set it (see example in the description of this bug). I will remove the EFL specific part from the patch. 637170 7 144801 mikhail.pozdnyakov 2012-05-30 06:57:07 -0700 Created attachment 144801 patch v3 (removed EFL related part) 637344 8 ap 2012-05-30 10:04:37 -0700 I agree with Gustavo - it's wrong to rely on a test to reset preferences to original state itself. Very few tests do that. 639032 9 144801 rniwa 2012-06-01 00:20:06 -0700 Comment on attachment 144801 patch v3 (removed EFL related part) View in context: https://bugs.webkit.org/attachment.cgi?id=144801&action=review > LayoutTests/fast/html/tab-order.html:5 > + if (window.layoutTestController) > + layoutTestController.overridePreference('WebKitTabToLinksPreferenceKey', false); This should be done in http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp#L205. 640383 10 145530 mikhail.pozdnyakov 2012-06-04 00:57:14 -0700 Created attachment 145530 patch v4 (reset "WebKitTabToLinksPreferenceKey" to false in EFL DRT) 640386 11 145532 mikhail.pozdnyakov 2012-06-04 01:00:55 -0700 Created attachment 145532 patch v4 (reset "WebKitTabToLinksPreferenceKey" to false in EFL DRT) 640427 12 145532 webkit.review.bot 2012-06-04 02:28:51 -0700 Comment on attachment 145532 patch v4 (reset "WebKitTabToLinksPreferenceKey" to false in EFL DRT) Clearing flags on attachment: 145532 Committed r119377: <http://trac.webkit.org/changeset/119377> 640428 13 webkit.review.bot 2012-06-04 02:28:57 -0700 All reviewed patches have been landed. Closing bug. 144368 2012-05-28 08:17:47 -0700 2012-05-28 10:24:17 -0700 patch bug87668 text/plain 1982 mikhail.pozdnyakov Y29tbWl0IGI1ZTg2MzMwMzEwZDg4ZDRkNGQyNTEzODBlYWUwODYyNDdjZTNmMGMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg TW9uIE1heSAyOCAxODoxNjoxNyAyMDEyICswMzAwCgogICAgYnVnODc2NjgKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDZj OGE4YS4uMThiOTZjMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTI4ICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtE UlRdIExheW91dFRlc3RzL2Zhc3QvaHRtbC90YWItb3JkZXIuaHRtbCBzaG91bGQgc2V0IHRvIGZh bHNlICJXZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIgIExheW91dFRlc3RDb250cm9sbGVy IHNldHRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg3NjY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBmYXN0L2h0bWwvdGFiLW9yZGVyLmh0bWw6IFNldCB0byBmYWxzZSAiV2ViS2l0VGFiVG9MaW5r c1ByZWZlcmVuY2VLZXkiICBMYXlvdXRUZXN0Q29udHJvbGxlciBzZXR0aW5nLgorICAgICAgICAq IHBsYXRmb3JtL2VmbC9Ta2lwcGVkOiBVbnNraXBwZWQgTGF5b3V0VGVzdHMvZmFzdC9odG1sL3Rh Yi1vcmRlci5odG1sIGZvciBFRkwgcG9ydC4KKwogMjAxMi0wNS0yOCAgQ2hyaXN0b3BoZSBEdW1l eiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIE5ldyB0ZXN0 cyBhZGRlZCBpbiByMTE4NTY3IHNob3VsZCBiZSBza2lwcGVkIG9uIEVGTCBwb3J0CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2h0bWwvdGFiLW9yZGVyLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2h0bWwvdGFiLW9yZGVyLmh0bWwKaW5kZXggMTIzY2QxZS4uMzYwN2Q3ZSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RhYi1vcmRlci5odG1sCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvaHRtbC90YWItb3JkZXIuaHRtbApAQCAtMSw2ICsxLDkgQEAKIDxodG1sPgogPGhlYWQ+ CiAgICAgPHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK KyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJyaWRlUHJlZmVyZW5jZSgnV2Vi S2l0VGFiVG9MaW5rc1ByZWZlcmVuY2VLZXknLCBmYWxzZSk7CisKICAgICAgICAgZnVuY3Rpb24g bG9nKG1zZykKICAgICAgICAgewogICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2xvZycpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1zZyArICdcbicpKTsK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKaW5kZXggMjBkNjlmZi4uOTg2NmE5ZCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsL1NraXBwZWQKQEAgLTY1NSw3ICs2NTUsNiBAQCBmYXN0L2Zvcm1zL3NlYXJjaC10 cmFuc2Zvcm1lZC5odG1sCiBmYXN0L2Zvcm1zL3NlYXJjaC16b29tZWQuaHRtbAogZmFzdC9mb3Jt cy9yYW5nZS9zbGlkZXItZGVsZXRlLXdoaWxlLWRyYWdnaW5nLXRodW1iLmh0bWwKIGZhc3QvaGFy bmVzcy9yZXN1bHRzLmh0bWwKLWZhc3QvaHRtbC90YWItb3JkZXIuaHRtbAogZmFzdC9pbmxpbmUv c2tpcHBlZC13aGl0ZXNwYWNlLWJvdW5kaW5nQm94Lmh0bWwKIGZhc3QvbXVsdGljb2wvY2xpZW50 LXJlY3RzLmh0bWwKIGZhc3QvbXVsdGljb2wvc2luZ2xlLWxpbmUuaHRtbAo= 144382 2012-05-28 10:24:17 -0700 2012-05-30 06:57:07 -0700 patch v2 (corrected changelog) bug87668_v2 text/plain 2199 mikhail.pozdnyakov Y29tbWl0IDgwMzViYWVhZDc4NmE5ZTA4MjM4ZThlNDdmNzhkZDIxYmY2ODMyZDIKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg TW9uIE1heSAyOCAyMDoxODo0NyAyMDEyICswMzAwCgogICAgYnVnODc2NjgKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDZj OGE4YS4uYzg2ZThkNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTI4ICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIExh eW91dFRlc3RzL2Zhc3QvaHRtbC90YWItb3JkZXIuaHRtbCBzaG91bGQgc2V0IHRvIGZhbHNlICJX ZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIgIExheW91dFRlc3RDb250cm9sbGVyIHNldHRp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NjY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF5b3V0 VGVzdHMvZmFzdC9odG1sL3RhYi1vcmRlci5odG1sIGhhcyBhIGxpbmsgaW5zaWRlIHRoZSB0ZXN0 IGRlc2NyaXB0aW9uIHdoaWNoIG1pZ2h0IGhhdmUgYmVlbiBpbmNsdWRlZCBpbiBmb2N1cyBjaGFp biAKKyAgICAgICAgKGlmICJXZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIgc2V0dGluZyB3 YXMgc2V0KSBhbmQgbGVhZCB0byB0ZXN0IGZhaWxpbmcuIAorCisgICAgICAgICogZmFzdC9odG1s L3RhYi1vcmRlci5odG1sOiBTZXQgdG8gZmFsc2UgIldlYktpdFRhYlRvTGlua3NQcmVmZXJlbmNl S2V5IiAgTGF5b3V0VGVzdENvbnRyb2xsZXIgc2V0dGluZy4KKyAgICAgICAgKiBwbGF0Zm9ybS9l ZmwvU2tpcHBlZDogVW5za2lwcGVkIExheW91dFRlc3RzL2Zhc3QvaHRtbC90YWItb3JkZXIuaHRt bCBmb3IgRUZMIHBvcnQuCisKIDIwMTItMDUtMjggIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3Rv cGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBOZXcgdGVzdHMgYWRkZWQgaW4g cjExODU2NyBzaG91bGQgYmUgc2tpcHBlZCBvbiBFRkwgcG9ydApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9odG1sL3RhYi1vcmRlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9odG1sL3Rh Yi1vcmRlci5odG1sCmluZGV4IDEyM2NkMWUuLjM2MDdkN2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvaHRtbC90YWItb3JkZXIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2h0bWwv dGFiLW9yZGVyLmh0bWwKQEAgLTEsNiArMSw5IEBACiA8aHRtbD4KIDxoZWFkPgogICAgIDxzY3Jp cHQ+CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoJ1dlYktpdFRhYlRvTGlu a3NQcmVmZXJlbmNlS2V5JywgZmFsc2UpOworCiAgICAgICAgIGZ1bmN0aW9uIGxvZyhtc2cpCiAg ICAgICAgIHsKICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdsb2cnKS5hcHBl bmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtc2cgKyAnXG4nKSk7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC9Ta2lwcGVkCmluZGV4IDIwZDY5ZmYuLjk4NjZhOWQgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9T a2lwcGVkCkBAIC02NTUsNyArNjU1LDYgQEAgZmFzdC9mb3Jtcy9zZWFyY2gtdHJhbnNmb3JtZWQu aHRtbAogZmFzdC9mb3Jtcy9zZWFyY2gtem9vbWVkLmh0bWwKIGZhc3QvZm9ybXMvcmFuZ2Uvc2xp ZGVyLWRlbGV0ZS13aGlsZS1kcmFnZ2luZy10aHVtYi5odG1sCiBmYXN0L2hhcm5lc3MvcmVzdWx0 cy5odG1sCi1mYXN0L2h0bWwvdGFiLW9yZGVyLmh0bWwKIGZhc3QvaW5saW5lL3NraXBwZWQtd2hp dGVzcGFjZS1ib3VuZGluZ0JveC5odG1sCiBmYXN0L211bHRpY29sL2NsaWVudC1yZWN0cy5odG1s CiBmYXN0L211bHRpY29sL3NpbmdsZS1saW5lLmh0bWwK 144801 2012-05-30 06:57:07 -0700 2012-06-04 00:57:14 -0700 patch v3 (removed EFL related part) bug87668_v3 text/plain 1576 mikhail.pozdnyakov Y29tbWl0IDViODNhODUyMjdiMjU5NDRjZDk5MGM3NDc1YWZlYTRmMTMzZDM5NzMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg TW9uIE1heSAyOCAyMDoxODo0NyAyMDEyICswMzAwCgogICAgYnVnODc2NjgKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzRm NGY3Mi4uYjQwMmI5YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI4ICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIExh eW91dFRlc3RzL2Zhc3QvaHRtbC90YWItb3JkZXIuaHRtbCBzaG91bGQgc2V0IHRvIGZhbHNlICJX ZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIgIExheW91dFRlc3RDb250cm9sbGVyIHNldHRp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NjY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF5b3V0 VGVzdHMvZmFzdC9odG1sL3RhYi1vcmRlci5odG1sIGhhcyBhIGxpbmsgaW5zaWRlIHRoZSB0ZXN0 IGRlc2NyaXB0aW9uIHdoaWNoIG1pZ2h0IGhhdmUgYmVlbiBpbmNsdWRlZCBpbiBmb2N1cyBjaGFp biAKKyAgICAgICAgKGlmICJXZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIgc2V0dGluZyB3 YXMgc2V0KSBhbmQgdGh1cyBsZWFkIHRvIHRlc3QgZmFpbGluZy4gCisKKyAgICAgICAgKiBmYXN0 L2h0bWwvdGFiLW9yZGVyLmh0bWw6IFNldCB0byBmYWxzZSAiV2ViS2l0VGFiVG9MaW5rc1ByZWZl cmVuY2VLZXkiICBMYXlvdXRUZXN0Q29udHJvbGxlciBzZXR0aW5nLgorCiAyMDEyLTA1LTMwICBN aWtlIExhd3RoZXIgIDxtaWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ1NTMyBj YWxjOiBJbXBsZW1lbnQgQ1NTT00gc3VwcG9ydApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9odG1sL3RhYi1vcmRlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RhYi1vcmRlci5o dG1sCmluZGV4IDEyM2NkMWUuLjM2MDdkN2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv aHRtbC90YWItb3JkZXIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2h0bWwvdGFiLW9yZGVy Lmh0bWwKQEAgLTEsNiArMSw5IEBACiA8aHRtbD4KIDxoZWFkPgogICAgIDxzY3JpcHQ+CisgICAg ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoJ1dlYktpdFRhYlRvTGlua3NQcmVmZXJl bmNlS2V5JywgZmFsc2UpOworCiAgICAgICAgIGZ1bmN0aW9uIGxvZyhtc2cpCiAgICAgICAgIHsK ICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdsb2cnKS5hcHBlbmRDaGlsZChk b2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtc2cgKyAnXG4nKSk7Cg== 145530 2012-06-04 00:57:14 -0700 2012-06-04 00:57:48 -0700 patch v4 (reset "WebKitTabToLinksPreferenceKey" to false in EFL DRT) bug87668_v3 text/plain 1576 mikhail.pozdnyakov Y29tbWl0IDViODNhODUyMjdiMjU5NDRjZDk5MGM3NDc1YWZlYTRmMTMzZDM5NzMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg TW9uIE1heSAyOCAyMDoxODo0NyAyMDEyICswMzAwCgogICAgYnVnODc2NjgKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzRm NGY3Mi4uYjQwMmI5YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI4ICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIExh eW91dFRlc3RzL2Zhc3QvaHRtbC90YWItb3JkZXIuaHRtbCBzaG91bGQgc2V0IHRvIGZhbHNlICJX ZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIgIExheW91dFRlc3RDb250cm9sbGVyIHNldHRp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NjY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF5b3V0 VGVzdHMvZmFzdC9odG1sL3RhYi1vcmRlci5odG1sIGhhcyBhIGxpbmsgaW5zaWRlIHRoZSB0ZXN0 IGRlc2NyaXB0aW9uIHdoaWNoIG1pZ2h0IGhhdmUgYmVlbiBpbmNsdWRlZCBpbiBmb2N1cyBjaGFp biAKKyAgICAgICAgKGlmICJXZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIgc2V0dGluZyB3 YXMgc2V0KSBhbmQgdGh1cyBsZWFkIHRvIHRlc3QgZmFpbGluZy4gCisKKyAgICAgICAgKiBmYXN0 L2h0bWwvdGFiLW9yZGVyLmh0bWw6IFNldCB0byBmYWxzZSAiV2ViS2l0VGFiVG9MaW5rc1ByZWZl cmVuY2VLZXkiICBMYXlvdXRUZXN0Q29udHJvbGxlciBzZXR0aW5nLgorCiAyMDEyLTA1LTMwICBN aWtlIExhd3RoZXIgIDxtaWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ1NTMyBj YWxjOiBJbXBsZW1lbnQgQ1NTT00gc3VwcG9ydApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9odG1sL3RhYi1vcmRlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RhYi1vcmRlci5o dG1sCmluZGV4IDEyM2NkMWUuLjM2MDdkN2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv aHRtbC90YWItb3JkZXIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2h0bWwvdGFiLW9yZGVy Lmh0bWwKQEAgLTEsNiArMSw5IEBACiA8aHRtbD4KIDxoZWFkPgogICAgIDxzY3JpcHQ+CisgICAg ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoJ1dlYktpdFRhYlRvTGlua3NQcmVmZXJl bmNlS2V5JywgZmFsc2UpOworCiAgICAgICAgIGZ1bmN0aW9uIGxvZyhtc2cpCiAgICAgICAgIHsK ICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdsb2cnKS5hcHBlbmRDaGlsZChk b2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtc2cgKyAnXG4nKSk7Cg== 145532 2012-06-04 01:00:55 -0700 2012-06-04 02:28:51 -0700 patch v4 (reset "WebKitTabToLinksPreferenceKey" to false in EFL DRT) bug87668_v4 text/plain 3151 mikhail.pozdnyakov Y29tbWl0IDRlMzQ3NDQ0ZDZlNWYwNjViYWRiNTgxNjc5ZDhmZDFjMjJiMGJhMjAKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg TW9uIEp1biA0IDEwOjU0OjE2IDIwMTIgKzAzMDAKCiAgICBidWc4NzY2OAoKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3YmE5 MmRmLi41MzUwOWNmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMDQgIE1pa2hhaWwg UG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VG TF0gUmVzZXQgIldlYktpdFRhYlRvTGlua3NQcmVmZXJlbmNlS2V5IiBpbiBEdW1wUmVuZGVyVHJl ZUNocm9tZTo6cmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc2NjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOiBV bnNraXBwZWQgZmFzdC9odG1sL3RhYi1vcmRlci5odG1sLgorCiAyMDEyLTA2LTAzICBTaGVyaWZm IEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMTE5MzU5LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAppbmRleCBlZDdk NGM5Li42NGE5ZTQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBl ZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZApAQCAtNTU5LDcgKzU1OSw2 IEBAIGZhc3QvZm9ybXMvc2VhcmNoLXRyYW5zZm9ybWVkLmh0bWwKIGZhc3QvZm9ybXMvc2VhcmNo LXpvb21lZC5odG1sCiBmYXN0L2Zvcm1zL3JhbmdlL3NsaWRlci1kZWxldGUtd2hpbGUtZHJhZ2dp bmctdGh1bWIuaHRtbAogZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbAotZmFzdC9odG1sL3RhYi1v cmRlci5odG1sCiBmYXN0L3JlcGFpbnQvc2VsZWN0aW9uLWNsZWFyLmh0bWwKIGZhc3QvcmVwYWlu dC90YWJsZS1jZWxsLW92ZXJmbG93Lmh0bWwKIGZhc3QvcmVwYWludC90ZXh0LWVtcGhhc2lzLWgu aHRtbApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4 IGNmY2FmMGUuLmIxY2I0YTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNi0wNCAgTWlraGFpbCBQb3pkbnlh a292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSZXNl dCAiV2ViS2l0VGFiVG9MaW5rc1ByZWZlcmVuY2VLZXkiIGluIER1bXBSZW5kZXJUcmVlQ2hyb21l OjpyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzY2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIExheW91dCB0ZXN0IGNvbnRyb2xsZXIgIldlYktpdFRh YlRvTGlua3NQcmVmZXJlbmNlS2V5IiBzZXR0aW5nIHNob3VsZCBiZSByZXNldCB0byBmYWxzZQor ICAgICAgICBvdGhlcndpc2UgTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RhYi1vcmRlci5odG1sIGlz IGZhaWxpbmcgYXMgaXQgaGFzIGEgbGluayBpbnNpZGUgdGhlIHRlc3QgZGVzY3JpcHRpb24gd2hp Y2ggbWlnaHQgCisgICAgICAgIGJlIGluY2x1ZGVkIGluIGZvY3VzIGNoYWluIChpZiAiV2ViS2l0 VGFiVG9MaW5rc1ByZWZlcmVuY2VLZXkiIHNldHRpbmcgaXMgc2V0IHRvIHRydWUpLiAKKworICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHA6CisgICAg ICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6cmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVl cyk6CisKIDIwMTItMDYtMDMgIFZhcnVuIEphaW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KIAog ICAgICAgICBbY2hyb21pdW1dIEFkZCBuZXcgZ2VzdHVyZSB0eXBlICh0d28gZmluZ2VyIHRhcCkg dGhhdCB0cmlnZ2VycyBjb250ZXh0IG1lbnUuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv ZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAppbmRleCA4NjJhNjE2Li44NThmYWNjIDEwMDY0 NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3Bw CisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAK QEAgLTI0MCw3ICsyNDAsNyBAQCB2b2lkIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpyZXNldERlZmF1 bHRzVG9Db25zaXN0ZW50VmFsdWVzKCkKICAgICBld2tfdmlld19zZXR0aW5nX21pbmltdW1fdGlt ZXJfaW50ZXJ2YWxfc2V0KGJyb3dzZXItPm1haW5WaWV3KCksIDAuMDEwKTsgLy8gMTAgbWlsbGlz ZWNvbmRzIChET01UaW1lcjo6c19taW5EZWZhdWx0VGltZXJJbnRlcnZhbCkKICAgICBld2tfdmll d19zZXR0aW5nX2VuYWJsZV93ZWJnbF9zZXQobWFpblZpZXcoKSwgRUlOQV9UUlVFKTsKICAgICBl d2tfdmlld19zZXR0aW5nX2VuYWJsZV9oeXBlcmxpbmtfYXVkaXRpbmdfc2V0KG1haW5WaWV3KCks IEVJTkFfRkFMU0UpOwotICAgIGV3a192aWV3X3NldHRpbmdfaW5jbHVkZV9saW5rc19pbl9mb2N1 c19jaGFpbl9zZXQobWFpblZpZXcoKSwgRUlOQV9UUlVFKTsKKyAgICBld2tfdmlld19zZXR0aW5n X2luY2x1ZGVfbGlua3NfaW5fZm9jdXNfY2hhaW5fc2V0KG1haW5WaWV3KCksIEVJTkFfRkFMU0Up OwogICAgIGV3a192aWV3X3NldHRpbmdfc2NyaXB0c19jYW5fYWNjZXNzX2NsaXBib2FyZF9zZXQo bWFpblZpZXcoKSwgRUlOQV9UUlVFKTsKIAogICAgIGV3a192aWV3X3pvb21fc2V0KG1haW5WaWV3 KCksIDEuMCwgMCwgMCk7Cg==