87665 2012-05-28 07:43:27 -0700 [BlackBerry] http authentication challenge issue when loading favicon 2012-05-28 19:58:31 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jonathan.dong.webkit webkit-unassigned charles.wei japhet joenotcharles leo.yang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 635215 0 jonathan.dong.webkit 2012-05-28 07:43:27 -0700 RIM PR: 160587 way to reproduce: if we try to load any site which needs http authentication, and when the authentication challenge pops up, we press cancel button to cancel the challenge, then the favicon loading will trigger the authentication challenge once again. root cause: favicon loading is triggered when the main resource has been loaded and parsed, so if we cancel the main resource loading, we should cancel the favicon loading as well. 635219 1 144360 jonathan.dong.webkit 2012-05-28 07:56:55 -0700 Created attachment 144360 Patch 635321 2 144360 rwlbuis 2012-05-28 10:44:01 -0700 Comment on attachment 144360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144360&action=review Ok. > Source/WebCore/ChangeLog:8 > + Provided the TargetType when generating a favicon loading Provide the TargetType > Source/WebCore/ChangeLog:9 > + request. Loading favicon is triggered after the main resource Loading favicons > Source/WebCore/ChangeLog:14 > + loading, which may confuse user. the user. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:764 > + // The favicon loading is triggerred after the main resource has been loaded Typo: triggered > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:767 > + // load. If not we will receive another challenge which may confuse user. Slightly better: // and parsed, so if we cancel the authentication challenge when loading the main // resource, we should also cancel loading the favicon when it starts to // load. If not we will receive another challenge which may confuse the user. 635493 3 144418 jonathan.dong.webkit 2012-05-28 18:36:32 -0700 Created attachment 144418 Patch 635522 4 144418 webkit.review.bot 2012-05-28 19:58:26 -0700 Comment on attachment 144418 Patch Clearing flags on attachment: 144418 Committed r118716: <http://trac.webkit.org/changeset/118716> 635523 5 webkit.review.bot 2012-05-28 19:58:31 -0700 All reviewed patches have been landed. Closing bug. 144360 2012-05-28 07:56:55 -0700 2012-05-28 18:36:16 -0700 Patch bug-87665-20120528225651.patch text/plain 3391 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGViZDUwZDUyNjlmOTll MmU3ZWQ1ODVjZjBjODllYWRlNzU4ZDZmZS4uY2M5ZDM5N2ZlYmZlNGI0NmQ0YzMyOWI2NmRmMjgy ZWI5NWRhN2Q3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA1LTI4ICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIGh0dHAgYXV0aGVudGljYXRpb24gY2hhbGxlbmdlIGlzc3VlIHdoZW4gbG9h ZGluZyBmYXZpY29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzY2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByb3ZpZGVkIHRoZSBUYXJnZXRUeXBlIHdoZW4gZ2VuZXJhdGluZyBhIGZhdmljb24gbG9h ZGluZworICAgICAgICByZXF1ZXN0LiBMb2FkaW5nIGZhdmljb24gaXMgdHJpZ2dlcmVkIGFmdGVy IHRoZSBtYWluIHJlc291cmNlCisgICAgICAgIGhhcyBiZWVuIGxvYWRlZCBhbmQgcGFyc2VkLCBz byBpZiB3ZSBjYW5jZWwgdGhlIGF1dGhlbnRpY2F0aW9uCisgICAgICAgIGNoYWxsZW5nZSB3aGVu IGxvYWRpbmcgbWFpbiByZXNvdXJjZSwgd2Ugc2hvdWxkIGFsc28gY2FuY2VsCisgICAgICAgIGxv YWRpbmcgdGhlIGZhdmljb24gd2hlbiBpdCBzdGFydHMgdG8gbG9hZC4gSWYgbm90IHdlIHdpbGwK KyAgICAgICAgcmVjZWl2ZSBhbm90aGVyIGNoYWxsZW5nZSBhZnRlciB3ZSBjYW5jZWxlZCB0aGUg bWFpbiByZXNvdXJjZQorICAgICAgICBsb2FkaW5nLCB3aGljaCBtYXkgY29uZnVzZSB1c2VyLgor CisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgSm9lIE1hc29uIDxqbWFzb25AcmltLmNv bT4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBvZiBubyBiZWhhdmlvciBjaGFuZ2Vz LgorCisgICAgICAgICogbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJY29uTG9hZGVyOjpzdGFydExvYWRpbmcpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtK b2I6OnNlbmRSZXF1ZXN0V2l0aENyZWRlbnRpYWxzKToKKwogMjAxMi0wNS0yOCAgS2Vpc2hpIEhh dHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBFeHBvc2UgdmFsdWUgbG9jYWxp emF0aW9uIGZ1bmN0aW9uIG9mIEhUTUxJbnB1dEVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9pY29uL0ljb25Mb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L2ljb24vSWNvbkxvYWRlci5jcHAKaW5kZXggMWIwN2M4MzNjZDgwMjJhNDc5ZTI4NTU4NzlhN2Zj OTNmZWZkZmViZC4uOWQ3MzNkYTRkOGI5MDEwNjE5NmNhYzRiZWQzNDc5MTY4MGE1MGVjYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAKQEAgLTYwLDYgKzYwLDkg QEAgdm9pZCBJY29uTG9hZGVyOjpzdGFydExvYWRpbmcoKQogICAgICAgICByZXR1cm47CiAKICAg ICBSZXNvdXJjZVJlcXVlc3QgcmVzb3VyY2VSZXF1ZXN0KG1fZnJhbWUtPmxvYWRlcigpLT5pY29u KCktPnVybCgpKTsKKyNpZiBQTEFURk9STShCTEFDS0JFUlJZKQorICAgIHJlc291cmNlUmVxdWVz dC5zZXRUYXJnZXRUeXBlKFJlc291cmNlUmVxdWVzdDo6VGFyZ2V0SXNGYXZpY29uKTsKKyNlbmRp ZgogICAgIHJlc291cmNlUmVxdWVzdC5zZXRQcmlvcml0eShSZXNvdXJjZUxvYWRQcmlvcml0eUxv dyk7CiAKICAgICBtX3Jlc291cmNlID0gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+Y2FjaGVkUmVzb3Vy Y2VMb2FkZXIoKS0+cmVxdWVzdFJhd1Jlc291cmNlKHJlc291cmNlUmVxdWVzdCwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9i LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr Sm9iLmNwcAppbmRleCBmYWIzYjI3ZTZjMTdhY2U2YzAzN2NiMTY1ZDI5MWI5NDg3YzRlYzNmLi41 NGJlNzQ2MmIzYWNlNTk1OTU3YTc3MDhmNjQ3MDkwZTdlOWUxNGE4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2Iu Y3BwCkBAIC03NjAsNiArNzYwLDE0IEBAIGJvb2wgTmV0d29ya0pvYjo6c2VuZFJlcXVlc3RXaXRo Q3JlZGVudGlhbHMoUHJvdGVjdGlvblNwYWNlU2VydmVyVHlwZSB0eXBlLCBQcm90CiAgICAgICAg IG1faGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5tX2N1cnJlbnRXZWJDaGFsbGVuZ2UgPSBBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZShwcm90ZWN0aW9uU3BhY2UsIGNyZWRlbnRpYWwsIDAsIG1fcmVzcG9u c2UsIFJlc291cmNlRXJyb3IoKSk7CiAgICAgICAgIG1faGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5t X2N1cnJlbnRXZWJDaGFsbGVuZ2Uuc2V0U3RvcmVkKHRydWUpOwogICAgIH0gZWxzZSB7CisgICAg ICAgIGlmIChtX2hhbmRsZS0+Zmlyc3RSZXF1ZXN0KCkudGFyZ2V0VHlwZSgpID09IFJlc291cmNl UmVxdWVzdDo6VGFyZ2V0SXNGYXZpY29uKSB7CisgICAgICAgICAgICAvLyBUaGUgZmF2aWNvbiBs b2FkaW5nIGlzIHRyaWdnZXJyZWQgYWZ0ZXIgdGhlIG1haW4gcmVzb3VyY2UgaGFzIGJlZW4gbG9h ZGVkCisgICAgICAgICAgICAvLyBhbmQgcGFyc2VkLCBzbyBpZiB3ZSBjYW5jZWwgdGhlIGF1dGhl bnRpY2F0aW9uIGNoYWxsZW5nZSB3aGVuIGxvYWRpbmcgbWFpbgorICAgICAgICAgICAgLy8gcmVz b3VyY2UsIHdlIHNob3VsZCBhbHNvIGNhbmNlbCBsb2FkaW5nIHRoZSBmYXZpY29uIHdoZW4gZmF2 aWNvbiBzdGFydCB0bworICAgICAgICAgICAgLy8gbG9hZC4gSWYgbm90IHdlIHdpbGwgcmVjZWl2 ZSBhbm90aGVyIGNoYWxsZW5nZSB3aGljaCBtYXkgY29uZnVzZSB1c2VyLgorICAgICAgICAgICAg cmV0dXJuIGZhbHNlOworICAgICAgICB9CisKICAgICAgICAgLy8gQ3JlZGVudGlhbFN0b3JlIGlz IGVtcHR5LiBBc2sgdGhlIHVzZXIgdmlhIGRpYWxvZy4KICAgICAgICAgU3RyaW5nIHVzZXJuYW1l OwogICAgICAgICBTdHJpbmcgcGFzc3dvcmQ7Cg== 144418 2012-05-28 18:36:32 -0700 2012-05-28 19:58:26 -0700 Patch bug-87665-20120529093629.patch text/plain 3421 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWNjYjg3MDMwODExZjA4 NzE4YTU3MTcwZjdiMGJlNDAxYTY3N2U5Yy4uODIxNmQyNjhlMGY1MjNjNjFmMmM4YjE0ODAzNjZl YzJlYjk5NzdiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA1LTI4ICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIGh0dHAgYXV0aGVudGljYXRpb24gY2hhbGxlbmdlIGlzc3VlIHdoZW4gbG9h ZGluZyBmYXZpY29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzY2NQorCisgICAgICAgIFJldmlld2VkIGJ5IFJvYiBCdWlzLgorCisgICAgICAgIFBy b3ZpZGUgdGhlIFRhcmdldFR5cGUgd2hlbiBnZW5lcmF0aW5nIGEgZmF2aWNvbiBsb2FkaW5nCisg ICAgICAgIHJlcXVlc3QuIExvYWRpbmcgZmF2aWNvbnMgaXMgdHJpZ2dlcmVkIGFmdGVyIHRoZSBt YWluIHJlc291cmNlCisgICAgICAgIGhhcyBiZWVuIGxvYWRlZCBhbmQgcGFyc2VkLCBzbyBpZiB3 ZSBjYW5jZWwgdGhlIGF1dGhlbnRpY2F0aW9uCisgICAgICAgIGNoYWxsZW5nZSB3aGVuIGxvYWRp bmcgbWFpbiByZXNvdXJjZSwgd2Ugc2hvdWxkIGFsc28gY2FuY2VsCisgICAgICAgIGxvYWRpbmcg dGhlIGZhdmljb24gd2hlbiBpdCBzdGFydHMgdG8gbG9hZC4gSWYgbm90IHdlIHdpbGwKKyAgICAg ICAgcmVjZWl2ZSBhbm90aGVyIGNoYWxsZW5nZSBhZnRlciB3ZSBjYW5jZWxlZCB0aGUgbWFpbiBy ZXNvdXJjZQorICAgICAgICBsb2FkaW5nLCB3aGljaCBtYXkgY29uZnVzZSB0aGUgdXNlci4KKwor ICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEpvZSBNYXNvbiA8am1hc29uQHJpbS5jb20+ CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugb2Ygbm8gYmVoYXZpb3IgY2hhbmdlcy4K KworICAgICAgICAqIGxvYWRlci9pY29uL0ljb25Mb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SWNvbkxvYWRlcjo6c3RhcnRMb2FkaW5nKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3Jr L2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9i OjpzZW5kUmVxdWVzdFdpdGhDcmVkZW50aWFscyk6CisKIDIwMTItMDUtMjggIERhdmlkIEJhcnRv biAgPGRiYXJ0b25AbWF0aHNjcmliZS5jb20+CiAKICAgICAgICAgbWF0aG1sL3ByZXNlbnRhdGlv bi9tby1zdHJldGNoLmh0bWwgYW5kIG1yb290LXByZWYtd2lkdGguaHRtbCB0ZXN0cyBmYWlsIG9u IE1hYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcAppbmRleCAxYjA3 YzgzM2NkODAyMmE0NzllMjg1NTg3OWE3ZmM5M2ZlZmRmZWJkLi45ZDczM2RhNGQ4YjkwMTA2MTk2 Y2FjNGJlZDM0NzkxNjgwYTUwZWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv aWNvbi9JY29uTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29u TG9hZGVyLmNwcApAQCAtNjAsNiArNjAsOSBAQCB2b2lkIEljb25Mb2FkZXI6OnN0YXJ0TG9hZGlu ZygpCiAgICAgICAgIHJldHVybjsKIAogICAgIFJlc291cmNlUmVxdWVzdCByZXNvdXJjZVJlcXVl c3QobV9mcmFtZS0+bG9hZGVyKCktPmljb24oKS0+dXJsKCkpOworI2lmIFBMQVRGT1JNKEJMQUNL QkVSUlkpCisgICAgcmVzb3VyY2VSZXF1ZXN0LnNldFRhcmdldFR5cGUoUmVzb3VyY2VSZXF1ZXN0 OjpUYXJnZXRJc0Zhdmljb24pOworI2VuZGlmCiAgICAgcmVzb3VyY2VSZXF1ZXN0LnNldFByaW9y aXR5KFJlc291cmNlTG9hZFByaW9yaXR5TG93KTsKIAogICAgIG1fcmVzb3VyY2UgPSBtX2ZyYW1l LT5kb2N1bWVudCgpLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigpLT5yZXF1ZXN0UmF3UmVzb3VyY2Uo cmVzb3VyY2VSZXF1ZXN0LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmluZGV4IGZhYjNiMjdlNmMxN2FjZTZj MDM3Y2IxNjVkMjkxYjk0ODdjNGVjM2YuLjk5ZjNmMjIxY2M5NDE2YjQwYzEzMTljOWI2ZWIxM2Ez MTE3OTA2NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxh Y2tiZXJyeS9OZXR3b3JrSm9iLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKQEAgLTc2MCw2ICs3NjAsMTQgQEAgYm9vbCBO ZXR3b3JrSm9iOjpzZW5kUmVxdWVzdFdpdGhDcmVkZW50aWFscyhQcm90ZWN0aW9uU3BhY2VTZXJ2 ZXJUeXBlIHR5cGUsIFByb3QKICAgICAgICAgbV9oYW5kbGUtPmdldEludGVybmFsKCktPm1fY3Vy cmVudFdlYkNoYWxsZW5nZSA9IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKHByb3RlY3Rpb25TcGFj ZSwgY3JlZGVudGlhbCwgMCwgbV9yZXNwb25zZSwgUmVzb3VyY2VFcnJvcigpKTsKICAgICAgICAg bV9oYW5kbGUtPmdldEludGVybmFsKCktPm1fY3VycmVudFdlYkNoYWxsZW5nZS5zZXRTdG9yZWQo dHJ1ZSk7CiAgICAgfSBlbHNlIHsKKyAgICAgICAgaWYgKG1faGFuZGxlLT5maXJzdFJlcXVlc3Qo KS50YXJnZXRUeXBlKCkgPT0gUmVzb3VyY2VSZXF1ZXN0OjpUYXJnZXRJc0Zhdmljb24pIHsKKyAg ICAgICAgICAgIC8vIFRoZSBmYXZpY29uIGxvYWRpbmcgaXMgdHJpZ2dlcnJlZCBhZnRlciB0aGUg bWFpbiByZXNvdXJjZSBoYXMgYmVlbiBsb2FkZWQKKyAgICAgICAgICAgIC8vIGFuZCBwYXJzZWQs IHNvIGlmIHdlIGNhbmNlbCB0aGUgYXV0aGVudGljYXRpb24gY2hhbGxlbmdlIHdoZW4gbG9hZGlu ZyB0aGUgbWFpbgorICAgICAgICAgICAgLy8gcmVzb3VyY2UsIHdlIHNob3VsZCBhbHNvIGNhbmNl bCBsb2FkaW5nIHRoZSBmYXZpY29uIHdoZW4gaXQgc3RhcnRzIHRvCisgICAgICAgICAgICAvLyBs b2FkLiBJZiBub3Qgd2Ugd2lsbCByZWNlaXZlIGFub3RoZXIgY2hhbGxlbmdlIHdoaWNoIG1heSBj b25mdXNlIHRoZSB1c2VyLgorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9CisK ICAgICAgICAgLy8gQ3JlZGVudGlhbFN0b3JlIGlzIGVtcHR5LiBBc2sgdGhlIHVzZXIgdmlhIGRp YWxvZy4KICAgICAgICAgU3RyaW5nIHVzZXJuYW1lOwogICAgICAgICBTdHJpbmcgcGFzc3dvcmQ7 Cg==