8765 2006-05-07 01:26:06 -0700 Random crashes on TOT since the form state change 2006-05-07 22:54:03 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED P1 Major --- 1 mjs darin mitz oldest_to_newest 41426 0 mjs 2006-05-07 01:26:06 -0700 The recent form state change apparently caused a bunch of random memory trashers. Here's one set of steps that consistently reproduces a crash for me: 1) Go to http://www.cnn.com and wait for it to fully load. 2) Click any link. 3) Go back. Darin has a patch for this attached to a bug where this was misdiagnosed as the cause. 41434 1 mitz 2006-05-07 04:46:53 -0700 Darin's patch is attached to bug 8753. 41449 2 8144 darin 2006-05-07 10:48:54 -0700 Created attachment 8144 patch based on Mitz's analysis 41451 3 8145 darin 2006-05-07 10:56:18 -0700 Created attachment 8145 patch with improved change log 41498 4 8145 mjs 2006-05-07 21:45:42 -0700 Comment on attachment 8145 patch with improved change log r=me 41500 5 mjs 2006-05-07 21:52:21 -0700 People have been complaining about the crasher so I went ahead and commited this, hope you don't mind, Darin. 41503 6 darin 2006-05-07 22:54:03 -0700 (In reply to comment #5) > People have been complaining about the crasher so I went ahead and commited > this, hope you don't mind, Darin. Not at all. I've been waiting on review or I would have committed a while back. 8144 2006-05-07 10:48:54 -0700 2006-05-07 10:56:18 -0700 patch based on Mitz's analysis FormElementHashPatch.txt text/plain 3367 darin SW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDE0MjE2KQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDc4LDcgKzMwNzgsOCBAQAogCiBWZWN0b3I8U3RyaW5n PiBEb2N1bWVudDo6Zm9ybUVsZW1lbnRzU3RhdGUoKSBjb25zdAogewotICAgIFZlY3RvcjxTdHJp bmc+IHN0YXRlVmVjdG9yKG1fZm9ybUVsZW1lbnRzV2l0aFN0YXRlLnNpemUoKSAqIDMpOworICAg IFZlY3RvcjxTdHJpbmc+IHN0YXRlVmVjdG9yOworICAgIHN0YXRlVmVjdG9yLnJlc2VydmVDYXBh Y2l0eShtX2Zvcm1FbGVtZW50c1dpdGhTdGF0ZS5zaXplKCkgKiAzKTsKICAgICB0eXBlZGVmIEhh c2hTZXQ8SFRNTEdlbmVyaWNGb3JtRWxlbWVudCo+Ojpjb25zdF9pdGVyYXRvciBJdGVyYXRvcjsK ICAgICBJdGVyYXRvciBlbmQgPSBtX2Zvcm1FbGVtZW50c1dpdGhTdGF0ZS5lbmQoKTsKICAgICBm b3IgKEl0ZXJhdG9yIGl0ID0gbV9mb3JtRWxlbWVudHNXaXRoU3RhdGUuYmVnaW4oKTsgaXQgIT0g ZW5kOyArK2l0KSB7CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQyMTYpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDA2LTA1LTA2ICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6IChXZWJDb3JlOjpEb2N1bWVudDo6Zm9ybUVsZW1l bnRzU3RhdGUpOiBGaXhlZCBtaXN0YWtlIHdoZXJlIHRoZQorICAgICAgICB2ZWN0b3IgaGFzIGFu IGluaXRpYWwgc2l6ZSBhbmQgaW5zdGVhZCBzaG91bGQgaGF2ZSBhbiBpbml0aWFsIGNhcGFjaXR5 LiBNb3N0bHkgaGFybWxlc3MsCisgICAgICAgIGJ1dCBjZXJ0YWlubHkgbm90IHdoYXQgdGhpcyBj b2RlIHdhcyBpbnRlbmRlZCB0byBkbywgYW5kIGh1cnRzIHBlcmZvcm1hbmNlLgorCiAyMDA2LTA1 LTA2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgV2Vi Q29yZUZvbnQgdG8gRm9udFBsYXRmb3JtRGF0YSBhbmQgV2ViVGV4dFJlbmRlcmVyIHRvIEZvbnRE YXRhLiAgTWVyZ2UgdGhlbSBpbnRvIHRoZQpJbmRleDogSmF2YVNjcmlwdENvcmUva3htbGNvcmUv SGFzaFNldC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2t4bWxjb3JlL0hhc2hTZXQu aAkocmV2aXNpb24gMTQyMTYpCisrKyBKYXZhU2NyaXB0Q29yZS9reG1sY29yZS9IYXNoU2V0LmgJ KHdvcmtpbmcgY29weSkKQEAgLTI3NCw4ICsyNzQsNyBAQAogICAgIHsKICAgICAgICAgaWYgKGl0 Lm1faW1wbCA9PSBtX2ltcGwuZW5kKCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIC8v IFVzZSAiKCppdCkuIiBpbnN0ZWFkIG9mICJpdC0+IiB0byB3b3JrIGFyb3VuZCBhIHByb2JsZW0g c2VlbiB3aXRoIHRoZSBWaXN1YWwgQysrIGNvbXBpbGVyLgotICAgICAgICAoKml0KS5+VmFsdWVU eXBlKCk7CisgICAgICAgIFJlZkNvdW50ZXI8VmFsdWVUcmFpdHMsIFN0b3JhZ2VUcmFpdHM+Ojpk ZXJlZigqaXQubV9pbXBsKTsKICAgICAgICAgbV9pbXBsLnJlbW92ZShpdC5tX2ltcGwpOwogICAg IH0KIApJbmRleDogSmF2YVNjcmlwdENvcmUva3htbGNvcmUvSGFzaE1hcC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEphdmFTY3JpcHRDb3JlL2t4bWxjb3JlL0hhc2hNYXAuaAkocmV2aXNpb24gMTQyMTYpCisr KyBKYXZhU2NyaXB0Q29yZS9reG1sY29yZS9IYXNoTWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4 OCw4ICsyODgsNyBAQAogICAgIHsKICAgICAgICAgaWYgKGl0Lm1faW1wbCA9PSBtX2ltcGwuZW5k KCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIC8vIFVzZSAiKCppdCkuIiBpbnN0ZWFk IG9mICJpdC0+IiB0byB3b3JrIGFyb3VuZCBhIHByb2JsZW0gc2VlbiB3aXRoIHRoZSBWaXN1YWwg QysrIGNvbXBpbGVyLgotICAgICAgICAoKml0KS5+VmFsdWVUeXBlKCk7CisgICAgICAgIFJlZkNv dW50ZXI8VmFsdWVUcmFpdHMsIFZhbHVlU3RvcmFnZVRyYWl0cz46OmRlcmVmKCppdC5tX2ltcGwp OwogICAgICAgICBtX2ltcGwucmVtb3ZlKGl0Lm1faW1wbCk7CiAgICAgfQogCkluZGV4OiBKYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiAxNDIxNikKKysrIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDA2LTA1LTA3ICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAtIGZpeCBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lk PTg3NjUKKyAgICAgICAgICBSYW5kb20gY3Jhc2hlcyBvbiBUT1Qgc2luY2UgdGhlIGZvcm0gc3Rh dGUgY2hhbmdlCisKKyAgICAgICAgSSBoYXZlbid0IGZpZ3VyZWQgb3V0IGhvdyB0byBjb25zdHJ1 Y3QgYSB0ZXN0IGZvciB0aGlzLgorCisgICAgICAgICoga3htbGNvcmUvSGFzaE1hcC5oOiAoS1hN TENvcmU6Ojo6cmVtb3ZlKTogVXNlIFJlZkNvdW50ZXI6OmRlcmVmIGluc3RlYWQgb2YgY2FsbGlu ZworICAgICAgICB+VmFsdWVUeXBlLCBiZWNhdXNlIH5WYWx1ZVR5cGUgaXMgb2Z0ZW4gYSBkb3Vi bGUtZGVzdHJveSEgVGhlIFJlZkNvdW50ZXIgdGVtcGxhdGUKKyAgICAgICAgaGFuZGxlcyB0aGlz IHByb3Blcmx5IGFuZCBpcyB3aGF0J3MgdXNlZCBlbHNld2hlcmUgZm9yIHRoZSBzYW1lIHB1cnBv c2UuCisgICAgICAgICoga3htbGNvcmUvSGFzaFNldC5oOiAoS1hNTENvcmU6Ojo6cmVtb3ZlKTog RGl0dG8uCisKIDIwMDYtMDUtMDUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIC0gaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD04 NzIyCg== 8145 2006-05-07 10:56:18 -0700 2006-05-07 21:45:42 -0700 patch with improved change log FormElementHashPatch.txt text/plain 3719 darin SW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDE0MjE2KQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDc4LDcgKzMwNzgsOCBAQAogCiBWZWN0b3I8U3RyaW5n PiBEb2N1bWVudDo6Zm9ybUVsZW1lbnRzU3RhdGUoKSBjb25zdAogewotICAgIFZlY3RvcjxTdHJp bmc+IHN0YXRlVmVjdG9yKG1fZm9ybUVsZW1lbnRzV2l0aFN0YXRlLnNpemUoKSAqIDMpOworICAg IFZlY3RvcjxTdHJpbmc+IHN0YXRlVmVjdG9yOworICAgIHN0YXRlVmVjdG9yLnJlc2VydmVDYXBh Y2l0eShtX2Zvcm1FbGVtZW50c1dpdGhTdGF0ZS5zaXplKCkgKiAzKTsKICAgICB0eXBlZGVmIEhh c2hTZXQ8SFRNTEdlbmVyaWNGb3JtRWxlbWVudCo+Ojpjb25zdF9pdGVyYXRvciBJdGVyYXRvcjsK ICAgICBJdGVyYXRvciBlbmQgPSBtX2Zvcm1FbGVtZW50c1dpdGhTdGF0ZS5lbmQoKTsKICAgICBm b3IgKEl0ZXJhdG9yIGl0ID0gbV9mb3JtRWxlbWVudHNXaXRoU3RhdGUuYmVnaW4oKTsgaXQgIT0g ZW5kOyArK2l0KSB7CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQyMTYpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDA2LTA1LTA2ICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6IChXZWJDb3JlOjpEb2N1bWVudDo6Zm9ybUVsZW1l bnRzU3RhdGUpOiBGaXhlZCBtaXN0YWtlIHdoZXJlIHRoZQorICAgICAgICB2ZWN0b3IgaGFzIGFu IGluaXRpYWwgc2l6ZSBhbmQgaW5zdGVhZCBzaG91bGQgaGF2ZSBhbiBpbml0aWFsIGNhcGFjaXR5 LiBNb3N0bHkgaGFybWxlc3MsCisgICAgICAgIGJ1dCBjZXJ0YWlubHkgbm90IHdoYXQgdGhpcyBj b2RlIHdhcyBpbnRlbmRlZCB0byBkbywgYW5kIGh1cnRzIHBlcmZvcm1hbmNlLgorCiAyMDA2LTA1 LTA2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgV2Vi Q29yZUZvbnQgdG8gRm9udFBsYXRmb3JtRGF0YSBhbmQgV2ViVGV4dFJlbmRlcmVyIHRvIEZvbnRE YXRhLiAgTWVyZ2UgdGhlbSBpbnRvIHRoZQpJbmRleDogSmF2YVNjcmlwdENvcmUva3htbGNvcmUv SGFzaFNldC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2t4bWxjb3JlL0hhc2hTZXQu aAkocmV2aXNpb24gMTQyMTYpCisrKyBKYXZhU2NyaXB0Q29yZS9reG1sY29yZS9IYXNoU2V0LmgJ KHdvcmtpbmcgY29weSkKQEAgLTI3NCw4ICsyNzQsNyBAQAogICAgIHsKICAgICAgICAgaWYgKGl0 Lm1faW1wbCA9PSBtX2ltcGwuZW5kKCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIC8v IFVzZSAiKCppdCkuIiBpbnN0ZWFkIG9mICJpdC0+IiB0byB3b3JrIGFyb3VuZCBhIHByb2JsZW0g c2VlbiB3aXRoIHRoZSBWaXN1YWwgQysrIGNvbXBpbGVyLgotICAgICAgICAoKml0KS5+VmFsdWVU eXBlKCk7CisgICAgICAgIFJlZkNvdW50ZXI8VmFsdWVUcmFpdHMsIFN0b3JhZ2VUcmFpdHM+Ojpk ZXJlZigqaXQubV9pbXBsKTsKICAgICAgICAgbV9pbXBsLnJlbW92ZShpdC5tX2ltcGwpOwogICAg IH0KIApJbmRleDogSmF2YVNjcmlwdENvcmUva3htbGNvcmUvSGFzaE1hcC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEphdmFTY3JpcHRDb3JlL2t4bWxjb3JlL0hhc2hNYXAuaAkocmV2aXNpb24gMTQyMTYpCisr KyBKYXZhU2NyaXB0Q29yZS9reG1sY29yZS9IYXNoTWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4 OCw4ICsyODgsNyBAQAogICAgIHsKICAgICAgICAgaWYgKGl0Lm1faW1wbCA9PSBtX2ltcGwuZW5k KCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIC8vIFVzZSAiKCppdCkuIiBpbnN0ZWFk IG9mICJpdC0+IiB0byB3b3JrIGFyb3VuZCBhIHByb2JsZW0gc2VlbiB3aXRoIHRoZSBWaXN1YWwg QysrIGNvbXBpbGVyLgotICAgICAgICAoKml0KS5+VmFsdWVUeXBlKCk7CisgICAgICAgIFJlZkNv dW50ZXI8VmFsdWVUcmFpdHMsIFZhbHVlU3RvcmFnZVRyYWl0cz46OmRlcmVmKCppdC5tX2ltcGwp OwogICAgICAgICBtX2ltcGwucmVtb3ZlKGl0Lm1faW1wbCk7CiAgICAgfQogCkluZGV4OiBKYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiAxNDIxNikKKysrIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDA2LTA1LTA3ICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAtIGZpeCBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lk PTg3NjUKKyAgICAgICAgICBSYW5kb20gY3Jhc2hlcyBvbiBUT1Qgc2luY2UgdGhlIGZvcm0gc3Rh dGUgY2hhbmdlCisKKyAgICAgICAgSSBoYXZlbid0IGZpZ3VyZWQgb3V0IGhvdyB0byBjb25zdHJ1 Y3QgYSB0ZXN0IGZvciB0aGlzLCBidXQgdGhpcyBkb2VzIHNlZW0gdG8gZml4IHRoZQorICAgICAg ICBwcm9ibGVtOyBNaXR6IG1lbnRpb25lZCB0aGF0IGEgZG91YmxlLWRlc3Ryb3kgd2FzIG9jY3Vy cmluZyBpbiB0aGVzZSBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBreG1sY29yZS9IYXNoTWFwLmg6 IChLWE1MQ29yZTo6SGFzaE1hcDo6cmVtb3ZlKTogVXNlIFJlZkNvdW50ZXI6OmRlcmVmIGluc3Rl YWQgb2YgY2FsbGluZworICAgICAgICB+VmFsdWVUeXBlLCBiZWNhdXNlIH5WYWx1ZVR5cGUgb2Z0 ZW4gcmVzdWx0cyBpbiBhIGRvdWJsZS1kZXN0cm95LCBzaW5jZSB0aGUgSGFzaFRhYmxlIGFsc28K KyAgICAgICAgZGVzdHJveXMgdGhlIGVsZW1lbnQgYmFzZWQgb24gdGhlIHN0b3JhZ2UgdHlwZS4g VGhlIFJlZkNvdW50ZXIgdGVtcGxhdGUgY29ycmVjdGx5IGRvZXMgd29yaworICAgICAgICBvbmx5 IGluIGNhc2VzIHdoZXJlIFZhbHVlVHlwZSBhbmQgVmFsdWVTdG9yYWdlVHlwZSBkaWZmZXJlIGFu ZCB0aGlzIGNsYXNzIGlzIHdoYXQncyB1c2VkCisgICAgICAgIGVsc2V3aGVyZSBmb3IgdGhlIHNh bWUgcHVycG9zZTsgSSBzb21laG93IG1pc3NlZCB0aGlzIGNhc2Ugd2hlbiBvcHRpbWl6aW5nIEhh c2hNYXAuCisgICAgICAgICoga3htbGNvcmUvSGFzaFNldC5oOiAoS1hNTENvcmU6Okhhc2hTZXQ6 OnJlbW92ZSk6IERpdHRvLgorCiAyMDA2LTA1LTA1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxl LmNvbT4KIAogICAgICAgICAtIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODcyMgo=