87636 2012-05-28 01:43:17 -0700 [EFL] Compilation warning in DumpRenderTreeView.cpp 2012-05-29 00:51:46 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 634997 0 cdumez 2012-05-28 01:43:17 -0700 We get the following compilation warning on the build bot: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:135:36: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘int64_t {aka long int}’ [-Wformat] 634999 1 144304 cdumez 2012-05-28 01:44:42 -0700 Created attachment 144304 Patch 635027 2 144304 gyuyoung.kim 2012-05-28 02:11:29 -0700 Comment on attachment 144304 Patch Looks fine. By the way, don't you need to fix return type as well ? static *int64_t* onExceededApplicationCacheQuota ? 635042 3 cdumez 2012-05-28 02:41:31 -0700 (In reply to comment #2) > (From update of attachment 144304 [details]) > Looks fine. By the way, don't you need to fix return type as well ? > > static *int64_t* onExceededApplicationCacheQuota ? It makes sense. 635047 4 144310 cdumez 2012-05-28 02:45:14 -0700 Created attachment 144310 Patch 635100 5 144310 gyuyoung.kim 2012-05-28 03:53:55 -0700 Comment on attachment 144310 Patch Looks good to me now. 635177 6 144310 rakuco 2012-05-28 06:39:27 -0700 Comment on attachment 144310 Patch Looks good, thanks. 635679 7 144310 webkit.review.bot 2012-05-29 00:51:40 -0700 Comment on attachment 144310 Patch Clearing flags on attachment: 144310 Committed r118729: <http://trac.webkit.org/changeset/118729> 635680 8 webkit.review.bot 2012-05-29 00:51:46 -0700 All reviewed patches have been landed. Closing bug. 144304 2012-05-28 01:44:42 -0700 2012-05-28 02:45:14 -0700 Patch 87636_warning.patch text/plain 1705 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiNGUz NGRkLi42ZTU5NDU5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMjggIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBDb21waWxhdGlvbiB3 YXJuaW5nIGluIER1bXBSZW5kZXJUcmVlVmlldy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdhcm5pbmcgaW4gRHVtcFJl bmRlclRyZWVWaWV3LmNwcCBjYXVzZWQgYnkgd3JvbmcKKyAgICAgICAgZm9ybWF0IHNwZWNpZmll ciBpbiBwcmludGYoKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVy VHJlZVZpZXcuY3BwOgorICAgICAgICAob25FeGNlZWRlZEFwcGxpY2F0aW9uQ2FjaGVRdW90YSk6 CisKIDIwMTItMDUtMjcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gRW5hYmxlIGJsb2Igc3VwcG9ydCBmb3Ig dGhlIEVGTCBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJl bmRlclRyZWVWaWV3LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJl ZVZpZXcuY3BwCmluZGV4IGY5ZjhmNjUuLmVlNTQ4ZDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwCkBAIC0xMjgsNyArMTI4LDcgQEAgc3Rh dGljIHVpbnQ2NF90IG9uRXhjZWVkZWRBcHBsaWNhdGlvbkNhY2hlUXVvdGEoRXdrX1ZpZXdfU21h cnRfRGF0YSosIEV3a19TZWN1cmkKICAgICAgICAgLy8gc3VmZmljaWVudCB0byBqdXN0IGdldCBh IHJhbmdlIG9mIDEwMDAwIHRvIGRldGVybWluZSBpZiB3ZSB3ZXJlCiAgICAgICAgIC8vIGFib3Zl IG9yIGJlbG93IGEgdGhyZXNob2xkLgogICAgICAgICBpbnQ2NF90IHRydW5jYXRlZFNwYWNlTmVl ZGVkID0gKHRvdGFsU3BhY2VOZWVkZWQgLyAxMDAwMCkgKiAxMDAwMDsKLSAgICAgICAgcHJpbnRm KCJVSSBERUxFR0FURSBBUFBMSUNBVElPTiBDQUNIRSBDQUxMQkFDSzogZXhjZWVkZWRBcHBsaWNh dGlvbkNhY2hlT3JpZ2luUXVvdGFGb3JTZWN1cml0eU9yaWdpbjp7JXMsICVzLCAlaX0gdG90YWxT cGFjZU5lZWRlZDp+JWxsdVxuIiwKKyAgICAgICAgcHJpbnRmKCJVSSBERUxFR0FURSBBUFBMSUNB VElPTiBDQUNIRSBDQUxMQkFDSzogZXhjZWVkZWRBcHBsaWNhdGlvbkNhY2hlT3JpZ2luUXVvdGFG b3JTZWN1cml0eU9yaWdpbjp7JXMsICVzLCAlaX0gdG90YWxTcGFjZU5lZWRlZDp+JWxsZFxuIiwK ICAgICAgICAgICAgICAgIGV3a19zZWN1cml0eV9vcmlnaW5fcHJvdG9jb2xfZ2V0KG9yaWdpbiks CiAgICAgICAgICAgICAgICBld2tfc2VjdXJpdHlfb3JpZ2luX2hvc3RfZ2V0KG9yaWdpbiksCiAg ICAgICAgICAgICAgICBld2tfc2VjdXJpdHlfb3JpZ2luX3BvcnRfZ2V0KG9yaWdpbiksCg== 144310 2012-05-28 02:45:14 -0700 2012-05-29 00:51:39 -0700 Patch 87636_warning.patch text/plain 4268 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA1OTc4ODY5Li5lMDg3MzYwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDUtMjggIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhl LmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBDb21waWxhdGlvbiB3YXJuaW5nIGlu IER1bXBSZW5kZXJUcmVlVmlldy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg3NjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IHJldHVybiB0eXBlIG9mIGV4Y2VlZGVkX2FwcGxpY2F0aW9uX2Nh Y2hlX3F1b3RhIGNhbGxiYWNrLCBpdAorICAgICAgICBzaG91bGQgYmUgaW50NjRfdCwgbm90IHVp bnQ2NF90LgorCisgICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKIDIwMTItMDUtMjUgIE1pa2hh aWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAg W0VGTF0gQVBJIGZvciBQYWdlR3JvdXAgdmlzaXRlZCBsaW5rcyBoYXNoIHBvcHVsYXRpbmcKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a192aWV3LmgKaW5kZXggNDMzMWJkOC4uY2M2NTAzOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmgKQEAgLTE3Nyw3ICsxNzcsNyBAQCBzdHJ1Y3QgX0V3a19WaWV3X1NtYXJ0 X0NsYXNzIHsKICAgICBFaW5hX0Jvb2wgKCpydW5famF2YXNjcmlwdF9jb25maXJtKShFd2tfVmll d19TbWFydF9EYXRhICpzZCwgRXZhc19PYmplY3QgKmZyYW1lLCBjb25zdCBjaGFyICptZXNzYWdl KTsKICAgICBFaW5hX0Jvb2wgKCpydW5famF2YXNjcmlwdF9wcm9tcHQpKEV3a19WaWV3X1NtYXJ0 X0RhdGEgKnNkLCBFdmFzX09iamVjdCAqZnJhbWUsIGNvbnN0IGNoYXIgKm1lc3NhZ2UsIGNvbnN0 IGNoYXIgKmRlZmF1bHRWYWx1ZSwgY2hhciAqKnZhbHVlKTsKICAgICBFaW5hX0Jvb2wgKCpzaG91 bGRfaW50ZXJydXB0X2phdmFzY3JpcHQpKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkKTsKLSAgICB1 aW50NjRfdCAoKmV4Y2VlZGVkX2FwcGxpY2F0aW9uX2NhY2hlX3F1b3RhKShFd2tfVmlld19TbWFy dF9EYXRhICpzZCwgRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luLCBpbnQ2NF90IGRlZmF1bHRP cmlnaW5RdW90YSwgaW50NjRfdCB0b3RhbFNwYWNlTmVlZGVkKTsKKyAgICBpbnQ2NF90ICgqZXhj ZWVkZWRfYXBwbGljYXRpb25fY2FjaGVfcXVvdGEpKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkLCBF d2tfU2VjdXJpdHlfT3JpZ2luKiBvcmlnaW4sIGludDY0X3QgZGVmYXVsdE9yaWdpblF1b3RhLCBp bnQ2NF90IHRvdGFsU3BhY2VOZWVkZWQpOwogICAgIHVpbnQ2NF90ICgqZXhjZWVkZWRfZGF0YWJh c2VfcXVvdGEpKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkLCBFdmFzX09iamVjdCAqZnJhbWUsIGNv bnN0IGNoYXIgKmRhdGFiYXNlTmFtZSwgdWludDY0X3QgY3VycmVudF9zaXplLCB1aW50NjRfdCBl eHBlY3RlZF9zaXplKTsKIAogICAgIEVpbmFfQm9vbCAoKnJ1bl9vcGVuX3BhbmVsKShFd2tfVmll d19TbWFydF9EYXRhICpzZCwgRXZhc19PYmplY3QgKmZyYW1lLCBFaW5hX0Jvb2wgYWxsb3dzX211 bHRpcGxlX2ZpbGVzLCBFaW5hX0xpc3QgKmFjY2VwdF90eXBlcywgRWluYV9MaXN0ICoqc2VsZWN0 ZWRfZmlsZW5hbWVzKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCBiNGUzNGRkLi5lZWZkMTY0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDUtMjggIENocmlz dG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZM XSBDb21waWxhdGlvbiB3YXJuaW5nIGluIER1bXBSZW5kZXJUcmVlVmlldy5jcHAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NjM2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIGVy cm9yIGluIER1bXBSZW5kZXJUcmVlVmlldy5jcHAgZHVlIHRvIHdyb25nIGZvcm1hdAorICAgICAg ICBzcGVjaWZpZXIgaW4gcHJpbnRmLiBBbHNvIGZpeCB0aGUgcmV0dXJuIHR5cGUgZm9yCisgICAg ICAgIG9uRXhjZWVkZWRBcHBsaWNhdGlvbkNhY2hlUXVvdGEgY2FsbGJhY2suCisKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVWaWV3LmNwcDoKKyAgICAgICAgKG9u RXhjZWVkZWRBcHBsaWNhdGlvbkNhY2hlUXVvdGEpOgorCiAyMDEyLTA1LTI3ICBTdWRhcnNhbmEg TmFnaW5lbmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAbGludXguaW50ZWwuY29tPgogCiAgICAgICAg IFtFRkxdIEVuYWJsZSBibG9iIHN1cHBvcnQgZm9yIHRoZSBFRkwgcG9ydApkaWZmIC0tZ2l0IGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5jcHAgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVWaWV3LmNwcAppbmRleCBmOWY4ZjY1Li5j ZDhhZGM2IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWVWaWV3LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVW aWV3LmNwcApAQCAtMTIwLDcgKzEyMCw3IEBAIHN0YXRpYyB1aW50NjRfdCBvbkV4Y2VlZGVkRGF0 YWJhc2VRdW90YShFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEsIEV2YXNfT2JqCiAgICAg cmV0dXJuIDUgKiAxMDI0ICogMTAyNDsKIH0KIAotc3RhdGljIHVpbnQ2NF90IG9uRXhjZWVkZWRB cHBsaWNhdGlvbkNhY2hlUXVvdGEoRXdrX1ZpZXdfU21hcnRfRGF0YSosIEV3a19TZWN1cml0eV9P cmlnaW4gKm9yaWdpbiwgaW50NjRfdCBkZWZhdWx0T3JpZ2luUXVvdGEsIGludDY0X3QgdG90YWxT cGFjZU5lZWRlZCkKK3N0YXRpYyBpbnQ2NF90IG9uRXhjZWVkZWRBcHBsaWNhdGlvbkNhY2hlUXVv dGEoRXdrX1ZpZXdfU21hcnRfRGF0YSosIEV3a19TZWN1cml0eV9PcmlnaW4gKm9yaWdpbiwgaW50 NjRfdCBkZWZhdWx0T3JpZ2luUXVvdGEsIGludDY0X3QgdG90YWxTcGFjZU5lZWRlZCkKIHsKICAg ICBpZiAoZ0xheW91dFRlc3RDb250cm9sbGVyLT5kdW1wQXBwbGljYXRpb25DYWNoZURlbGVnYXRl Q2FsbGJhY2tzKCkpIHsKICAgICAgICAgLy8gRm9yIGV4YW1wbGUsIG51bWJlcnMgZnJvbSAzMDAw MCAtIDM5OTk5IHdpbGwgb3V0cHV0IGFzIDMwMDAwLgpAQCAtMTI4LDcgKzEyOCw3IEBAIHN0YXRp YyB1aW50NjRfdCBvbkV4Y2VlZGVkQXBwbGljYXRpb25DYWNoZVF1b3RhKEV3a19WaWV3X1NtYXJ0 X0RhdGEqLCBFd2tfU2VjdXJpCiAgICAgICAgIC8vIHN1ZmZpY2llbnQgdG8ganVzdCBnZXQgYSBy YW5nZSBvZiAxMDAwMCB0byBkZXRlcm1pbmUgaWYgd2Ugd2VyZQogICAgICAgICAvLyBhYm92ZSBv ciBiZWxvdyBhIHRocmVzaG9sZC4KICAgICAgICAgaW50NjRfdCB0cnVuY2F0ZWRTcGFjZU5lZWRl ZCA9ICh0b3RhbFNwYWNlTmVlZGVkIC8gMTAwMDApICogMTAwMDA7Ci0gICAgICAgIHByaW50Zigi VUkgREVMRUdBVEUgQVBQTElDQVRJT04gQ0FDSEUgQ0FMTEJBQ0s6IGV4Y2VlZGVkQXBwbGljYXRp b25DYWNoZU9yaWdpblF1b3RhRm9yU2VjdXJpdHlPcmlnaW46eyVzLCAlcywgJWl9IHRvdGFsU3Bh Y2VOZWVkZWQ6fiVsbHVcbiIsCisgICAgICAgIHByaW50ZigiVUkgREVMRUdBVEUgQVBQTElDQVRJ T04gQ0FDSEUgQ0FMTEJBQ0s6IGV4Y2VlZGVkQXBwbGljYXRpb25DYWNoZU9yaWdpblF1b3RhRm9y U2VjdXJpdHlPcmlnaW46eyVzLCAlcywgJWl9IHRvdGFsU3BhY2VOZWVkZWQ6fiVsbGRcbiIsCiAg ICAgICAgICAgICAgICBld2tfc2VjdXJpdHlfb3JpZ2luX3Byb3RvY29sX2dldChvcmlnaW4pLAog ICAgICAgICAgICAgICAgZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChvcmlnaW4pLAogICAg ICAgICAgICAgICAgZXdrX3NlY3VyaXR5X29yaWdpbl9wb3J0X2dldChvcmlnaW4pLAo=