87628 2012-05-28 00:32:30 -0700 Web Inspector: dom counters graphs vanish on switching between timeline views 2012-05-28 03:20:56 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein caseq joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 634956 0 yurys 2012-05-28 00:32:30 -0700 1. Go to Timeline and start recording events. 2. Switch to the memory view. See DOM counters graphs there. 3. Stop recording and switch to the events view and back. Result: counters section is cleared. 634957 1 yurys 2012-05-28 00:33:28 -0700 Also there is an exception in the console on click in the counters area. [12433:12433:236022046902:ERROR:CONSOLE(309)] "Uncaught TypeError: Cannot read property 'time' of undefined", source: chrome-devtools://devtools/MemoryStatistics.js (309) 634971 2 144295 yurys 2012-05-28 01:03:51 -0700 Created attachment 144295 Patch 634998 3 144295 vsevik 2012-05-28 01:43:50 -0700 Comment on attachment 144295 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > Source/WebCore/inspector/front-end/MemoryStatistics.js:-254 > - addTimlineEvent: function(event) Could you please fix spelling (addTimelineEvent) while you are at it? 635063 4 144295 caseq 2012-05-28 02:57:39 -0700 Comment on attachment 144295 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review This looks ok, but you may also want to consider directly subscribing to WebInspector.TimelineModel.Events.RecordAdded/RecordsCleared from the model. > Source/WebCore/inspector/front-end/MemoryStatistics.js:254 > + addTimlineEvent: function(record) addTimelineRecord? 635082 5 144319 yurys 2012-05-28 03:17:57 -0700 Created attachment 144319 Patch for landing 635085 6 yurys 2012-05-28 03:18:47 -0700 (In reply to comment #3) > (From update of attachment 144295 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > > > Source/WebCore/inspector/front-end/MemoryStatistics.js:-254 > > - addTimlineEvent: function(event) > > Could you please fix spelling (addTimelineEvent) while you are at it? Done. Renamed the method. (In reply to comment #4) > (From update of attachment 144295 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > > This looks ok, but you may also want to consider directly subscribing to WebInspector.TimelineModel.Events.RecordAdded/RecordsCleared from the model. > Good point. Done. > > Source/WebCore/inspector/front-end/MemoryStatistics.js:254 > > + addTimlineEvent: function(record) > > addTimelineRecord? Done. 635089 7 yurys 2012-05-28 03:20:56 -0700 Committed r118670: <http://trac.webkit.org/changeset/118670> 144295 2012-05-28 01:03:51 -0700 2012-05-28 03:17:57 -0700 Patch bug-87628-20120528120350.patch text/plain 3140 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIyYmZlODk3ZjYxYjE4 MWYyMzljYWNiZmQ4YmZmMzEzZWE0NjAxMi4uNzhhZDZlMzdhYTkwNTFkNDE1MTA5ZTY5ODU2NTlh ZjA0ODIzMzg1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTI4ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGRvbSBjb3VudGVycyBncmFwaHMgdmFuaXNoIG9uIHN3aXRjaGluZyBiZXR3ZWVuIHRpbWVs aW5lIHZpZXdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04NzYyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1lbW9yeVN0YXRpc3RpY3Mgb2JqZWN0IGlzIHBvcHVsYXRlZCB3aXRoIHJlY29yZHMgYWxvbmcg d2l0aCB0aGUgVGltZWxpbmVQcmVzZW50YXRpb25Nb2RlbCwKKyAgICAgICAgb3RoZXJ3aXNlIGl0 IGlzIHJlc2V0IG9uIHN3aXRjaGluZyB0byBhIGRpZmZlcmVudCB0aW1saW5lIG1vZGUgYW5kIG5l dmVyIHBvcHVsYXRlZAorICAgICAgICBhZ2Fpbi4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvTWVtb3J5U3RhdGlzdGljcy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5NZW1vcnlT dGF0aXN0aWNzLnByb3RvdHlwZS5hZGRUaW1saW5lRXZlbnQpOgorICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1l bGluZVBhbmVsLnByb3RvdHlwZS5fb25UaW1lbGluZUV2ZW50UmVjb3JkZWQpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlLl9pbm5lckFkZFJlY29yZFRvVGlt ZWxpbmUpOgorCiAyMDEyLTA1LTI3ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBjdXQsIGNvcHkgb3IgcGFzdGUgZXZlbnQgd29uJ3QgYmUgZmlyZWQg aW4gU2hhZG93IERPTS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvTWVtb3J5U3RhdGlzdGljcy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvTWVtb3J5U3RhdGlzdGljcy5qcwppbmRleCA2YjlhN2JmYTg1ZGU3ZGI4NGY5NjU3NmM1 MWQzZGFhOWZlODczMmFiLi44ZDg5NTZjOTRiY2ZkNWY5NjU4ODE5MDliZGRlOWIzYTcwODYxNmFl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL01lbW9yeVN0 YXRpc3RpY3MuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9NZW1v cnlTdGF0aXN0aWNzLmpzCkBAIC0yNTEsMTEgKzI1MSwxMSBAQCBXZWJJbnNwZWN0b3IuTWVtb3J5 U3RhdGlzdGljcy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2NhbnZhcy5oZWlnaHQgPSBo ZWlnaHQ7CiAgICAgfSwKIAotICAgIGFkZFRpbWxpbmVFdmVudDogZnVuY3Rpb24oZXZlbnQpCisg ICAgYWRkVGltbGluZUV2ZW50OiBmdW5jdGlvbihyZWNvcmQpCiAgICAgewotICAgICAgICB2YXIg Y291bnRlcnMgPSBldmVudC5kYXRhWyJjb3VudGVycyJdOworICAgICAgICB2YXIgY291bnRlcnMg PSByZWNvcmRbImNvdW50ZXJzIl07CiAgICAgICAgIHRoaXMuX2NvdW50ZXJzLnB1c2goewotICAg ICAgICAgICAgdGltZTogZXZlbnQuZGF0YS5lbmRUaW1lIHx8IGV2ZW50LmRhdGEuc3RhcnRUaW1l LAorICAgICAgICAgICAgdGltZTogcmVjb3JkLmVuZFRpbWUgfHwgcmVjb3JkLnN0YXJ0VGltZSwK ICAgICAgICAgICAgIGRvY3VtZW50Q291bnQ6IGNvdW50ZXJzWyJkb2N1bWVudHMiXSwKICAgICAg ICAgICAgIG5vZGVDb3VudDogY291bnRlcnNbIm5vZGVzIl0sCiAgICAgICAgICAgICBsaXN0ZW5l ckNvdW50OiBjb3VudGVyc1sianNFdmVudExpc3RlbmVycyJdCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggMjk4ZjVmYTJj Y2E2MzAzMjMwODI2OGY0YjY0NWZhODQ5YThjMGVkMC4uNDNjMTQzZmE4ZTZkNjk5NGMzNjk5ODEz ZDY1MmY2NzA1OWFmMmRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9UaW1lbGluZVBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcwpAQCAtNDgyLDkgKzQ4Miw2IEBAIFdlYkluc3BlY3Rv ci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHRoaXMuX2lubmVy QWRkUmVjb3JkVG9UaW1lbGluZShldmVudC5kYXRhLCB0aGlzLl9yb290UmVjb3JkKCkpOwogICAg ICAgICB0aGlzLl9zY2hlZHVsZVJlZnJlc2goZmFsc2UpOwotCi0gICAgICAgIGlmIChldmVudC5k YXRhWyJjb3VudGVycyJdKQotICAgICAgICAgICAgdGhpcy5fbWVtb3J5U3RhdGlzdGljcy5hZGRU aW1saW5lRXZlbnQoZXZlbnQpOwogICAgIH0sCiAKICAgICBfaW5uZXJBZGRSZWNvcmRUb1RpbWVs aW5lOiBmdW5jdGlvbihyZWNvcmQsIHBhcmVudFJlY29yZCkKQEAgLTQ5OSw2ICs0OTYsOSBAQCBX ZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAg dGltZVN0YW1wUmVjb3Jkcy5wdXNoKHJlY29yZCk7CiAgICAgICAgIH0KICAgICAgICAgV2ViSW5z cGVjdG9yLlRpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwuZm9yQWxsUmVjb3JkcyhbIGZvcm1hdHRl ZFJlY29yZCBdLCBhZGRUaW1lc3RhbXBSZWNvcmRzKTsKKworICAgICAgICBpZiAocmVjb3JkWyJj b3VudGVycyJdKQorICAgICAgICAgICAgdGhpcy5fbWVtb3J5U3RhdGlzdGljcy5hZGRUaW1saW5l RXZlbnQocmVjb3JkKTsKICAgICB9LAogCiAgICAgc2lkZWJhclJlc2l6ZWQ6IGZ1bmN0aW9uKGV2 ZW50KQo= 144319 2012-05-28 03:17:57 -0700 2012-05-28 03:17:57 -0700 Patch for landing timeline-memory.patch text/plain 4371 yurys ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZjMyNjBiLi44YWRhYTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDUtMjggIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgV2ViIEluc3BlY3RvcjogZG9tIGNvdW50ZXJzIGdyYXBocyB2YW5pc2ggb24gc3dp dGNoaW5nIGJldHdlZW4gdGltZWxpbmUgdmlld3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWVtb3J5U3RhdGlzdGljcyBvYmplY3Qgbm93IGxpc3RlbnMg dG8gdGhlIFRpbWVsaW5lTW9kZWwgZXZlbnRzIGluc3RlYWQgb2YgYmVpbmcKKyAgICAgICAgcG9w dWxhdGVkIGJ5IHRpbWVsaW5lIHBhbmVsLiBUaGlzIGJlaGF2aW9yIG1hdGhlcyB0aGF0IG9mIHRo ZSBvdmVydmlldyBwYW5lLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9NZW1vcnlT dGF0aXN0aWNzLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk1lbW9yeVN0YXRpc3RpY3MucHJv dG90eXBlLmFkZFRpbWxpbmVFdmVudCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9U aW1lbGluZVBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJv dG90eXBlLl9vblRpbWVsaW5lRXZlbnRSZWNvcmRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGltZWxpbmVQYW5lbC5wcm90b3R5cGUuX2lubmVyQWRkUmVjb3JkVG9UaW1lbGluZSk6CisKIDIw MTItMDUtMjggIFBldGVyIFJ5YmluICA8cGV0ZXIucnliaW5AZ21haWwuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IENvZGVHZW5lcmF0b3JJbnNwZWN0b3IucHk6IHByb3RlY3QgdHlwZWQg QVBJIGZyb20gQysrIGltcGxpY2l0IGZsb2F0IHRvIGludCBjYXN0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL01lbW9yeVN0YXRpc3RpY3MuanMgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL01lbW9yeVN0YXRpc3RpY3MuanMKaW5kZXgg NmI5YTdiZi4uZTk3MDdlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9NZW1vcnlTdGF0aXN0aWNzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvTWVtb3J5U3RhdGlzdGljcy5qcwpAQCAtMzAsMTQgKzMwLDE4IEBACiAKIC8q KgogICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbH0gdGltZWxpbmVQYW5lbAor ICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuVGltZWxpbmVNb2RlbH0gbW9kZWwKICAqIEBwYXJhbSB7 bnVtYmVyfSBzaWRlYmFyV2lkdGgKICAqIEBjb25zdHJ1Y3RvcgogICovCi1XZWJJbnNwZWN0b3Iu TWVtb3J5U3RhdGlzdGljcyA9IGZ1bmN0aW9uKHRpbWVsaW5lUGFuZWwsIHNpZGViYXJXaWR0aCkK K1dlYkluc3BlY3Rvci5NZW1vcnlTdGF0aXN0aWNzID0gZnVuY3Rpb24odGltZWxpbmVQYW5lbCwg bW9kZWwsIHNpZGViYXJXaWR0aCkKIHsKICAgICB0aGlzLl90aW1lbGluZVBhbmVsID0gdGltZWxp bmVQYW5lbDsKICAgICB0aGlzLl9jb3VudGVycyA9IFtdOwogCisgICAgbW9kZWwuYWRkRXZlbnRM aXN0ZW5lcihXZWJJbnNwZWN0b3IuVGltZWxpbmVNb2RlbC5FdmVudHMuUmVjb3JkQWRkZWQsIHRo aXMuX29uUmVjb3JkQWRkZWQsIHRoaXMpOworICAgIG1vZGVsLmFkZEV2ZW50TGlzdGVuZXIoV2Vi SW5zcGVjdG9yLlRpbWVsaW5lTW9kZWwuRXZlbnRzLlJlY29yZHNDbGVhcmVkLCB0aGlzLl9vblJl Y29yZHNDbGVhcmVkLCB0aGlzKTsKKwogICAgIHRoaXMuX2NvbnRhaW5lckFuY2hvciA9IHRpbWVs aW5lUGFuZWwuZWxlbWVudC5sYXN0Q2hpbGQ7CiAgICAgdGhpcy5fbWVtb3J5U3BsaXRWaWV3ID0g bmV3IFdlYkluc3BlY3Rvci5TcGxpdFZpZXcoV2ViSW5zcGVjdG9yLlNwbGl0Vmlldy5TaWRlYmFy UG9zaXRpb24uTGVmdCwgdW5kZWZpbmVkLCBzaWRlYmFyV2lkdGgpOwogICAgIHRoaXMuX21lbW9y eVNwbGl0Vmlldy5zaWRlYmFyRWxlbWVudC5hZGRTdHlsZUNsYXNzKCJzaWRlYmFyIik7CkBAIC0y MDcsNyArMjExLDcgQEAgV2ViSW5zcGVjdG9yLkNvdW50ZXJVSS5wcm90b3R5cGUgPSB7CiAKIAog V2ViSW5zcGVjdG9yLk1lbW9yeVN0YXRpc3RpY3MucHJvdG90eXBlID0gewotICAgIHJlc2V0OiBm dW5jdGlvbigpCisgICAgX29uUmVjb3Jkc0NsZWFyZWQ6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAg ICAgIHRoaXMuX2NvdW50ZXJzID0gW107CiAgICAgfSwKQEAgLTI1MSw3ICsyNTUsNyBAQCBXZWJJ bnNwZWN0b3IuTWVtb3J5U3RhdGlzdGljcy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2Nh bnZhcy5oZWlnaHQgPSBoZWlnaHQ7CiAgICAgfSwKIAotICAgIGFkZFRpbWxpbmVFdmVudDogZnVu Y3Rpb24oZXZlbnQpCisgICAgX29uUmVjb3JkQWRkZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsK ICAgICAgICAgdmFyIGNvdW50ZXJzID0gZXZlbnQuZGF0YVsiY291bnRlcnMiXTsKICAgICAgICAg dGhpcy5fY291bnRlcnMucHVzaCh7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggMjk4ZjVmYS4uYWVkYjNkYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5q cwpAQCAtNjEsNyArNjEsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbCA9IGZ1bmN0aW9u KCkKICAgICB0aGlzLl90aW1lbGluZU1lbW9yeVNwbGl0dGVyLmlkID0gInRpbWVsaW5lLW1lbW9y eS1zcGxpdHRlciI7CiAgICAgdGhpcy5fdGltZWxpbmVNZW1vcnlTcGxpdHRlci5hZGRFdmVudExp c3RlbmVyKCJtb3VzZWRvd24iLCB0aGlzLl9zdGFydFNwbGl0dGVyRHJhZ2dpbmcuYmluZCh0aGlz KSwgZmFsc2UpOwogICAgIHRoaXMuX3RpbWVsaW5lTWVtb3J5U3BsaXR0ZXIuYWRkU3R5bGVDbGFz cygiaGlkZGVuIik7Ci0gICAgdGhpcy5fbWVtb3J5U3RhdGlzdGljcyA9IG5ldyBXZWJJbnNwZWN0 b3IuTWVtb3J5U3RhdGlzdGljcyh0aGlzLCB0aGlzLnNwbGl0Vmlldy5wcmVmZXJyZWRTaWRlYmFy V2lkdGgoKSk7CisgICAgdGhpcy5fbWVtb3J5U3RhdGlzdGljcyA9IG5ldyBXZWJJbnNwZWN0b3Iu TWVtb3J5U3RhdGlzdGljcyh0aGlzLCB0aGlzLl9tb2RlbCwgdGhpcy5zcGxpdFZpZXcucHJlZmVy cmVkU2lkZWJhcldpZHRoKCkpOwogICAgIFdlYkluc3BlY3Rvci5zZXR0aW5ncy5tZW1vcnlDb3Vu dGVyR3JhcGhzSGVpZ2h0ID0gV2ViSW5zcGVjdG9yLnNldHRpbmdzLmNyZWF0ZVNldHRpbmcoIm1l bW9yeUNvdW50ZXJHcmFwaHNIZWlnaHQiLCAxNTApOwogCiAgICAgdmFyIGl0ZW1zVHJlZUVsZW1l bnQgPSBuZXcgV2ViSW5zcGVjdG9yLlNpZGViYXJTZWN0aW9uVHJlZUVsZW1lbnQoV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJSRUNPUkRTIiksIHt9LCB0cnVlKTsKQEAgLTQ4Miw5ICs0ODIsNiBAQCBX ZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICB0 aGlzLl9pbm5lckFkZFJlY29yZFRvVGltZWxpbmUoZXZlbnQuZGF0YSwgdGhpcy5fcm9vdFJlY29y ZCgpKTsKICAgICAgICAgdGhpcy5fc2NoZWR1bGVSZWZyZXNoKGZhbHNlKTsKLQotICAgICAgICBp ZiAoZXZlbnQuZGF0YVsiY291bnRlcnMiXSkKLSAgICAgICAgICAgIHRoaXMuX21lbW9yeVN0YXRp c3RpY3MuYWRkVGltbGluZUV2ZW50KGV2ZW50KTsKICAgICB9LAogCiAgICAgX2lubmVyQWRkUmVj b3JkVG9UaW1lbGluZTogZnVuY3Rpb24ocmVjb3JkLCBwYXJlbnRSZWNvcmQpCkBAIC01MzcsNyAr NTM0LDYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAg ICB0aGlzLl9hZGp1c3RTY3JvbGxQb3NpdGlvbigwKTsKICAgICAgICAgdGhpcy5fY2xvc2VSZWNv cmREZXRhaWxzKCk7CiAgICAgICAgIHRoaXMuX2FsbFJlY29yZHNDb3VudCA9IDA7Ci0gICAgICAg IHRoaXMuX21lbW9yeVN0YXRpc3RpY3MucmVzZXQoKTsKICAgICB9LAogCiAgICAgZWxlbWVudHNU b1Jlc3RvcmVTY3JvbGxQb3NpdGlvbnNGb3I6IGZ1bmN0aW9uKCkK