87617 2012-05-27 22:45:28 -0700 [Refactoring][ShadowDOM] Some ElementShadow methods can be inlined. 2012-05-28 01:40:24 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87223 1 morrita morrita cmarcelo dglazkov webkit.review.bot oldest_to_newest 634899 0 morrita 2012-05-27 22:45:28 -0700 This is a preparation for Bug 87223. Where we get rid of special form of ElementShadow::attach() 634933 1 144280 morrita 2012-05-27 23:49:30 -0700 Created attachment 144280 Patch 634994 2 morrita 2012-05-28 01:40:24 -0700 Committed r118654: <http://trac.webkit.org/changeset/118654> 144280 2012-05-27 23:49:30 -0700 2012-05-27 23:51:32 -0700 Patch bug-87617-20120528154929.patch text/plain 4113 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIyYmZlODk3ZjYxYjE4 MWYyMzljYWNiZmQ4YmZmMzEzZWE0NjAxMi4uZmQyMmNjMDJiZjgzODRjNmVhNWRjNTkwZDRjMjE3 MDM0ZGYzMjgwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTI3ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFtSZWZhY3RvcmluZ11b U2hhZG93RE9NXSBTb21lIEVsZW1lbnRTaGFkb3cgbWV0aG9kcyBjYW4gYmUgaW5saW5lZC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NjE3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5saW5lZCBFbGVt ZW50U2hhZG93OjphdHRhY2hIb3N0KCksIEVsZW1lbnRTaGFkb3c6OmRldGFjaEhvc3QoKSBhbmQK KyAgICAgICAgRWxlbWVudFNoYWRvdzo6cmVhdHRhY2goKQorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gTm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RWxlbWVudDo6YXR0YWNoKToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1l bnQ6OmRldGFjaCk6CisgICAgICAgICogZG9tL0VsZW1lbnRTaGFkb3cuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RWxlbWVtdG5TaGFkb3c6OnJlYXR0YWNoSG9zdENoaWxkcmVuQW5kU2hhZG93KToK KyAgICAgICAgKiBkb20vRWxlbWVudFNoYWRvdy5oOgorICAgICAgICAoRWxlbWVudFNoYWRvdyk6 CisKIDIwMTItMDUtMjcgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIGN1dCwgY29weSBvciBwYXN0ZSBldmVudCB3b24ndCBiZSBmaXJlZCBpbiBTaGFk b3cgRE9NLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IDg0MzFjYmJhMDhmMTQ3YjAxYThiNTUz NGFkMDJiMjM5YTM0ZDRiYzEuLjI0YTExM2YxZDEzNGE1OGI2N2Q1NDdlNjkxZmM1YzY4YTI0NzUw NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTk0Nyw3ICs5NDcsOSBAQCB2b2lkIEVsZW1l bnQ6OmF0dGFjaCgpCiAgICAgLy8gV2hlbiBhIHNoYWRvdyByb290IGV4aXN0cywgaXQgZG9lcyB0 aGUgd29yayBvZiBhdHRhY2hpbmcgdGhlIGNoaWxkcmVuLgogICAgIGlmIChFbGVtZW50U2hhZG93 KiBzaGFkb3cgPSB0aGlzLT5zaGFkb3coKSkgewogICAgICAgICBwYXJlbnRQdXNoZXIucHVzaCgp OwotICAgICAgICBzaGFkb3ctPmF0dGFjaEhvc3QodGhpcyk7CisgICAgICAgIHNoYWRvdy0+YXR0 YWNoKCk7CisgICAgICAgIGF0dGFjaENoaWxkcmVuSWZOZWVkZWQoKTsKKyAgICAgICAgYXR0YWNo QXNOb2RlKCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgaWYgKGZpcnN0Q2hpbGQoKSkKICAgICAg ICAgICAgIHBhcmVudFB1c2hlci5wdXNoKCk7CkBAIC05ODMsOSArOTg1LDExIEBAIHZvaWQgRWxl bWVudDo6ZGV0YWNoKCkKICAgICBpZiAoaGFzUmFyZURhdGEoKSkKICAgICAgICAgcmFyZURhdGEo KS0+cmVzZXRDb21wdXRlZFN0eWxlKCk7CiAKLSAgICBpZiAoRWxlbWVudFNoYWRvdyogc2hhZG93 ID0gdGhpcy0+c2hhZG93KCkpCi0gICAgICAgIHNoYWRvdy0+ZGV0YWNoSG9zdCh0aGlzKTsKLSAg ICBlbHNlCisgICAgaWYgKEVsZW1lbnRTaGFkb3cqIHNoYWRvdyA9IHRoaXMtPnNoYWRvdygpKSB7 CisgICAgICAgIGRldGFjaENoaWxkcmVuSWZOZWVkZWQoKTsKKyAgICAgICAgc2hhZG93LT5kZXRh Y2goKTsKKyAgICAgICAgZGV0YWNoQXNOb2RlKCk7CisgICAgfSBlbHNlCiAgICAgICAgIENvbnRh aW5lck5vZGU6OmRldGFjaCgpOwogCiAgICAgUmVuZGVyV2lkZ2V0OjpyZXN1bWVXaWRnZXRIaWVy YXJjaHlVcGRhdGVzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudFNo YWRvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudFNoYWRvdy5jcHAKaW5kZXggZDVl ZmVmNmFmZjYxZGQ1ZThkOTgxZDY1NDk1ZDg3ZGY2ZjA4NDcwOC4uYmRmMzE0YmY4ZTRmOWNiODYx MWNjYzY2NDQ5OWFjYmVhYjA1MTQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnRTaGFkb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50U2hhZG93LmNw cApAQCAtMTIzLDEzICsxMjMsNiBAQCB2b2lkIEVsZW1lbnRTaGFkb3c6OmF0dGFjaCgpCiAgICAg ZGlzdHJpYnV0b3IoKS5kaWREaXN0cmlidXRlKCk7CiB9CiAKLXZvaWQgRWxlbWVudFNoYWRvdzo6 YXR0YWNoSG9zdChFbGVtZW50KiBob3N0KQotewotICAgIGF0dGFjaCgpOwotICAgIGhvc3QtPmF0 dGFjaENoaWxkcmVuSWZOZWVkZWQoKTsKLSAgICBob3N0LT5hdHRhY2hBc05vZGUoKTsKLX0KLQog dm9pZCBFbGVtZW50U2hhZG93OjpkZXRhY2goKQogewogICAgIGZvciAoU2hhZG93Um9vdCogcm9v dCA9IHlvdW5nZXN0U2hhZG93Um9vdCgpOyByb290OyByb290ID0gcm9vdC0+b2xkZXJTaGFkb3dS b290KCkpIHsKQEAgLTEzOCwxMyArMTMxLDYgQEAgdm9pZCBFbGVtZW50U2hhZG93OjpkZXRhY2go KQogICAgIH0KIH0KIAotdm9pZCBFbGVtZW50U2hhZG93OjpkZXRhY2hIb3N0KEVsZW1lbnQqIGhv c3QpCi17Ci0gICAgaG9zdC0+ZGV0YWNoQ2hpbGRyZW5JZk5lZWRlZCgpOwotICAgIGRldGFjaCgp OwotICAgIGhvc3QtPmRldGFjaEFzTm9kZSgpOwotfQotCiBJbnNlcnRpb25Qb2ludCogRWxlbWVu dFNoYWRvdzo6aW5zZXJ0aW9uUG9pbnRGb3IoY29uc3QgTm9kZSogbm9kZSkgY29uc3QKIHsKICAg ICBBU1NFUlQobm9kZSAmJiBub2RlLT5wYXJlbnROb2RlKCkpOwpAQCAtMTU5LDEyICsxNDUsNiBA QCBJbnNlcnRpb25Qb2ludCogRWxlbWVudFNoYWRvdzo6aW5zZXJ0aW9uUG9pbnRGb3IoY29uc3Qg Tm9kZSogbm9kZSkgY29uc3QKICAgICByZXR1cm4gZGlzdHJpYnV0b3IoKS5maW5kSW5zZXJ0aW9u UG9pbnRGb3Iobm9kZSk7CiB9CiAKLXZvaWQgRWxlbWVudFNoYWRvdzo6cmVhdHRhY2goKQotewot ICAgIGRldGFjaCgpOwotICAgIGF0dGFjaCgpOwotfQotCiBib29sIEVsZW1lbnRTaGFkb3c6OmNo aWxkTmVlZHNTdHlsZVJlY2FsYygpCiB7CiAgICAgQVNTRVJUKHlvdW5nZXN0U2hhZG93Um9vdCgp KTsKQEAgLTI0MSw3ICsyMjEsOCBAQCB2b2lkIEVsZW1lbnRTaGFkb3c6OnJlYXR0YWNoSG9zdENo aWxkcmVuQW5kU2hhZG93KCkKIAogICAgIEVsZW1lbnQqIGhvc3ROb2RlID0geW91bmdlc3RTaGFk b3dSb290KCktPmhvc3QoKTsKICAgICBob3N0Tm9kZS0+ZGV0YWNoQ2hpbGRyZW5JZk5lZWRlZCgp OwotICAgIHJlYXR0YWNoKCk7CisgICAgZGV0YWNoKCk7CisgICAgYXR0YWNoKCk7CiAgICAgaG9z dE5vZGUtPmF0dGFjaENoaWxkcmVuSWZOZWVkZWQoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnRTaGFkb3cuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 U2hhZG93LmgKaW5kZXggODU2YzQ2YzMxNGNlMTIxYWM2ZDQ0OGZmYjE2Zjk0NGMzYTJkM2I5Mi4u YjYyMTExODViNDdkNzJmZGRlM2ZkMGNlNjNhMzhhYWY3MDlhOThmMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRTaGFkb3cuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudFNoYWRvdy5oCkBAIC01Niw5ICs1Niw2IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgYXR0 YWNoKCk7CiAgICAgdm9pZCBkZXRhY2goKTsKLSAgICB2b2lkIHJlYXR0YWNoKCk7Ci0gICAgdm9p ZCBhdHRhY2hIb3N0KEVsZW1lbnQqKTsKLSAgICB2b2lkIGRldGFjaEhvc3QoRWxlbWVudCopOwog CiAgICAgYm9vbCBjaGlsZE5lZWRzU3R5bGVSZWNhbGMoKTsKICAgICBib29sIG5lZWRzU3R5bGVS ZWNhbGMoKTsK