87608 2012-05-27 18:35:26 -0700 HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach() 2012-05-28 02:54:26 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87223 1 morrita morrita tkent webkit.review.bot oldest_to_newest 634834 0 morrita 2012-05-27 18:35:26 -0700 This is a preparation for Bug 87223. ValidationMessage mutates DOM tree. But mutating DOM tree during detach() causes troubles which we hit by the change on Bug 87223. It could be moved to removedFrom(). 634842 1 144256 morrita 2012-05-27 19:02:32 -0700 Created attachment 144256 Patch 634865 2 144256 tkent 2012-05-27 21:04:12 -0700 Comment on attachment 144256 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144256&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:76 > void HTMLFormControlElement::detach() > { > - m_validationMessage = nullptr; > HTMLElement::detach(); > } So, we can remove HTMLFormControlElement::detach(). 634872 3 144256 morrita 2012-05-27 21:25:17 -0700 Comment on attachment 144256 Patch > So, we can remove HTMLFormControlElement::detach(). True. will do. Thanks for taking look! 634883 4 144264 morrita 2012-05-27 21:59:31 -0700 Created attachment 144264 Patch for landing 635056 5 144264 webkit.review.bot 2012-05-28 02:54:21 -0700 Comment on attachment 144264 Patch for landing Clearing flags on attachment: 144264 Committed r118664: <http://trac.webkit.org/changeset/118664> 635057 6 webkit.review.bot 2012-05-28 02:54:26 -0700 All reviewed patches have been landed. Closing bug. 144256 2012-05-27 19:02:32 -0700 2012-05-27 21:59:22 -0700 Patch bug-87608-20120528110231.patch text/plain 1785 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEyZTA1MzkxYjA4ZTVi OGM5YTVlYTJmMWQ5MjBjYzc5MDI5MmUzMy4uZGVkOWFkZjcxNThlYmU3ODc3MWY2YmJkYWE0NDhk NDc2YTI0MmFjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTI3ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIEhUTUxGb3JtQ29udHJv bEVsZW1lbnQ6Om1fdmFsaWRhdGlvbk1lc3NhZ2Ugc2hvdWxkbid0IGJlIGNsZWFyZWQgb24gZGV0 YWNoKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3 NjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92 ZWQgbV92YWxpZGF0aW9uTWVzc2FnZSBjbGVhcmFuY2UgZnJvbSBkZXRhY2goKSB0byByZW1vdmVk RnJvbSgpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBjaGFuZ2UgaGFzIG5vIHZpc2li bGUgZGlmZmVyZW5jZS4gVXBjb21pbmcgY2hhbmdlcyByZWx5IG9uIHRoaXMgdGhvdWdoLgorCisg ICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmRldGFjaCk6CisgICAgICAgIChXZWJDb3JlOjpI VE1MRm9ybUNvbnRyb2xFbGVtZW50OjpyZW1vdmVkRnJvbSk6CisKIDIwMTItMDUtMjcgIEFydmlk IE5pbHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVcGRh dGUgY29sb3IgZm9yIHRhcCBoaWdobGlnaHQgYW5kIHNlbGVjdGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKaW5kZXggYWJiMzYxMGI1ZTcxOWM3 OGU2ZmM2NDU4Zjk2YmVjM2RjZTJmMWM2ZC4uODAzYjkxMzg1ZWExOWRiY2YyYzkzNTkxZTNlNWFk ZDU3ZDcxYWYxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRy b2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVs ZW1lbnQuY3BwCkBAIC03Miw3ICs3Miw2IEBAIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6On5IVE1M Rm9ybUNvbnRyb2xFbGVtZW50KCkKIAogdm9pZCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpkZXRh Y2goKQogewotICAgIG1fdmFsaWRhdGlvbk1lc3NhZ2UgPSBudWxscHRyOwogICAgIEhUTUxFbGVt ZW50OjpkZXRhY2goKTsKIH0KIApAQCAtMjMzLDYgKzIzMiw3IEBAIE5vZGU6Okluc2VydGlvbk5v dGlmaWNhdGlvblJlcXVlc3QgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6aW5zZXJ0ZWRJbnRvKENv bnRhaW5lCiAKIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6cmVtb3ZlZEZyb20oQ29udGFp bmVyTm9kZSogaW5zZXJ0aW9uUG9pbnQpCiB7CisgICAgbV92YWxpZGF0aW9uTWVzc2FnZSA9IG51 bGxwdHI7CiAgICAgbV9maWVsZFNldEFuY2VzdG9yVmFsaWQgPSBmYWxzZTsKICAgICBtX2RhdGFM aXN0QW5jZXN0b3JTdGF0ZSA9IFVua25vd247CiAgICAgSFRNTEVsZW1lbnQ6OnJlbW92ZWRGcm9t KGluc2VydGlvblBvaW50KTsK 144264 2012-05-27 21:59:31 -0700 2012-05-28 02:54:21 -0700 Patch for landing bug-87608-20120528135928.patch text/plain 2525 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEyZTA1MzkxYjA4ZTVi OGM5YTVlYTJmMWQ5MjBjYzc5MDI5MmUzMy4uYzllNjljYmIwYmNlZmU2YmI3MzM0MjYzZjMwZGE3 OTBkZDllZmU2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTI3ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIEhUTUxGb3JtQ29udHJv bEVsZW1lbnQ6Om1fdmFsaWRhdGlvbk1lc3NhZ2Ugc2hvdWxkbid0IGJlIGNsZWFyZWQgb24gZGV0 YWNoKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3 NjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCisKKyAgICAgICAgTW92ZWQg bV92YWxpZGF0aW9uTWVzc2FnZSBjbGVhcmFuY2UgZnJvbSBkZXRhY2goKSB0byByZW1vdmVkRnJv bSgpIGFuZAorICAgICAgICByZW1vdmUgZGV0YWNoKCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiBUaGlzIGNoYW5nZSBoYXMgbm8gdmlzaWJsZSBkaWZmZXJlbmNlLiBVcGNvbWluZyBjaGFuZ2Vz IHJlbHkgb24gdGhpcyB0aG91Z2guCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtQ29udHJvbEVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1Db250cm9sRWxlbWVudDo6cmVt b3ZlZEZyb20pOgorCiAyMDEyLTA1LTI3ICBBcnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBkYXRlIGNvbG9yIGZvciB0YXAgaGlnaGxpZ2h0 IGFuZCBzZWxlY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1D b250cm9sRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVs ZW1lbnQuY3BwCmluZGV4IGFiYjM2MTBiNWU3MTljNzhlNmZjNjQ1OGY5NmJlYzNkY2UyZjFjNmQu LmU1OTljZDE1MTk2NTJhNWFiZmU4ODBlMTY5Mjk1NjZlZWU5MjdiNjcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcApAQCAtNzAsMTIgKzcwLDYg QEAgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6fkhUTUxGb3JtQ29udHJvbEVsZW1lbnQoKQogewog fQogCi12b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmRldGFjaCgpCi17Ci0gICAgbV92YWxp ZGF0aW9uTWVzc2FnZSA9IG51bGxwdHI7Ci0gICAgSFRNTEVsZW1lbnQ6OmRldGFjaCgpOwotfQot CiBTdHJpbmcgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6Zm9ybUVuY3R5cGUoKSBjb25zdAogewog ICAgIHJldHVybiBGb3JtU3VibWlzc2lvbjo6QXR0cmlidXRlczo6cGFyc2VFbmNvZGluZ1R5cGUo ZmFzdEdldEF0dHJpYnV0ZShmb3JtZW5jdHlwZUF0dHIpKTsKQEAgLTIzMyw2ICsyMjcsNyBAQCBO b2RlOjpJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6 Omluc2VydGVkSW50byhDb250YWluZQogCiB2b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OnJl bW92ZWRGcm9tKENvbnRhaW5lck5vZGUqIGluc2VydGlvblBvaW50KQogeworICAgIG1fdmFsaWRh dGlvbk1lc3NhZ2UgPSBudWxscHRyOwogICAgIG1fZmllbGRTZXRBbmNlc3RvclZhbGlkID0gZmFs c2U7CiAgICAgbV9kYXRhTGlzdEFuY2VzdG9yU3RhdGUgPSBVbmtub3duOwogICAgIEhUTUxFbGVt ZW50OjpyZW1vdmVkRnJvbShpbnNlcnRpb25Qb2ludCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEZvcm1Db250cm9sRWxlbWVudC5oCmluZGV4IDg1OWMwZjA4MTBmOTZiOTMzMWNjNGYxNTJk YjY5OTkxMGI0NTQ2OTkuLjE3NDhkMDgyZDY5MGJiMGZlZWVhYTMxNDEwOWJlZTc1NmU5ZWM1YzYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5oCkBAIC0x MzAsNyArMTMwLDYgQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNhbGNTdHls ZShTdHlsZUNoYW5nZSkgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIHZvaWQgZGlzcGF0Y2hCbHVy RXZlbnQoUGFzc1JlZlB0cjxOb2RlPiBuZXdGb2N1c2VkTm9kZSk7Ci0gICAgdmlydHVhbCB2b2lk IGRldGFjaCgpOwogCiAgICAgLy8gVGhpcyBtdXN0IGJlIGNhbGxlZCBhbnkgdGltZSB0aGUgcmVz dWx0IG9mIHdpbGxWYWxpZGF0ZSgpIGhhcyBjaGFuZ2VkLgogICAgIHZvaWQgc2V0TmVlZHNXaWxs VmFsaWRhdGVDaGVjaygpOwo=