87596 2012-05-27 13:41:43 -0700 String should be move enabled/optimized 2012-05-29 16:47:01 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 sam andersca andersca oldest_to_newest 634781 0 sam 2012-05-27 13:41:43 -0700 For builds with rvalue references, WTF::String (and StringImpl) should be move enabled/optimized. 636381 1 144609 andersca 2012-05-29 13:24:25 -0700 Created attachment 144609 Patch 636395 2 144609 kling 2012-05-29 13:33:03 -0700 Comment on attachment 144609 Patch Srsly cool! r=me 636560 3 andersca 2012-05-29 16:47:01 -0700 Committed r118859: <http://trac.webkit.org/changeset/118859> 144609 2012-05-29 13:24:25 -0700 2012-05-29 13:33:02 -0700 Patch bug-87596-20120529132653.patch text/plain 3746 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMxZTQxNjU1MzY3ODczYmVlMTg3MzEx YTQ3OWEzOWNjNjRjYzE4ZWQuLjdiYjNjYjM1NGNhNzY4ODdiNmYxOTI4MGYxZDQwN2MxNmI4MDRj YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTItMDUtMjkgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBTdHJpbmcgc2hvdWxkIGJlIG1vdmUgZW5hYmxl ZC9vcHRpbWl6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg3NTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIG1vdmUgY29uc3RydWN0b3JzIGFuZCBtb3ZlIGFzc2lnbm1lbnQgb3BlcmF0b3JzIHRv IFN0cmluZyBhbmQgQXRvbWljU3RyaW5nIHdoZW4gYnVpbGRpbmcgd2l0aAorICAgICAgICBjb21w aWxlcnMgdGhhdCBzdXBwb3J0IHJ2YWx1ZSByZWZlcmVuY2VzLiBUaGlzIGdldHMgcmlkIG9mIHJl Zi1jaHVybiB3aGVuIHRoZSBzb3VyY2Ugb2YgdGhlIAorICAgICAgICBjb25zdHJ1Y3RvciBvciBh c3NpZ25tZW50IGlzIGEgdGVtcG9yYXJ5IG9iamVjdC4KKworICAgICAgICAqIHd0Zi90ZXh0L0F0 b21pY1N0cmluZy5oOgorICAgICAgICAoQXRvbWljU3RyaW5nKToKKyAgICAgICAgKFdURjo6QXRv bWljU3RyaW5nOjpBdG9taWNTdHJpbmcpOgorICAgICAgICAoV1RGOjpBdG9taWNTdHJpbmc6Om9w ZXJhdG9yPSk6CisgICAgICAgICogd3RmL3RleHQvV1RGU3RyaW5nLmg6CisgICAgICAgIChTdHJp bmcpOgorICAgICAgICAoV1RGOjpTdHJpbmc6OlN0cmluZyk6CisgICAgICAgIChXVEY6OlN0cmlu Zzo6b3BlcmF0b3I9KToKKwogMjAxMi0wNS0yOSAgVG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5l LnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBSZW1vdmUgZHVwbGljYXRpb24gb2Yg bG9naWMgZm9yIGRpc2FibGluZyBzZWxlY3RlZCB3YXJuaW5ncyByZWxhdGVkIHRvIEMrKzExCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oIGIvU291cmNlL1dU Ri93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAppbmRleCBjYTEzM2E1ZTFjYmJkODdkNjE4ZDljM2Ji YjJkMjhmYjZlNjc3YWJjLi43M2E4NTU5OTc3Y2FjZTIyYmU0MWM5ZGM4OWZmOTc0MTE1ZDA5ZWVl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKQEAgLTUxLDYgKzUxLDE3IEBAIHB1Ymxp YzoKICAgICBBVE9NSUNTVFJJTkdfQ09OVkVSU0lPTiBBdG9taWNTdHJpbmcoY29uc3QgU3RyaW5n JiBzKSA6IG1fc3RyaW5nKGFkZChzLmltcGwoKSkpIHsgfQogICAgIEF0b21pY1N0cmluZyhTdHJp bmdJbXBsKiBiYXNlU3RyaW5nLCB1bnNpZ25lZCBzdGFydCwgdW5zaWduZWQgbGVuZ3RoKSA6IG1f c3RyaW5nKGFkZChiYXNlU3RyaW5nLCBzdGFydCwgbGVuZ3RoKSkgeyB9CiAKKyNpZiBDT01QSUxF Ul9TVVBQT1JUUyhDWFhfUlZBTFVFX1JFRkVSRU5DRVMpCisgICAgLy8gV2UgaGF2ZSB0byBkZWNs YXJlIHRoZSBjb3B5IGNvbnN0cnVjdG9yIGFuZCBjb3B5IGFzc2lnbm1lbnQgb3BlcmF0b3IgYXMg d2VsbCwgb3RoZXJ3aXNlCisgICAgLy8gdGhleSdsbCBiZSBpbXBsaWNpdGx5IGRlbGV0ZWQgYnkg YWRkaW5nIHRoZSBtb3ZlIGNvbnN0cnVjdG9yIGFuZCBtb3ZlIGFzc2lnbm1lbnQgb3BlcmF0b3Iu CisgICAgLy8gRklYTUU6IEluc3RlYWQgb2YgZXhwbGljaXRseSBjYXN0aW5nIHRvIFN0cmluZyYm IGhlcmUsIHdlIHNob3VsZCB1c2Ugc3RkOjptb3ZlLCBidXQgdGhhdCByZXF1aXJlcyB1cyB0bwor ICAgIC8vIGhhdmUgYSBzdGFuZGFyZCBsaWJyYXJ5IHRoYXQgc3VwcG9ydHMgbW92ZSBzZW1hbnRp Y3MuCisgICAgQXRvbWljU3RyaW5nKGNvbnN0IEF0b21pY1N0cmluZyYgb3RoZXIpIDogbV9zdHJp bmcob3RoZXIubV9zdHJpbmcpIHsgfQorICAgIEF0b21pY1N0cmluZyhBdG9taWNTdHJpbmcmJiBv dGhlcikgOiBtX3N0cmluZyhzdGF0aWNfY2FzdDxTdHJpbmcmJj4ob3RoZXIubV9zdHJpbmcpKSB7 IH0KKyAgICBBdG9taWNTdHJpbmcmIG9wZXJhdG9yPShjb25zdCBBdG9taWNTdHJpbmcmIG90aGVy KSB7IG1fc3RyaW5nID0gb3RoZXIubV9zdHJpbmc7IHJldHVybiAqdGhpczsgfQorICAgIEF0b21p Y1N0cmluZyYgb3BlcmF0b3I9KEF0b21pY1N0cmluZyYmIG90aGVyKSB7IG1fc3RyaW5nID0gc3Rh dGljX2Nhc3Q8U3RyaW5nJiY+KG90aGVyLm1fc3RyaW5nKTsgcmV0dXJuICp0aGlzOyB9CisjZW5k aWYKKwogICAgIC8vIEhhc2ggdGFibGUgZGVsZXRlZCB2YWx1ZXMsIHdoaWNoIGFyZSBvbmx5IGNv bnN0cnVjdGVkIGFuZCBuZXZlciBjb3BpZWQgb3IgZGVzdHJveWVkLgogICAgIEF0b21pY1N0cmlu ZyhXVEY6Okhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpIDogbV9zdHJpbmcoV1RGOjpIYXNoVGFi bGVEZWxldGVkVmFsdWUpIHsgfQogICAgIGJvb2wgaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKSBj b25zdCB7IHJldHVybiBtX3N0cmluZy5pc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZSgpOyB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL1dURi93dGYv dGV4dC9XVEZTdHJpbmcuaAppbmRleCA1ZTE3NjNhZDc1ZWU0NGJmYzcxMmZiM2VlM2IxYzU1NTNi NGNmNDliLi5iZmJmZGE0ZDQ1M2QzM2NhYTczZDBjNzI0NmNjNmFjNGIxZTI0NmFmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L3RleHQvV1RGU3RyaW5nLmgKQEAgLTEzMSw2ICsxMzEsMTUgQEAgcHVibGljOgogICAgIFN0cmlu ZyhQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGltcGwpIDogbV9pbXBsKGltcGwpIHsgfQogICAgIFN0 cmluZyhSZWZQdHI8U3RyaW5nSW1wbD4gaW1wbCkgOiBtX2ltcGwoaW1wbCkgeyB9CiAKKyNpZiBD T01QSUxFUl9TVVBQT1JUUyhDWFhfUlZBTFVFX1JFRkVSRU5DRVMpCisgICAgLy8gV2UgaGF2ZSB0 byBkZWNsYXJlIHRoZSBjb3B5IGNvbnN0cnVjdG9yIGFuZCBjb3B5IGFzc2lnbm1lbnQgb3BlcmF0 b3IgYXMgd2VsbCwgb3RoZXJ3aXNlCisgICAgLy8gdGhleSdsbCBiZSBpbXBsaWNpdGx5IGRlbGV0 ZWQgYnkgYWRkaW5nIHRoZSBtb3ZlIGNvbnN0cnVjdG9yIGFuZCBtb3ZlIGFzc2lnbm1lbnQgb3Bl cmF0b3IuCisgICAgU3RyaW5nKGNvbnN0IFN0cmluZyYgb3RoZXIpIDogbV9pbXBsKG90aGVyLm1f aW1wbCkgeyB9CisgICAgU3RyaW5nKFN0cmluZyYmIG90aGVyKSA6IG1faW1wbChvdGhlci5tX2lt cGwucmVsZWFzZSgpKSB7IH0KKyAgICBTdHJpbmcmIG9wZXJhdG9yPShjb25zdCBTdHJpbmcmIG90 aGVyKSB7IG1faW1wbCA9IG90aGVyLm1faW1wbDsgcmV0dXJuICp0aGlzOyB9CisgICAgU3RyaW5n JiBvcGVyYXRvcj0oU3RyaW5nJiYgb3RoZXIpIHsgbV9pbXBsID0gb3RoZXIubV9pbXBsLnJlbGVh c2UoKTsgcmV0dXJuICp0aGlzOyB9CisjZW5kaWYKKwogICAgIC8vIElubGluZSB0aGUgZGVzdHJ1 Y3Rvci4KICAgICBBTFdBWVNfSU5MSU5FIH5TdHJpbmcoKSB7IH0KIAo=