87588 2012-05-26 23:47:28 -0700 Use xcrun to find path to nm for Mac port 2012-05-27 14:31:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 80915 1 ddkilzer ddkilzer abarth dpranke mitz ojan webkit.review.bot oldest_to_newest 634721 0 ddkilzer 2012-05-26 23:47:28 -0700 Use xcrun to find path to nm for Mac port 634722 1 144219 ddkilzer 2012-05-26 23:49:24 -0700 Created attachment 144219 Patch v1 634723 2 ddkilzer 2012-05-26 23:52:36 -0700 Committed r118621: <http://trac.webkit.org/changeset/118621> 634774 3 dpranke 2012-05-27 12:26:02 -0700 Perhaps a comment somewhere in the code, changelog, or bug about why xcrun is needed / useful? 634778 4 ddkilzer 2012-05-27 12:52:51 -0700 (In reply to comment #3) > Perhaps a comment somewhere in the code, changelog, or bug about why xcrun is needed / useful? Newer versions of Xcode now bundle build tools (like nm, gperf, etc.) inside each SDK (macosx, iphoneos, iphonesimulator) instead of in /usr/bin. This allows different versions of each tool to be shipped independent of the host (Mac) that's used to build and independent of each SDK. The xcrun tool is how one finds the path to the correct tool (based on which SDK you're currently building for). See Bug 80915. 634784 5 dpranke 2012-05-27 14:31:38 -0700 thanks! 144219 2012-05-26 23:49:24 -0700 2012-05-26 23:50:53 -0700 Patch v1 bug-87588-20120526234923.patch text/plain 3567 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2M3ZjNmZTE4NjFkMzRjYTczNjBkNjU0NmRkMWI3Zjdk MzA1MjFhMy4uZjIxZWZkNTNjMDhmM2FiOGQwMjE5Y2U1ZWMxZTc4YWQwZjJhZWY3NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA1LTI2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgVXNlIHhjcnVuIHRvIGZpbmQgcGF0aCB0byBubSBmb3IgTWFjIHBvcnQKKyAgICAgICAg PGh0dHA6Ly93ZWJraXQub3JnL2IvODc1ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L21hYy5weToKKyAgICAgICAgKE1hY1BvcnQubm1fY29tbWFuZCk6IEFkZC4gVHJpZXMgdG8gZmlu ZCBhIHBhdGggZm9yIHRoZSBubQorICAgICAgICBjb21tYW5kIHVzaW5nIHhjcnVuLiAgRmFsbHMg YmFjayB0byByZXR1cm5pbmcgJ25tJy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3dlYmtpdC5weToKKyAgICAgICAgKFdlYktpdFBvcnQubm1fY29tbWFuZCk6 IEFkZC4gUmV0dXJucyAnbm0nLgorICAgICAgICAoV2ViS2l0UG9ydC5fd2ViY29yZV9zeW1ib2xz X3N0cmluZyk6IENhbGwgc2VsZi5ubV9jb21tYW5kKCkuCisKIDIwMTItMDUtMjUgIEx5bm4gTmVp ciAgPGx5bm4ubmVpckBza3lwZS5uZXQ+CiAKICAgICAgICAgQWRkZWQgd2luZG93cyBpbXBsZW1l bnRhdGlvbiBpbiBEUlQgZm9yIFRleHRJbnB1dENvbnRyb2xsZXIsIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjAyMQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQppbmRleCA5NTEzYWU1YmRlM2JmN2IwNzZmMjhmNzYx OWY2YjYzM2FmZjI0YzBhLi44NTUyMTc2ODI4ZTE3OWQ4OGUzODBlZjc1YWE4MDU2NmIyMDI3MWYy IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21h Yy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5w eQpAQCAtMSw0ICsxLDUgQEAKICMgQ29weXJpZ2h0IChDKSAyMDExIEdvb2dsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBi aW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC0yMzksMyAr MjQwLDEwIEBAIGNsYXNzIE1hY1BvcnQoQXBwbGVQb3J0KToKICAgICAgICAgICAgICAgICBfbG9n LmRlYnVnKCJJT0Vycm9yIHJhaXNlZCB3aGlsZSBzdG9wcGluZyBoZWxwZXI6ICVzIiAlIHN0cihl KSkKICAgICAgICAgICAgICAgICBwYXNzCiAgICAgICAgICAgICBzZWxmLl9oZWxwZXIgPSBOb25l CisKKyAgICBkZWYgbm1fY29tbWFuZChzZWxmKToKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAg cmV0dXJuIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3hjcnVuJywgJy1maW5kJywgJ25t J10pLnJzdHJpcCgpCisgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKKyAgICAgICAgICAg IF9sb2cud2FybigieGNydW4gZmFpbGVkOyBmYWxsaW5nIGJhY2sgdG8gJ25tJy4iKQorICAgICAg ICAgICAgcmV0dXJuICdubScKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXggMDk2NWI0NGE0ZmQ4MWM5YjUwODlkYjAzMjFjM2My Mzg1ZTczYzk2Ni4uZDc5ODAzOWFjODhiYmU0MjQ1NjE4YWUzZTY5Njc2ZjU2Njk4YmI3MyAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQu cHkKQEAgLTEsNyArMSw3IEBACiAjIS91c3IvYmluL2VudiBweXRob24KICMgQ29weXJpZ2h0IChD KSAyMDEwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjIENvcHlyaWdodCAoQykg MjAxMCBHYWJvciBSYXBjc2FueWkgPHJnYWJvckBpbmYudS1zemVnZWQuaHU+LCBVbml2ZXJzaXR5 IG9mIFN6ZWdlZAotIyBDb3B5cmlnaHQgKEMpIDIwMTEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMTEsIDIwMTIgQXBwbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAtMjYyLDEyICsy NjIsMTUgQEAgY2xhc3MgV2ViS2l0UG9ydChQb3J0KToKICAgICAgICAgIiIiSWYgYSBwb3J0IG1h a2VzIGNlcnRhaW4gZmVhdHVyZXMgYXZhaWxhYmxlIG9ubHkgdGhyb3VnaCBydW50aW1lIGZsYWdz LCBpdCBjYW4gb3ZlcnJpZGUgdGhpcyByb3V0aW5lIHRvIGluZGljYXRlIHdoaWNoIG9uZXMgYXJl IGF2YWlsYWJsZS4iIiIKICAgICAgICAgcmV0dXJuIE5vbmUKIAorICAgIGRlZiBubV9jb21tYW5k KHNlbGYpOgorICAgICAgICByZXR1cm4gJ25tJworCiAgICAgZGVmIF93ZWJjb3JlX3N5bWJvbHNf c3RyaW5nKHNlbGYpOgogICAgICAgICB3ZWJjb3JlX2xpYnJhcnlfcGF0aCA9IHNlbGYuX3BhdGhf dG9fd2ViY29yZV9saWJyYXJ5KCkKICAgICAgICAgaWYgbm90IHdlYmNvcmVfbGlicmFyeV9wYXRo OgogICAgICAgICAgICAgcmV0dXJuIE5vbmUKICAgICAgICAgdHJ5OgotICAgICAgICAgICAgcmV0 dXJuIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ25tJywgd2ViY29yZV9saWJyYXJ5X3Bh dGhdLCBlcnJvcl9oYW5kbGVyPUV4ZWN1dGl2ZS5pZ25vcmVfZXJyb3IpCisgICAgICAgICAgICBy ZXR1cm4gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFtzZWxmLm5tX2NvbW1hbmQoKSwgd2Vi Y29yZV9saWJyYXJ5X3BhdGhdLCBlcnJvcl9oYW5kbGVyPUV4ZWN1dGl2ZS5pZ25vcmVfZXJyb3Ip CiAgICAgICAgIGV4Y2VwdCBPU0Vycm9yLCBlOgogICAgICAgICAgICAgX2xvZy53YXJuKCJGYWls ZWQgdG8gcnVuIG5tOiAlcy4gIENhbid0IGRldGVybWluZSBXZWJDb3JlIHN1cHBvcnRlZCBmZWF0 dXJlcy4iICUgZSkKICAgICAgICAgcmV0dXJuIE5vbmUK