87583 2012-05-26 16:03:24 -0700 [Cairo] [OpenGL] Enable GL_OES_standard_derivatives 2012-06-05 16:12:47 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/webgl-conformance-tests.html P2 Normal --- 1 mrobinson mrobinson webkit.review.bot oldest_to_newest 634678 0 mrobinson 2012-05-26 16:03:24 -0700 This extension is required by the WebGL conformance tests and is necessary to run the WebGL water demo at http://madebyevan.com/webgl-water/. We can add support via ANGLE. 636608 1 144653 mrobinson 2012-05-29 17:21:49 -0700 Created attachment 144653 Patch 637068 2 144653 alex 2012-05-30 02:35:59 -0700 Comment on attachment 144653 Patch LGTM 637215 3 144653 webkit.review.bot 2012-05-30 07:52:36 -0700 Comment on attachment 144653 Patch Rejecting attachment 144653 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Alejandro G found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12815013 641986 4 144653 webkit.review.bot 2012-06-05 16:12:41 -0700 Comment on attachment 144653 Patch Clearing flags on attachment: 144653 Committed r119533: <http://trac.webkit.org/changeset/119533> 641987 5 webkit.review.bot 2012-06-05 16:12:47 -0700 All reviewed patches have been landed. Closing bug. 144653 2012-05-29 17:21:49 -0700 2012-06-05 16:12:41 -0700 Patch bug-87583-20120529172148.patch text/plain 2232 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU4NmMzZDZmYzE2NzUw YWNjZjE4MDMxNGYyMjA0OWRjMjE3YWZhYy4uNjAzODgyZDY0MTcwMDhiMDQ2ODg1MDA2NTZiZmZj MmE5YTcxNTYwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTI5ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIFtP cGVuR0xdIEVuYWJsZSBHTF9PRVNfc3RhbmRhcmRfZGVyaXZhdGl2ZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NTgzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGlzIGNv dmVyZWQgYnkgb2VzLXN0YW5kYXJkLWRlcml2YXRpdmVzLmh0bWwKKyAgICAgICAgaW4gdGhlIEto cm9ub3MgV2ViR0wgY29uZm9ybWFuY2UgdGVzdHMsIHdoaWNoIG1heSBvbmUgZGF5IGJlIHBhcnQK KyAgICAgICAgb2YgdGhlIFdlYktpdCB0ZXN0IHN1aXRlLgorCisgICAgICAgIEFjdGl2YXRlIHRo ZSBHTF9PRVNfc3RhbmRhcmRfZGVyaXZhdGl2ZXMgb24gQ2Fpcm8gYWxvbmcgd2l0aAorICAgICAg ICBRdCBhbmQgTWFjLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVu c2lvbnMzRE9wZW5HTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFeHRlbnNpb25zM0RPcGVuR0w6 OmVuc3VyZUVuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uczNET3BlbkdMOjpp c0VuYWJsZWQpOgorCiAyMDEyLTA1LTI0ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgYW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcg aW1wbGVtZW50YXRpb24gZm9yIFdlYktpdDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0wuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTC5jcHAKaW5k ZXggNTk2YjJmYTNmMmZlYTQzYTMxZjFkMDViMGUzMzNiOGFjZDg3NGZiNS4uMGQzM2I5MjMwNjE1 N2JmOWMyM2M0YTZlNTE3MDZiMmNmNjA2YjAxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTC5j cHAKQEAgLTEwNiw3ICsxMDYsNyBAQCBib29sIEV4dGVuc2lvbnMzRE9wZW5HTDo6c3VwcG9ydHMo Y29uc3QgU3RyaW5nJiBuYW1lKQogCiB2b2lkIEV4dGVuc2lvbnMzRE9wZW5HTDo6ZW5zdXJlRW5h YmxlZChjb25zdCBTdHJpbmcmIG5hbWUpCiB7Ci0jaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9S TShRVCkKKyNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEsp CiAgICAgaWYgKG5hbWUgPT0gIkdMX09FU19zdGFuZGFyZF9kZXJpdmF0aXZlcyIpIHsKICAgICAg ICAgLy8gRW5hYmxlIHN1cHBvcnQgaW4gQU5HTEUgKGlmIG5vdCBlbmFibGVkIGFscmVhZHkpCiAg ICAgICAgIEFOR0xFV2ViS2l0QnJpZGdlJiBjb21waWxlciA9IG1fY29udGV4dC0+bV9jb21waWxl cjsKQEAgLTEyMyw3ICsxMjMsNyBAQCB2b2lkIEV4dGVuc2lvbnMzRE9wZW5HTDo6ZW5zdXJlRW5h YmxlZChjb25zdCBTdHJpbmcmIG5hbWUpCiAKIGJvb2wgRXh0ZW5zaW9uczNET3BlbkdMOjppc0Vu YWJsZWQoY29uc3QgU3RyaW5nJiBuYW1lKQogewotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZP Uk0oUVQpCisjaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RL KQogICAgIGlmIChuYW1lID09ICJHTF9PRVNfc3RhbmRhcmRfZGVyaXZhdGl2ZXMiKSB7CiAgICAg ICAgIEFOR0xFV2ViS2l0QnJpZGdlJiBjb21waWxlciA9IG1fY29udGV4dC0+bV9jb21waWxlcjsK ICAgICAgICAgcmV0dXJuIGNvbXBpbGVyLmdldFJlc291cmNlcygpLk9FU19zdGFuZGFyZF9kZXJp dmF0aXZlczsK