87579 2012-05-26 09:14:13 -0700 [BlackBerry] http authentication crash the browser when user commit or cancel the http authentication dialog 2012-05-30 17:39:38 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jonathan.dong.webkit joenotcharles charles.wei joenotcharles leo.yang rwlbuis tonikitoo webkit.review.bot oldest_to_newest 634648 0 jonathan.dong.webkit 2012-05-26 09:14:13 -0700 RIM PR: 158892 Way to reproduce: navigate to any site which needs http authentication, input something or cancel it directly. Then you'll see the webviews process crash. Root cause: We release the m_handle in the old network job too early before we start a new one with authentication information attached. when the m_handle has been passed to the new network job and the old one received a dataReceivedNotify (e.g. parsing the body data received together with 401 header), the crash happens. So we should make sure that we cancel the current network job first, and then start the new one. by doing this we can avoid receiving a dataReceivedNotify after we start the new job. 634652 1 144203 jonathan.dong.webkit 2012-05-26 09:47:06 -0700 Created attachment 144203 Patch 635007 2 144203 webkit.review.bot 2012-05-28 01:54:02 -0700 Comment on attachment 144203 Patch Clearing flags on attachment: 144203 Committed r118655: <http://trac.webkit.org/changeset/118655> 635008 3 webkit.review.bot 2012-05-28 01:54:07 -0700 All reviewed patches have been landed. Closing bug. 637301 4 joenotcharles 2012-05-30 09:20:58 -0700 This patch "works" in release, but causes an assertion fail in debug: Thread 3 (CRITICAL!): ASSERTION FAILED: !findJobForHandle(guardJob) /home/jmason/dev/webkit/Source/WebCore/platform/network/blackberry/NetworkManager.cpp(135) : bool WebCore::NetworkManager::startJob(int, const WTF::String&, WTF::PassRefPtr<WebCore::ResourceHandle>, const WebCore::ResourceRequest&, BlackBerry::Platform::NetworkStreamFactory*, const WebCore::Frame&, int, int) Thread 3 (CRITICAL!): SIGSEGV: 557486080 The cause is that in a redirect, it calls close on the original job, but then tries to create a new job for the handle before the notifyClose is processed, so there are briefly 2 jobs with the same handle. 637317 5 144842 joenotcharles 2012-05-30 09:41:26 -0700 Created attachment 144842 assertion fix 2012-05-30 Joe Mason <jmason@rim.com> [BlackBerry] Fix assertion fail on redirect due to multiple jobs per handle https://bugs.webkit.org/show_bug.cgi?id=87579 Reviewed by NOBODY (OOPS!). RIM PR #158892: When we start a redirect, we now call cancelJob instead of just deleting it immediately to make sure that all cleanup is performed. However, we also reassign the ResourceHandle to the new job, and since cancelJob is asynchronous it is now assigned to two jobs simultaneously. Work around this by only returning handles that have not been cancelled from findJobForHandle. Cancelled jobs still technically exist in the jobs list, but they're invisible to callers. This is safe because there is literally nothing that can be done with a cancelled job - it is supposed to merely consume any notifications that are already in progress and then kill itself off - so no callers of findJobForHandle are expecting a cancelled job. (All existing callers call methods on the returned job which are no-ops for cancelled jobs, so there is no behaviour change.) No new tests because there is no behaviour change (fixes a regression). * platform/network/blackberry/NetworkManager.cpp: (WebCore::NetworkManager::findJobForHandle): 637406 6 144865 joenotcharles 2012-05-30 10:39:18 -0700 Created attachment 144865 fix with changelogs 637511 7 144865 staikos 2012-05-30 12:04:56 -0700 Comment on attachment 144865 fix with changelogs It seems testable, but I'm not quite sure how. There was a behavior test, hence we could have a regression test. That said, I have no idea how to test it and the alternative is to revert the previous patch so let's go with it for now. Suggest we put in a test if we can find one. 637518 8 joenotcharles 2012-05-30 12:11:38 -0700 (In reply to comment #7) > (From update of attachment 144865 [details]) > It seems testable, but I'm not quite sure how. There was a behavior test, hence we could have a regression test. That said, I have no idea how to test it and the alternative is to revert the previous patch so let's go with it for now. Suggest we put in a test if we can find one. The problem was the existing tests were only run with a release build. 637862 9 144865 webkit.review.bot 2012-05-30 17:39:33 -0700 Comment on attachment 144865 fix with changelogs Clearing flags on attachment: 144865 Committed r119005: <http://trac.webkit.org/changeset/119005> 637863 10 webkit.review.bot 2012-05-30 17:39:38 -0700 All reviewed patches have been landed. Closing bug. 144203 2012-05-26 09:47:06 -0700 2012-05-28 01:54:02 -0700 Patch bug-87579-20120527004703.patch text/plain 2024 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI4NDg2ODVhZmJhMmJj YWU0NDEyNTk5MjJlMmQ1MTQ0ZWRjODI1MC4uNzVmOTQ5MzAyMGZhNzdjYTU5OTMwNWQxN2NlNzRl YWViNzc1ZTJmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTI2ICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIGh0dHAgYXV0aGVudGljYXRpb24gY3Jhc2ggdGhlIGJyb3dzZXIgd2hlbiB1 c2VyIGNvbW1pdCBvciBjYW5jZWwgdGhlIGh0dHAgYXV0aGVudGljYXRpb24gZGlhbG9nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzU3OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGZ1bmN0aW9uIE5l dHdvcmtKb2I6OnN0YXJ0TmV3Sm9iV2l0aFJlcXVlc3QsIFdlIHNob3VsZCBjYW5jZWwgdGhlCisg ICAgICAgIE5ldHdvcmtKb2IgZmlyc3QgYmVmb3JlIHdlIHN0YXJ0IGEgbmV3IE5ldHdvcmtKb2Ig d2hpY2ggcmV1c2VzIHRoZQorICAgICAgICByZXNvdXJjZSBoYW5kbGUgb2YgdGhlIG9sZCBvbmUu IElmIHdlIG9ubHkgc2V0IHRoZSBtX2hhbmRsZSA9IDAgb2YgdGhlCisgICAgICAgIG9sZCBOZXR3 b3JrSm9iIHdpdGhvdXQgY2FuY2VsbGluZyBpdHNlbGYsIGl0IHdpbGwgc3RpbGwgcmVjZWl2ZXMg ZGF0YQorICAgICAgICBub3RpZmljYXRpb24gZnJvbSBuZXR3b3JrIHRocmVhZCBhbmQgaGFuZGxl cyB0aGUgcmVjZWl2ZWQgZGF0YSB3aXRoCisgICAgICAgIHRoZSByZWxlYXNlZCByZXNvdXJjZSBo YW5kbGVyLCB3aGljaCB3aWxsIGNhdXNlIHRoZSBjcmFzaC4KKworICAgICAgICBObyBuZXcgdGVz dHMgYmVjYXVzZSBubyBiZWhhdmlvciBoYXMgY2hhbmdlZC4KKworICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5l dHdvcmtKb2I6OnN0YXJ0TmV3Sm9iV2l0aFJlcXVlc3QpOgorCiAyMDEyLTA1LTI1ICBQaGlsaXBw ZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBS ZW1vdmUgSW1hZ2VHU3RyZWFtZXJDRyBpbXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmlu ZGV4IDFlODExOTYxYjFmNGU3NjgxM2RhZjU3MDA2ZWVkNTdiYTA5MDA0YjguLmZhYjNiMjdlNmMx N2FjZTZjMDM3Y2IxNjVkMjkxYjk0ODdjNGVjM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKQEAgLTUy OCw4ICs1MjgsNyBAQCBib29sIE5ldHdvcmtKb2I6OnN0YXJ0TmV3Sm9iV2l0aFJlcXVlc3QoUmVz b3VyY2VSZXF1ZXN0JiBuZXdSZXF1ZXN0LCBib29sIGluY3JlYQogCiAgICAgLy8gUGFzcyB0aGUg b3duZXJzaGlwIG9mIHRoZSBSZXNvdXJjZUhhbmRsZSB0byB0aGUgbmV3IE5ldHdvcmtKb2IuCiAg ICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5kbGUgPSBtX2hhbmRsZTsKLSAgICBtX2hhbmRs ZSA9IDA7Ci0gICAgbV9tdWx0aXBhcnRSZXNwb25zZSA9IG51bGxwdHI7CisgICAgY2FuY2VsSm9i KCk7CiAKICAgICBOZXR3b3JrTWFuYWdlcjo6aW5zdGFuY2UoKS0+c3RhcnRKb2IobV9wbGF5ZXJJ ZCwKICAgICAgICAgbV9wYWdlR3JvdXBOYW1lLAo= 144842 2012-05-30 09:41:26 -0700 2012-05-30 10:39:18 -0700 assertion fix 0002-2012-05-30-Joe-Mason-jmason-rim.com.patch text/plain 2884 joenotcharles RnJvbSAwZjNlZWNjZjgzYzliNzIyYzY3MmIzZmFlZTViMTBmMzQ4ZDk3NTIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBXZWQs IDMwIE1heSAyMDEyIDEyOjIzOjQwIC0wNDAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIDIwMTItMDUt MzAgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgoKICAgICAgICBbQmxhY2tCZXJyeV0gRml4 IGFzc2VydGlvbiBmYWlsIG9uIHJlZGlyZWN0IGR1ZSB0byBtdWx0aXBsZSBqb2JzIHBlciBoYW5k bGUKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc1NzkK CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFJJTSBQUiAjMTU4 ODkyOgoKICAgICAgICBXaGVuIHdlIHN0YXJ0IGEgcmVkaXJlY3QsIHdlIG5vdyBjYWxsIGNhbmNl bEpvYiBpbnN0ZWFkIG9mIGp1c3QgZGVsZXRpbmcgaXQgaW1tZWRpYXRlbHkgdG8gbWFrZSBzdXJl CiAgICAgICAgdGhhdCBhbGwgY2xlYW51cCBpcyBwZXJmb3JtZWQuIEhvd2V2ZXIsIHdlIGFsc28g cmVhc3NpZ24gdGhlIFJlc291cmNlSGFuZGxlIHRvIHRoZSBuZXcgam9iLCBhbmQKICAgICAgICBz aW5jZSBjYW5jZWxKb2IgaXMgYXN5bmNocm9ub3VzIGl0IGlzIG5vdyBhc3NpZ25lZCB0byB0d28g am9icyBzaW11bHRhbmVvdXNseS4KCiAgICAgICAgV29yayBhcm91bmQgdGhpcyBieSBvbmx5IHJl dHVybmluZyBoYW5kbGVzIHRoYXQgaGF2ZSBub3QgYmVlbiBjYW5jZWxsZWQgZnJvbSBmaW5kSm9i Rm9ySGFuZGxlLgogICAgICAgIENhbmNlbGxlZCBqb2JzIHN0aWxsIHRlY2huaWNhbGx5IGV4aXN0 IGluIHRoZSBqb2JzIGxpc3QsIGJ1dCB0aGV5J3JlIGludmlzaWJsZSB0byBjYWxsZXJzLiBUaGlz IGlzCiAgICAgICAgc2FmZSBiZWNhdXNlIHRoZXJlIGlzIGxpdGVyYWxseSBub3RoaW5nIHRoYXQg Y2FuIGJlIGRvbmUgd2l0aCBhIGNhbmNlbGxlZCBqb2IgLSBpdCBpcyBzdXBwb3NlZCB0bwogICAg ICAgIG1lcmVseSBjb25zdW1lIGFueSBub3RpZmljYXRpb25zIHRoYXQgYXJlIGFscmVhZHkgaW4g cHJvZ3Jlc3MgYW5kIHRoZW4ga2lsbCBpdHNlbGYgb2ZmIC0gc28gbm8KICAgICAgICBjYWxsZXJz IG9mIGZpbmRKb2JGb3JIYW5kbGUgYXJlIGV4cGVjdGluZyBhIGNhbmNlbGxlZCBqb2IuIChBbGwg ZXhpc3RpbmcgY2FsbGVycyBjYWxsIG1ldGhvZHMgb24gdGhlCiAgICAgICAgcmV0dXJuZWQgam9i IHdoaWNoIGFyZSBuby1vcHMgZm9yIGNhbmNlbGxlZCBqb2JzLCBzbyB0aGVyZSBpcyBubyBiZWhh dmlvdXIgY2hhbmdlLikKCiAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8g YmVoYXZpb3VyIGNoYW5nZSAoZml4ZXMgYSByZWdyZXNzaW9uKS4KCiAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFnZXIuY3BwOgogICAgICAgIChXZWJDb3Jl OjpOZXR3b3JrTWFuYWdlcjo6ZmluZEpvYkZvckhhbmRsZSk6Ci0tLQogLi4uL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFuYWdlci5jcHAgfCAgICA4ICsrKystLS0tCiAxIGZp bGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFn ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdv cmtNYW5hZ2VyLmNwcAppbmRleCBiY2ViMWRhLi44OWQ2MTljIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFnZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFu YWdlci5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA5LCAyMDEw LCAyMDExIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkLiBBbGwgcmlnaHRzIHJlc2VydmVkLgor ICogQ29weXJpZ2h0IChDKSAyMDA5LCAyMDEwLCAyMDExLCAyMDEyIFJlc2VhcmNoIEluIE1vdGlv biBMaW1pdGVkLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFRoaXMgbGlicmFyeSBpcyBm cmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqIG1vZGlmeSBp dCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKQEAgLTE2 MCwxMCArMTYwLDEwIEBAIE5ldHdvcmtKb2IqIE5ldHdvcmtNYW5hZ2VyOjpmaW5kSm9iRm9ySGFu ZGxlKFBhc3NSZWZQdHI8UmVzb3VyY2VIYW5kbGU+IGpvYikKIHsKICAgICBmb3IgKHVuc2lnbmVk IGkgPSAwOyBpIDwgbV9qb2JzLnNpemUoKTsgKytpKSB7CiAgICAgICAgIE5ldHdvcmtKb2IqIG5l dHdvcmtKb2IgPSBtX2pvYnNbaV07Ci0gICAgICAgIGlmIChuZXR3b3JrSm9iLT5oYW5kbGUoKSA9 PSBqb2IpIHsKLSAgICAgICAgICAgIC8vIFdlIGhhdmUgb25seSBvbmUgam9iIGZvciBvbmUgaGFu ZGxlLgorICAgICAgICAvLyBXZSBoYXZlIG9ubHkgb25lIGpvYiBmb3Igb25lIGhhbmRsZSAobm90 IGluY2x1ZGluZyBjYW5jZWxsZWQgam9icyB3aGljaCBtYXkgaGFuZworICAgICAgICAvLyBhcm91 bmQgYnJpZWZseSksIHNvIHJldHVybiB0aGUgZmlyc3Qgbm9uLWNhbmNlbGxlZCBqb2IuCisgICAg ICAgIGlmICghbmV0d29ya0pvYi0+aXNDYW5jZWxsZWQoKSAmJiBuZXR3b3JrSm9iLT5oYW5kbGUo KSA9PSBqb2IpCiAgICAgICAgICAgICByZXR1cm4gbmV0d29ya0pvYjsKLSAgICAgICAgfQogICAg IH0KICAgICByZXR1cm4gMDsKIH0KLS0gCjEuNy41LjQKCg== 144865 2012-05-30 10:39:18 -0700 2012-05-30 17:39:33 -0700 fix with changelogs 0002-2012-05-30-Joe-Mason-jmason-rim.com.patch text/plain 4704 joenotcharles RnJvbSBjZGEwZjk3YzI5ODg4NDM2Nzc4NTY1MTg3MDBlNWE1YjhmYTM1ZTkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBXZWQs IDMwIE1heSAyMDEyIDEyOjIzOjQwIC0wNDAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIDIwMTItMDUt MzAgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgoKICAgICAgICBbQmxhY2tCZXJyeV0gRml4 IGFzc2VydGlvbiBmYWlsIG9uIHJlZGlyZWN0IGR1ZSB0byBtdWx0aXBsZSBqb2JzIHBlciBoYW5k bGUKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc1NzkK CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFJJTSBQUiAjMTU4 ODkyOgoKICAgICAgICBXaGVuIHdlIHN0YXJ0IGEgcmVkaXJlY3QsIHdlIG5vdyBjYWxsIGNhbmNl bEpvYiBpbnN0ZWFkIG9mIGp1c3QgZGVsZXRpbmcgaXQgaW1tZWRpYXRlbHkgdG8gbWFrZSBzdXJl CiAgICAgICAgdGhhdCBhbGwgY2xlYW51cCBpcyBwZXJmb3JtZWQuIEhvd2V2ZXIsIHdlIGFsc28g cmVhc3NpZ24gdGhlIFJlc291cmNlSGFuZGxlIHRvIHRoZSBuZXcgam9iLCBhbmQKICAgICAgICBz aW5jZSBjYW5jZWxKb2IgaXMgYXN5bmNocm9ub3VzIGl0IGlzIG5vdyBhc3NpZ25lZCB0byB0d28g am9icyBzaW11bHRhbmVvdXNseS4KCiAgICAgICAgV29yayBhcm91bmQgdGhpcyBieSBvbmx5IHJl dHVybmluZyBoYW5kbGVzIHRoYXQgaGF2ZSBub3QgYmVlbiBjYW5jZWxsZWQgZnJvbSBmaW5kSm9i Rm9ySGFuZGxlLgogICAgICAgIENhbmNlbGxlZCBqb2JzIHN0aWxsIHRlY2huaWNhbGx5IGV4aXN0 IGluIHRoZSBqb2JzIGxpc3QsIGJ1dCB0aGV5J3JlIGludmlzaWJsZSB0byBjYWxsZXJzLiBUaGlz IGlzCiAgICAgICAgc2FmZSBiZWNhdXNlIHRoZXJlIGlzIGxpdGVyYWxseSBub3RoaW5nIHRoYXQg Y2FuIGJlIGRvbmUgd2l0aCBhIGNhbmNlbGxlZCBqb2IgLSBpdCBpcyBzdXBwb3NlZCB0bwogICAg ICAgIG1lcmVseSBjb25zdW1lIGFueSBub3RpZmljYXRpb25zIHRoYXQgYXJlIGFscmVhZHkgaW4g cHJvZ3Jlc3MgYW5kIHRoZW4ga2lsbCBpdHNlbGYgb2ZmIC0gc28gbm8KICAgICAgICBjYWxsZXJz IG9mIGZpbmRKb2JGb3JIYW5kbGUgYXJlIGV4cGVjdGluZyBhIGNhbmNlbGxlZCBqb2IuIChBbGwg ZXhpc3RpbmcgY2FsbGVycyBjYWxsIG1ldGhvZHMgb24gdGhlCiAgICAgICAgcmV0dXJuZWQgam9i IHdoaWNoIGFyZSBuby1vcHMgZm9yIGNhbmNlbGxlZCBqb2JzLCBzbyB0aGVyZSBpcyBubyBiZWhh dmlvdXIgY2hhbmdlLikKCiAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8g YmVoYXZpb3VyIGNoYW5nZSAoZml4ZXMgYSByZWdyZXNzaW9uKS4KCiAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFnZXIuY3BwOgogICAgICAgIChXZWJDb3Jl OjpOZXR3b3JrTWFuYWdlcjo6ZmluZEpvYkZvckhhbmRsZSk6Ci0tLQogU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDI1ICsrKysrKysrKysrKysr KysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2VyLmNw cCB8ICAgIDggKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDQgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDAwMjIwN2MuLjY2ZjljNDQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsNSArMSwzMCBAQAogMjAxMi0wNS0zMCAgSm9lIE1hc29uICA8am1hc29uQHJpbS5jb20+CiAK KyAgICAgICAgW0JsYWNrQmVycnldIEZpeCBhc3NlcnRpb24gZmFpbCBvbiByZWRpcmVjdCBkdWUg dG8gbXVsdGlwbGUgam9icyBwZXIgaGFuZGxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NzU3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJJTSBQUiAjMTU4ODkyOgorCisgICAgICAgIFdoZW4gd2Ugc3Rh cnQgYSByZWRpcmVjdCwgd2Ugbm93IGNhbGwgY2FuY2VsSm9iIGluc3RlYWQgb2YganVzdCBkZWxl dGluZyBpdCBpbW1lZGlhdGVseSB0byBtYWtlIHN1cmUKKyAgICAgICAgdGhhdCBhbGwgY2xlYW51 cCBpcyBwZXJmb3JtZWQuIEhvd2V2ZXIsIHdlIGFsc28gcmVhc3NpZ24gdGhlIFJlc291cmNlSGFu ZGxlIHRvIHRoZSBuZXcgam9iLCBhbmQKKyAgICAgICAgc2luY2UgY2FuY2VsSm9iIGlzIGFzeW5j aHJvbm91cyBpdCBpcyBub3cgYXNzaWduZWQgdG8gdHdvIGpvYnMgc2ltdWx0YW5lb3VzbHkuCisK KyAgICAgICAgV29yayBhcm91bmQgdGhpcyBieSBvbmx5IHJldHVybmluZyBoYW5kbGVzIHRoYXQg aGF2ZSBub3QgYmVlbiBjYW5jZWxsZWQgZnJvbSBmaW5kSm9iRm9ySGFuZGxlLgorICAgICAgICBD YW5jZWxsZWQgam9icyBzdGlsbCB0ZWNobmljYWxseSBleGlzdCBpbiB0aGUgam9icyBsaXN0LCBi dXQgdGhleSdyZSBpbnZpc2libGUgdG8gY2FsbGVycy4gVGhpcyBpcworICAgICAgICBzYWZlIGJl Y2F1c2UgdGhlcmUgaXMgbGl0ZXJhbGx5IG5vdGhpbmcgdGhhdCBjYW4gYmUgZG9uZSB3aXRoIGEg Y2FuY2VsbGVkIGpvYiAtIGl0IGlzIHN1cHBvc2VkIHRvCisgICAgICAgIG1lcmVseSBjb25zdW1l IGFueSBub3RpZmljYXRpb25zIHRoYXQgYXJlIGFscmVhZHkgaW4gcHJvZ3Jlc3MgYW5kIHRoZW4g a2lsbCBpdHNlbGYgb2ZmIC0gc28gbm8KKyAgICAgICAgY2FsbGVycyBvZiBmaW5kSm9iRm9ySGFu ZGxlIGFyZSBleHBlY3RpbmcgYSBjYW5jZWxsZWQgam9iLiAoQWxsIGV4aXN0aW5nIGNhbGxlcnMg Y2FsbCBtZXRob2RzIG9uIHRoZQorICAgICAgICByZXR1cm5lZCBqb2Igd2hpY2ggYXJlIG5vLW9w cyBmb3IgY2FuY2VsbGVkIGpvYnMsIHNvIHRoZXJlIGlzIG5vIGJlaGF2aW91ciBjaGFuZ2UuKQor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW91ciBjaGFu Z2UgKGZpeGVzIGEgcmVncmVzc2lvbikuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2Js YWNrYmVycnkvTmV0d29ya01hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya01h bmFnZXI6OmZpbmRKb2JGb3JIYW5kbGUpOgorCisyMDEyLTA1LTMwICBKb2UgTWFzb24gIDxqbWFz b25AcmltLmNvbT4KKwogICAgICAgICBbQmxhY2tCZXJyeV0gUmVtb3ZlIHVzZWxlc3Mgc3RyaW5n LT5jaGFyKi0+c3RyaW5nIGNvbnZlcnNpb24gaW4gTmV0d29ya0pvYi4KICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3ODYxCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFuYWdlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01h bmFnZXIuY3BwCmluZGV4IGJjZWIxZGEuLjg5ZDYxOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFuYWdlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2Vy LmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDksIDIwMTAsIDIw MTEgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBD b3B5cmlnaHQgKEMpIDIwMDksIDIwMTAsIDIwMTEsIDIwMTIgUmVzZWFyY2ggSW4gTW90aW9uIExp bWl0ZWQuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUg c29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVu ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwpAQCAtMTYwLDEw ICsxNjAsMTAgQEAgTmV0d29ya0pvYiogTmV0d29ya01hbmFnZXI6OmZpbmRKb2JGb3JIYW5kbGUo UGFzc1JlZlB0cjxSZXNvdXJjZUhhbmRsZT4gam9iKQogewogICAgIGZvciAodW5zaWduZWQgaSA9 IDA7IGkgPCBtX2pvYnMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgTmV0d29ya0pvYiogbmV0d29y a0pvYiA9IG1fam9ic1tpXTsKLSAgICAgICAgaWYgKG5ldHdvcmtKb2ItPmhhbmRsZSgpID09IGpv YikgewotICAgICAgICAgICAgLy8gV2UgaGF2ZSBvbmx5IG9uZSBqb2IgZm9yIG9uZSBoYW5kbGUu CisgICAgICAgIC8vIFdlIGhhdmUgb25seSBvbmUgam9iIGZvciBvbmUgaGFuZGxlIChub3QgaW5j bHVkaW5nIGNhbmNlbGxlZCBqb2JzIHdoaWNoIG1heSBoYW5nCisgICAgICAgIC8vIGFyb3VuZCBi cmllZmx5KSwgc28gcmV0dXJuIHRoZSBmaXJzdCBub24tY2FuY2VsbGVkIGpvYi4KKyAgICAgICAg aWYgKCFuZXR3b3JrSm9iLT5pc0NhbmNlbGxlZCgpICYmIG5ldHdvcmtKb2ItPmhhbmRsZSgpID09 IGpvYikKICAgICAgICAgICAgIHJldHVybiBuZXR3b3JrSm9iOwotICAgICAgICB9CiAgICAgfQog ICAgIHJldHVybiAwOwogfQotLSAKMS43LjUuNAoK