87566 2012-05-25 22:19:07 -0700 [BlackBerry] Add a constructor to create a Path from an SkPath 2012-05-28 08:04:52 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87569 1 anilsson anilsson rwlbuis tonikitoo webkit.review.bot oldest_to_newest 634584 0 anilsson 2012-05-25 22:19:07 -0700 commit 00ee90cf093e9004e08e7b4970b5c84be263a295 Author: Arvid Nilsson <anilsson@rim.com> Date: Fri May 4 00:20:05 2012 +0200 2012-05-03 Arvid Nilsson <anilsson@rim.com> Add a constructor to create a Path from an SkPath PR #154329 Skia allows the creation of more complex paths than WebCore would allow. This will be used in the BlackBerry port to implement a default tap highlight appearance. Reviewed by Mike Lattanzio. * platform/graphics/Path.h: (Path): * platform/graphics/skia/PathSkia.cpp: (WebCore::Path::Path): (WebCore): 634743 1 144229 anilsson 2012-05-27 06:22:14 -0700 Created attachment 144229 Patch 634744 2 144229 tonikitoo 2012-05-27 06:31:15 -0700 Comment on attachment 144229 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144229&action=review r+, but lets fix one think before landing: when reuploading, please pre-fill "Reviewed by Antonio Gomes" and just set cq? > Source/WebCore/platform/graphics/Path.h:162 > +#if PLATFORM(BLACKBERRY) && USE(SKIA) I would drop the use(skia) here. 634768 3 144237 anilsson 2012-05-27 10:58:01 -0700 Created attachment 144237 Patch 635221 4 144237 webkit.review.bot 2012-05-28 08:04:47 -0700 Comment on attachment 144237 Patch Clearing flags on attachment: 144237 Committed r118682: <http://trac.webkit.org/changeset/118682> 635222 5 webkit.review.bot 2012-05-28 08:04:52 -0700 All reviewed patches have been landed. Closing bug. 144229 2012-05-27 06:22:14 -0700 2012-05-27 10:57:53 -0700 Patch bug-87566-20120527152213.patch text/plain 2305 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTVkN2I5ZmM2N2U3MDM3 ODNkY2I5YWNjZTg1NGFjZTcwNDg0ZGJhYi4uMDMzMDg4OGE4MDBkZGY2YTVlYjFkODQ0ODcyY2I1 YTBlYzBjM2E2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTA1LTI3ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KIAorICAgICAgICBbQmxhY2tCZXJyeV0gQWRk IGEgY29uc3RydWN0b3IgdG8gY3JlYXRlIGEgUGF0aCBmcm9tIGFuIFNrUGF0aAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc1NjYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTa2lhIGFsbG93cyB0aGUgY3Jl YXRpb24gb2YgbW9yZSBjb21wbGV4IHBhdGhzIHRoYW4gV2ViQ29yZSB3b3VsZAorICAgICAgICBh bGxvdy4gVGhpcyB3aWxsIGJlIHVzZWQgaW4gdGhlIEJsYWNrQmVycnkgcG9ydCB0byBpbXBsZW1l bnQgYSBkZWZhdWx0CisgICAgICAgIHRhcCBoaWdobGlnaHQgYXBwZWFyYW5jZS4KKworICAgICAg ICBSZXZpZXdlZCBpbnRlcm5hbGx5IGJ5IE1pa2UgTGF0dGFuemlvLgorCisgICAgICAgIFBSICMx NTQzMjkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BhdGguaDoKKyAgICAgICAgKFBh dGgpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0aFNraWEuY3BwOgorICAg ICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjpQYXRoKToKKworMjAxMi0w NS0yNyAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CisKICAgICAgICAgW0JsYWNr QmVycnldIFVwZGF0ZSBXZWJQYWdlQ29tcG9zaXRvcjo6cmVuZGVyKCkgQVBJCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzU2NQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmgKaW5kZXggOTZjODEwNDI1OTgzYTc2YjY4MjQzMDZm ODlhYWVhMmNlNWM1ZDEyOS4uOWI5MTA3MDc2Y2I4MzA3OTM3YmIyOTkzYTkzYzE3OTI1MTQ0ZTg5 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguaApAQCAtMTU5LDYgKzE1 OSwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQgcGxhdGZvcm1BZGRQYXRo Rm9yUm91bmRlZFJlY3QoY29uc3QgRmxvYXRSZWN0JiwgY29uc3QgRmxvYXRTaXplJiB0b3BMZWZ0 UmFkaXVzLCBjb25zdCBGbG9hdFNpemUmIHRvcFJpZ2h0UmFkaXVzLCBjb25zdCBGbG9hdFNpemUm IGJvdHRvbUxlZnRSYWRpdXMsIGNvbnN0IEZsb2F0U2l6ZSYgYm90dG9tUmlnaHRSYWRpdXMpOwog I2VuZGlmCiAKKyNpZiBQTEFURk9STShCTEFDS0JFUlJZKSAmJiBVU0UoU0tJQSkKKyAgICAgICAg UGF0aChjb25zdCBTa1BhdGgmKTsKKyNlbmRpZgorCiAgICAgcHJpdmF0ZToKICAgICAgICAgUGxh dGZvcm1QYXRoUHRyIG1fcGF0aDsKICAgICB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1BhdGhTa2lhLmNwcAppbmRleCAwYmE2ZDA3MGU1ZDAwY2NkOTRj NzE1MzhjNGEwNmRhMjRiM2M3YTMyLi44Nzk1YjRjM2M3YmNiYjgyZmFhNDVlNWNmMzkxMzEzNzgw OTE0OWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1BhdGhTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1BhdGhTa2lhLmNwcApAQCAtNTMsNiArNTMsMTMgQEAgUGF0aDo6UGF0aChjb25zdCBQYXRoJiBv dGhlcikKICAgICBtX3BhdGggPSBuZXcgU2tQYXRoKCpvdGhlci5tX3BhdGgpOwogfQogCisjaWYg UExBVEZPUk0oQkxBQ0tCRVJSWSkKK1BhdGg6OlBhdGgoY29uc3QgU2tQYXRoJiBwYXRoKQorewor ICAgIG1fcGF0aCA9IG5ldyBTa1BhdGgocGF0aCk7Cit9CisjZW5kaWYKKwogUGF0aDo6flBhdGgo KQogewogICAgIGRlbGV0ZSBtX3BhdGg7Cg== 144237 2012-05-27 10:58:01 -0700 2012-05-28 08:04:47 -0700 Patch bug-87566-20120527195759.patch text/plain 2291 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTVkN2I5ZmM2N2U3MDM3 ODNkY2I5YWNjZTg1NGFjZTcwNDg0ZGJhYi4uZTIyMTM5OWFkNmI0NTc0ODdkMTA4MmMzMjAxZjky Nzc4YTU5NDkwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTA1LTI3ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KIAorICAgICAgICBbQmxhY2tCZXJyeV0gQWRk IGEgY29uc3RydWN0b3IgdG8gY3JlYXRlIGEgUGF0aCBmcm9tIGFuIFNrUGF0aAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc1NjYKKworICAgICAgICBS ZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgorCisgICAgICAgIFNraWEgYWxsb3dzIHRoZSBjcmVh dGlvbiBvZiBtb3JlIGNvbXBsZXggcGF0aHMgdGhhbiBXZWJDb3JlIHdvdWxkCisgICAgICAgIGFs bG93LiBUaGlzIHdpbGwgYmUgdXNlZCBpbiB0aGUgQmxhY2tCZXJyeSBwb3J0IHRvIGltcGxlbWVu dCBhIGRlZmF1bHQKKyAgICAgICAgdGFwIGhpZ2hsaWdodCBhcHBlYXJhbmNlLgorCisgICAgICAg IFJldmlld2VkIGludGVybmFsbHkgYnkgTWlrZSBMYXR0YW56aW8uCisKKyAgICAgICAgUFIgIzE1 NDMyOQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5oOgorICAgICAgICAoUGF0 aCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHA6CisgICAg ICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlBhdGg6OlBhdGgpOgorCisyMDEyLTA1 LTI3ICBBcnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKwogICAgICAgICBbQmxhY2tC ZXJyeV0gVXBkYXRlIFdlYlBhZ2VDb21wb3NpdG9yOjpyZW5kZXIoKSBBUEkKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NTY1CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguaAppbmRleCA5NmM4MTA0MjU5ODNhNzZiNjgyNDMwNmY4 OWFhZWEyY2U1YzVkMTI5Li5hMzNhYjRjOGIwYWY1ZWM2NWRhY2UxZjQxZjk3ZGE0ZWU1Mzc5YmUw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5oCkBAIC0xNTksNiArMTU5 LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBwbGF0Zm9ybUFkZFBhdGhG b3JSb3VuZGVkUmVjdChjb25zdCBGbG9hdFJlY3QmLCBjb25zdCBGbG9hdFNpemUmIHRvcExlZnRS YWRpdXMsIGNvbnN0IEZsb2F0U2l6ZSYgdG9wUmlnaHRSYWRpdXMsIGNvbnN0IEZsb2F0U2l6ZSYg Ym90dG9tTGVmdFJhZGl1cywgY29uc3QgRmxvYXRTaXplJiBib3R0b21SaWdodFJhZGl1cyk7CiAj ZW5kaWYKIAorI2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgICAgIFBhdGgoY29uc3QgU2tQ YXRoJik7CisjZW5kaWYKKwogICAgIHByaXZhdGU6CiAgICAgICAgIFBsYXRmb3JtUGF0aFB0ciBt X3BhdGg7CiAgICAgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3NraWEvUGF0aFNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9QYXRoU2tpYS5jcHAKaW5kZXggMGJhNmQwNzBlNWQwMGNjZDk0YzcxNTM4YzRhMDZkYTI0 YjNjN2EzMi4uODc5NWI0YzNjN2JjYmI4MmZhYTQ1ZTVjZjM5MTMxMzc4MDkxNDliNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHAK QEAgLTUzLDYgKzUzLDEzIEBAIFBhdGg6OlBhdGgoY29uc3QgUGF0aCYgb3RoZXIpCiAgICAgbV9w YXRoID0gbmV3IFNrUGF0aCgqb3RoZXIubV9wYXRoKTsKIH0KIAorI2lmIFBMQVRGT1JNKEJMQUNL QkVSUlkpCitQYXRoOjpQYXRoKGNvbnN0IFNrUGF0aCYgcGF0aCkKK3sKKyAgICBtX3BhdGggPSBu ZXcgU2tQYXRoKHBhdGgpOworfQorI2VuZGlmCisKIFBhdGg6On5QYXRoKCkKIHsKICAgICBkZWxl dGUgbV9wYXRoOwo=