87564 2012-05-25 22:12:40 -0700 [BlackBerry] Plumb through the return value of makeCurrent to the caller 2012-05-28 09:24:05 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87563 87565 1 anilsson anilsson mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 634581 0 anilsson 2012-05-25 22:12:40 -0700 Source/WebKit/blackberry: 2012-04-21 Arvid Nilsson <anilsson@rim.com> Plumb through the return value of makeCurrent to the caller PR #149721 Reviewed by George Staikos. * WebKitSupport/GLES2Context.cpp: (BlackBerry::WebKit::GLES2Context::makeCurrent): Source/WebCore: 2012-04-21 Arvid Nilsson <anilsson@rim.com> Bail if we fail to make the context current PR #149721 Let initializeSharedGLObjects return false if we fail to make the GL context current, so we never enter the "hardware compositing" state. Also bail from drawLayers() if we're not hardware compositing. Reviewed by George Staikos. Tested by forcing the GLES2Context to return false from makeCurrent. * platform/graphics/blackberry/LayerRenderer.cpp: (WebCore::LayerRenderer::~LayerRenderer): (WebCore::LayerRenderer::drawLayers): (WebCore::LayerRenderer::initializeSharedGLObjects): 634741 1 144227 anilsson 2012-05-27 05:53:23 -0700 Created attachment 144227 Patch 635247 2 mifenton 2012-05-28 08:26:58 -0700 Looks good to me. 635250 3 144227 rwlbuis 2012-05-28 08:29:10 -0700 Comment on attachment 144227 Patch Looks good. 635284 4 144227 webkit.review.bot 2012-05-28 09:24:01 -0700 Comment on attachment 144227 Patch Clearing flags on attachment: 144227 Committed r118689: <http://trac.webkit.org/changeset/118689> 635285 5 webkit.review.bot 2012-05-28 09:24:05 -0700 All reviewed patches have been landed. Closing bug. 144227 2012-05-27 05:53:23 -0700 2012-05-28 09:24:01 -0700 Patch bug-87564-20120527145322.patch text/plain 1713 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyMjJkMTJlMjE3NWRkOGE2NDdjNGU0YTQyM2FlZGQ0YmRmZGU3NmQ3Li45OGM2NGZkY2My NTQ0ZDEyM2ZkOTE0MGMyZTdiOGJiNWIzOTQyYTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMi0wNS0yNyAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIFBsdW1iIHRocm91Z2ggdGhlIHJl dHVybiB2YWx1ZSBvZiBtYWtlQ3VycmVudCB0byBjYWxsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3YXkgdGhlIGNhbGxlciBjYW4gdGFrZSBh cHByb3ByaWF0ZSBhY3Rpb24gaWYgbWFrZUN1cnJlbnQgZmFpbHMsCisgICAgICAgIGZvciBleGFt cGxlIGJlY2F1c2Ugd2UncmUgcnVubmluZyBvdXQgb2YgbWVtb3J5LgorCisgICAgICAgIFJldmll d2VkIGludGVybmFsbHkgYnkgR2VvcmdlIFN0YWlrb3MuCisKKyAgICAgICAgUFIgIzE0OTcyMQor CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9HTEVTMkNvbnRleHQuY3BwOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpHTEVTMkNvbnRleHQ6Om1ha2VDdXJyZW50KToKKworMjAxMi0wNS0y NyAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CisKICAgICAgICAgMjAxMi0wNC0x OCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVy cnldIEJhY2tpbmdTdG9yZSBhY2Nlc3NlcyB0aWxlcyBldmVuIHRob3VnaCBpdCdzIG5vdCBhY3Rp dmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0dM RVMyQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9H TEVTMkNvbnRleHQuY3BwCmluZGV4IDA2NTA3YWNhYzcyZDM4ZDJkOTQxOTMyMThiZmJhNzk0ZWIw NDQ3ZjMuLjc4MTJkYThkZmQ0MzljZThjM2VhMzg4NmQ4NGIwN2YyNjE0ZDlkNWQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0dMRVMyQ29udGV4dC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvR0xFUzJDb250 ZXh0LmNwcApAQCAtMTAwLDggKzEwMCw3IEBAIFBsYXRmb3JtOjpJbnRTaXplIEdMRVMyQ29udGV4 dDo6c3VyZmFjZVNpemUoKSBjb25zdAogCiBib29sIEdMRVMyQ29udGV4dDo6bWFrZUN1cnJlbnQo KQogewotICAgIFBsYXRmb3JtOjpHcmFwaGljczo6bWFrZUJ1ZmZlckN1cnJlbnQoYnVmZmVyKCks IFBsYXRmb3JtOjpHcmFwaGljczo6R0xFUzIpOwotICAgIHJldHVybiB0cnVlOworICAgIHJldHVy biBQbGF0Zm9ybTo6R3JhcGhpY3M6Om1ha2VCdWZmZXJDdXJyZW50KGJ1ZmZlcigpLCBQbGF0Zm9y bTo6R3JhcGhpY3M6OkdMRVMyKTsKIH0KIAogYm9vbCBHTEVTMkNvbnRleHQ6OnN3YXBCdWZmZXJz KCkK