87563 2012-05-25 22:10:39 -0700 [BlackBerry] BackingStore accesses tiles even though it's not active 2012-05-27 07:42:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87562 87564 1 anilsson anilsson tonikitoo webkit.review.bot oldest_to_newest 634580 0 anilsson 2012-05-25 22:10:39 -0700 PR #150403 There are many scenarios that can call render and cause tile access, and they used to be rerouted to the direct rendering code when the backing store was not active. This was thanks to an implicit check for isActive() by virtue of calling shouldDirectRenderingToWindow() from render(). If we're using OpenGL for compositing the backing store contents however, direct rendering is always disabled and we jump right into the tile based rendering code. Fixed by adding an explicit check for isActive() in render(), now that the implicit check in shouldDirectRenderingToWindow() is conditional on having raster usage. Since PR136381/bug83131, when OpenGL compositing is used, and the backing store is not active, it is not in charge of drawing the root layer. Instead, we switch off the paintingGoesToWindow flag on the root RenderLayer so no invalidates will reach the ChromeClient or the BackingStore any more. Instead, invalidations will cause the root accelerated compositing layer to be repainted. Any BackingStore render calls while in this state are pointless, and can safely do an early return. Reviewed internally by Jakob Petsovits. 634740 1 144226 anilsson 2012-05-27 05:42:58 -0700 Created attachment 144226 Patch 634756 2 144226 webkit.review.bot 2012-05-27 07:41:57 -0700 Comment on attachment 144226 Patch Clearing flags on attachment: 144226 Committed r118626: <http://trac.webkit.org/changeset/118626> 634757 3 webkit.review.bot 2012-05-27 07:42:01 -0700 All reviewed patches have been landed. Closing bug. 144226 2012-05-27 05:42:58 -0700 2012-05-27 07:41:57 -0700 Patch bug-87563-20120527144256.patch text/plain 3058 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBkOTEzY2U0N2YxMjBjZTcyOWU4OTJlNDg2MmE2ODY0MTFhODVhZTE0Li4yMjJkMTJlMjE3 NWRkOGE2NDdjNGU0YTQyM2FlZGQ0YmRmZGU3NmQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSw0NCBAQAogMjAxMi0wNS0yNyAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CiAKKyAgICAgICAgMjAxMi0wNC0xOCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEJhY2tpbmdTdG9yZSBhY2Nlc3Nl cyB0aWxlcyBldmVuIHRob3VnaCBpdCdzIG5vdCBhY3RpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIG1hbnkgc2NlbmFyaW9zIHRoYXQg Y2FuIGNhbGwgcmVuZGVyIGFuZCBjYXVzZSB0aWxlIGFjY2VzcywKKyAgICAgICAgYW5kIHRoZXkg dXNlZCB0byBiZSByZXJvdXRlZCB0byB0aGUgZGlyZWN0IHJlbmRlcmluZyBjb2RlIHdoZW4gdGhl CisgICAgICAgIGJhY2tpbmcgc3RvcmUgd2FzIG5vdCBhY3RpdmUuIFRoaXMgd2FzIHRoYW5rcyB0 byBhbiBpbXBsaWNpdCBjaGVjayBmb3IKKyAgICAgICAgaXNBY3RpdmUoKSBieSB2aXJ0dWUgb2Yg Y2FsbGluZyBzaG91bGREaXJlY3RSZW5kZXJpbmdUb1dpbmRvdygpIGZyb20KKyAgICAgICAgcmVu ZGVyKCkuCisKKyAgICAgICAgSWYgd2UncmUgdXNpbmcgT3BlbkdMIGZvciBjb21wb3NpdGluZyB0 aGUgYmFja2luZyBzdG9yZSBjb250ZW50cworICAgICAgICBob3dldmVyLCBkaXJlY3QgcmVuZGVy aW5nIGlzIGFsd2F5cyBkaXNhYmxlZCBhbmQgd2UganVtcCByaWdodCBpbnRvIHRoZQorICAgICAg ICB0aWxlIGJhc2VkIHJlbmRlcmluZyBjb2RlLgorCisgICAgICAgIEZpeGVkIGJ5IGFkZGluZyBh biBleHBsaWNpdCBjaGVjayBmb3IgaXNBY3RpdmUoKSBpbiByZW5kZXIoKSwgbm93IHRoYXQKKyAg ICAgICAgdGhlIGltcGxpY2l0IGNoZWNrIGluIHNob3VsZERpcmVjdFJlbmRlcmluZ1RvV2luZG93 KCkgaXMgY29uZGl0aW9uYWwgb24KKyAgICAgICAgaGF2aW5nIHJhc3RlciB1c2FnZS4KKworICAg ICAgICBTaW5jZSBQUjEzNjM4MS9idWc4MzEzMSwgd2hlbiBPcGVuR0wgY29tcG9zaXRpbmcgaXMg dXNlZCwgYW5kIHRoZQorICAgICAgICBiYWNraW5nIHN0b3JlIGlzIG5vdCBhY3RpdmUsIGl0IGlz IG5vdCBpbiBjaGFyZ2Ugb2YgZHJhd2luZyB0aGUgcm9vdAorICAgICAgICBsYXllci4gSW5zdGVh ZCwgd2Ugc3dpdGNoIG9mZiB0aGUgcGFpbnRpbmdHb2VzVG9XaW5kb3cgZmxhZyBvbiB0aGUgcm9v dAorICAgICAgICBSZW5kZXJMYXllciBzbyBubyBpbnZhbGlkYXRlcyB3aWxsIHJlYWNoIHRoZSBD aHJvbWVDbGllbnQgb3IgdGhlCisgICAgICAgIEJhY2tpbmdTdG9yZSBhbnkgbW9yZS4gSW5zdGVh ZCwgaW52YWxpZGF0aW9ucyB3aWxsIGNhdXNlIHRoZSByb290CisgICAgICAgIGFjY2VsZXJhdGVk IGNvbXBvc2l0aW5nIGxheWVyIHRvIGJlIHJlcGFpbnRlZC4gQW55IEJhY2tpbmdTdG9yZSByZW5k ZXIKKyAgICAgICAgY2FsbHMgd2hpbGUgaW4gdGhpcyBzdGF0ZSBhcmUgcG9pbnRsZXNzLCBhbmQg Y2FuIHNhZmVseSBkbyBhbiBlYXJseQorICAgICAgICByZXR1cm4uCisKKyAgICAgICAgUmV2aWV3 ZWQgaW50ZXJuYWxseSBieSBKYWtvYiBQZXRzb3ZpdHMuCisKKyAgICAgICAgUFIgIzE1MDQwMwor CisgICAgICAgICogQXBpL0JhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OnJlbmRlcik6CisKKzIwMTItMDUtMjcgIEFydmlk IE5pbHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgorCiAgICAgICAgIDIwMTItMDQtMTIgIEFydmlk IE5pbHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBXZWIg cGFnZSBmYWlscyB0byByZW5kZXIgYWZ0ZXIgY2xpY2tpbmcgbGluayB3aXRoIHRhcmdldD1fYmxh bmsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3Jl LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRl eCAwOTJmZTRjNzgwOWQxZDgyNmE3MmI2ZDQ4NDYwZGViODM1NmUwYzkzLi45MjljZDk5MjE4ZDgy MjUxZDRjYTAxZjUwNGE4YzU4MzBhMzkyYjgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCkBAIC0xMDExLDYgKzEwMTEsMTIgQEAgYm9vbCBCYWNr aW5nU3RvcmVQcml2YXRlOjpyZW5kZXIoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIHJlY3QpCiAg ICAgaWYgKHNob3VsZERpcmVjdFJlbmRlcmluZ1RvV2luZG93KCkpCiAgICAgICAgIHJldHVybiBy ZW5kZXJEaXJlY3RUb1dpbmRvdyhyZWN0KTsKIAorICAgIC8vIElmIGRpcmVjdCByZW5kZXJpbmcg aXMgb2ZmLCBldmVuIHRob3VnaCB3ZSdyZSBub3QgYWN0aXZlLCBzb21lb25lIGVsc2UKKyAgICAv LyBoYXMgdG8gcmVuZGVyIHRoZSByb290IGxheWVyLiBUaGVyZSBhcmUgbm8gdGlsZXMgYXZhaWxh YmxlIGZvciB1cyB0bworICAgIC8vIGRyYXcgdG8uCisgICAgaWYgKCFpc0FjdGl2ZSgpKQorICAg ICAgICByZXR1cm4gZmFsc2U7CisKICAgICBUaWxlUmVjdExpc3QgdGlsZVJlY3RMaXN0ID0gbWFw RnJvbVRyYW5zZm9ybWVkQ29udGVudHNUb1RpbGVzKHJlY3QpOwogICAgIGlmICh0aWxlUmVjdExp c3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7Cg==