87549 2012-05-25 16:43:24 -0700 weakCompareAndSwap should work on Windows 2012-05-26 17:16:34 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned darin webkit.review.bot oldest_to_newest 634437 0 fpizlo 2012-05-25 16:43:24 -0700 By using the InterlockedCompareExchange function. 634440 1 144170 fpizlo 2012-05-25 16:45:02 -0700 Created attachment 144170 the patch 634444 2 144170 jberlin 2012-05-25 16:51:02 -0700 Comment on attachment 144170 the patch r=me (assuming this passes win EWS) 634447 3 fpizlo 2012-05-25 16:52:00 -0700 (In reply to comment #2) > (From update of attachment 144170 [details]) > r=me (assuming this passes win EWS) Thanks! Will await the greenness. 634453 4 144170 buildbot 2012-05-25 17:07:13 -0700 Comment on attachment 144170 the patch Attachment 144170 did not pass win-ews (win): Output: http://queues.webkit.org/results/12801605 634458 5 144174 fpizlo 2012-05-25 17:11:20 -0700 Created attachment 144174 attempt to actually make it build 634550 6 144174 webkit.review.bot 2012-05-25 20:09:52 -0700 Comment on attachment 144174 attempt to actually make it build Clearing flags on attachment: 144174 Committed r118603: <http://trac.webkit.org/changeset/118603> 634551 7 webkit.review.bot 2012-05-25 20:09:56 -0700 All reviewed patches have been landed. Closing bug. 634693 8 144170 darin 2012-05-26 17:16:17 -0700 Comment on attachment 144170 the patch Windows EWS says: 2>c:\cygwin\home\buildbot\WebKit\Source\WTF\wtf/Atomics.h(124) : error C2664: 'InterlockedCompareExchange' : cannot convert parameter 1 from 'volatile unsigned int *' to 'volatile LONG *' Thus, I suspect we have a need for some type casting. 634694 9 darin 2012-05-26 17:16:34 -0700 Oh, I see that was fixed before landing. 144170 2012-05-25 16:45:02 -0700 2012-05-26 17:16:17 -0700 the patch caswin_patch_1.diff text/plain 1736 fpizlo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMTg1ODYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTI1ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CisKKyAgICAgICAgd2Vha0NvbXBhcmVBbmRTd2FwIHNob3VsZCB3b3JrIG9u IFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg3NTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB3dGYvQXRvbWljcy5oOgorICAgICAgICAoV1RGKToKKyAgICAgICAgKFdURjo6d2Vha0NvbXBh cmVBbmRTd2FwKToKKwogMjAxMi0wNS0yNCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4u amVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBjdGlfdm1fdGhyb3cgZ2V0cyBraWNrZWQgb3V0 IGJ5IGdjYyA0LjYgLWZsdG8KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0F0b21pY3MuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgJKHJldmlzaW9uIDExODU4MykKKysrIFNv dXJjZS9XVEYvd3RmL0F0b21pY3MuaAkod29ya2luZyBjb3B5KQpAQCAtMTE4LDYgKzExOCwxNyBA QCBpbmxpbmUgaW50IGF0b21pY0RlY3JlbWVudChpbnQgdm9sYXRpbGUqCiAKICNlbmRpZgogCisj aWYgT1MoV0lORE9XUykKK2lubGluZSBib29sIHdlYWtDb21wYXJlQW5kU3dhcCh2b2xhdGlsZSB1 bnNpZ25lZCogbG9jYXRpb24sIHVuc2lnbmVkIGV4cGVjdGVkLCB1bnNpZ25lZCBuZXdWYWx1ZSkK K3sKKyAgICByZXR1cm4gSW50ZXJsb2NrZWRDb21wYXJlRXhjaGFuZ2UobG9jYXRpb24sIG5ld1Zh bHVlLCBleHBlY3RlZCkgPT0gZXhwZWN0ZWQ7Cit9CisKK2lubGluZSBib29sIHdlYWtDb21wYXJl QW5kU3dhcCh2b2lkKnZvbGF0aWxlKiBsb2NhdGlvbiwgdm9pZCogZXhwZWN0ZWQsIHZvaWQqIG5l d1ZhbHVlKQoreworICAgIHJldHVybiBJbnRlcmxvY2tlZENvbXBhcmVFeGNoYW5nZVBvaW50ZXIo bG9jYXRpb24sIG5ld1ZhbHVlLCBleHBlY3RlZCkgPT0gZXhwZWN0ZWQ7Cit9CisjZWxzZSAvLyBP UyhXSU5ET1dTKSAtLT4gbm90IHdpbmRvd3MKICNpZiBDT01QSUxFUihHQ0MpICYmICFDT01QSUxF UihDTEFORykgLy8gV29yayBhcm91bmQgYSBnY2MgYnVnIAogaW5saW5lIGJvb2wgd2Vha0NvbXBh cmVBbmRTd2FwKHZvbGF0aWxlIHVuc2lnbmVkKiBsb2NhdGlvbiwgdW5zaWduZWQgZXhwZWN0ZWQs IHVuc2lnbmVkIG5ld1ZhbHVlKSAKICNlbHNlCkBAIC0xODQsNiArMTk1LDcgQEAgaW5saW5lIGJv b2wgd2Vha0NvbXBhcmVBbmRTd2FwKHZvaWQqdm9sYQogICAgIHJldHVybiAwOwogI2VuZGlmIC8v IEVOQUJMRShDT01QQVJFX0FORF9TV0FQKQogfQorI2VuZGlmIC8vIE9TKFdJTkRPV1MpIChlbmQg b2Ygbm90LXdpbmRvd3MgZWxzZSBjYXNlKQogCiBpbmxpbmUgYm9vbCB3ZWFrQ29tcGFyZUFuZFN3 YXBVSW50UHRyKHZvbGF0aWxlIHVpbnRwdHJfdCogbG9jYXRpb24sIHVpbnRwdHJfdCBleHBlY3Rl ZCwgdWludHB0cl90IG5ld1ZhbHVlKQogewo= 144174 2012-05-25 17:11:20 -0700 2012-05-25 20:09:52 -0700 attempt to actually make it build caswin_patch_2.diff text/plain 1825 fpizlo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMTg1ODYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTI1ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CisKKyAgICAgICAgd2Vha0NvbXBhcmVBbmRTd2FwIHNob3VsZCB3b3JrIG9u IFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg3NTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmVzc2llIEJlcmxpbi4KKworICAgICAgICAq IHd0Zi9BdG9taWNzLmg6CisgICAgICAgIChXVEYpOgorICAgICAgICAoV1RGOjp3ZWFrQ29tcGFy ZUFuZFN3YXApOgorCiAyMDEyLTA1LTI0ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5q ZW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIGN0aV92bV90aHJvdyBnZXRzIGtpY2tlZCBvdXQg YnkgZ2NjIDQuNiAtZmx0bwpJbmRleDogU291cmNlL1dURi93dGYvQXRvbWljcy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F0b21pY3MuaAkocmV2aXNpb24gMTE4NTgzKQorKysgU291 cmNlL1dURi93dGYvQXRvbWljcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTgsNiArMTE4LDE3IEBA IGlubGluZSBpbnQgYXRvbWljRGVjcmVtZW50KGludCB2b2xhdGlsZSoKIAogI2VuZGlmCiAKKyNp ZiBPUyhXSU5ET1dTKQoraW5saW5lIGJvb2wgd2Vha0NvbXBhcmVBbmRTd2FwKHZvbGF0aWxlIHVu c2lnbmVkKiBsb2NhdGlvbiwgdW5zaWduZWQgZXhwZWN0ZWQsIHVuc2lnbmVkIG5ld1ZhbHVlKQor eworICAgIHJldHVybiBJbnRlcmxvY2tlZENvbXBhcmVFeGNoYW5nZShyZWludGVycHJldF9jYXN0 PExPTkcgdm9sYXRpbGUqPihsb2NhdGlvbiksIHN0YXRpY19jYXN0PExPTkc+KG5ld1ZhbHVlKSwg c3RhdGljX2Nhc3Q8TE9ORz4oZXhwZWN0ZWQpKSA9PSBzdGF0aWNfY2FzdDxMT05HPihleHBlY3Rl ZCk7Cit9CisKK2lubGluZSBib29sIHdlYWtDb21wYXJlQW5kU3dhcCh2b2lkKnZvbGF0aWxlKiBs b2NhdGlvbiwgdm9pZCogZXhwZWN0ZWQsIHZvaWQqIG5ld1ZhbHVlKQoreworICAgIHJldHVybiBJ bnRlcmxvY2tlZENvbXBhcmVFeGNoYW5nZVBvaW50ZXIobG9jYXRpb24sIG5ld1ZhbHVlLCBleHBl Y3RlZCkgPT0gZXhwZWN0ZWQ7Cit9CisjZWxzZSAvLyBPUyhXSU5ET1dTKSAtLT4gbm90IHdpbmRv d3MKICNpZiBDT01QSUxFUihHQ0MpICYmICFDT01QSUxFUihDTEFORykgLy8gV29yayBhcm91bmQg YSBnY2MgYnVnIAogaW5saW5lIGJvb2wgd2Vha0NvbXBhcmVBbmRTd2FwKHZvbGF0aWxlIHVuc2ln bmVkKiBsb2NhdGlvbiwgdW5zaWduZWQgZXhwZWN0ZWQsIHVuc2lnbmVkIG5ld1ZhbHVlKSAKICNl bHNlCkBAIC0xODQsNiArMTk1LDcgQEAgaW5saW5lIGJvb2wgd2Vha0NvbXBhcmVBbmRTd2FwKHZv aWQqdm9sYQogICAgIHJldHVybiAwOwogI2VuZGlmIC8vIEVOQUJMRShDT01QQVJFX0FORF9TV0FQ KQogfQorI2VuZGlmIC8vIE9TKFdJTkRPV1MpIChlbmQgb2YgdGhlIG5vdC13aW5kb3dzIGNhc2Up CiAKIGlubGluZSBib29sIHdlYWtDb21wYXJlQW5kU3dhcFVJbnRQdHIodm9sYXRpbGUgdWludHB0 cl90KiBsb2NhdGlvbiwgdWludHB0cl90IGV4cGVjdGVkLCB1aW50cHRyX3QgbmV3VmFsdWUpCiB7 Cg==