87545 2012-05-25 16:10:11 -0700 Support building the Android port of chromium with Ninja 2012-05-31 18:13:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 yfriedman yfriedman abarth thakis wangxianzhu webkit.review.bot oldest_to_newest 634403 0 yfriedman 2012-05-25 16:10:11 -0700 Support building the Android port of chromium with Ninja 634406 1 144165 yfriedman 2012-05-25 16:13:20 -0700 Created attachment 144165 Patch 634409 2 webkit.review.bot 2012-05-25 16:15:33 -0700 Attachment 144165 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/D..." exit_code: 1 Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 634412 3 abarth 2012-05-25 16:17:37 -0700 Looks like you've got some tabs in your ChangeLog. This looks plausible to me, but I don't actually know how this all works. Hopefully thakis can help. :) 634413 4 thakis 2012-05-25 16:19:15 -0700 LGTM. I'm not a fan of the ant_build_dir, but that's how android's doing it in chromium land too. 634416 5 144167 yfriedman 2012-05-25 16:23:55 -0700 Created attachment 144167 Patch 634417 6 yfriedman 2012-05-25 16:24:58 -0700 Fixed changelog. I'm gonna land the dependent change in chromium on Tuesday (don't want to hit the bit now) and then I guess wait for that to roll into webkit? 634436 7 abarth 2012-05-25 16:43:24 -0700 > Fixed changelog. I'm gonna land the dependent change in chromium on Tuesday (don't want to hit the bit now) and then I guess wait for that to roll into webkit? Once your change lands in Chromium, you just need to edit this revision number: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS#L35 We typically just bump the number in a separate commit as needed. It usually goes smoothly, but if you have and trouble, feel free to ping me and we'll figure it out. 638836 8 yfriedman 2012-05-31 17:30:03 -0700 While I was doing something else, looks like other folks already rolled DEPS past my revision. Seems like this is ready to go. 638838 9 yfriedman 2012-05-31 17:32:06 -0700 I'm not a committer, though. Adam can you put it in the CQ? 638867 10 144167 webkit.review.bot 2012-05-31 18:13:29 -0700 Comment on attachment 144167 Patch Clearing flags on attachment: 144167 Committed r119183: <http://trac.webkit.org/changeset/119183> 638868 11 webkit.review.bot 2012-05-31 18:13:33 -0700 All reviewed patches have been landed. Closing bug. 144165 2012-05-25 16:13:20 -0700 2012-05-25 16:23:51 -0700 Patch bug-87545-20120525161319.patch text/plain 2622 yfriedman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NTQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzFlYTJmNDI2OTlhMmZhNjE2YmJmYjhiOWVlZGFiMjc4 ODA1OTNhNS4uMDI1OGE3NjliNDFkNGNjNThkNjE3MzEwNzI1Yzc2ODlmYzZjNGI3NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA1LTI1ICBZYXJvbiBGcmllZG1hbiAgPHlmcmllZG1hbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgU3VwcG9ydCBidWlsZGluZyB0aGUgQW5kcm9pZCBwb3J0IG9mIGNocm9taXVt IHdpdGggTmluamEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg3NTQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwkJCQlF bnN1cmVzIHRoYXQgc2hhcmVkIGxpYnJhcmllcyBhcmUgbG9va2VkIHVwIGluIGEgZ2VuZXJhdG9y LWFnbm9zdGljCisJCQkJd2F5IGFuZCB0aGF0IG91dHB1dCBpcyBwbGFjZWQgaW4gdGhlIGNvcnJl Y3QgZGlyZWN0b3J5LgorCisJCQkJRGVwZW5kcyBvbiBodHRwOi8vY29kZXJldmlldy5jaHJvbWl1 bS5vcmcvMTAzODYxODgvCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJl ZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwOgorCiAyMDEyLTA1LTI1ICBKZXNzaWUgQmVybGluICA8 amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gZmFzdC9ldmVudHMva2V5ZG93bi1s ZWZ0cmlnaHQta2V5cy5odG1sIGZhaWxpbmcgc2luY2UgaW50cm9kdWN0aW9uIGluIHIxMTgwMDEK ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1w UmVuZGVyVHJlZS5neXAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAv RHVtcFJlbmRlclRyZWUuZ3lwCmluZGV4IDkyZTZiMTA0ZDg5MWM1MTA3ZjU0ZDgwYzdjMmMxZTA3 OTMzOTJhNzEuLmVkYWUzYWFlYjQ0NWU2NzUyMGM5NzFiYzFkZDI5NzVlMzlkMDIwNTQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVy VHJlZS5neXAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1 bXBSZW5kZXJUcmVlLmd5cApAQCAtNDE2LDcgKzQxNiw3IEBACiAgICAgICAgICAgICAgICAgICAg ICdhY3Rpb25fbmFtZSc6ICdnZW5lcmF0ZV9hbmRfYnVpbGQnLAogICAgICAgICAgICAgICAgICAg ICAnaW5wdXRzJzogWwogICAgICAgICAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rp cikvdGVzdGluZy9hbmRyb2lkL2dlbmVyYXRlX25hdGl2ZV90ZXN0LnB5JywKLSAgICAgICAgICAg ICAgICAgICAgICAgICc8KFBST0RVQ1RfRElSKS9saWIudGFyZ2V0L2xpYkR1bXBSZW5kZXJUcmVl LnNvJywKKyAgICAgICAgICAgICAgICAgICAgICAgICc8KFNIQVJFRF9MSUJfRElSKS88KFNIQVJF RF9MSUJfUFJFRklYKUR1bXBSZW5kZXJUcmVlPChTSEFSRURfTElCX1NVRkZJWCknLAogICAgICAg ICAgICAgICAgICAgICAgICAgIyBGSVhNRTogQnVpbGQgdGhlIGphciBmb3IgbmF0aXZlIHRlc3Rz IHdpdGggU0RLLgogICAgICAgICAgICAgICAgICAgICAgICAgIyBGb3Igbm93IHdlIGFyZSB1c2lu ZyBBbmRyb2lkLm1rIHRvIGJ1aWxkIHRoZSBhcGsuCiAgICAgICAgICAgICAgICAgICAgIF0sCkBA IC00MjYsMTQgKzQyNiwxNCBAQAogICAgICAgICAgICAgICAgICAgICAnYWN0aW9uJzogWwogICAg ICAgICAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGVzdGluZy9hbmRyb2lk L2dlbmVyYXRlX25hdGl2ZV90ZXN0LnB5JywKICAgICAgICAgICAgICAgICAgICAgICAgICctLW5h dGl2ZV9saWJyYXJ5JywKLSAgICAgICAgICAgICAgICAgICAgICAgICc8KFBST0RVQ1RfRElSKS9s aWIudGFyZ2V0L2xpYkR1bXBSZW5kZXJUcmVlLnNvJywKKyAgICAgICAgICAgICAgICAgICAgICAg ICc8KFNIQVJFRF9MSUJfRElSKS88KFNIQVJFRF9MSUJfUFJFRklYKUR1bXBSZW5kZXJUcmVlPChT SEFSRURfTElCX1NVRkZJWCknLAogICAgICAgICAgICAgICAgICAgICAgICAgIyBGSVhNRTogQnVp bGQgdGhlIGphciBmb3IgbmF0aXZlIHRlc3RzIHdpdGggU0RLLgogICAgICAgICAgICAgICAgICAg ICAgICAgIyAnLS1qYXInLAogICAgICAgICAgICAgICAgICAgICAgICAgIyAnZm9vL2Jhci5qYXIn LAogICAgICAgICAgICAgICAgICAgICAgICAgJy0tb3V0cHV0JywKICAgICAgICAgICAgICAgICAg ICAgICAgICc8KFBST0RVQ1RfRElSKS9EdW1wUmVuZGVyVHJlZV9hcGsnLAogICAgICAgICAgICAg ICAgICAgICAgICAgJy0tYW50LWFyZ3MnLAotICAgICAgICAgICAgICAgICAgICAgICAgJy1EUFJP RFVDVF9ESVI9PChQUk9EVUNUX0RJUiknLAorICAgICAgICAgICAgICAgICAgICAgICAgJy1EUFJP RFVDVF9ESVI9PChhbnRfYnVpbGRfb3V0KScsCiAgICAgICAgICAgICAgICAgICAgICAgICAnLS1h bnQtY29tcGlsZScKICAgICAgICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAgICAgICB9XSwK 144167 2012-05-25 16:23:55 -0700 2012-05-31 18:13:29 -0700 Patch bug-87545-20120525162354.patch text/plain 2634 yfriedman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NTQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzFlYTJmNDI2OTlhMmZhNjE2YmJmYjhiOWVlZGFiMjc4 ODA1OTNhNS4uNDAxYTI1YjhmN2NlZTljYjU1ZDhjMTc0YjY5ZGNlMmU2NzAyMjlmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA1LTI1ICBZYXJvbiBGcmllZG1hbiAgPHlmcmllZG1hbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgU3VwcG9ydCBidWlsZGluZyB0aGUgQW5kcm9pZCBwb3J0IG9mIGNocm9taXVt IHdpdGggTmluamEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg3NTQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRW5zdXJlcyB0aGF0IHNoYXJlZCBsaWJyYXJpZXMgYXJlIGxvb2tlZCB1cCBpbiBhIGdlbmVy YXRvci1hZ25vc3RpYworICAgICAgICB3YXkgYW5kIHRoYXQgb3V0cHV0IGlzIHBsYWNlZCBpbiB0 aGUgY29ycmVjdCBkaXJlY3RvcnkuCisKKyAgICAgICAgRGVwZW5kcyBvbiBodHRwOi8vY29kZXJl dmlldy5jaHJvbWl1bS5vcmcvMTAzODYxODgvCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9E dW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwOgorCiAyMDEyLTA1LTI1ICBKZXNz aWUgQmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gZmFzdC9ldmVu dHMva2V5ZG93bi1sZWZ0cmlnaHQta2V5cy5odG1sIGZhaWxpbmcgc2luY2UgaW50cm9kdWN0aW9u IGluIHIxMTgwMDEKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJU cmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVu ZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCmluZGV4IDkyZTZiMTA0ZDg5MWM1MTA3ZjU0 ZDgwYzdjMmMxZTA3OTMzOTJhNzEuLmVkYWUzYWFlYjQ0NWU2NzUyMGM5NzFiYzFkZDI5NzVlMzlk MDIwNTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5 cC9EdW1wUmVuZGVyVHJlZS5neXAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRl clRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cApAQCAtNDE2LDcgKzQxNiw3IEBACiAgICAgICAg ICAgICAgICAgICAgICdhY3Rpb25fbmFtZSc6ICdnZW5lcmF0ZV9hbmRfYnVpbGQnLAogICAgICAg ICAgICAgICAgICAgICAnaW5wdXRzJzogWwogICAgICAgICAgICAgICAgICAgICAgICAgJzwoY2hy b21pdW1fc3JjX2RpcikvdGVzdGluZy9hbmRyb2lkL2dlbmVyYXRlX25hdGl2ZV90ZXN0LnB5JywK LSAgICAgICAgICAgICAgICAgICAgICAgICc8KFBST0RVQ1RfRElSKS9saWIudGFyZ2V0L2xpYkR1 bXBSZW5kZXJUcmVlLnNvJywKKyAgICAgICAgICAgICAgICAgICAgICAgICc8KFNIQVJFRF9MSUJf RElSKS88KFNIQVJFRF9MSUJfUFJFRklYKUR1bXBSZW5kZXJUcmVlPChTSEFSRURfTElCX1NVRkZJ WCknLAogICAgICAgICAgICAgICAgICAgICAgICAgIyBGSVhNRTogQnVpbGQgdGhlIGphciBmb3Ig bmF0aXZlIHRlc3RzIHdpdGggU0RLLgogICAgICAgICAgICAgICAgICAgICAgICAgIyBGb3Igbm93 IHdlIGFyZSB1c2luZyBBbmRyb2lkLm1rIHRvIGJ1aWxkIHRoZSBhcGsuCiAgICAgICAgICAgICAg ICAgICAgIF0sCkBAIC00MjYsMTQgKzQyNiwxNCBAQAogICAgICAgICAgICAgICAgICAgICAnYWN0 aW9uJzogWwogICAgICAgICAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGVz dGluZy9hbmRyb2lkL2dlbmVyYXRlX25hdGl2ZV90ZXN0LnB5JywKICAgICAgICAgICAgICAgICAg ICAgICAgICctLW5hdGl2ZV9saWJyYXJ5JywKLSAgICAgICAgICAgICAgICAgICAgICAgICc8KFBS T0RVQ1RfRElSKS9saWIudGFyZ2V0L2xpYkR1bXBSZW5kZXJUcmVlLnNvJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICc8KFNIQVJFRF9MSUJfRElSKS88KFNIQVJFRF9MSUJfUFJFRklYKUR1bXBS ZW5kZXJUcmVlPChTSEFSRURfTElCX1NVRkZJWCknLAogICAgICAgICAgICAgICAgICAgICAgICAg IyBGSVhNRTogQnVpbGQgdGhlIGphciBmb3IgbmF0aXZlIHRlc3RzIHdpdGggU0RLLgogICAgICAg ICAgICAgICAgICAgICAgICAgIyAnLS1qYXInLAogICAgICAgICAgICAgICAgICAgICAgICAgIyAn Zm9vL2Jhci5qYXInLAogICAgICAgICAgICAgICAgICAgICAgICAgJy0tb3V0cHV0JywKICAgICAg ICAgICAgICAgICAgICAgICAgICc8KFBST0RVQ1RfRElSKS9EdW1wUmVuZGVyVHJlZV9hcGsnLAog ICAgICAgICAgICAgICAgICAgICAgICAgJy0tYW50LWFyZ3MnLAotICAgICAgICAgICAgICAgICAg ICAgICAgJy1EUFJPRFVDVF9ESVI9PChQUk9EVUNUX0RJUiknLAorICAgICAgICAgICAgICAgICAg ICAgICAgJy1EUFJPRFVDVF9ESVI9PChhbnRfYnVpbGRfb3V0KScsCiAgICAgICAgICAgICAgICAg ICAgICAgICAnLS1hbnQtY29tcGlsZScKICAgICAgICAgICAgICAgICAgICAgXSwKICAgICAgICAg ICAgICAgICB9XSwK