87534 2012-05-25 14:17:33 -0700 [EFL] [DRT] Reset CacheModel before running each test 2012-06-11 13:16:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cdumez gustavo gyuyoung.kim lucas.de.marchi mikhail.pozdnyakov rakuco tonikitoo webkit.review.bot oldest_to_newest 634282 0 naginenis 2012-05-25 14:17:33 -0700 Reset CacheModel before running each test to fix some flakiness on EFL build bots. fast/dom/StyleSheet/detached-style-2.html fast/dom/StyleSheet/detached-style-pi-2.xhtml fast/dom/StyleSheet/detached-style-pi.xhtml fast/dom/StyleSheet/detached-style.html 634344 1 144157 naginenis 2012-05-25 15:28:58 -0700 Created attachment 144157 patch Reset cache model before running each test to fix some flaky tests. 634388 2 rakuco 2012-05-25 15:59:15 -0700 Nice that Mikhail is already CC'ed; https://bugs.webkit.org/show_bug.cgi?id=86840#c4 says these settings should be already being reset. Isn't that the case? 634613 3 naginenis 2012-05-26 01:05:19 -0700 They are not reset to default on the test startup. memory_cache_clear() clears the page cache and reset to the previous value. So, we need to reset the values to default to avoid any flakiness. 634640 4 mikhail.pozdnyakov 2012-05-26 03:35:35 -0700 (In reply to comment #2) > Nice that Mikhail is already CC'ed; https://bugs.webkit.org/show_bug.cgi?id=86840#c4 says these settings should be already being reset. Isn't that the case? My bad :( we've discussed it with Babu memory_cache_clear() is not enough actually. 634955 5 144157 cdumez 2012-05-28 00:28:05 -0700 Comment on attachment 144157 patch View in context: https://bugs.webkit.org/attachment.cgi?id=144157&action=review > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:273 > + unsigned cacheTotalCapacity = 8192 * 1024; Small nit: We could mark this variable as const. 634960 6 mikhail.pozdnyakov 2012-05-28 00:36:36 -0700 (In reply to comment #5) > (From update of attachment 144157 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144157&action=review > > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:273 > > + unsigned cacheTotalCapacity = 8192 * 1024; > Small nit: We could mark this variable as const. And static.. 635660 7 144157 cmarcelo 2012-05-29 00:11:12 -0700 Comment on attachment 144157 patch View in context: https://bugs.webkit.org/attachment.cgi?id=144157&action=review > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:550 > - case 3: // WebCacheModelPrimaryWebBrowser > + case 2: // WebCacheModelPrimaryWebBrowser Nit pick: the fact that each number have a comment with a name suggests that we could have an enum, even if it needs to be synchronized. It would also have avoided the typo you're fixing now. 636066 8 144568 naginenis 2012-05-29 08:40:44 -0700 Created attachment 144568 Patch fixed review comments. 646200 9 144568 webkit.review.bot 2012-06-11 13:16:47 -0700 Comment on attachment 144568 Patch Clearing flags on attachment: 144568 Committed r120001: <http://trac.webkit.org/changeset/120001> 646201 10 webkit.review.bot 2012-06-11 13:16:52 -0700 All reviewed patches have been landed. Closing bug. 144157 2012-05-25 15:28:58 -0700 2012-05-29 08:40:44 -0700 patch 87534.patch text/plain 2531 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhY2Fk ZDk3Li41ZTkzZjg5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMjUgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW0RS VF0gUmVzZXQgQ2FjaGVNb2RlbCBiZWZvcmUgcnVubmluZyBlYWNoIHRlc3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NTM0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzZXQgY2FjaGUgbW9kZWwgdG8g ZGVmYXVsdCBiZWZvcmUgcnVubmluZyBlYWNoIHRlc3QgdG8gZml4IHNvbWUKKyAgICAgICAgZmxh a3kgdGVzdHMgb24gRUZMIGJ1aWxkIGJvdHMuIEFsc28gZml4IGNhc2UgdmFsdWUgaW4gc2V0Q2Fj aGVNb2RlbC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNo cm9tZS5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6cmVzZXREZWZhdWx0c1Rv Q29uc2lzdGVudFZhbHVlcyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRl c3RDb250cm9sbGVyRWZsLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRD YWNoZU1vZGVsKToKKwogMjAxMi0wNS0yNSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFtRdF0gQnVpbGRmaXggZm9yIG5ld2VyIFF0NQpkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcCBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKaW5kZXggMmEz OWE2OS4uMzUwYTEzMCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBS ZW5kZXJUcmVlQ2hyb21lLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJl bmRlclRyZWVDaHJvbWUuY3BwCkBAIC0yNjgsNyArMjY4LDEyIEBAIHZvaWQgRHVtcFJlbmRlclRy ZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgIER1bXBSZW5k ZXJUcmVlU3VwcG9ydEVmbDo6c2V0SmF2YVNjcmlwdFByb2ZpbGluZ0VuYWJsZWQobWFpblZpZXco KSwgZmFsc2UpOwogICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2V0TG9hZHNTaXRlSWNv bnNJZ25vcmluZ0ltYWdlTG9hZGluZ1NldHRpbmcobWFpblZpZXcoKSwgZmFsc2UpOwogICAgIER1 bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2V0U2VyaWFsaXplSFRUUExvYWRzKGZhbHNlKTsKKwor ICAgIC8vIFJlc2V0IGNhcGFjaXRpZXMgZm9yIHRoZSBtZW1vcnkgY2FjaGUgZm9yIGRlYWQgb2Jq ZWN0cy4KKyAgICB1bnNpZ25lZCBjYWNoZVRvdGFsQ2FwYWNpdHkgPSAgODE5MiAqIDEwMjQ7Cisg ICAgZXdrX3NldHRpbmdzX29iamVjdF9jYWNoZV9jYXBhY2l0eV9zZXQoMCwgY2FjaGVUb3RhbENh cGFjaXR5LCBjYWNoZVRvdGFsQ2FwYWNpdHkpOwogICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVm bDo6c2V0RGVhZERlY29kZWREYXRhRGVsZXRpb25JbnRlcnZhbCgwKTsKKyAgICBld2tfc2V0dGlu Z3NfcGFnZV9jYWNoZV9jYXBhY2l0eV9zZXQoMyk7CiAKICAgICBpZiAobV9jdXJyZW50SW50ZW50 UmVxdWVzdCkgewogICAgICAgICBld2tfaW50ZW50X3JlcXVlc3RfdW5yZWYobV9jdXJyZW50SW50 ZW50UmVxdWVzdCk7CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0 VGVzdENvbnRyb2xsZXJFZmwuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRl c3RDb250cm9sbGVyRWZsLmNwcAppbmRleCA5MjEyM2U4Li5jNzRhMzM3IDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwCisrKyBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHAKQEAg LTU0Nyw3ICs1NDcsNyBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRDYWNoZU1vZGVs KGludCBjYWNoZU1vZGVsKQogICAgICAgICBjYWNoZU1heERlYWRDYXBhY2l0eSA9IGNhY2hlVG90 YWxDYXBhY2l0eSAvIDQ7CiAgICAgICAgIGRlYWREZWNvZGVkRGF0YURlbGV0aW9uSW50ZXJ2YWwg PSAwOwogICAgICAgICBicmVhazsKLSAgICBjYXNlIDM6IC8vIFdlYkNhY2hlTW9kZWxQcmltYXJ5 V2ViQnJvd3NlcgorICAgIGNhc2UgMjogLy8gV2ViQ2FjaGVNb2RlbFByaW1hcnlXZWJCcm93c2Vy CiAgICAgICAgIHBhZ2VDYWNoZUNhcGFjaXR5ID0gMzsKICAgICAgICAgY2FjaGVUb3RhbENhcGFj aXR5ID0gMzIgKiAxMDI0ICogMTAyNDsKICAgICAgICAgY2FjaGVNaW5EZWFkQ2FwYWNpdHkgPSBj YWNoZVRvdGFsQ2FwYWNpdHkgLyA0Owo= 144568 2012-05-29 08:40:44 -0700 2012-06-11 13:16:47 -0700 Patch 87534.patch text/plain 3530 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxMDUw OGE1Li5iNzllNzI4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMjkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW0RS VF0gUmVzZXQgQ2FjaGVNb2RlbCBiZWZvcmUgcnVubmluZyBlYWNoIHRlc3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NTM0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzZXQgY2FjaGUgbW9kZWwgdG8g ZGVmYXVsdCBiZWZvcmUgcnVubmluZyBlYWNoIHRlc3QgdG8gZml4IHNvbWUKKyAgICAgICAgZmxh a3kgdGVzdHMgb24gRUZMIGJ1aWxkIGJvdHMuIEFsc28gZml4IGNhc2UgdmFsdWUgaW4gc2V0Q2Fj aGVNb2RlbC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNo cm9tZS5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6cmVzZXREZWZhdWx0c1Rv Q29uc2lzdGVudFZhbHVlcyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRl c3RDb250cm9sbGVyRWZsLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRD YWNoZU1vZGVsKToKKwogMjAxMi0wNS0yOSAgVG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5lLnZl c3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBEb24ndCBhZGQgY3h4LWZsYWdzIHRvIFFN QUtFX0NGTEFHUwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5k ZXJUcmVlQ2hyb21lLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJl ZUNocm9tZS5jcHAKaW5kZXggN2FjMmVjZS4uYmRlYjJlYiAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCkBAIC0yNjcsNyArMjY3LDEy IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRW YWx1ZXMoKQogICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2V0RGVmZXJzTG9hZGluZyht YWluVmlldygpLCBmYWxzZSk7CiAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpzZXRMb2Fk c1NpdGVJY29uc0lnbm9yaW5nSW1hZ2VMb2FkaW5nU2V0dGluZyhtYWluVmlldygpLCBmYWxzZSk7 CiAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpzZXRTZXJpYWxpemVIVFRQTG9hZHMoZmFs c2UpOworCisgICAgLy8gUmVzZXQgY2FwYWNpdGllcyBmb3IgdGhlIG1lbW9yeSBjYWNoZSBmb3Ig ZGVhZCBvYmplY3RzLgorICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBjYWNoZVRvdGFsQ2FwYWNp dHkgPSAgODE5MiAqIDEwMjQ7CisgICAgZXdrX3NldHRpbmdzX29iamVjdF9jYWNoZV9jYXBhY2l0 eV9zZXQoMCwgY2FjaGVUb3RhbENhcGFjaXR5LCBjYWNoZVRvdGFsQ2FwYWNpdHkpOwogICAgIER1 bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2V0RGVhZERlY29kZWREYXRhRGVsZXRpb25JbnRlcnZh bCgwKTsKKyAgICBld2tfc2V0dGluZ3NfcGFnZV9jYWNoZV9jYXBhY2l0eV9zZXQoMyk7CiAKICAg ICBpZiAobV9jdXJyZW50SW50ZW50UmVxdWVzdCkgewogICAgICAgICBld2tfaW50ZW50X3JlcXVl c3RfdW5yZWYobV9jdXJyZW50SW50ZW50UmVxdWVzdCk7CmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcAppbmRleCBmODVhZDRmLi45 NmJkOTY0IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENv bnRyb2xsZXJFZmwuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0 Q29udHJvbGxlckVmbC5jcHAKQEAgLTU0LDYgKzU0LDEzIEBACiAjaW5jbHVkZSA8c3RkaW8uaD4K ICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAorLy8gU2FtZSBhcyBNYWMgY2FjaGUg bW9kZWwgZW51bSBpbiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLmgu CitlbnVtIHsKKyAgICBXZWJDYWNoZU1vZGVsRG9jdW1lbnRWaWV3ZXIgPSAwLAorICAgIFdlYkNh Y2hlTW9kZWxEb2N1bWVudEJyb3dzZXIgPSAxLAorICAgIFdlYkNhY2hlTW9kZWxQcmltYXJ5V2Vi QnJvd3NlciA9IDIKK307CisKIExheW91dFRlc3RDb250cm9sbGVyOjp+TGF5b3V0VGVzdENvbnRy b2xsZXIoKQogewogfQpAQCAtNTI1LDIxICs1MzIsMjEgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJv bGxlcjo6c2V0Q2FjaGVNb2RlbChpbnQgY2FjaGVNb2RlbCkKIAogICAgIC8vIFRoZXNlIGNvbnN0 YW50cyBhcmUgZGVyaXZlZCBmcm9tIHRoZSBNYWMgY2FjaGUgbW9kZWwgZW51bSBpbiBTb3VyY2Uv V2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLmguCiAgICAgc3dpdGNoIChjYWNoZU1v ZGVsKSB7Ci0gICAgY2FzZSAwOiAvLyBXZWJDYWNoZU1vZGVsRG9jdW1lbnRWaWV3ZXIKKyAgICBj YXNlIFdlYkNhY2hlTW9kZWxEb2N1bWVudFZpZXdlcjoKICAgICAgICAgcGFnZUNhY2hlQ2FwYWNp dHkgPSAwOwogICAgICAgICBjYWNoZVRvdGFsQ2FwYWNpdHkgPSAwOwogICAgICAgICBjYWNoZU1p bkRlYWRDYXBhY2l0eSA9IDA7CiAgICAgICAgIGNhY2hlTWF4RGVhZENhcGFjaXR5ID0gMDsKICAg ICAgICAgZGVhZERlY29kZWREYXRhRGVsZXRpb25JbnRlcnZhbCA9IDA7CiAgICAgICAgIGJyZWFr OwotICAgIGNhc2UgMTogLy8gV2ViQ2FjaGVNb2RlbERvY3VtZW50QnJvd3NlcgorICAgIGNhc2Ug V2ViQ2FjaGVNb2RlbERvY3VtZW50QnJvd3NlcjoKICAgICAgICAgcGFnZUNhY2hlQ2FwYWNpdHkg PSAyOwogICAgICAgICBjYWNoZVRvdGFsQ2FwYWNpdHkgPSAxNiAqIDEwMjQgKiAxMDI0OwogICAg ICAgICBjYWNoZU1pbkRlYWRDYXBhY2l0eSA9IGNhY2hlVG90YWxDYXBhY2l0eSAvIDg7CiAgICAg ICAgIGNhY2hlTWF4RGVhZENhcGFjaXR5ID0gY2FjaGVUb3RhbENhcGFjaXR5IC8gNDsKICAgICAg ICAgZGVhZERlY29kZWREYXRhRGVsZXRpb25JbnRlcnZhbCA9IDA7CiAgICAgICAgIGJyZWFrOwot ICAgIGNhc2UgMzogLy8gV2ViQ2FjaGVNb2RlbFByaW1hcnlXZWJCcm93c2VyCisgICAgY2FzZSBX ZWJDYWNoZU1vZGVsUHJpbWFyeVdlYkJyb3dzZXI6CiAgICAgICAgIHBhZ2VDYWNoZUNhcGFjaXR5 ID0gMzsKICAgICAgICAgY2FjaGVUb3RhbENhcGFjaXR5ID0gMzIgKiAxMDI0ICogMTAyNDsKICAg ICAgICAgY2FjaGVNaW5EZWFkQ2FwYWNpdHkgPSBjYWNoZVRvdGFsQ2FwYWNpdHkgLyA0Owo=