87530 2012-05-25 13:13:57 -0700 [chromium] Instrument V8 GC with TraceEvent 2012-05-25 23:39:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca nduca abarth haraken japhet webkit.review.bot oldest_to_newest 634227 0 nduca 2012-05-25 13:13:57 -0700 [chromium] Instrument V8 GC with TraceEvent 634232 1 144136 nduca 2012-05-25 13:15:57 -0700 Created attachment 144136 Patch 634237 2 nduca 2012-05-25 13:18:30 -0700 @haraken, I'd like to add tracing for GC so we an tell from about:tracing results when there are GC stalls. We often get bug reports with traces where we see long message loop pauses that are ultimately the result of GC. Does this seem okay? 634354 3 144136 haraken 2012-05-25 15:35:47 -0700 Comment on attachment 144136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144136&action=review > Source/WebCore/ChangeLog:7 > + Let's describe "I'd like to add tracing for GC so we can tell from about:tracing results when there are GC stalls. We often get bug reports with traces where we see long message loop pauses that are ultimately the result of GC." here. 634570 4 144190 nduca 2012-05-25 21:20:17 -0700 Created attachment 144190 Patch for landing 634601 5 144190 webkit.review.bot 2012-05-25 23:39:46 -0700 Comment on attachment 144190 Patch for landing Clearing flags on attachment: 144190 Committed r118606: <http://trac.webkit.org/changeset/118606> 634602 6 webkit.review.bot 2012-05-25 23:39:50 -0700 All reviewed patches have been landed. Closing bug. 144136 2012-05-25 13:15:57 -0700 2012-05-25 21:20:14 -0700 Patch bug-87530-20120525131556.patch text/plain 1673 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhkYjkxNDBiNzMyOGZh N2I0MGY5MTlkZGY0N2FkOWIxMjIzNzdhYy4uOTI5NjQ1ZDk0ODBiMTY0NjFjZDkxMWZhOGVkNDNl OGMxNTNlMTk3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTI1ICBOYXQg RHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEluc3RydW1l bnQgVjggR0Mgd2l0aCBUcmFjZUV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NzUzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUpOgorICAgICAgICAoV2ViQ29y ZTo6VjhHQ0NvbnRyb2xsZXI6OmdjRXBpbG9ndWUpOgorCiAyMDEyLTA1LTI0ICBNT1JJVEEgSGFq aW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFNjb3BlZCBzdHlsZXNoZWV0IHNo b3VsZCBiZSBwZXItZG9jdW1lbnQtY29uZmlndXJhYmxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCmluZGV4IGQ4OGE1M2MyZjAzNGJjOTg5YzQ5NWQ1 NTY3NDViNjI2OTVmMmRmNGYuLjE4ZmVjYzI2MWFhMDc1Mzk3NjIxOTIxZTI2YTkzNTA2ZTliMDYw MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAK QEAgLTU5LDYgKzU5LDEwIEBACiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgogI2luY2x1 ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisjaW5jbHVk ZSAiVHJhY2VFdmVudC5oIgorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogI2lmbmRl ZiBOREVCVUcKQEAgLTM4OSw2ICszOTMsMTAgQEAgdm9pZCBWOEdDQ29udHJvbGxlcjo6Z2NQcm9s b2d1ZSgpCiB7CiAgICAgdjg6OkhhbmRsZVNjb3BlIHNjb3BlOwogCisjaWYgUExBVEZPUk0oQ0hS T01JVU0pCisgICAgVFJBQ0VfRVZFTlRfQkVHSU4wKCJ2OCIsICJHQyIpOworI2VuZGlmCisKICNp Zm5kZWYgTkRFQlVHCiAgICAgRE9NT2JqZWN0VmlzaXRvciBkb21PYmplY3RWaXNpdG9yOwogICAg IHZpc2l0RE9NT2JqZWN0cygmZG9tT2JqZWN0VmlzaXRvcik7CkBAIC01MDksNiArNTE3LDEwIEBA IHZvaWQgVjhHQ0NvbnRyb2xsZXI6OmdjRXBpbG9ndWUoKQogCiAgICAgZW51bWVyYXRlR2xvYmFs SGFuZGxlcygpOwogI2VuZGlmCisKKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyAgICBUUkFDRV9F VkVOVF9FTkQwKCJ2OCIsICJHQyIpOworI2VuZGlmCiB9CiAKIHZvaWQgVjhHQ0NvbnRyb2xsZXI6 OmNoZWNrTWVtb3J5VXNhZ2UoKQo= 144190 2012-05-25 21:20:17 -0700 2012-05-25 23:39:46 -0700 Patch for landing bug-87530-20120525212016.patch text/plain 1964 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhkYjkxNDBiNzMyOGZh N2I0MGY5MTlkZGY0N2FkOWIxMjIzNzdhYy4uYWE1ZmU3YmQ5OWJkYTgyYTJkZDUzOTk4MWQ3OTcz OWY4NjRjMzQzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTI1ICBOYXQg RHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEluc3RydW1l bnQgVjggR0Mgd2l0aCBUcmFjZUV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NzUzMAorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbnRhcm8gSGFy YS4KKworICAgICAgICBXZSBzb21ldGltZXMgZ2V0IHBlcmZvcm1hbmNlIGlzc3VlcyB3aGVyZSBw ZXJmb3JtYW5jZSBzdGFsbHMgY2FuCisgICAgICAgIGJlIGF0dHJpYnV0ZWQgdG8gYmFkbHkgdGlt ZWQgR0Mgb3BlcmF0aW9ucywgZXNwZWNpYWxseSBvbmVzIHRoYXQKKyAgICAgICAgaGFwcGVuIGp1 c3QgYmVmb3JlIGEgZnJhbWUgcnVubmluZy4gVGhpcyBhZGRzIHRyYWNpbmcgY2FsbHMgYXJvdW5k CisgICAgICAgIEdDIHNvIHRoYXQgd2UgY2FuIGJldHRlciB1bmRlcnN0YW5kIHRoZXNlIGtpbmRz IG9mIGhhbmdzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUpOgorICAgICAgICAo V2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6OmdjRXBpbG9ndWUpOgorCiAyMDEyLTA1LTI0ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFNjb3BlZCBzdHlsZXNo ZWV0IHNob3VsZCBiZSBwZXItZG9jdW1lbnQtY29uZmlndXJhYmxlLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCmluZGV4IGQ4OGE1M2MyZjAzNGJjOTg5 YzQ5NWQ1NTY3NDViNjI2OTVmMmRmNGYuLjE4ZmVjYzI2MWFhMDc1Mzk3NjIxOTIxZTI2YTkzNTA2 ZTliMDYwMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250 cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxl ci5jcHAKQEAgLTU5LDYgKzU5LDEwIEBACiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgog I2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisj aW5jbHVkZSAiVHJhY2VFdmVudC5oIgorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog I2lmbmRlZiBOREVCVUcKQEAgLTM4OSw2ICszOTMsMTAgQEAgdm9pZCBWOEdDQ29udHJvbGxlcjo6 Z2NQcm9sb2d1ZSgpCiB7CiAgICAgdjg6OkhhbmRsZVNjb3BlIHNjb3BlOwogCisjaWYgUExBVEZP Uk0oQ0hST01JVU0pCisgICAgVFJBQ0VfRVZFTlRfQkVHSU4wKCJ2OCIsICJHQyIpOworI2VuZGlm CisKICNpZm5kZWYgTkRFQlVHCiAgICAgRE9NT2JqZWN0VmlzaXRvciBkb21PYmplY3RWaXNpdG9y OwogICAgIHZpc2l0RE9NT2JqZWN0cygmZG9tT2JqZWN0VmlzaXRvcik7CkBAIC01MDksNiArNTE3 LDEwIEBAIHZvaWQgVjhHQ0NvbnRyb2xsZXI6OmdjRXBpbG9ndWUoKQogCiAgICAgZW51bWVyYXRl R2xvYmFsSGFuZGxlcygpOwogI2VuZGlmCisKKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyAgICBU UkFDRV9FVkVOVF9FTkQwKCJ2OCIsICJHQyIpOworI2VuZGlmCiB9CiAKIHZvaWQgVjhHQ0NvbnRy b2xsZXI6OmNoZWNrTWVtb3J5VXNhZ2UoKQo=