87525 2012-05-25 11:52:54 -0700 [New MultiColumn] Create the flow thread and make sure children get placed inside it. 2012-05-25 13:36:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt eric webkit.review.bot oldest_to_newest 634136 0 hyatt 2012-05-25 11:52:54 -0700 Create the flow thread and make sure children get placed inside it. 634147 1 144119 hyatt 2012-05-25 11:57:43 -0700 Created attachment 144119 Patch 634153 2 144119 eric 2012-05-25 12:08:59 -0700 Comment on attachment 144119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144119&action=review LGTM, other than the comments being a bit odd. Won't this break the multi-column painting? (since presumably the children used to be direct decendents of MultiColumBlock?) Or does it happen to work since the flowThread is just a block and so it just seems to have an anonymous block inside it, but otherwise works? > Source/WebCore/rendering/RenderMultiColumnBlock.cpp:83 > + RenderBlock::addChild(m_flowThread); // Always put the flow thread at the end. Interesting. I thought regions made all their flow threads direct children of the body element. I guess in that case, they can flow into any element, where here you're contained within the block marked for multicolumn? > Source/WebCore/rendering/RenderMultiColumnBlock.cpp:87 > + // of the flow thread itself. It would be nice if the thread could be a non-displayed child of some form. Since with the exception of render region, we don't generally have children which are not displayed. > Source/WebCore/rendering/RenderMultiColumnBlock.cpp:89 > + RenderBlock::addChild(newChild, beforeChild); I'm confused why the comment above says to always put the flow-thread at the end, when this code won't keep it at the end. It seems the flow ends up always being the first child. 634176 3 hyatt 2012-05-25 12:28:34 -0700 (In reply to comment #2) > (From update of attachment 144119 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144119&action=review > > LGTM, other than the comments being a bit odd. Won't this break the multi-column painting? (since presumably the children used to be direct decendents of MultiColumBlock?) Or does it happen to work since the flowThread is just a block and so it just seems to have an anonymous block inside it, but otherwise works? This is a brand new implementation. It's not building on previous code. Nothing can "break" since nobody is using this code. It's all turned off in ToT. Painting is not implemented yet. > > > Source/WebCore/rendering/RenderMultiColumnBlock.cpp:83 > > + RenderBlock::addChild(m_flowThread); // Always put the flow thread at the end. > > Interesting. I thought regions made all their flow threads direct children of the body element. I guess in that case, they can flow into any element, where here you're contained within the block marked for multicolumn? Yes, this is a difference (and the reason for the conceptual split between RenderNamedFlowThread and RenderFlowThread). Named flow threads are document-level. Multi-column (and eventually paged) flow threads are children of the block that spawned them. > > > Source/WebCore/rendering/RenderMultiColumnBlock.cpp:87 > > + // of the flow thread itself. > > It would be nice if the thread could be a non-displayed child of some form. Since with the exception of render region, we don't generally have children which are not displayed. The flow thread does get displayed. It just does so through the regions. It's not undisplayed though. > > > Source/WebCore/rendering/RenderMultiColumnBlock.cpp:89 > > + RenderBlock::addChild(newChild, beforeChild); > > I'm confused why the comment above says to always put the flow-thread at the end, when this code won't keep it at the end. It seems the flow ends up always being the first child. You're looking at the column set case not the flow thread case. The comment was on this line: RenderBlock::addChild(m_flowThread); // Always put the flow thread at the end. Which does put the flow thread at the end. When I do get around to adding column sets (not yet implemented), they'll always be inserted before the flow thread, so this function doesn't have to special case that at all. 634180 4 144119 buildbot 2012-05-25 12:31:44 -0700 Comment on attachment 144119 Patch Attachment 144119 did not pass win-ews (win): Output: http://queues.webkit.org/results/12791608 634189 5 144119 eric 2012-05-25 12:36:10 -0700 Comment on attachment 144119 Patch OK. thanks. You may need to fix Win. 634192 6 hyatt 2012-05-25 12:38:23 -0700 (In reply to comment #5) > (From update of attachment 144119 [details]) > OK. thanks. You may need to fix Win. Yup, will do. Just need to add the multi-column files to RenderingAllInOne.cpp. 634201 7 hyatt 2012-05-25 12:50:26 -0700 Fixed in r118552. 634251 8 144119 darin 2012-05-25 13:36:42 -0700 Comment on attachment 144119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144119&action=review > Source/WebCore/rendering/RenderMultiColumnBlock.h:51 > + > private: > + RenderMultiColumnFlowThread* m_flowThread; An extra private here we could delete. > Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:38 > +RenderMultiColumnFlowThread::~RenderMultiColumnFlowThread() > +{ > +} Why was this added? > Source/WebCore/rendering/RenderMultiColumnFlowThread.h:37 > + ~RenderMultiColumnFlowThread(); Normally we explicitly make it virtual. > Source/WebCore/rendering/RenderMultiColumnSet.h:48 > + virtual bool isRenderMultiColumnSet() const OVERRIDE { return true; } Should be private, not public. > Source/WebCore/rendering/RenderObject.h:366 > virtual bool isRenderNamedFlowThread() const { return false; } > + > + virtual bool isRenderMultiColumnSet() const { return false; } > + > virtual bool isRenderScrollbarPart() const { return false; } Why add these blank lines? 144119 2012-05-25 11:57:43 -0700 2012-05-25 13:36:42 -0700 Patch patch.txt text/plain 6341 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODU0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEyLTA1LTI1ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODc1MjUKKyAgICAgICAgCisgICAgICAgIEZvciB0aGUgbmV3IG11 bHRpLWNvbHVtbiBsYXlvdXQsIGNyZWF0ZSBhIGZsb3cgdGhyZWFkIGFuZCBtYWtlIHN1cmUgdGhl IGNoaWxkcmVuIGdldCBwdXQgaW5zaWRlIGl0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uQmxvY2su Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTXVsdGlDb2x1bW5CbG9jazo6UmVuZGVyTXVs dGlDb2x1bW5CbG9jayk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJNdWx0aUNvbHVtbkJsb2Nr OjphZGRDaGlsZCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTXVsdGlDb2x1bW5CbG9jay5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChSZW5k ZXJNdWx0aUNvbHVtbkJsb2NrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck11bHRpQ29sdW1u QmxvY2s6OmZsb3dUaHJlYWQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVt bkZsb3dUaHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTXVsdGlDb2x1bW5GbG93 VGhyZWFkOjp+UmVuZGVyTXVsdGlDb2x1bW5GbG93VGhyZWFkKToKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuaDoKKyAg ICAgICAgKFJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZCk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlck11bHRpQ29sdW1uU2V0Lmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVj dC5oOgorICAgICAgICAoUmVuZGVyT2JqZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9i amVjdDo6aXNSZW5kZXJNdWx0aUNvbHVtblNldCk6CisKIDIwMTItMDUtMjUgIEtlbiBCdWNoYW5h biAgPGtlbnJiQGNocm9taXVtLm9yZz4KIAogICAgICAgICBMYXlvdXQgcm9vdCBub3QgZ2V0dGlu ZyBjbGVhcmVkIGZvciBhbm9ueW1vdXMgcmVuZGVyZXJzIGdldGluZyBkZXN0cm95ZWQKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkJsb2NrLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5CbG9j ay5jcHAJKHJldmlzaW9uIDExODUzNikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJNdWx0aUNvbHVtbkJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUsNiArMjUsNyBAQAog CiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUmVuZGVyTXVsdGlDb2x1bW5CbG9jay5o IgorI2luY2x1ZGUgIlJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZC5oIgogCiB1c2luZyBuYW1l c3BhY2Ugc3RkOwogCkBAIC0zMiw2ICszMyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogUmVu ZGVyTXVsdGlDb2x1bW5CbG9jazo6UmVuZGVyTXVsdGlDb2x1bW5CbG9jayhOb2RlKiBub2RlKQog ICAgIDogUmVuZGVyQmxvY2sobm9kZSkKKyAgICAsIG1fZmxvd1RocmVhZCgwKQogICAgICwgbV9j b2x1bW5Db3VudCgxKQogICAgICwgbV9jb2x1bW5XaWR0aCgwKQogewpAQCAtNzMsNiArNzUsMjIg QEAgYm9vbCBSZW5kZXJNdWx0aUNvbHVtbkJsb2NrOjpyZWNvbXB1dGVMbwogICAgIHJldHVybiBy ZWxheW91dENoaWxkcmVuOwogfQogCit2b2lkIFJlbmRlck11bHRpQ29sdW1uQmxvY2s6OmFkZENo aWxkKFJlbmRlck9iamVjdCogbmV3Q2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQpCit7 CisgICAgaWYgKCFtX2Zsb3dUaHJlYWQpIHsKKyAgICAgICAgbV9mbG93VGhyZWFkID0gbmV3IChy ZW5kZXJBcmVuYSgpKSBSZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQoZG9jdW1lbnQoKSk7Cisg ICAgICAgIG1fZmxvd1RocmVhZC0+c2V0U3R5bGUoUmVuZGVyU3R5bGU6OmNyZWF0ZUFub255bW91 c1N0eWxlV2l0aERpc3BsYXkoc3R5bGUoKSwgQkxPQ0spKTsKKyAgICAgICAgUmVuZGVyQmxvY2s6 OmFkZENoaWxkKG1fZmxvd1RocmVhZCk7IC8vIEFsd2F5cyBwdXQgdGhlIGZsb3cgdGhyZWFkIGF0 IHRoZSBlbmQuCisgICAgfQorCisgICAgLy8gQ29sdW1uIHNldHMgYXJlIHNpYmxpbmdzIG9mIHRo ZSBmbG93IHRocmVhZC4gQWxsIGNoaWxkcmVuIGRlc2lnbmVkIHRvIGJlIGluIHRoZSBjb2x1bW5z LCBob3dldmVyLCBhcmUgcGFydAorICAgIC8vIG9mIHRoZSBmbG93IHRocmVhZCBpdHNlbGYuCisg ICAgaWYgKG5ld0NoaWxkLT5pc1JlbmRlck11bHRpQ29sdW1uU2V0KCkpCisgICAgICAgIFJlbmRl ckJsb2NrOjphZGRDaGlsZChuZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOworICAgIGVsc2UKKyAgICAg ICAgbV9mbG93VGhyZWFkLT5hZGRDaGlsZChuZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOworfQorCiBj b25zdCBjaGFyKiBSZW5kZXJNdWx0aUNvbHVtbkJsb2NrOjpyZW5kZXJOYW1lKCkgY29uc3QKIHsg ICAgCiAgICAgaWYgKGlzRmxvYXRpbmcoKSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJNdWx0aUNvbHVtbkJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uQmxvY2suaAkocmV2aXNpb24gMTE4NTM2KQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uQmxvY2suaAkod29ya2lu ZyBjb3B5KQpAQCAtMzEsNiArMzEsOCBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNz IFJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZDsKKwogY2xhc3MgUmVuZGVyTXVsdGlDb2x1bW5C bG9jayA6IHB1YmxpYyBSZW5kZXJCbG9jayB7CiBwdWJsaWM6CiAgICAgUmVuZGVyTXVsdGlDb2x1 bW5CbG9jayhOb2RlKik7CkBAIC00MSw3ICs0MywxMyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwg Ym9vbCByZWNvbXB1dGVMb2dpY2FsV2lkdGgoKTsKICAgICB2b2lkIGNvbXB1dGVDb2x1bW5Db3Vu dEFuZFdpZHRoKCk7CiAKKyAgICB2aXJ0dWFsIHZvaWQgYWRkQ2hpbGQoUmVuZGVyT2JqZWN0KiBu ZXdDaGlsZCwgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCA9IDApIE9WRVJSSURFOworCisgICAg UmVuZGVyTXVsdGlDb2x1bW5GbG93VGhyZWFkKiBmbG93VGhyZWFkKCkgY29uc3QgeyByZXR1cm4g bV9mbG93VGhyZWFkOyB9CisKIHByaXZhdGU6CisgICAgUmVuZGVyTXVsdGlDb2x1bW5GbG93VGhy ZWFkKiBtX2Zsb3dUaHJlYWQ7CisKICAgICB1bnNpZ25lZCBtX2NvbHVtbkNvdW50OyAgIC8vIFRo ZSBkZWZhdWx0IGNvbHVtbiBjb3VudC93aWR0aCB0aGF0IGFyZSBiYXNlZCBvZmYgb3VyIGNvbnRh aW5pbmcgYmxvY2sgd2lkdGguIFRoZXNlIHZhbHVlcyByZXByZXNlbnQgb25seSB0aGUgZGVmYXVs dCwKICAgICBMYXlvdXRVbml0IG1fY29sdW1uV2lkdGg7IC8vIHNpbmNlIGEgbXVsdGktY29sdW1u IGJsb2NrIHRoYXQgaXMgc3BsaXQgYWNyb3NzIHZhcmlhYmxlIHdpZHRoIHBhZ2VzIG9yIHJlZ2lv bnMgd2lsbCBoYXZlIGRpZmZlcmVudCBjb2x1bW4gY291bnRzIGFuZCB3aWR0aHMgaW4gZWFjaC4K ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vIFRoZXNlIHZhbHVlcyB3aWxsIGJlIGNh Y2hlZCAoZXZlbnR1YWxseSkgZm9yIG11bHRpLWNvbHVtbiBibG9ja3MuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5GbG93VGhyZWFkLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5GbG93VGhy ZWFkLmNwcAkocmV2aXNpb24gMTE4NTM2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlck11bHRpQ29sdW1uRmxvd1RocmVhZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMz LDEwIEBAIFJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZDo6UmVuZGVyTXVsdGkKIHsKIH0KIAor UmVuZGVyTXVsdGlDb2x1bW5GbG93VGhyZWFkOjp+UmVuZGVyTXVsdGlDb2x1bW5GbG93VGhyZWFk KCkKK3sKK30KKwogY29uc3QgY2hhciogUmVuZGVyTXVsdGlDb2x1bW5GbG93VGhyZWFkOjpyZW5k ZXJOYW1lKCkgY29uc3QKIHsgICAgCiAgICAgcmV0dXJuICJSZW5kZXJNdWx0aUNvbHVtbkZsb3dU aHJlYWQiOwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1u Rmxvd1RocmVhZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuaAkocmV2aXNpb24gMTE4NTM2KQorKysgU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZC5oCSh3b3JraW5nIGNv cHkpCkBAIC0zNCw3ICszNCw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIFJlbmRlck11 bHRpQ29sdW1uRmxvd1RocmVhZCA6IHB1YmxpYyBSZW5kZXJGbG93VGhyZWFkIHsKIHB1YmxpYzoK ICAgICBSZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQoTm9kZSopOwotICAgIAorICAgIH5SZW5k ZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQoKTsKKwogcHJpdmF0ZToKICAgICB2aXJ0dWFsIGNvbnN0 IGNoYXIqIHJlbmRlck5hbWUoKSBjb25zdCBPVkVSUklERTsKIH07CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5TZXQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5TZXQuaAkocmV2aXNpb24gMTE4 NTM2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uU2V0LmgJ KHdvcmtpbmcgY29weSkKQEAgLTQ1LDYgKzQ1LDggQEAgY2xhc3MgUmVuZGVyTXVsdGlDb2x1bW5T ZXQgOiBwdWJsaWMgUmVuZAogcHVibGljOgogICAgIFJlbmRlck11bHRpQ29sdW1uU2V0KE5vZGUq LCBSZW5kZXJGbG93VGhyZWFkKik7CiAgICAgCisgICAgdmlydHVhbCBib29sIGlzUmVuZGVyTXVs dGlDb2x1bW5TZXQoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CisKIHByaXZhdGU6 CiAgICAgdmlydHVhbCBjb25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3Q7CiB9OwpJbmRleDog U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAkocmV2aXNpb24gMTE4NTM2KQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCSh3b3JraW5nIGNvcHkp CkBAIC0zNjAsNiArMzYwLDkgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBib29sIGlzUmVuZGVy Rmxvd1RocmVhZCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlz UmVuZGVyTmFtZWRGbG93VGhyZWFkKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKyAgICAKKyAg ICB2aXJ0dWFsIGJvb2wgaXNSZW5kZXJNdWx0aUNvbHVtblNldCgpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CisKICAgICB2aXJ0dWFsIGJvb2wgaXNSZW5kZXJTY3JvbGxiYXJQYXJ0KCkgY29uc3Qg eyByZXR1cm4gZmFsc2U7IH0KICAgICBib29sIGNhbkhhdmVSZWdpb25TdHlsZSgpIGNvbnN0IHsg cmV0dXJuIGlzUmVuZGVyQmxvY2soKSAmJiAhaXNBbm9ueW1vdXMoKSAmJiAhaXNSZW5kZXJGbG93 VGhyZWFkKCk7IH0KIAo=