87523 2012-05-25 11:42:06 -0700 Make RenderLayer not arena-allocated 2013-10-12 02:14:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 122651 1 simon.fraser webkit-unassigned commit-queue eric esprehn+autocc glenn hyatt jchaffraix kling kondapallykalyan ojan simon.fraser oldest_to_newest 634119 0 simon.fraser 2012-05-25 11:42:06 -0700 We don't think we're getting any benefit from RenderLayer being arena-allocated, and it adds code complexity. 634154 1 eric 2012-05-25 12:12:04 -0700 Agreed! 634164 2 ojan 2012-05-25 12:21:19 -0700 How is RenderLayer different than the other Render* classes WRT usefulness of being arena-allocated? 634199 3 simon.fraser 2012-05-25 12:47:00 -0700 There don't tend to be that many RenderLayers on most pages (tens - hundreds, not thousands). 634210 4 ojan 2012-05-25 13:03:17 -0700 Fair enough. 938743 5 213975 kling 2013-10-11 01:14:29 -0700 Created attachment 213975 Patch 938751 6 213975 commit-queue 2013-10-11 02:37:57 -0700 Comment on attachment 213975 Patch Clearing flags on attachment: 213975 Committed r157297: <http://trac.webkit.org/changeset/157297> 938752 7 commit-queue 2013-10-11 02:37:59 -0700 All reviewed patches have been landed. Closing bug. 938822 8 commit-queue 2013-10-11 09:49:08 -0700 Re-opened since this is blocked by bug 122651 938832 9 ap 2013-10-11 09:53:46 -0700 This caused crashes on tests (debug and release WK2). Very strange that EWS didn't catch it, was the landed patch identical to the one posted here? Rolled out in <https://trac.webkit.org/r157306>. Results: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r157297%20(13299)/results.html 939067 10 kling 2013-10-12 02:14:09 -0700 Committed r157333: <http://trac.webkit.org/changeset/157333> 213975 2013-10-11 01:14:29 -0700 2013-10-11 02:37:57 -0700 Patch bug-87523.diff text/plain 5078 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNWM2ZDEzLi43M2VkNDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTMtMTAtMTAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIE1ha2UgUmVuZGVyTGF5ZXIgbm90IGFyZW5hLWFsbG9jYXRlZC4KKyAgICAgICAgPGh0dHBz Oi8vd2Via2l0Lm9yZy9iLzg3NTIzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIExldCBSZW5kZXJMYXllck1vZGVsT2JqZWN0IHN0b3JlIGl0cyBSZW5k ZXJMYXllciBpbiBhIHVuaXF1ZV9wdHIuCisgICAgICAgIExheWVycyBhcmUgcmVsYXRpdmVseSBs b3ctdm9sdW1lIG9iamVjdHMgYW5kIHRoaXMgbG9va3MgbmV1dHJhbAorICAgICAgICBvbiBvdXIg cGVyZm9ybWFuY2UgdGVzdHMuCisKIDIwMTMtMTAtMTAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5n LmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBBZGQgdG9TVkdDb2xvcnxQYWludCgpIHRvIGNs ZWFudXAgc3RhdGljX2Nhc3Q8PiwgYW5kIHVzZSBpdCAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuY3BwCmluZGV4IDEyZjI2ZDMuLmY3MGM1NzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMTczNCwyNSArMTczNCw2IEBAIHZvaWQgUmVu ZGVyTGF5ZXI6OmJlZ2luVHJhbnNwYXJlbmN5TGF5ZXJzKEdyYXBoaWNzQ29udGV4dCogY29udGV4 dCwgY29uc3QgUmVuZGVyCiAgICAgfQogfQogCi12b2lkKiBSZW5kZXJMYXllcjo6b3BlcmF0b3Ig bmV3KHNpemVfdCBzeiwgUmVuZGVyQXJlbmEmIHJlbmRlckFyZW5hKQotewotICAgIHJldHVybiBy ZW5kZXJBcmVuYS5hbGxvY2F0ZShzeik7Ci19Ci0KLXZvaWQgUmVuZGVyTGF5ZXI6Om9wZXJhdG9y IGRlbGV0ZSh2b2lkKiBwdHIsIHNpemVfdCBzeikKLXsKLSAgICAvLyBTdGFzaCBzaXplIHdoZXJl IGRlc3Ryb3kgY2FuIGZpbmQgaXQuCi0gICAgKihzaXplX3QgKilwdHIgPSBzejsKLX0KLQotdm9p ZCBSZW5kZXJMYXllcjo6ZGVzdHJveShSZW5kZXJBcmVuYSYgcmVuZGVyQXJlbmEpCi17Ci0gICAg ZGVsZXRlIHRoaXM7Ci0KLSAgICAvLyBSZWNvdmVyIHRoZSBzaXplIGxlZnQgdGhlcmUgZm9yIHVz IGJ5IG9wZXJhdG9yIGRlbGV0ZSBhbmQgZnJlZSB0aGUgbWVtb3J5LgotICAgIHJlbmRlckFyZW5h LmZyZWUoKihzaXplX3QgKil0aGlzLCB0aGlzKTsKLX0KLQogdm9pZCBSZW5kZXJMYXllcjo6YWRk Q2hpbGQoUmVuZGVyTGF5ZXIqIGNoaWxkLCBSZW5kZXJMYXllciogYmVmb3JlQ2hpbGQpCiB7CiAg ICAgUmVuZGVyTGF5ZXIqIHByZXZTaWJsaW5nID0gYmVmb3JlQ2hpbGQgPyBiZWZvcmVDaGlsZC0+ cHJldmlvdXNTaWJsaW5nKCkgOiBsYXN0Q2hpbGQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyLmgKaW5kZXggYTA4NzBiMi4uM2I3Mjk5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmgKQEAgLTc0OCwxMyArNzQ4LDYgQEAgcHVibGljOgogICAgIGJvb2wg aGFzQmxlbmRNb2RlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICNlbmRpZgogCi0gICAgLy8g T3ZlcmxvYWRlZCBuZXcgb3BlcmF0b3IuIERlcml2ZWQgY2xhc3NlcyBtdXN0IG92ZXJyaWRlIG9w ZXJhdG9yIG5ldwotICAgIC8vIGluIG9yZGVyIHRvIGFsbG9jYXRlIG91dCBvZiB0aGUgUmVuZGVy QXJlbmEuCi0gICAgdm9pZCogb3BlcmF0b3IgbmV3KHNpemVfdCwgUmVuZGVyQXJlbmEmKTsKLQot ICAgIC8vIE92ZXJyaWRkZW4gdG8gcHJldmVudCB0aGUgbm9ybWFsIGRlbGV0ZSBmcm9tIGJlaW5n IGNhbGxlZC4KLSAgICB2b2lkIG9wZXJhdG9yIGRlbGV0ZSh2b2lkKiwgc2l6ZV90KTsKLQogI2lm IFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBib29sIGlzQ29tcG9zaXRlZCgpIGNv bnN0IHsgcmV0dXJuIG1fYmFja2luZyAhPSAwOyB9CiAgICAgYm9vbCBoYXNDb21wb3NpdGVkTWFz aygpIGNvbnN0OwpAQCAtODg3LDkgKzg4MCw2IEBAIHByaXZhdGU6CiAKICAgICBJbnRTaXplIGNs YW1wU2Nyb2xsT2Zmc2V0KGNvbnN0IEludFNpemUmKSBjb25zdDsKIAotICAgIC8vIFRoZSBub3Jt YWwgb3BlcmF0b3IgbmV3IGlzIGRpc2FsbG93ZWQgb24gYWxsIHJlbmRlciBvYmplY3RzLgotICAg IHZvaWQqIG9wZXJhdG9yIG5ldyhzaXplX3QpIHRocm93KCk7Ci0KICAgICB2b2lkIHNldE5leHRT aWJsaW5nKFJlbmRlckxheWVyKiBuZXh0KSB7IG1fbmV4dCA9IG5leHQ7IH0KICAgICB2b2lkIHNl dFByZXZpb3VzU2libGluZyhSZW5kZXJMYXllciogcHJldikgeyBtX3ByZXZpb3VzID0gcHJldjsg fQogICAgIHZvaWQgc2V0UGFyZW50KFJlbmRlckxheWVyKiBwYXJlbnQpOwpAQCAtMTExNyw5ICsx MTA3LDYgQEAgcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgUmVuZGVyTGF5ZXJDb21wb3NpdG9y OwogICAgIGZyaWVuZCBjbGFzcyBSZW5kZXJMYXllck1vZGVsT2JqZWN0OwogCi0gICAgLy8gT25s eSBzYWZlIHRvIGNhbGwgZnJvbSBSZW5kZXJCb3hNb2RlbE9iamVjdDo6ZGVzdHJveUxheWVyKFJl bmRlckFyZW5hJikKLSAgICB2b2lkIGRlc3Ryb3koUmVuZGVyQXJlbmEmKTsKLQogICAgIExheW91 dFVuaXQgb3ZlcmZsb3dUb3AoKSBjb25zdDsKICAgICBMYXlvdXRVbml0IG92ZXJmbG93Qm90dG9t KCkgY29uc3Q7CiAgICAgTGF5b3V0VW5pdCBvdmVyZmxvd0xlZnQoKSBjb25zdDsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmNwcAppbmRl eCBmNDhiNGQ2Li4zZjVkODFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyTW9kZWxPYmplY3QuY3BwCkBAIC0zOSw3ICszOSw2IEBAIGJvb2wgUmVuZGVy TGF5ZXJNb2RlbE9iamVjdDo6c19sYXllcldhc1NlbGZQYWludGluZyA9IGZhbHNlOwogCiBSZW5k ZXJMYXllck1vZGVsT2JqZWN0OjpSZW5kZXJMYXllck1vZGVsT2JqZWN0KEVsZW1lbnQqIGVsZW1l bnQsIHVuc2lnbmVkIGJhc2VUeXBlRmxhZ3MpCiAgICAgOiBSZW5kZXJFbGVtZW50KGVsZW1lbnQs IGJhc2VUeXBlRmxhZ3MgfCBSZW5kZXJMYXllck1vZGVsT2JqZWN0RmxhZykKLSAgICAsIG1fbGF5 ZXIoMCkKIHsKIH0KIApAQCAtNTQsOCArNTMsNyBAQCB2b2lkIFJlbmRlckxheWVyTW9kZWxPYmpl Y3Q6OmRlc3Ryb3lMYXllcigpCiB7CiAgICAgQVNTRVJUKCFoYXNMYXllcigpKTsgLy8gQ2FsbGVy cyBzaG91bGQgaGF2ZSBhbHJlYWR5IGNhbGxlZCBzZXRIYXNMYXllcihmYWxzZSkKICAgICBBU1NF UlQobV9sYXllcik7Ci0gICAgbV9sYXllci0+ZGVzdHJveShyZW5kZXJBcmVuYSgpKTsKLSAgICBt X2xheWVyID0gMDsKKyAgICBtX2xheWVyID0gbnVsbHB0cjsKIH0KIAogdm9pZCBSZW5kZXJMYXll ck1vZGVsT2JqZWN0OjplbnN1cmVMYXllcigpCkBAIC02Myw3ICs2MSw3IEBAIHZvaWQgUmVuZGVy TGF5ZXJNb2RlbE9iamVjdDo6ZW5zdXJlTGF5ZXIoKQogICAgIGlmIChtX2xheWVyKQogICAgICAg ICByZXR1cm47CiAKLSAgICBtX2xheWVyID0gbmV3IChyZW5kZXJBcmVuYSgpKSBSZW5kZXJMYXll cigqdGhpcyk7CisgICAgbV9sYXllciA9IHN0ZDo6bWFrZV91bmlxdWU8UmVuZGVyTGF5ZXI+KCp0 aGlzKTsKICAgICBzZXRIYXNMYXllcih0cnVlKTsKICAgICBtX2xheWVyLT5pbnNlcnRPbmx5VGhp c0xheWVyKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJNb2RlbE9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy TW9kZWxPYmplY3QuaAppbmRleCA2OGE3OGU2Li45ZTFkOGQwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmgKQEAgLTM4LDcgKzM4LDcg QEAgcHVibGljOgogICAgIHZvaWQgZGVzdHJveUxheWVyKCk7CiAKICAgICBib29sIGhhc1NlbGZQ YWludGluZ0xheWVyKCkgY29uc3Q7Ci0gICAgUmVuZGVyTGF5ZXIqIGxheWVyKCkgY29uc3QgeyBy ZXR1cm4gbV9sYXllcjsgfQorICAgIFJlbmRlckxheWVyKiBsYXllcigpIGNvbnN0IHsgcmV0dXJu IG1fbGF5ZXIuZ2V0KCk7IH0KIAogICAgIHZpcnR1YWwgdm9pZCBzdHlsZVdpbGxDaGFuZ2UoU3R5 bGVEaWZmZXJlbmNlLCBjb25zdCBSZW5kZXJTdHlsZSogbmV3U3R5bGUpIE9WRVJSSURFOwogICAg IHZpcnR1YWwgdm9pZCBzdHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UsIGNvbnN0IFJlbmRl clN0eWxlKiBvbGRTdHlsZSkgT1ZFUlJJREU7CkBAIC01Niw3ICs1Niw3IEBAIHByb3RlY3RlZDoK ICAgICB2aXJ0dWFsIHZvaWQgd2lsbEJlRGVzdHJveWVkKCkgT1ZFUlJJREU7CiAKIHByaXZhdGU6 Ci0gICAgUmVuZGVyTGF5ZXIqIG1fbGF5ZXI7CisgICAgc3RkOjp1bmlxdWVfcHRyPFJlbmRlckxh eWVyPiBtX2xheWVyOwogCiAgICAgLy8gVXNlZCB0byBzdG9yZSBzdGF0ZSBiZXR3ZWVuIHN0eWxl V2lsbENoYW5nZSBhbmQgc3R5bGVEaWRDaGFuZ2UKICAgICBzdGF0aWMgYm9vbCBzX3dhc0Zsb2F0 aW5nOwo=