87520 log 2012-05-25 11:26:44 -0700 add a new logging channel for MediaStream 2013-09-06 10:16:20 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 87514 0 danilo.eu webkit-unassigned dglazkov gustavo philn webkit.review.bot xan.lopez oldest_to_newest 634103 0 danilo.eu 2012-05-25 11:26:44 -0700 Since MediaStream components produce a lot of useful debug information, would be nice to create its own log channel. 634113 1 144108 danilo.eu 2012-05-25 11:36:36 -0700 Created attachment 144108 patch proposal 634114 2 webkit.review.bot 2012-05-25 11:39:32 -0700 Attachment 144108 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 634135 3 144108 buildbot 2012-05-25 11:52:46 -0700 Comment on attachment 144108 patch proposal Attachment 144108 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12791589 634137 4 144108 buildbot 2012-05-25 11:52:55 -0700 Comment on attachment 144108 patch proposal Attachment 144108 did not pass win-ews (win): Output: http://queues.webkit.org/results/12795592 634148 5 144108 webkit-ews 2012-05-25 11:57:49 -0700 Comment on attachment 144108 patch proposal Attachment 144108 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12792573 634150 6 144108 webkit-ews 2012-05-25 12:05:21 -0700 Comment on attachment 144108 patch proposal Attachment 144108 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12795596 634175 7 144108 gyuyoung.kim 2012-05-25 12:28:34 -0700 Comment on attachment 144108 patch proposal Attachment 144108 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12802519 634184 8 144108 webkit.review.bot 2012-05-25 12:33:56 -0700 Comment on attachment 144108 patch proposal Attachment 144108 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12794573 634216 9 144134 danilo.eu 2012-05-25 13:04:43 -0700 Created attachment 144134 patch proposal Fixing a small issue. 634224 10 danilo.eu 2012-05-25 13:12:24 -0700 I will push a few dependencies to this bug (using this log channel) in the next hours. 723538 11 144134 webkit.review.bot 2012-09-19 07:04:48 -0700 Comment on attachment 144134 patch proposal Rejecting attachment 144134 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13891579 723544 12 144134 pnormand 2012-09-19 07:09:06 -0700 Comment on attachment 144134 patch proposal Reviewed by field is missing indeed 723557 13 danilo.eu 2012-09-19 07:33:17 -0700 It seems that all the logging addresses bits are being used now. any idea on what should we do on that case? 925699 14 danilo.eu 2013-09-06 10:16:20 -0700 not necessary anymore 144108 2012-05-25 11:36:36 -0700 2012-05-25 13:04:43 -0700 patch proposal 0002-add-MediaStream-channel-to-the-logging-component.patch text/plain 2744 danilo.eu RnJvbSA1MTNjMTIyZTZiNGE0MDljNjJkOWZiOWViNzVkYmRlNDEzZmY3YzhkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pbG8gQ2VzYXIgTGVtZXMgZGUgUGF1bGEgPGRhbmlsby5j ZXNhckBjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgMjUgTWF5IDIwMTIgMTU6MTU6MjkgLTAz MDAKU3ViamVjdDogW1BBVENIIDIvM10gYWRkIE1lZGlhU3RyZWFtIGNoYW5uZWwgdG8gdGhlIGxv Z2dpbmcgY29tcG9uZW50CgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg IHwgICAxNiArKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5n LmNwcCB8ICAgIDQgKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oICAgfCAg ICAxICsKIDMgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1 NmZlZTc1Li40Yzc5MDViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDUtMjUg IERhbmlsbyBDZXNhciBMZW1lcyBkZSBQYXVsYSAgPGRhbmlsby5jZXNhckBjb2xsYWJvcmEuY28u dWs+CisKKyAgICAgICAgYWRkIE1lZGlhU3RyZWFtIGNoYW5uZWwgdG8gdGhlIGxvZ2dpbmcgY29t cG9uZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NzUyMAorCisgICAgICAgIFNpbmNlIE1lZGlhU3RyZWFtIGNvbXBvbmVudHMgcHJvZHVjZSBhIGxv dCBvZiB1c2VmdWwgZGVidWcgaW5mb3JtYXRpb24sCisgICAgICAgIHdvdWxkIGJlIG5pY2UgdG8g Y3JlYXRlIGl0cyBvd24gbG9nIGNoYW5uZWwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09Q UyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2dnaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAoV2ViQ29yZTo6Z2V0Q2hhbm5lbEZyb21OYW1lKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9Mb2dnaW5nLmg6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0wNS0yNSAgRGFuaWxv IENlc2FyIExlbWVzIGQgUGF1bGEgIDxkYW5pbG8uY2VzYXJAY29sbGFib3JhLmNvLnVrPgogCiAg ICAgICAgIFtHVEtdIEFkZGluZyBGYXJzdHJlYW0gZmxhZ3MvZGVwcyB0byBXZWJLaXRHdGsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAKaW5kZXggMzQ2MzdhNy4uM2U4NTYzNSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAKQEAgLTY0LDYgKzY0LDcgQEAgV1RGTG9nQ2hhbm5l bCBMb2dGaWxlQVBJID0gICAgICAgICAgIHsgMHgxMDAwMDAwMCwgIldlYkNvcmVMb2dMZXZlbCIs IFdURkxvZ0NoYW4KIFdURkxvZ0NoYW5uZWwgTG9nV2ViQXVkaW8gPSAgICAgICAgICB7IDB4MjAw MDAwMDAsICJXZWJDb3JlTG9nTGV2ZWwiLCBXVEZMb2dDaGFubmVsT2ZmIH07CiBXVEZMb2dDaGFu bmVsIExvZ0NvbXBvc2l0aW5nID0gICAgICAgeyAweDQwMDAwMDAwLCAiV2ViQ29yZUxvZ0xldmVs IiwgV1RGTG9nQ2hhbm5lbE9mZiB9OwogCitXVEZMb2dDaGFubmVsIExvZ01lZGlhU3RyZWFtID0g ICAgICAgeyAweDgwMDAwMDAwLCAiV2ViQ29yZUxvZ0xldmVsIiwgV1RGTG9nQ2hhbm5lbE9mZiB9 OwogCiBXVEZMb2dDaGFubmVsKiBnZXRDaGFubmVsRnJvbU5hbWUoY29uc3QgU3RyaW5nJiBjaGFu bmVsTmFtZSkKIHsKQEAgLTEzOSw2ICsxNDAsOSBAQCBXVEZMb2dDaGFubmVsKiBnZXRDaGFubmVs RnJvbU5hbWUoY29uc3QgU3RyaW5nJiBjaGFubmVsTmFtZSkKICAgICBpZiAoZXF1YWxJZ25vcmlu Z0Nhc2UoY2hhbm5lbE5hbWUsIFN0cmluZygiRmlsZUFQSSIpKSkKICAgICAgICAgcmV0dXJuICZM b2dGaWxlQVBJOwogCisgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKGNoYW5uZWxOYW1lLCBTdHJp bmcoIk1lZGlhU3RyZWFtIikpKQorICAgICAgICByZXR1cm4gJkxvZ0dldE1lZGlhU3RyZWFtOwor CiAgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKGNoYW5uZWxOYW1lLCBTdHJpbmcoIldlYkF1ZGlv IikpKQogICAgICAgICByZXR1cm4gJkxvZ1dlYkF1ZGlvOwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dn aW5nLmgKaW5kZXggMWFmMWMwNC4uZDE0ZThhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vTG9nZ2luZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcu aApAQCAtNTksNiArNTksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgZXh0ZXJuIFdURkxv Z0NoYW5uZWwgTG9nQXJjaGl2ZXM7CiAgICAgZXh0ZXJuIFdURkxvZ0NoYW5uZWwgTG9nUHJvZ3Jl c3M7CiAgICAgZXh0ZXJuIFdURkxvZ0NoYW5uZWwgTG9nRmlsZUFQSTsKKyAgICBleHRlcm4gV1RG TG9nQ2hhbm5lbCBMb2dNZWRpYVN0cmVhbTsKICAgICBleHRlcm4gV1RGTG9nQ2hhbm5lbCBMb2dX ZWJBdWRpbzsKICAgICBleHRlcm4gV1RGTG9nQ2hhbm5lbCBMb2dDb21wb3NpdGluZzsKIAotLSAK MS43LjEwCgo= 144134 2012-05-25 13:04:43 -0700 2012-09-19 07:09:06 -0700 patch proposal 0002-add-MediaStream-channel-to-the-logging-component.patch text/plain 2811 danilo.eu RnJvbSA0ZmU3MTZhYWQ3MGE0MDMzNzEwMDlmYjFlNDZjZjdjOGYzNWY4Mjg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pbG8gQ2VzYXIgTGVtZXMgZGUgUGF1bGEgPGRhbmlsby5j ZXNhckBjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgMjUgTWF5IDIwMTIgMTU6MTU6MjkgLTAz MDAKU3ViamVjdDogW1BBVENIIDIvM10gYWRkIE1lZGlhU3RyZWFtIGNoYW5uZWwgdG8gdGhlIGxv Z2dpbmcgY29tcG9uZW50CgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg IHwgICAxNiArKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5n LmNwcCB8ICAgIDQgKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oICAgfCAg ICAxICsKIDMgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1 MTIzYTAxLi5lYzUwZjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTItMDUtMjUg IERhbmlsbyBDZXNhciBMZW1lcyBkZSBQYXVsYSAgPGRhbmlsby5jZXNhckBjb2xsYWJvcmEuY28u dWs+CiAKKyAgICAgICAgYWRkIE1lZGlhU3RyZWFtIGNoYW5uZWwgdG8gdGhlIGxvZ2dpbmcgY29t cG9uZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NzUyMAorCisgICAgICAgIFNpbmNlIE1lZGlhU3RyZWFtIGNvbXBvbmVudHMgcHJvZHVjZSBhIGxv dCBvZiB1c2VmdWwgZGVidWcgaW5mb3JtYXRpb24sCisgICAgICAgIHdvdWxkIGJlIG5pY2UgdG8g Y3JlYXRlIGl0cyBvd24gbG9nIGNoYW5uZWwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBm dW5jdGlvbmFsaXR5IGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL0xvZ2dpbmcuY3BwOgor ICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpnZXRDaGFubmVsRnJvbU5hbWUp OgorICAgICAgICAqIHBsYXRmb3JtL0xvZ2dpbmcuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorCisy MDEyLTA1LTI1ICBEYW5pbG8gQ2VzYXIgTGVtZXMgZGUgUGF1bGEgIDxkYW5pbG8uY2VzYXJAY29s bGFib3JhLmNvLnVrPgorCiAgICAgICAgIFtHU3RyZWFtZXJdIEFkZGluZyBGYXJzdHJlYW0gZmxh Z3MvZGVwcyB0byBXZWJLaXQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg3NTE0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xv Z2dpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAKaW5kZXggMzQ2 MzdhNy4uY2I0N2EzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2lu Zy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAKQEAgLTY0LDYg KzY0LDcgQEAgV1RGTG9nQ2hhbm5lbCBMb2dGaWxlQVBJID0gICAgICAgICAgIHsgMHgxMDAwMDAw MCwgIldlYkNvcmVMb2dMZXZlbCIsIFdURkxvZ0NoYW4KIFdURkxvZ0NoYW5uZWwgTG9nV2ViQXVk aW8gPSAgICAgICAgICB7IDB4MjAwMDAwMDAsICJXZWJDb3JlTG9nTGV2ZWwiLCBXVEZMb2dDaGFu bmVsT2ZmIH07CiBXVEZMb2dDaGFubmVsIExvZ0NvbXBvc2l0aW5nID0gICAgICAgeyAweDQwMDAw MDAwLCAiV2ViQ29yZUxvZ0xldmVsIiwgV1RGTG9nQ2hhbm5lbE9mZiB9OwogCitXVEZMb2dDaGFu bmVsIExvZ01lZGlhU3RyZWFtID0gICAgICAgeyAweDgwMDAwMDAwLCAiV2ViQ29yZUxvZ0xldmVs IiwgV1RGTG9nQ2hhbm5lbE9mZiB9OwogCiBXVEZMb2dDaGFubmVsKiBnZXRDaGFubmVsRnJvbU5h bWUoY29uc3QgU3RyaW5nJiBjaGFubmVsTmFtZSkKIHsKQEAgLTk3LDYgKzk4LDkgQEAgV1RGTG9n Q2hhbm5lbCogZ2V0Q2hhbm5lbEZyb21OYW1lKGNvbnN0IFN0cmluZyYgY2hhbm5lbE5hbWUpCiAg ICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKGNoYW5uZWxOYW1lLCBTdHJpbmcoIk1lZGlhIikpKQog ICAgICAgICByZXR1cm4gJkxvZ01lZGlhOwogCisgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKGNo YW5uZWxOYW1lLCBTdHJpbmcoIk1lZGlhU3RyZWFtIikpKQorICAgICAgICByZXR1cm4gJkxvZ01l ZGlhU3RyZWFtOworCiAgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKGNoYW5uZWxOYW1lLCBTdHJp bmcoIk5ldHdvcmsiKSkpCiAgICAgICAgIHJldHVybiAmTG9nTmV0d29yazsKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vTG9nZ2luZy5oCmluZGV4IDFhZjFjMDQuLmQxNGU4YTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9Mb2dnaW5nLmgKQEAgLTU5LDYgKzU5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGV4 dGVybiBXVEZMb2dDaGFubmVsIExvZ0FyY2hpdmVzOwogICAgIGV4dGVybiBXVEZMb2dDaGFubmVs IExvZ1Byb2dyZXNzOwogICAgIGV4dGVybiBXVEZMb2dDaGFubmVsIExvZ0ZpbGVBUEk7CisgICAg ZXh0ZXJuIFdURkxvZ0NoYW5uZWwgTG9nTWVkaWFTdHJlYW07CiAgICAgZXh0ZXJuIFdURkxvZ0No YW5uZWwgTG9nV2ViQXVkaW87CiAgICAgZXh0ZXJuIFdURkxvZ0NoYW5uZWwgTG9nQ29tcG9zaXRp bmc7CiAKLS0gCjEuNy4xMAoK