87511 2012-05-25 10:18:32 -0700 [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001 2012-05-25 10:48:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Windows 7 RESOLVED FIXED LayoutTestFailure, MakingBotsRed P2 Normal --- 1 jberlin jberlin ap jberlin jhoneycutt sfalken oldest_to_newest 634026 0 jberlin 2012-05-25 10:18:32 -0700 The Windows implementation of eventSender.keyDown needs to be updated for the changes made to that function for other ports in http://trac.webkit.org/changeset/118001 --- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/events/keydown-leftright-keys-expected.txt 2012-05-25 08:59:06.963869600 -0700 +++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/events/keydown-leftright-keys-actual.txt 2012-05-25 08:59:06.961869500 -0700 @@ -5,23 +5,23 @@ PASS lastKeyboardEvent.type is "keydown" -PASS lastKeyboardEvent.keyCode is 16 -PASS lastKeyboardEvent.keyLocation is KEY_LOCATION_LEFT +FAIL lastKeyboardEvent.keyCode should be 16. Was 76. +FAIL lastKeyboardEvent.keyLocation should be 1. Was 0. PASS lastKeyboardEvent.type is "keydown" -PASS lastKeyboardEvent.keyCode is 17 -PASS lastKeyboardEvent.keyLocation is KEY_LOCATION_LEFT +FAIL lastKeyboardEvent.keyCode should be 17. Was 76. +FAIL lastKeyboardEvent.keyLocation should be 1. Was 0. PASS lastKeyboardEvent.type is "keydown" -PASS lastKeyboardEvent.keyCode is 18 -PASS lastKeyboardEvent.keyLocation is KEY_LOCATION_LEFT +FAIL lastKeyboardEvent.keyCode should be 18. Was 76. +FAIL lastKeyboardEvent.keyLocation should be 1. Was 0. PASS lastKeyboardEvent.type is "keydown" -PASS lastKeyboardEvent.keyCode is 16 -PASS lastKeyboardEvent.keyLocation is KEY_LOCATION_RIGHT +FAIL lastKeyboardEvent.keyCode should be 16. Was 82. +FAIL lastKeyboardEvent.keyLocation should be 2. Was 0. PASS lastKeyboardEvent.type is "keydown" -PASS lastKeyboardEvent.keyCode is 17 -PASS lastKeyboardEvent.keyLocation is KEY_LOCATION_RIGHT +FAIL lastKeyboardEvent.keyCode should be 17. Was 82. +FAIL lastKeyboardEvent.keyLocation should be 2. Was 0. PASS lastKeyboardEvent.type is "keydown" -PASS lastKeyboardEvent.keyCode is 18 -PASS lastKeyboardEvent.keyLocation is KEY_LOCATION_RIGHT +FAIL lastKeyboardEvent.keyCode should be 18. Was 82. +FAIL lastKeyboardEvent.keyLocation should be 2. Was 0. PASS successfullyParsed is true TEST COMPLETE 634031 1 144095 jberlin 2012-05-25 10:21:39 -0700 Created attachment 144095 Patch 634063 2 144095 jberlin 2012-05-25 10:48:38 -0700 Comment on attachment 144095 Patch Committed in http://trac.webkit.org/changeset/118540 144095 2012-05-25 10:21:39 -0700 2012-05-25 10:48:37 -0700 Patch fixWin118001.patch text/plain 1863 jberlin ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhY2Fk ZDk3Li5jNzRhYmMyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUtMjUgIEplc3NpZSBCZXJsaW4gIDxqYmVy bGluQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBmYXN0L2V2ZW50cy9rZXlkb3duLWxlZnRy aWdodC1rZXlzLmh0bWwgZmFpbGluZyBzaW5jZSBpbnRyb2R1Y3Rpb24gaW4gcjExODAwMQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc1MTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIFdp bmRvd3MgaW1wbGVtZW50YXRpb24gb2Yga2V5RG93biB0byBtYXRjaCB0aGUgTWFjIG9uZSBjaGFu Z2VkIGluIHIxMTgwMDEuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vRXZlbnRTZW5k ZXIuY3BwOgorICAgICAgICAoa2V5RG93bkNhbGxiYWNrKToKKwogMjAxMi0wNS0yNSAgQ3NhYmEg T3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gQnVpbGRmaXgg Zm9yIG5ld2VyIFF0NQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0V2ZW50 U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9FdmVudFNlbmRlci5jcHAKaW5k ZXggMzc2YzA3Ni4uNWMwOTkzNiAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvd2lu L0V2ZW50U2VuZGVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRXZlbnRTZW5k ZXIuY3BwCkBAIC00NzUsNiArNDc1LDE4IEBAIHN0YXRpYyBKU1ZhbHVlUmVmIGtleURvd25DYWxs YmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZnVuY3Rpb24sIEpTCiAgICAg ICAgIHZpcnR1YWxLZXlDb2RlID0gVktfU05BUFNIT1Q7CiAgICAgZWxzZSBpZiAoSlNTdHJpbmdJ c0VxdWFsVG9VVEY4Q1N0cmluZyhjaGFyYWN0ZXIsICJtZW51IikpCiAgICAgICAgIHZpcnR1YWxL ZXlDb2RlID0gVktfQVBQUzsKKyAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3Ry aW5nKGNoYXJhY3RlciwgImxlZnRDb250cm9sIikpCisgICAgICAgIHZpcnR1YWxLZXlDb2RlID0g VktfTENPTlRST0w7CisgICAgZWxzZSBpZiAoSlNTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhj aGFyYWN0ZXIsICJsZWZ0U2hpZnQiKSkKKyAgICAgICAgdmlydHVhbEtleUNvZGUgPSBWS19MU0hJ RlQ7CisgICAgZWxzZSBpZiAoSlNTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhjaGFyYWN0ZXIs ICJsZWZ0QWx0IikpCisgICAgICAgIHZpcnR1YWxLZXlDb2RlID0gVktfTE1FTlU7CisgICAgZWxz ZSBpZiAoSlNTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhjaGFyYWN0ZXIsICJyaWdodENvbnRy b2wiKSkKKyAgICAgICAgdmlydHVhbEtleUNvZGUgPSBWS19SQ09OVFJPTDsKKyAgICBlbHNlIGlm IChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKGNoYXJhY3RlciwgInJpZ2h0U2hpZnQiKSkK KyAgICAgICAgdmlydHVhbEtleUNvZGUgPSBWS19SU0hJRlQ7CisgICAgZWxzZSBpZiAoSlNTdHJp bmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhjaGFyYWN0ZXIsICJyaWdodEFsdCIpKQorICAgICAgICB2 aXJ0dWFsS2V5Q29kZSA9IFZLX1JNRU5VOwogICAgIGVsc2UgewogICAgICAgICBjaGFyQ29kZSA9 IEpTU3RyaW5nR2V0Q2hhcmFjdGVyc1B0cihjaGFyYWN0ZXIpWzBdOwogICAgICAgICB2aXJ0dWFs S2V5Q29kZSA9IExPQllURShWa0tleVNjYW4oY2hhckNvZGUpKTsK