87494 2012-05-25 05:59:21 -0700 Body scrollWidth() and scrollHeight() should be page scale-invariant 2012-05-28 23:36:21 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87700 1 jknotten jknotten eric jamesr skyostil webkit.review.bot oldest_to_newest 633857 0 jknotten 2012-05-25 05:59:21 -0700 RenderView::documentRect() is calculating the "scaled" document rect by applying the current transformation matrix to the unscaledDocumentRect() and then returning the rounded-out IntRect result. This rounding out is incorrect because it allows the scaled rectangle to represent an area that is not actually covered by the document. This is evidenced by the document.body.scrollWidth() and document.body.scrollHeight() changing under page scale factor when they are expected to remain invariant. 633864 1 144054 jknotten 2012-05-25 06:04:53 -0700 Created attachment 144054 Patch 633882 2 144060 jknotten 2012-05-25 06:36:53 -0700 Created attachment 144060 Patch 633890 3 skyostil 2012-05-25 06:51:53 -0700 For posterity, the effect of this bug is being able to scroll a page one pixel beyond the actual content dimensions at some page scale factors. With the Chromium compositor this causes a red band to be shown to the right and bottom of the page. 634290 4 144060 jamesr 2012-05-25 14:37:48 -0700 Comment on attachment 144060 Patch Rounding for teh loss! R=me. 634304 5 144060 webkit.review.bot 2012-05-25 14:49:09 -0700 Comment on attachment 144060 Patch Clearing flags on attachment: 144060 Committed r118569: <http://trac.webkit.org/changeset/118569> 634305 6 webkit.review.bot 2012-05-25 14:49:13 -0700 All reviewed patches have been landed. Closing bug. 144054 2012-05-25 06:04:53 -0700 2012-05-25 06:36:48 -0700 Patch bug-87494-20120525140452.patch text/plain 6093 jknotten U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY1NDliZGZjNTQxZTA1 YzE0ZTk2OGQyMjkyOGQ4NzEwZDY0M2I2OS4uZGY2NjE5YzNjYTc5MmUzN2JjZDE4MThiY2Q0MDM2 OTdlYzhjNDIyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA1LTI1ICBKb2hu IEtub3R0ZW5iZWx0ICA8amtub3R0ZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEJvZHkgc2Ny b2xsV2lkdGgoKSBhbmQgc2Nyb2xsSGVpZ2h0KCkgc2hvdWxkIGJlIHBhZ2Ugc2NhbGUtaW52YXJp YW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzQ5 NAorCisgICAgICAgIFJlbmRlclZpZXc6OmRvY3VtZW50UmVjdCgpIGlzIGNhbGN1bGF0aW5nIHRo ZSAic2NhbGVkIiBkb2N1bWVudCByZWN0IGJ5IGFwcGx5aW5nCisgICAgICAgIHRoZSBjdXJyZW50 IHRyYW5zZm9ybWF0aW9uIG1hdHJpeCB0byB0aGUgdW5zY2FsZWREb2N1bWVudFJlY3QoKSBhbmQg dGhlbgorICAgICAgICByZXR1cm5pbmcgdGhlIHJvdW5kZWQtb3V0IEludFJlY3QgcmVzdWx0Lgor CisgICAgICAgIFRoaXMgcm91bmRpbmcgb3V0IGlzIGluY29ycmVjdCBiZWNhdXNlIGl0IGFsbG93 cyB0aGUgc2NhbGVkIHJlY3RhbmdsZSB0bworICAgICAgICByZXByZXNlbnQgYW4gYXJlYSB0aGF0 IGlzIG5vdCBhY3R1YWxseSBjb3ZlcmVkIGJ5IHRoZSBkb2N1bWVudC4KKworICAgICAgICBUaGlz IGlzIGV2aWRlbmNlZCBieSB0aGUgZG9jdW1lbnQuYm9keS5zY3JvbGxXaWR0aCgpIGFuZAorICAg ICAgICBkb2N1bWVudC5ib2R5LnNjcm9sbEhlaWdodCgpIGNoYW5naW5nIHVuZGVyIHBhZ2Ugc2Nh bGUgZmFjdG9yIHdoZW4KKyAgICAgICAgdGhleSBhcmUgZXhwZWN0ZWQgdG8gcmVtYWluIGludmFy aWFudC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU ZXN0OiBmYXN0L2RvbS93aW5kb3ctc2Nyb2xsLXNjYWxpbmcuaHRtbAorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlclZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlldzo6ZG9j dW1lbnRSZWN0KToKKwogMjAxMi0wNS0yNSAgWmFsYW4gQnVqdGFzICA8emJ1anRhc0BnbWFpbC5j b20+CiAKICAgICAgICAgW1F0XSBCcm9rZW4gY29udHJvbHMgcmVuZGVyaW5nIHdoZW4gdHJhbnNm b3JtIGlzIGFwcGxpZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKaW5k ZXggODYzMzEwNGUzZjExNmI0YmM1NThiNDQ3NzMwNGYyNjNlMTUzZTVmMC4uOWQ4YmU0YzFiMjlk MzI3OWY0YzQ1ZWRiNzU2Y2U4NGY1NjNhM2RlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJWaWV3LmNwcApAQCAtNzMzLDEwICs3MzMsMTAgQEAgTGF5b3V0UmVjdCBSZW5kZXJWaWV3 OjpiYWNrZ3JvdW5kUmVjdChSZW5kZXJCb3gqIGJhY2tncm91bmRSZW5kZXJlcikgY29uc3QKIAog SW50UmVjdCBSZW5kZXJWaWV3Ojpkb2N1bWVudFJlY3QoKSBjb25zdAogewotICAgIEludFJlY3Qg b3ZlcmZsb3dSZWN0KHVuc2NhbGVkRG9jdW1lbnRSZWN0KCkpOworICAgIEZsb2F0UmVjdCBvdmVy Zmxvd1JlY3QodW5zY2FsZWREb2N1bWVudFJlY3QoKSk7CiAgICAgaWYgKGhhc1RyYW5zZm9ybSgp KQogICAgICAgICBvdmVyZmxvd1JlY3QgPSBsYXllcigpLT5jdXJyZW50VHJhbnNmb3JtKCkubWFw UmVjdChvdmVyZmxvd1JlY3QpOwotICAgIHJldHVybiBvdmVyZmxvd1JlY3Q7CisgICAgcmV0dXJu IEludFJlY3Qob3ZlcmZsb3dSZWN0KTsKIH0KIAogaW50IFJlbmRlclZpZXc6OnZpZXdIZWlnaHQo KSBjb25zdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IGM2YmYyNDcyMjVhMGVlMjE3NDczZjFjZjRiNWQxNWY5Njk2ZTU0ZWQu LmRhOGRiMTQ3MDVlZjgyMzBjNzQ0YjY3NWFhNjFjOGNmMWQzMmI0ZTEgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyNCBAQAorMjAxMi0wNS0yNSAgSm9obiBLbm90dGVuYmVsdCAgPGprbm90dGVuQGNocm9taXVt Lm9yZz4KKworICAgICAgICBCb2R5IHNjcm9sbFdpZHRoKCkgYW5kIHNjcm9sbEhlaWdodCgpIHNo b3VsZCBiZSBwYWdlIHNjYWxlLWludmFyaWFudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc0OTQKKworICAgICAgICBSZW5kZXJWaWV3Ojpkb2N1bWVu dFJlY3QoKSBpcyBjYWxjdWxhdGluZyB0aGUgInNjYWxlZCIgZG9jdW1lbnQgcmVjdCBieSBhcHBs eWluZworICAgICAgICB0aGUgY3VycmVudCB0cmFuc2Zvcm1hdGlvbiBtYXRyaXggdG8gdGhlIHVu c2NhbGVkRG9jdW1lbnRSZWN0KCkgYW5kIHRoZW4KKyAgICAgICAgcmV0dXJuaW5nIHRoZSByb3Vu ZGVkLW91dCBJbnRSZWN0IHJlc3VsdC4KKworICAgICAgICBUaGlzIHJvdW5kaW5nIG91dCBpcyBp bmNvcnJlY3QgYmVjYXVzZSBpdCBhbGxvd3MgdGhlIHNjYWxlZCByZWN0YW5nbGUgdG8KKyAgICAg ICAgcmVwcmVzZW50IGFuIGFyZWEgdGhhdCBpcyBub3QgYWN0dWFsbHkgY292ZXJlZCBieSB0aGUg ZG9jdW1lbnQuCisKKyAgICAgICAgVGhpcyBpcyBldmlkZW5jZWQgYnkgdGhlIGRvY3VtZW50LmJv ZHkuc2Nyb2xsV2lkdGgoKSBhbmQKKyAgICAgICAgZG9jdW1lbnQuYm9keS5zY3JvbGxIZWlnaHQo KSBjaGFuZ2luZyB1bmRlciBwYWdlIHNjYWxlIGZhY3RvciB3aGVuCisgICAgICAgIHRoZXkgYXJl IGV4cGVjdGVkIHRvIHJlbWFpbiBpbnZhcmlhbnQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS93aW5kb3ctc2Nyb2xsLXNjYWxpbmct ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS93aW5kb3ctc2Nyb2xsLXNj YWxpbmcuaHRtbDogQWRkZWQuCisKIDIwMTItMDUtMjUgIENocmlzdG9waGUgRHVtZXogIDxjaHJp c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBmYXN0L2Zvcm1zL2NvbG9y L2lucHV0LXZhbHVlLXNhbml0aXphdGlvbi1jb2xvci5odG1sIGNhbiBiZSB1bnNraXBwZWQKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3dpbmRvdy1zY3JvbGwtc2NhbGluZy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS93aW5kb3ctc2Nyb2xsLXNjYWxpbmctZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQ3YTUwODMwZTQzNmJkMDFiNTAyMjI3NGY2OWMyNWJlNmYz Y2FlYjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS93aW5kb3ctc2Ny b2xsLXNjYWxpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTEgQEAKK1RoaXMgdGVzdCBlbnN1 cmVzIHRoYXQgZG9jdW1lbnQgY29udGVudCB3aWR0aCAoaGVpZ2h0KSBhcyByZXBvcnRlZCBieSBz Y3JvbGxXaWR0aCAoc2Nyb2xsSGVpZ2h0KSBpcyBpbnZhcmlhbnQgdG8gY2hhbmdlcyBpbiBwYWdl IHNjYWxlIGZhY3Rvci4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQ QVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgYm9k eS5zY3JvbGxXaWR0aCBpcyBvcmlnaW5hbFNjcm9sbFdpZHRoCitQQVNTIGJvZHkuc2Nyb2xsSGVp Z2h0IGlzIG9yaWdpbmFsU2Nyb2xsSGVpZ2h0CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0 cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20v d2luZG93LXNjcm9sbC1zY2FsaW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS93aW5kb3ct c2Nyb2xsLXNjYWxpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kNmJlNzkyZDNmNjc3N2QxMzQ0M2I1YjM4 YjQzZjk0ODhhODkxM2Q4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20v d2luZG93LXNjcm9sbC1zY2FsaW5nLmh0bWwKQEAgLTAsMCArMSwzOSBAQAorPGh0bWw+Cis8Ym9k eT4KKyAgICA8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj cmlwdD4KKyAgICA8c2NyaXB0PgorICAgICAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IGVuc3Vy ZXMgdGhhdCBkb2N1bWVudCBjb250ZW50IHdpZHRoIChoZWlnaHQpIGFzIHJlcG9ydGVkIGJ5IHNj cm9sbFdpZHRoIChzY3JvbGxIZWlnaHQpIGlzIGludmFyaWFudCB0byBjaGFuZ2VzIGluIHBhZ2Ug c2NhbGUgZmFjdG9yLiIpOworCisgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgICAg ICAgICAgd2luZG93LmludGVybmFscy5zZXR0aW5ncy5zZXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWQo dHJ1ZSk7CisKKyAgICAgICAgdmFyIGJvZHkgPSBkb2N1bWVudC5ib2R5OworCisgICAgICAgIC8v IEFjY29yZGluZyB0byBDU1NPTSAoaHR0cDovL2Rldi53My5vcmcvY3Nzd2cvY3Nzb20tdmlldy8j ZG9tLWVsZW1lbnQtc2Nyb2xsd2lkdGgpCisgICAgICAgIC8vIHRoZSBzY3JvbGxXaWR0aCBvZiB0 aGUgYm9keSBlbGVtZW50IChpbiBRdWlya3MgbW9kZSkgaXMgZGVmaW5lZCBhcworICAgICAgICAv LyAgICBtYXgoZG9jdW1lbnQgY29udGVudCB3aWR0aCwgdmFsdWUgb2YgaW5uZXJXaWR0aCkuCisg ICAgICAgIC8vIEluIHRoaXMgdGVzdCwgd2Ugd2FudCB0byBtZWFzdXJlIHRoZSBkb2N1bWVudCBj b250ZW50IHdpZHRoIChoZWlnaHQpLAorICAgICAgICAvLyByYXRoZXIgdGhhbiBpbm5lcldpZHRo IChpbm5lckhlaWdodCksIHNvIHdlIG1ha2UgdGhlIGJvZHkgZWxlbWVudAorICAgICAgICAvLyBs YXJnZXIgdGhhbiB0aGUgaW5uZXJXaWR0aCAoaW5uZXJIZWlnaHQpLgorCisgICAgICAgIGJvZHku c3R5bGVbIndpZHRoIl0gPSB3aW5kb3cuaW5uZXJXaWR0aCArIDEwMCArICJweCI7CisgICAgICAg IGJvZHkuc3R5bGVbImhlaWdodCJdID0gd2luZG93LmlubmVySGVpZ2h0ICsgMTAwICsgInB4IjsK KworICAgICAgICB2YXIgb3JpZ2luYWxTY3JvbGxXaWR0aCA9IGJvZHkuc2Nyb2xsV2lkdGg7Cisg ICAgICAgIHZhciBvcmlnaW5hbFNjcm9sbEhlaWdodCA9IGJvZHkuc2Nyb2xsSGVpZ2h0OworCisg ICAgICAgIHZhciBzY2FsZSA9IDEuMTsKKyAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCisg ICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRpbmdzLnNldFBhZ2VTY2FsZUZhY3Rvcihz Y2FsZSwgMCwgMCk7CisKKyAgICAgICAgLy8gQXMgd2UgaGF2ZSBpbmNyZWFzZWQgdGhlIHNjYWxl IGZhY3RvciwgdGhlIGlubmVyV2lkdGggd2lsbCBiZSBsZXNzCisgICAgICAgIC8vIGFzIGZld2Vy IENTUyBwaXhlbHMgd2lsbCBiZSByZW5kZXJlZCBpbiB0aGUgc2FtZSB2aWV3cG9ydCwgc28KKyAg ICAgICAgLy8gYm9keS5zY3JvbGxXaWR0aCAoc2Nyb2xsSGVpZ2h0KSB3aWxsIHN0aWxsIGJlIG1l YXN1cmluZyB0aGUgZG9jdW1lbnQKKyAgICAgICAgLy8gY29udGVudCB3aWR0aCAoaGVpZ2h0KS4K KworICAgICAgICBzaG91bGRCZSgiYm9keS5zY3JvbGxXaWR0aCIsICJvcmlnaW5hbFNjcm9sbFdp ZHRoIik7CisgICAgICAgIHNob3VsZEJlKCJib2R5LnNjcm9sbEhlaWdodCIsICJvcmlnaW5hbFNj cm9sbEhlaWdodCIpOworICAgIDwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi9qcy9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K 144060 2012-05-25 06:36:53 -0700 2012-05-25 14:49:09 -0700 Patch bug-87494-20120525143651.patch text/plain 6601 jknotten U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY1NDliZGZjNTQxZTA1 YzE0ZTk2OGQyMjkyOGQ4NzEwZDY0M2I2OS4uMTg4Yjc2NTVjNTYwN2Y2N2I5ZjA3YzMyODFlNTRi YzhlZTVhOWQ1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEyLTA1LTI1ICBKb2hu IEtub3R0ZW5iZWx0ICA8amtub3R0ZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEJvZHkgc2Ny b2xsV2lkdGgoKSBhbmQgc2Nyb2xsSGVpZ2h0KCkgc2hvdWxkIGJlIHBhZ2Ugc2NhbGUtaW52YXJp YW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzQ5 NAorCisgICAgICAgIFJlbmRlclZpZXc6OmRvY3VtZW50UmVjdCgpIGlzIGNhbGN1bGF0aW5nIHRo ZSAic2NhbGVkIiBkb2N1bWVudCByZWN0IGJ5IGFwcGx5aW5nCisgICAgICAgIHRoZSBjdXJyZW50 IHRyYW5zZm9ybWF0aW9uIG1hdHJpeCB0byB0aGUgdW5zY2FsZWREb2N1bWVudFJlY3QoKSBhbmQg dGhlbgorICAgICAgICByZXR1cm5pbmcgdGhlIHJvdW5kZWQtb3V0IEludFJlY3QgcmVzdWx0Lgor CisgICAgICAgIFRoaXMgcm91bmRpbmcgb3V0IGlzIGluY29ycmVjdCBiZWNhdXNlIGl0IGFsbG93 cyB0aGUgc2NhbGVkIHJlY3RhbmdsZSB0bworICAgICAgICByZXByZXNlbnQgYW4gYXJlYSB0aGF0 IGlzIG5vdCBhY3R1YWxseSBjb3ZlcmVkIGJ5IHRoZSBkb2N1bWVudC4KKworICAgICAgICBXZSBm aXggdGhpcyBieSBhcHBseWluZyB0aGUgY3VycmVudCB0cmFuc2Zvcm0gdG8gdGhlIGRvY3VtZW50 IHJlY3QKKyAgICAgICAgYXMgYSBGbG9hdFJlY3QgYW5kIHRoZW4gZXhwbGljaXRseSBjb252ZXJ0 aW5nIHRvIEludFJlY3QsIHdoaWNoCisgICAgICAgIHRha2VzIHRoZSBmbG9vciBvZiB0aGUgcmVz dWx0aW5nIHJlY3RhbmdsZSBjb29yZGluYXRlcyBpbnN0ZWFkIG9mCisgICAgICAgIHJvdW5kaW5n IHRoZW0gb3V0LgorCisgICAgICAgIFRoaXMgaXMgZXZpZGVuY2VkIGJ5IHRoZSBkb2N1bWVudC5i b2R5LnNjcm9sbFdpZHRoKCkgYW5kCisgICAgICAgIGRvY3VtZW50LmJvZHkuc2Nyb2xsSGVpZ2h0 KCkgY2hhbmdpbmcgdW5kZXIgcGFnZSBzY2FsZSBmYWN0b3Igd2hlbgorICAgICAgICB0aGV5IGFy ZSBleHBlY3RlZCB0byByZW1haW4gaW52YXJpYW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL3dpbmRvdy1zY3JvbGwtc2Nh bGluZy5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVmlldy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJWaWV3Ojpkb2N1bWVudFJlY3QpOgorCiAyMDEyLTA1LTI1ICBaYWxh biBCdWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KIAogICAgICAgICBbUXRdIEJyb2tlbiBjb250 cm9scyByZW5kZXJpbmcgd2hlbiB0cmFuc2Zvcm0gaXMgYXBwbGllZC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJWaWV3LmNwcAppbmRleCA4NjMzMTA0ZTNmMTE2YjRiYzU1OGI0NDc3MzA0 ZjI2M2UxNTNlNWYwLi45ZDhiZTRjMWIyOWQzMjc5ZjRjNDVlZGI3NTZjZTg0ZjU2M2EzZGU3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCkBAIC03MzMsMTAgKzczMywx MCBAQCBMYXlvdXRSZWN0IFJlbmRlclZpZXc6OmJhY2tncm91bmRSZWN0KFJlbmRlckJveCogYmFj a2dyb3VuZFJlbmRlcmVyKSBjb25zdAogCiBJbnRSZWN0IFJlbmRlclZpZXc6OmRvY3VtZW50UmVj dCgpIGNvbnN0CiB7Ci0gICAgSW50UmVjdCBvdmVyZmxvd1JlY3QodW5zY2FsZWREb2N1bWVudFJl Y3QoKSk7CisgICAgRmxvYXRSZWN0IG92ZXJmbG93UmVjdCh1bnNjYWxlZERvY3VtZW50UmVjdCgp KTsKICAgICBpZiAoaGFzVHJhbnNmb3JtKCkpCiAgICAgICAgIG92ZXJmbG93UmVjdCA9IGxheWVy KCktPmN1cnJlbnRUcmFuc2Zvcm0oKS5tYXBSZWN0KG92ZXJmbG93UmVjdCk7Ci0gICAgcmV0dXJu IG92ZXJmbG93UmVjdDsKKyAgICByZXR1cm4gSW50UmVjdChvdmVyZmxvd1JlY3QpOwogfQogCiBp bnQgUmVuZGVyVmlldzo6dmlld0hlaWdodCgpIGNvbnN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzZiZjI0NzIyNWEwZWUy MTc0NzNmMWNmNGI1ZDE1Zjk2OTZlNTRlZC4uMThjYjkxMmZlMWEwNzlkY2RjY2NmZjA3NDk2OGNk NWQ3NmZlMjJiZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTA1LTI1ICBKb2huIEtub3R0 ZW5iZWx0ICA8amtub3R0ZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEJvZHkgc2Nyb2xsV2lk dGgoKSBhbmQgc2Nyb2xsSGVpZ2h0KCkgc2hvdWxkIGJlIHBhZ2Ugc2NhbGUtaW52YXJpYW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzQ5NAorCisg ICAgICAgIFJlbmRlclZpZXc6OmRvY3VtZW50UmVjdCgpIGlzIGNhbGN1bGF0aW5nIHRoZSAic2Nh bGVkIiBkb2N1bWVudCByZWN0IGJ5IGFwcGx5aW5nCisgICAgICAgIHRoZSBjdXJyZW50IHRyYW5z Zm9ybWF0aW9uIG1hdHJpeCB0byB0aGUgdW5zY2FsZWREb2N1bWVudFJlY3QoKSBhbmQgdGhlbgor ICAgICAgICByZXR1cm5pbmcgdGhlIHJvdW5kZWQtb3V0IEludFJlY3QgcmVzdWx0LgorCisgICAg ICAgIFRoaXMgcm91bmRpbmcgb3V0IGlzIGluY29ycmVjdCBiZWNhdXNlIGl0IGFsbG93cyB0aGUg c2NhbGVkIHJlY3RhbmdsZSB0bworICAgICAgICByZXByZXNlbnQgYW4gYXJlYSB0aGF0IGlzIG5v dCBhY3R1YWxseSBjb3ZlcmVkIGJ5IHRoZSBkb2N1bWVudC4KKworICAgICAgICBXZSBmaXggdGhp cyBieSBhcHBseWluZyB0aGUgY3VycmVudCB0cmFuc2Zvcm0gdG8gdGhlIGRvY3VtZW50IHJlY3QK KyAgICAgICAgYXMgYSBGbG9hdFJlY3QgYW5kIHRoZW4gZXhwbGljaXRseSBjb252ZXJ0aW5nIHRv IEludFJlY3QsIHdoaWNoCisgICAgICAgIHRha2VzIHRoZSBmbG9vciBvZiB0aGUgcmVzdWx0aW5n IHJlY3RhbmdsZSBjb29yZGluYXRlcyBpbnN0ZWFkIG9mCisgICAgICAgIHJvdW5kaW5nIHRoZW0g b3V0LgorCisgICAgICAgIFRoaXMgaXMgZXZpZGVuY2VkIGJ5IHRoZSBkb2N1bWVudC5ib2R5LnNj cm9sbFdpZHRoKCkgYW5kCisgICAgICAgIGRvY3VtZW50LmJvZHkuc2Nyb2xsSGVpZ2h0KCkgY2hh bmdpbmcgdW5kZXIgcGFnZSBzY2FsZSBmYWN0b3Igd2hlbgorICAgICAgICB0aGV5IGFyZSBleHBl Y3RlZCB0byByZW1haW4gaW52YXJpYW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9kb20vd2luZG93LXNjcm9sbC1zY2FsaW5nLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vd2luZG93LXNjcm9sbC1zY2FsaW5n Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTA1LTI1ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3Bo ZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gZmFzdC9mb3Jtcy9jb2xvci9pbnB1 dC12YWx1ZS1zYW5pdGl6YXRpb24tY29sb3IuaHRtbCBjYW4gYmUgdW5za2lwcGVkCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS93aW5kb3ctc2Nyb2xsLXNjYWxpbmctZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vd2luZG93LXNjcm9sbC1zY2FsaW5nLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5kN2E1MDgzMGU0MzZiZDAxYjUwMjIyNzRmNjljMjViZTZmM2NhZWIy Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vd2luZG93LXNjcm9sbC1z Y2FsaW5nLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitUaGlzIHRlc3QgZW5zdXJlcyB0 aGF0IGRvY3VtZW50IGNvbnRlbnQgd2lkdGggKGhlaWdodCkgYXMgcmVwb3J0ZWQgYnkgc2Nyb2xs V2lkdGggKHNjcm9sbEhlaWdodCkgaXMgaW52YXJpYW50IHRvIGNoYW5nZXMgaW4gcGFnZSBzY2Fs ZSBmYWN0b3IuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGJvZHkuc2Ny b2xsV2lkdGggaXMgb3JpZ2luYWxTY3JvbGxXaWR0aAorUEFTUyBib2R5LnNjcm9sbEhlaWdodCBp cyBvcmlnaW5hbFNjcm9sbEhlaWdodAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3dpbmRv dy1zY3JvbGwtc2NhbGluZy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vd2luZG93LXNjcm9s bC1zY2FsaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDZiZTc5MmQzZjY3NzdkMTM0NDNiNWIzOGI0M2Y5 NDg4YTg5MTNkOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3dpbmRv dy1zY3JvbGwtc2NhbGluZy5odG1sCkBAIC0wLDAgKzEsMzkgQEAKKzxodG1sPgorPGJvZHk+Cisg ICAgPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+ CisgICAgPHNjcmlwdD4KKyAgICAgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdCBlbnN1cmVzIHRo YXQgZG9jdW1lbnQgY29udGVudCB3aWR0aCAoaGVpZ2h0KSBhcyByZXBvcnRlZCBieSBzY3JvbGxX aWR0aCAoc2Nyb2xsSGVpZ2h0KSBpcyBpbnZhcmlhbnQgdG8gY2hhbmdlcyBpbiBwYWdlIHNjYWxl IGZhY3Rvci4iKTsKKworICAgICAgICBpZiAod2luZG93LmludGVybmFscykKKyAgICAgICAgICAg IHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3Muc2V0TW9ja1Njcm9sbGJhcnNFbmFibGVkKHRydWUp OworCisgICAgICAgIHZhciBib2R5ID0gZG9jdW1lbnQuYm9keTsKKworICAgICAgICAvLyBBY2Nv cmRpbmcgdG8gQ1NTT00gKGh0dHA6Ly9kZXYudzMub3JnL2Nzc3dnL2Nzc29tLXZpZXcvI2RvbS1l bGVtZW50LXNjcm9sbHdpZHRoKQorICAgICAgICAvLyB0aGUgc2Nyb2xsV2lkdGggb2YgdGhlIGJv ZHkgZWxlbWVudCAoaW4gUXVpcmtzIG1vZGUpIGlzIGRlZmluZWQgYXMKKyAgICAgICAgLy8gICAg bWF4KGRvY3VtZW50IGNvbnRlbnQgd2lkdGgsIHZhbHVlIG9mIGlubmVyV2lkdGgpLgorICAgICAg ICAvLyBJbiB0aGlzIHRlc3QsIHdlIHdhbnQgdG8gbWVhc3VyZSB0aGUgZG9jdW1lbnQgY29udGVu dCB3aWR0aCAoaGVpZ2h0KSwKKyAgICAgICAgLy8gcmF0aGVyIHRoYW4gaW5uZXJXaWR0aCAoaW5u ZXJIZWlnaHQpLCBzbyB3ZSBtYWtlIHRoZSBib2R5IGVsZW1lbnQKKyAgICAgICAgLy8gbGFyZ2Vy IHRoYW4gdGhlIGlubmVyV2lkdGggKGlubmVySGVpZ2h0KS4KKworICAgICAgICBib2R5LnN0eWxl WyJ3aWR0aCJdID0gd2luZG93LmlubmVyV2lkdGggKyAxMDAgKyAicHgiOworICAgICAgICBib2R5 LnN0eWxlWyJoZWlnaHQiXSA9IHdpbmRvdy5pbm5lckhlaWdodCArIDEwMCArICJweCI7CisKKyAg ICAgICAgdmFyIG9yaWdpbmFsU2Nyb2xsV2lkdGggPSBib2R5LnNjcm9sbFdpZHRoOworICAgICAg ICB2YXIgb3JpZ2luYWxTY3JvbGxIZWlnaHQgPSBib2R5LnNjcm9sbEhlaWdodDsKKworICAgICAg ICB2YXIgc2NhbGUgPSAxLjE7CisgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgICAg ICAgICAgd2luZG93LmludGVybmFscy5zZXR0aW5ncy5zZXRQYWdlU2NhbGVGYWN0b3Ioc2NhbGUs IDAsIDApOworCisgICAgICAgIC8vIEFzIHdlIGhhdmUgaW5jcmVhc2VkIHRoZSBzY2FsZSBmYWN0 b3IsIHRoZSBpbm5lcldpZHRoIHdpbGwgYmUgbGVzcworICAgICAgICAvLyBhcyBmZXdlciBDU1Mg cGl4ZWxzIHdpbGwgYmUgcmVuZGVyZWQgaW4gdGhlIHNhbWUgdmlld3BvcnQsIHNvCisgICAgICAg IC8vIGJvZHkuc2Nyb2xsV2lkdGggKHNjcm9sbEhlaWdodCkgd2lsbCBzdGlsbCBiZSBtZWFzdXJp bmcgdGhlIGRvY3VtZW50CisgICAgICAgIC8vIGNvbnRlbnQgd2lkdGggKGhlaWdodCkuCisKKyAg ICAgICAgc2hvdWxkQmUoImJvZHkuc2Nyb2xsV2lkdGgiLCAib3JpZ2luYWxTY3JvbGxXaWR0aCIp OworICAgICAgICBzaG91bGRCZSgiYm9keS5zY3JvbGxIZWlnaHQiLCAib3JpZ2luYWxTY3JvbGxI ZWlnaHQiKTsKKyAgICA8L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==