87490 2012-05-25 04:53:08 -0700 Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chunk size for better transfer-snapshot metric 2012-05-25 06:42:56 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo abarth alph apavlov bweinstein haraken japhet joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 633829 0 loislo 2012-05-25 04:53:08 -0700 Originally WebInspector.Uint32Array was used for dynamic array reallocation because we had no information about expected arrays sizes. Now we have these sizes and allocates array precisely. 633830 1 loislo 2012-05-25 04:55:05 -0700 before: RESULT heap-snapshot: transfer-snapshot= 1809 ms after: RESULT heap-snapshot: transfer-snapshot= 1530 ms 633832 2 144046 loislo 2012-05-25 04:57:34 -0700 Created attachment 144046 Patch 633833 3 144046 yurys 2012-05-25 05:01:11 -0700 Comment on attachment 144046 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144046&action=review > Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:156 > var node_fields_count = this._snapshot.snapshot.meta.node_fields.length; node_fields_count -> nodeFieldCount > Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:157 > var nodes_length = this._snapshot.snapshot.node_count * node_fields_count; nodes_length -> nodeLength 633884 4 loislo 2012-05-25 06:42:56 -0700 Committed r118521: <http://trac.webkit.org/changeset/118521> 144046 2012-05-25 04:57:34 -0700 2012-05-25 05:01:11 -0700 Patch bug-87490-20120525155733.patch text/plain 5458 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmVkYzdjNGI5NzYwMGY1 MTA0OTQ2MmZhOWJjZGMyYmU2Y2VmYmMwNi4uOTNiMWU4YWM2YmFlMmEyOWM3NDJkMzA4ZDA0ZGQ0 NzJmN2RhODdlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTI1ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBkcm9wIG9ic29sZXRlIFdlYkluc3BlY3Rvci5VaW50MzJBcnJheSBhbmQgYWRqdXN0IHNu YXBzaG90IGNodW5rIHNpemUgZm9yIGJldHRlciB0cmFuc2Zlci1zbmFwc2hvdCBtZXRyaWMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzQ5MAorCisg ICAgICAgIE9yaWdpbmFsbHkgV2ViSW5zcGVjdG9yLlVpbnQzMkFycmF5IHdhcyB1c2VkIGZvciBk eW5hbWljIGFycmF5CisgICAgICAgIHJlYWxsb2NhdGlvbiBiZWNhdXNlIHdlIGhhZCBubyBpbmZv cm1hdGlvbiBhYm91dCBleHBlY3RlZCBhcnJheXMgc2l6ZXMuCisgICAgICAgIE5vdyB3ZSBoYXZl IHRoZXNlIHNpemVzIGFuZCBhbGxvY2F0ZXMgYXJyYXkgcHJlY2lzZWx5LgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0 SGVhcFNuYXBzaG90LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvSGVhcFNuYXBzaG90TG9hZGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkhlYXBTbmFwc2hvdExvYWRlcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90 TG9hZGVyLnByb3RvdHlwZS5fcGFyc2VVaW50QXJyYXkpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkhlYXBTbmFwc2hvdExvYWRlci5wcm90b3R5cGUucHVzaEpTT05DaHVuayk6CisKIDIwMTItMDUt MjUgIFRhaWp1IFRzdWlraSAgPHR6aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IERyb3AgSW5zcGVjdG9yRmlsZVN5c3RlbUluc3RydW1lbnRhdGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0SGVhcFNuYXBzaG90LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdEhlYXBTbmFwc2hvdC5jcHAKaW5kZXggNzY5 NzY0ZTgyYzFhNjk5ODVlZTdmMGRjYWUwMDZhZDMyMWQwMTEyMy4uMzY1YzczZDhkNTE2ZWI3ZjI2 NDYyZDJmZTk4MThjZWU2N2ZkZWRmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0SGVhcFNuYXBzaG90LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9TY3JpcHRIZWFwU25hcHNob3QuY3BwCkBAIC02OCw3ICs2OCw3IEBAIHB1YmxpYzoKICAg ICBPdXRwdXRTdHJlYW1BZGFwdGVyKFNjcmlwdEhlYXBTbmFwc2hvdDo6T3V0cHV0U3RyZWFtKiBv dXRwdXQpCiAgICAgICAgIDogbV9vdXRwdXQob3V0cHV0KSB7IH0KICAgICB2b2lkIEVuZE9mU3Ry ZWFtKCkgeyBtX291dHB1dC0+Q2xvc2UoKTsgfQotICAgIGludCBHZXRDaHVua1NpemUoKSB7IHJl dHVybiAxMDI0MDsgfQorICAgIGludCBHZXRDaHVua1NpemUoKSB7IHJldHVybiAxMDI0MDA7IH0K ICAgICBXcml0ZVJlc3VsdCBXcml0ZUFzY2lpQ2h1bmsoY2hhciogZGF0YSwgaW50IHNpemUpCiAg ICAgewogICAgICAgICBtX291dHB1dC0+V3JpdGUoU3RyaW5nKGRhdGEsIHNpemUpKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90TG9h ZGVyLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RM b2FkZXIuanMKaW5kZXggYzNiYTQ2NzdjYzU1MmY4NTJmZWJmNzdmNjA2MjQwZGI3MGJkN2VjYi4u MTY5OGMxMjE4NDkwYjI5YjQ3ZmI0MjUxYjhkNjgzMjlkYWYyMzhjMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RMb2FkZXIuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RMb2FkZXIu anMKQEAgLTM2LDYgKzM2LDggQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdExvYWRlciA9IGZ1 bmN0aW9uKCkKICAgICB0aGlzLl9qc29uID0gIiI7CiAgICAgdGhpcy5fc3RhdGUgPSAiZmluZC1z bmFwc2hvdC1pbmZvIjsKICAgICB0aGlzLl9zbmFwc2hvdCA9IHt9OworICAgIHRoaXMuX2FycmF5 ID0gbnVsbDsKKyAgICB0aGlzLl9hcnJheUluZGV4ID0gMDsKIH0KIAogV2ViSW5zcGVjdG9yLkhl YXBTbmFwc2hvdExvYWRlci5wcm90b3R5cGUgPSB7CkBAIC03Miw2ICs3NCw4IEBAIFdlYkluc3Bl Y3Rvci5IZWFwU25hcHNob3RMb2FkZXIucHJvdG90eXBlID0gewogICAgICAgICB2YXIgaW5kZXgg PSAwOwogICAgICAgICB2YXIgY2hhcjAgPSAiMCIuY2hhckNvZGVBdCgwKSwgY2hhcjkgPSAiOSIu Y2hhckNvZGVBdCgwKSwgY2xvc2luZ0JyYWNrZXQgPSAiXSIuY2hhckNvZGVBdCgwKTsKICAgICAg ICAgdmFyIGxlbmd0aCA9IHRoaXMuX2pzb24ubGVuZ3RoOworICAgICAgICB2YXIgYXJyYXkgPSB0 aGlzLl9hcnJheTsKKyAgICAgICAgdmFyIGFycmF5SW5kZXggPSB0aGlzLl9hcnJheUluZGV4Owog ICAgICAgICB3aGlsZSAodHJ1ZSkgewogICAgICAgICAgICAgd2hpbGUgKGluZGV4IDwgbGVuZ3Ro KSB7CiAgICAgICAgICAgICAgICAgdmFyIGNvZGUgPSB0aGlzLl9qc29uLmNoYXJDb2RlQXQoaW5k ZXgpOwpAQCAtODUsNiArODksNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90TG9hZGVyLnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmIChpbmRleCA9PT0gbGVu Z3RoKSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fanNvbiA9ICIiOworICAgICAgICAgICAgICAg IHRoaXMuX2FycmF5SW5kZXggPSBhcnJheUluZGV4OwogICAgICAgICAgICAgICAgIHJldHVybiB0 cnVlOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgdmFyIG5leHROdW1iZXIgPSAwOwpAQCAt OTksOSArMTA0LDEwIEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RMb2FkZXIucHJvdG90eXBl ID0gewogICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKGluZGV4ID09PSBsZW5ndGgpIHsK ICAgICAgICAgICAgICAgICB0aGlzLl9qc29uID0gdGhpcy5fanNvbi5zbGljZShzdGFydEluZGV4 KTsKKyAgICAgICAgICAgICAgICB0aGlzLl9hcnJheUluZGV4ID0gYXJyYXlJbmRleDsKICAgICAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHRoaXMu X2FycmF5LnB1c2gobmV4dE51bWJlcik7CisgICAgICAgICAgICBhcnJheVthcnJheUluZGV4Kytd ID0gbmV4dE51bWJlcjsKICAgICAgICAgfQogICAgIH0sCiAKQEAgLTE0OSw3ICsxNTUsOCBAQCBX ZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90TG9hZGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg IHRoaXMuX2pzb24gPSB0aGlzLl9qc29uLnNsaWNlKGJyYWNrZXRJbmRleCArIDEpOwogICAgICAg ICAgICAgdmFyIG5vZGVfZmllbGRzX2NvdW50ID0gdGhpcy5fc25hcHNob3Quc25hcHNob3QubWV0 YS5ub2RlX2ZpZWxkcy5sZW5ndGg7CiAgICAgICAgICAgICB2YXIgbm9kZXNfbGVuZ3RoID0gdGhp cy5fc25hcHNob3Quc25hcHNob3Qubm9kZV9jb3VudCAqIG5vZGVfZmllbGRzX2NvdW50OwotICAg ICAgICAgICAgdGhpcy5fYXJyYXkgPSBuZXcgV2ViSW5zcGVjdG9yLlVpbnQzMkFycmF5KG5vZGVz X2xlbmd0aCk7CisgICAgICAgICAgICB0aGlzLl9hcnJheSA9IG5ldyBVaW50MzJBcnJheShub2Rl c19sZW5ndGgpOworICAgICAgICAgICAgdGhpcy5fYXJyYXlJbmRleCA9IDA7CiAgICAgICAgICAg ICB0aGlzLl9zdGF0ZSA9ICJwYXJzZS1ub2RlcyI7CiAgICAgICAgICAgICB0aGlzLnB1c2hKU09O Q2h1bmsoIiIpOwogICAgICAgICAgICAgYnJlYWs7CkBAIC0xNTcsNyArMTY0LDcgQEAgV2ViSW5z cGVjdG9yLkhlYXBTbmFwc2hvdExvYWRlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIGNhc2UgInBh cnNlLW5vZGVzIjogewogICAgICAgICAgICAgaWYgKHRoaXMuX3BhcnNlVWludEFycmF5KCkpCiAg ICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgdGhpcy5fc25hcHNob3Qubm9kZXMg PSB0aGlzLl9hcnJheS5hcnJheTsKKyAgICAgICAgICAgIHRoaXMuX3NuYXBzaG90Lm5vZGVzID0g dGhpcy5fYXJyYXk7CiAgICAgICAgICAgICB0aGlzLl9zdGF0ZSA9ICJmaW5kLWVkZ2VzIjsKICAg ICAgICAgICAgIHRoaXMuX2FycmF5ID0gbnVsbDsKICAgICAgICAgICAgIHRoaXMucHVzaEpTT05D aHVuaygiIik7CkBAIC0xNzQsNyArMTgxLDggQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdExv YWRlci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0aGlzLl9qc29uID0gdGhpcy5fanNvbi5z bGljZShicmFja2V0SW5kZXggKyAxKTsKICAgICAgICAgICAgIHZhciBlZGdlX2ZpZWxkc19jb3Vu dCA9IHRoaXMuX3NuYXBzaG90LnNuYXBzaG90Lm1ldGEuZWRnZV9maWVsZHMubGVuZ3RoOwogICAg ICAgICAgICAgdmFyIGVkZ2VzX2xlbmd0aCA9IHRoaXMuX3NuYXBzaG90LnNuYXBzaG90LmVkZ2Vf Y291bnQgKiBlZGdlX2ZpZWxkc19jb3VudDsKLSAgICAgICAgICAgIHRoaXMuX2FycmF5ID0gbmV3 IFdlYkluc3BlY3Rvci5VaW50MzJBcnJheShlZGdlc19sZW5ndGgpOworICAgICAgICAgICAgdGhp cy5fYXJyYXkgPSBuZXcgVWludDMyQXJyYXkoZWRnZXNfbGVuZ3RoKTsKKyAgICAgICAgICAgIHRo aXMuX2FycmF5SW5kZXggPSAwOwogICAgICAgICAgICAgdGhpcy5fc3RhdGUgPSAicGFyc2UtZWRn ZXMiOwogICAgICAgICAgICAgdGhpcy5wdXNoSlNPTkNodW5rKCIiKTsKICAgICAgICAgICAgIGJy ZWFrOwpAQCAtMTgyLDcgKzE5MCw3IEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RMb2FkZXIu cHJvdG90eXBlID0gewogICAgICAgICBjYXNlICJwYXJzZS1lZGdlcyI6IHsKICAgICAgICAgICAg IGlmICh0aGlzLl9wYXJzZVVpbnRBcnJheSgpKQogICAgICAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgICAgIHRoaXMuX3NuYXBzaG90LmVkZ2VzID0gdGhpcy5fYXJyYXkuYXJyYXk7CisgICAg ICAgICAgICB0aGlzLl9zbmFwc2hvdC5lZGdlcyA9IHRoaXMuX2FycmF5OwogICAgICAgICAgICAg dGhpcy5fYXJyYXkgPSBudWxsOwogICAgICAgICAgICAgdGhpcy5fc3RhdGUgPSAiZmluZC1zdHJp bmdzIjsKICAgICAgICAgICAgIHRoaXMucHVzaEpTT05DaHVuaygiIik7Cg==