87482 2012-05-25 02:56:45 -0700 Web Inspector: HeapProfiler: speed-up _calculateClassesRetainedSize and _buildAggregates 2012-05-28 00:57:26 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo alph apavlov bweinstein joepeck keishi loislo oliver pfeldman pmuellr rik timothy yurys oldest_to_newest 633763 0 loislo 2012-05-25 02:56:45 -0700 engine didn't inline node's classIndex method because the switch statement in it wasn't inlineable. Before: RESULT heap-snapshot: _buildAggregates= 642 ms RESULT heap-snapshot: _calculateClassesRetainedSize= 738 ms After: RESULT heap-snapshot: _buildAggregates= 335 ms RESULT heap-snapshot: _calculateClassesRetainedSize= 411 ms 633764 1 144020 loislo 2012-05-25 03:00:02 -0700 Created attachment 144020 Patch 633785 2 loislo 2012-05-25 03:16:12 -0700 Committed r118509: <http://trac.webkit.org/changeset/118509> 634060 3 oliver 2012-05-25 10:47:02 -0700 I would have argued that that's an engine bug, and not necessarily something that we should be rewriting js for. 634966 4 yurys 2012-05-28 00:57:26 -0700 (In reply to comment #3) > I would have argued that that's an engine bug, and not necessarily something that we should be rewriting js for. This is definitely an engine's flaw but given that in this case we get a noticeable performance effect without affecting the code readability and that we don't have an estimation on when the bug may be fixed in the engine I think it makes sense to fix it this way. 144020 2012-05-25 03:00:02 -0700 2012-05-25 03:07:11 -0700 Patch bug-87482-20120525140000.patch text/plain 1818 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFmNTVhNGIzNGIxMjJm YjJiODVlYjdmY2MyNTQ2YzQ1M2ZiMTY0MC4uOTE0M2MxYWZiZWMzOGMzNjJkNzAxODk2ZmJjOGVk ZWYwY2EyNWJmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI1ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBIZWFwUHJvZmlsZXI6IHNwZWVkLXVwIF9jYWxjdWxhdGVDbGFzc2VzUmV0YWluZWRTaXpl IGFuZCBfYnVpbGRBZ2dyZWdhdGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODc0ODIKKworICAgICAgICBFbmdpbmUgZGlkbid0IGlubGluZSBub2Rl J3MgY2xhc3NJbmRleCBtZXRob2QgYmVjYXVzZSB0aGUgc3dpdGNoIHN0YXRlbWVudCBpbiBpdCB3 YXNuJ3QgaW5saW5lYWJsZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdE5vZGUucHJvdG90eXBlLmNsYXNzSW5kZXgpOgor CiAyMDEyLTA1LTI0ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbY2hyb21pdW1dIERhdGFUcmFuc2Zlckl0ZW0ud2Via2l0R2V0QXNFbnRyeSgpIHNob3Vs ZG4ndCBiZSBleHBvc2VkIHdpdGhvdXQgZmxhZyB5ZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMKaW5kZXggYjU5N2E1YTZmZmJiZGIx MzA5OTQxMzk5YzRiN2IyMDJjNjMyMTM4Yy4uY2VkNDYyOWEwNGY5MjJhZDY0M2YzYWM3ODlkMGQ3 NDE4Mzc4ZWI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9IZWFwU25hcHNob3QuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9IZWFwU25hcHNob3QuanMKQEAgLTQ1NiwxMyArNDU2LDkgQEAgV2ViSW5zcGVjdG9yLkhlYXBT bmFwc2hvdE5vZGUucHJvdG90eXBlID0gewogICAgICAgICB2YXIgc25hcHNob3QgPSB0aGlzLl9z bmFwc2hvdDsKICAgICAgICAgdmFyIG5vZGVzID0gc25hcHNob3QuX25vZGVzOwogICAgICAgICB2 YXIgdHlwZSA9IG5vZGVzW3RoaXMubm9kZUluZGV4ICsgc25hcHNob3QuX25vZGVUeXBlT2Zmc2V0 XTs7Ci0gICAgICAgIHN3aXRjaCAodHlwZSkgewotICAgICAgICBjYXNlIHNuYXBzaG90Ll9ub2Rl T2JqZWN0VHlwZToKLSAgICAgICAgY2FzZSBzbmFwc2hvdC5fbm9kZU5hdGl2ZVR5cGU6CisgICAg ICAgIGlmICh0eXBlID09PSBzbmFwc2hvdC5fbm9kZU9iamVjdFR5cGUgfHwgdHlwZSA9PT0gc25h cHNob3QuX25vZGVOYXRpdmVUeXBlKQogICAgICAgICAgICAgcmV0dXJuIG5vZGVzW3RoaXMubm9k ZUluZGV4ICsgc25hcHNob3QuX25vZGVOYW1lT2Zmc2V0XTsKLSAgICAgICAgZGVmYXVsdDoKLSAg ICAgICAgICAgIHJldHVybiAtMSAtIHR5cGU7Ci0gICAgICAgIH0KKyAgICAgICAgcmV0dXJuIC0x IC0gdHlwZTsKICAgICB9LAogCiAgICAgZG9taW5hdG9ySW5kZXg6IGZ1bmN0aW9uKCkK