87472 2012-05-25 01:22:05 -0700 [WK2] Fix client interface size for WKPageContextMenuClient 2012-05-25 03:05:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski andersca cgarcia webkit.review.bot oldest_to_newest 633681 0 g.czajkowski 2012-05-25 01:22:05 -0700 Add correct offset for version 1 and 2 of WKPageContextMenuClient. Revision 109750 introduces a new API and increases size of interfaceSizesByVersion but the table is not properly initialized for newly introduced version 2. 633684 1 144001 g.czajkowski 2012-05-25 01:23:44 -0700 Created attachment 144001 proposed patch 633727 2 144001 cgarcia 2012-05-25 02:18:20 -0700 Comment on attachment 144001 proposed patch Right, thanks! 633772 3 144001 webkit.review.bot 2012-05-25 03:05:30 -0700 Comment on attachment 144001 proposed patch Clearing flags on attachment: 144001 Committed r118506: <http://trac.webkit.org/changeset/118506> 633773 4 webkit.review.bot 2012-05-25 03:05:35 -0700 All reviewed patches have been landed. Closing bug. 144001 2012-05-25 01:23:44 -0700 2012-05-25 03:05:30 -0700 proposed patch fix_client_interface_size_wkpagecontentmenuclinet.patch text/plain 1443 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkYjVhYjE5Li5kNmJjY2EyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDUtMjUgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW1dLMl0gRml4IGNsaWVudCBpbnRlcmZhY2Ugc2l6ZSBmb3IgV0tQ YWdlQ29udGV4dE1lbnVDbGllbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NzQ3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZCBjb3JyZWN0IG9mZnNldCBmb3IgdmVyc2lvbiAxIGFuZCAyIG9mIFdL UGFnZUNvbnRleHRNZW51Q2xpZW50LgorICAgICAgICBSZXZpc2lvbiAxMDk3NTAgaW50cm9kdWNl cyBhIG5ldyBBUEkgYW5kIGluY3JlYXNlcyBzaXplIG9mIGludGVyZmFjZVNpemVzQnlWZXJzaW9u CisgICAgICAgIGJ1dCB0aGUgdGFibGUgaXMgbm90IHByb3Blcmx5IGluaXRpYWxpemVkIGZvciBu ZXdseSBpbnRyb2R1Y2VkIHZlcnNpb24gMi4KKworICAgICAgICAqIFNoYXJlZC9BUElDbGllbnRU cmFpdHMuY3BwOgorICAgICAgICAoV2ViS2l0KToKKwogMjAxMi0wNS0yNCAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgZmVhdHVyZSBkZWZpbmVz IGZvciB3ZWItZmFjaW5nIHBhcnRzIG9mIENTUyBSZWdpb25zIGFuZCBFeGNsdXNpb25zCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50VHJhaXRzLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9BUElDbGllbnRUcmFpdHMuY3BwCmluZGV4IDE1MWE5NDMuLjY5YzZi YmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUElDbGllbnRUcmFpdHMuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUElDbGllbnRUcmFpdHMuY3BwCkBAIC00OSw2 ICs0OSw3IEBAIGNvbnN0IHNpemVfdCBBUElDbGllbnRUcmFpdHM8V0tCdW5kbGVQYWdlRnVsbFNj cmVlbkNsaWVudD46OmludGVyZmFjZVNpemVzQnlWZXJzCiAgICAgCiBjb25zdCBzaXplX3QgQVBJ Q2xpZW50VHJhaXRzPFdLUGFnZUNvbnRleHRNZW51Q2xpZW50Pjo6aW50ZXJmYWNlU2l6ZXNCeVZl cnNpb25bXSA9IHsKICAgICBvZmZzZXRvZihXS1BhZ2VDb250ZXh0TWVudUNsaWVudCwgY29udGV4 dE1lbnVEaXNtaXNzZWQpLAorICAgIG9mZnNldG9mKFdLUGFnZUNvbnRleHRNZW51Q2xpZW50LCBn ZXRDb250ZXh0TWVudUZyb21Qcm9wb3NlZE1lbnUpLAogICAgIHNpemVvZihXS1BhZ2VDb250ZXh0 TWVudUNsaWVudCkKIH07CiAK