87471 2012-05-25 01:20:58 -0700 [EFL][DRT] Gardening. fast/events/option-tab.html does not pass 2012-05-25 02:41:36 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim lucas.de.marchi tmpsantos webkit.review.bot oldest_to_newest 633679 0 mikhail.pozdnyakov 2012-05-25 01:20:58 -0700 fast/events/option-tab.html was erroneously unskipped with r118404. Should not pass as the EFL port uses different keyboard accelerators than Safari. 633687 1 144003 mikhail.pozdnyakov 2012-05-25 01:25:18 -0700 Created attachment 144003 patch 633688 2 tmpsantos 2012-05-25 01:28:46 -0700 (In reply to comment #1) > Created an attachment (id=144003) [details] > patch Why this patch was tagged as [GTK]? 633689 3 mikhail.pozdnyakov 2012-05-25 01:29:30 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=144003) [details] [details] > > patch > > Why this patch was tagged as [GTK]? ooops.. 633693 4 144003 tmpsantos 2012-05-25 01:31:21 -0700 Comment on attachment 144003 patch View in context: https://bugs.webkit.org/attachment.cgi?id=144003&action=review > LayoutTests/platform/efl/test_expectations.txt:115 > +// The EFL port uses different keyboard accelerators than Safari (via Chromium). I don't get this comment. 633700 5 144005 mikhail.pozdnyakov 2012-05-25 01:36:24 -0700 Created attachment 144005 patch v2 (corrected bug title in changelog) 633717 6 mikhail.pozdnyakov 2012-05-25 01:56:10 -0700 (In reply to comment #4) > (From update of attachment 144003 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144003&action=review > > > LayoutTests/platform/efl/test_expectations.txt:115 > > +// The EFL port uses different keyboard accelerators than Safari (via Chromium). > > I don't get this comment. From the test case description: <p>This tests that option-tab moves you from a text field to a link, but plain old tab does not.</p> <p>Note: Option is the Mac name for what other platforms call Alt.</p> Other platforms do not have such behavior. (See also other ports test expectations). 633755 7 144005 webkit.review.bot 2012-05-25 02:41:31 -0700 Comment on attachment 144005 patch v2 (corrected bug title in changelog) Clearing flags on attachment: 144005 Committed r118502: <http://trac.webkit.org/changeset/118502> 633756 8 webkit.review.bot 2012-05-25 02:41:36 -0700 All reviewed patches have been landed. Closing bug. 144003 2012-05-25 01:25:18 -0700 2012-05-25 01:31:21 -0700 patch bug87471 text/plain 1618 mikhail.pozdnyakov Y29tbWl0IGYxNTg1NTJlMjJiNGQ1YzgzMTkxODBhOTFjNDU5Y2MwOTY5MWIyOWUKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg RnJpIE1heSAyNSAxMToyNDoxMyAyMDEyICswMzAwCgogICAgYnVnODc0NzEKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWUx YThlMy4uNDdkNTZlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTI1ICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtH VEtdW0VGTF0gR2FyZGVuaW5nLiBmYXN0L2V2ZW50cy9vcHRpb24tdGFiLmh0bWwgZG9lcyBub3Qg cGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc0 NzEKKworICAgICAgICBVbnJldmlld2VkLiBmYXN0L2V2ZW50cy9vcHRpb24tdGFiLmh0bWwgc2hv dWxkIG5vdCBwYXNzIGFzIHRoZSAKKyAgICAgICAgRUZMIHBvcnQgdXNlcyBkaWZmZXJlbnQga2V5 Ym9hcmQgYWNjZWxlcmF0b3JzIHRoYW4gU2FmYXJpICh2aWEgQ2hyb21pdW0pLgorCisgICAgICAg ICogcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMi0wNS0yNCAgTWlr aGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KIAogICAgICAg ICBbRUZMXSBbRFJUXSBrZXlib2FyZC1yZWxhdGVkIHRlc3RzIGRvIG5vdCBwYXNzCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCAzYTA2ZTkw Li5kNTFmOTFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBl Y3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0 aW9ucy50eHQKQEAgLTExMiw2ICsxMTIsOSBAQCBCVUdXS0VGTCBTS0lQIDogc3ZnL2N1c3RvbS9p bWFnZS13aXRoLXByZWZpeC1pbi13ZWJhcmNoaXZlLnN2ZyA9IEZBSUwKIC8vIEZlYXR1cmUgbm90 IG1hdHVyZSB5ZXQgYW5kIGRpc2FibGVkIGJ5IGRlZmF1bHQgb24gV2ViQ29yZQogQlVHV0s4NzA4 OCA6IGZhc3QvanMvbmFtZXMuaHRtbCA9IFRFWFQKIAorLy8gVGhlIEVGTCBwb3J0IHVzZXMgZGlm ZmVyZW50IGtleWJvYXJkIGFjY2VsZXJhdG9ycyB0aGFuIFNhZmFyaSAodmlhIENocm9taXVtKS4K K0JVR1dLRUZMIFNLSVAgOiBmYXN0L2V2ZW50cy9vcHRpb24tdGFiLmh0bWwgPSBGQUlMCisKIC8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogLy8gQ1JBU0hFUwogLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vCg== 144005 2012-05-25 01:36:24 -0700 2012-05-25 02:41:31 -0700 patch v2 (corrected bug title in changelog) bug87471 text/plain 1618 mikhail.pozdnyakov Y29tbWl0IGYxNTg1NTJlMjJiNGQ1YzgzMTkxODBhOTFjNDU5Y2MwOTY5MWIyOWUKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg RnJpIE1heSAyNSAxMToyNDoxMyAyMDEyICswMzAwCgogICAgYnVnODc0NzEKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWUx YThlMy4uNDdkNTZlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTI1ICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdW0RSVF0gR2FyZGVuaW5nLiBmYXN0L2V2ZW50cy9vcHRpb24tdGFiLmh0bWwgZG9lcyBub3Qg cGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc0 NzEKKworICAgICAgICBVbnJldmlld2VkLiBmYXN0L2V2ZW50cy9vcHRpb24tdGFiLmh0bWwgc2hv dWxkIG5vdCBwYXNzIGFzIHRoZSAKKyAgICAgICAgRUZMIHBvcnQgdXNlcyBkaWZmZXJlbnQga2V5 Ym9hcmQgYWNjZWxlcmF0b3JzIHRoYW4gU2FmYXJpICh2aWEgQ2hyb21pdW0pLgorCisgICAgICAg ICogcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMi0wNS0yNCAgTWlr aGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KIAogICAgICAg ICBbRUZMXSBbRFJUXSBrZXlib2FyZC1yZWxhdGVkIHRlc3RzIGRvIG5vdCBwYXNzCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCAzYTA2ZTkw Li5kNTFmOTFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBl Y3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0 aW9ucy50eHQKQEAgLTExMiw2ICsxMTIsOSBAQCBCVUdXS0VGTCBTS0lQIDogc3ZnL2N1c3RvbS9p bWFnZS13aXRoLXByZWZpeC1pbi13ZWJhcmNoaXZlLnN2ZyA9IEZBSUwKIC8vIEZlYXR1cmUgbm90 IG1hdHVyZSB5ZXQgYW5kIGRpc2FibGVkIGJ5IGRlZmF1bHQgb24gV2ViQ29yZQogQlVHV0s4NzA4 OCA6IGZhc3QvanMvbmFtZXMuaHRtbCA9IFRFWFQKIAorLy8gVGhlIEVGTCBwb3J0IHVzZXMgZGlm ZmVyZW50IGtleWJvYXJkIGFjY2VsZXJhdG9ycyB0aGFuIFNhZmFyaSAodmlhIENocm9taXVtKS4K K0JVR1dLRUZMIFNLSVAgOiBmYXN0L2V2ZW50cy9vcHRpb24tdGFiLmh0bWwgPSBGQUlMCisKIC8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogLy8gQ1JBU0hFUwogLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vCg==