87453 2012-05-24 20:13:37 -0700 configure.ac has duplicated AC_MSG_RESULT([$enable_sandbox]) and nothing for seamless iframes 2012-05-25 12:40:26 -0700 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton zan eric webkit.review.bot zan oldest_to_newest 633493 0 thorton 2012-05-24 20:13:37 -0700 # check whether to enable HTML5 sandbox iframe support AC_MSG_CHECKING([whether to enable HTML5 sandboxed iframe support]) AC_ARG_ENABLE(sandbox, AC_HELP_STRING([--enable-sandbox], [enable HTML5 sandboxed iframe support [default=yes]]), [],[enable_sandbox="yes"]) AC_MSG_RESULT([$enable_sandbox]) # check whether to enable HTML5 iframe seamless attribute support AC_MSG_CHECKING([whether to enable HTML5 iframe seamless attribute support]) AC_ARG_ENABLE(iframe-seamless, AC_HELP_STRING([--enable-iframe-seamless], [enable HTML5 iframe seamless attribute support [default=yes]]), [],[enable_iframe_seamless="yes"]) AC_MSG_RESULT([$enable_sandbox]) Note the two AC_MSG_RESULTs are the same; I think this is the result of a failed copy and paste. 633534 1 zan 2012-05-24 21:51:37 -0700 Thanks for spotting this, a stupid mistake made on my side. 633537 2 143968 zan 2012-05-24 21:52:41 -0700 Created attachment 143968 Patch 634182 3 143968 eric 2012-05-25 12:31:56 -0700 Comment on attachment 143968 Patch OK. 634193 4 143968 webkit.review.bot 2012-05-25 12:40:22 -0700 Comment on attachment 143968 Patch Clearing flags on attachment: 143968 Committed r118550: <http://trac.webkit.org/changeset/118550> 634194 5 webkit.review.bot 2012-05-25 12:40:26 -0700 All reviewed patches have been landed. Closing bug. 143968 2012-05-24 21:52:41 -0700 2012-05-25 12:40:22 -0700 Patch bug-87453-20120525065240.patch text/plain 1321 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDExODQ3 MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1 LTI0ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgY29u ZmlndXJlLmFjIGhhcyBkdXBsaWNhdGVkIEFDX01TR19SRVNVTFQoWyRlbmFibGVfc2FuZGJveF0p IGFuZCBub3RoaW5nIGZvciBzZWFtbGVzcyBpZnJhbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzQ1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcG9ydCB0aGUgdmFsdWUgb2YgJGVuYWJsZV9pZnJh bWVfc2VhbWxlc3MgcmF0aGVyIHRoYW4gJGVuYWJsZV9zYW5kYm94CisgICAgICAgIGFmdGVyIGNo ZWNraW5nIHdoZXRoZXIgdG8gZW5hYmxlIHRoZSBpZnJhbWUgc2VhbWxlc3Mgb3B0aW9uLgorCisg ICAgICAgICogY29uZmlndXJlLmFjOgorCiAyMDEyLTA1LTI0ICBQaGlsaXBwZSBOb3JtYW5kICA8 cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgLS1lbmFibGUtY3NzMy1m bGV4Ym94IGNvbmZpZ3VyZSBvcHRpb24gYWZ0ZXIgcjExODMwNC4KSW5kZXg6IGNvbmZpZ3VyZS5h Ywo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBjb25maWd1cmUuYWMJKHJldmlzaW9uIDExODQ3MCkKKysrIGNvbmZp Z3VyZS5hYwkod29ya2luZyBjb3B5KQpAQCAtNzM5LDcgKzczOSw3IEBAIEFDX0FSR19FTkFCTEUo aWZyYW1lLXNlYW1sZXNzLAogICAgICAgICAgICAgICBBQ19IRUxQX1NUUklORyhbLS1lbmFibGUt aWZyYW1lLXNlYW1sZXNzXSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgW2VuYWJsZSBI VE1MNSBpZnJhbWUgc2VhbWxlc3MgYXR0cmlidXRlIHN1cHBvcnQgW2RlZmF1bHQ9eWVzXV0pLAog ICAgICAgICAgICAgICBbXSxbZW5hYmxlX2lmcmFtZV9zZWFtbGVzcz0ieWVzIl0pCi1BQ19NU0df UkVTVUxUKFskZW5hYmxlX3NhbmRib3hdKQorQUNfTVNHX1JFU1VMVChbJGVuYWJsZV9pZnJhbWVf c2VhbWxlc3NdKQogCiAjIGNoZWNrIHdoZXRoZXIgdG8gZW5hYmxlIEhUTUw1IGF1ZGlvL3ZpZGVv IHN1cHBvcnQKIEFDX01TR19DSEVDS0lORyhbd2hldGhlciB0byBlbmFibGUgSFRNTDUgdmlkZW8g c3VwcG9ydF0pCg==