87448 2012-05-24 18:41:15 -0700 Presence of video tag causes DumpRenderTree to exit before calling onload handler 2020-05-04 07:46:50 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 kbr webkit-unassigned ap eric.carlson jer.noble oldest_to_newest 633447 0 143946 kbr 2012-05-24 18:41:15 -0700 Created attachment 143946 Test case; unzip in LayoutTests/fast/canvas/webgl It appears that if a <video> tag is present, DumpRenderTree will exit before calling the body's onload handler, unless layoutTestController.waitUntilDone() has been called. If waitUntilDone() is called within the body's onload handler, the test will exit early. Reproduced with Chromium port's DumpRenderTree implementation. Not sure whether it happens with other ports. Commenting out the video tag causes the onload handler to run 100% reliably. Calling waitUntilDone() in script executed during page load causes the test to run 100% reliably. See the attached test case; unzip in LayoutTests/fast/canvas/webgl. 633450 1 kbr 2012-05-24 18:43:50 -0700 Discovered while working on Bug 87042 and Bug 86877. 633604 2 fischman 2012-05-24 23:29:09 -0700 kbr: do you know if DRT's behavior is document somewhere vis-a-vis what it guarantees to execute before exiting when waitUntilDone() hasn't been called? 633967 3 eric.carlson 2012-05-25 08:49:36 -0700 The media element will block the document's 'load' event during setup and initial buffering, are you sure your onload handler is being called at all? 634025 4 kbr 2012-05-25 10:18:26 -0700 (In reply to comment #2) > kbr: do you know if DRT's behavior is document somewhere vis-a-vis what it guarantees to execute before exiting when waitUntilDone() hasn't been called? I don't know whether it's written down but it seems to be common knowledge among WebKit developers; jamesr told me that that is definitely the rule. 634029 5 fischman 2012-05-25 10:20:15 -0700 (In reply to comment #4) > (In reply to comment #2) > > kbr: do you know if DRT's behavior is document somewhere vis-a-vis what it guarantees to execute before exiting when waitUntilDone() hasn't been called? > > I don't know whether it's written down but it seems to be common knowledge among WebKit developers; jamesr told me that that is definitely the rule. Sorry, what is the common knowledge? (I really don't know what the contract is) 634033 6 kbr 2012-05-25 10:22:40 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > kbr: do you know if DRT's behavior is document somewhere vis-a-vis what it guarantees to execute before exiting when waitUntilDone() hasn't been called? > > > > I don't know whether it's written down but it seems to be common knowledge among WebKit developers; jamesr told me that that is definitely the rule. > > Sorry, what is the common knowledge? > (I really don't know what the contract is) Sorry; I meant that the onload handler is called before DRT exits. 634035 7 kbr 2012-05-25 10:23:26 -0700 (In reply to comment #3) > The media element will block the document's 'load' event during setup and initial buffering, are you sure your onload handler is being called at all? When the problem occurs, the onload handler is definitely not getting called. I'll upload a revised test case showing this. 634036 8 144096 kbr 2012-05-25 10:24:02 -0700 Created attachment 144096 Revised test case showing onload handler is not called 634051 9 eric.carlson 2012-05-25 10:41:40 -0700 (In reply to comment #7) > > When the problem occurs, the onload handler is definitely not getting called. I'll upload a revised test case showing this. So I'll bet that this is caused by the <video> element delaying the 'load' event while loading and parsing the initial portion of the file. As far as I know DRT does not wait for the 'load' event to be fired, that is what waitUntilDone() is for. 634058 10 fischman 2012-05-25 10:45:55 -0700 (In reply to comment #9) > As far as I know DRT does not wait for the 'load' event to be fired, that is what waitUntilDone() is for. Eric: what would you say DRTs contract is/should be? FWIW, http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree says: By default, DumpRenderTree dumps each test file immediately after the document has loaded and the load event handlers have executed. 634076 11 eric.carlson 2012-05-25 11:02:41 -0700 (In reply to comment #10) > (In reply to comment #9) > > As far as I know DRT does not wait for the 'load' event to be fired, that is what waitUntilDone() is for. > > Eric: what would you say DRTs contract is/should be? > FWIW, http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree says: > By default, DumpRenderTree dumps each test file immediately after the document has loaded and the load event handlers have executed. Silly me! 143946 2012-05-24 18:41:15 -0700 2012-05-25 10:24:02 -0700 Test case; unzip in LayoutTests/fast/canvas/webgl video-race-test.zip application/octet-stream 1498 kbr UEsDBBQAAAAIACaUuEDm4AxksQMAACgJAAAUABwAdmlkZW8tcmFjZS10ZXN0Lmh0bWxVVAkAA1fh vk8u4b5PdXgLAAEEi3wBAASIEwAAlVbfb9s2EH7XX3Hhi53CltIsKALEDrAlHlBg6IrOfdgjLZ4k tjQpkJQdo8j/viMl2ZK3th5hQCDv7rtf35FeXD3/+bT+++MKKr9Vj8mi/yAX9Nmi55BX3Dr0S9b4 Yn7P6FhJ/RUsqiVz/qDQVYieQWWxWLI0zej3xWUWnWlsjo42c4/Oz6NymjvHMgJxuZW1B2fzHxrV FtMvjj0ustbgaPmYZBmsK+lgo0z+FUwBuRE4g32FGmrFcxRQoaWTnDcOHfgKIWCCN2AbHTKQfKMO aUD6CxG4cgZK1Gi5xzVpTq9nsEFl9qTyJpEFTPdSC9oqfjCNDypPRntrlEJ7Dd8SoPVfslQ02/pX t8YXwnz4vtqeS/9Ze6mejcag+Zq8yZKkaHTupdFQSC1d1YbWudtxC1hLZcoGYQnC5M0WtU9zi5TF SmHYTVlbNNY57w1So5Xhgux6F0fcsH6W8VHxuwlp42Vx6LMJaq9nERAByP0PKWCcDxxoDY8Jbow4 pLyuUYunSiox7SFj2U41Gzc0+ZZEGGr5++KiJgBRLOckEVBYs400asvWA1VcCzKcRRER1qHOMRAy 7HdSoAHPy56Gz0SFTxQ02rUl0hEZG9cQ/qGHwxfpiXaFsRh4qqUuB057b2nSJnIhK/8HMy9nZ+xn F0fgIbHTj7gUJacABLY0DLLJJ6ytEQ1VytKs0vBqIWPD9tJXXdmwpS9QyheFNKGgjt5CRC3MYCxK 9N1M/HZ4L6aMFNgg71DNq2g0LFxYgYq/c0k0mLIP5tTWoXVYwxEdSyz6xurT2esp0gCWciFWOwrs D+l84Ox0ZM3oSjsQFdhsNKuBIdFZG/QDvBINbRyCMboypqZCBNm5KCAP2hmz6KdnDH/Wz1CTj9y5 UJMuPMCQAlXB4qiw/y5L56mtSqROmNvBPZ91r1AY9I78y8l4mqnjpJBzveMOpFgyfOHbWiEjEglf Ldkvt/ULPU0oy8p3O3pKWgOyFHIXzQbEDHI6HgiJmc4QZi9IFlfzOTyZbWBRSJloeTbq8dFo35Of PD5tgaYWa2N9O+n8HC03jRJAVynhQmEaLa5TmM8pEoqlVevSfXd3c8r29vaexQQCx8N8haGhrAEW 7RXbPr6nC5daNi/pTtLptr5j1N5DjctJdJDRyUN8YHO3ZHyXv03vblc3b1czIAlP727SWzaB7CL0 PW62u/o+ftnISzg5uSGdGeyM3Uh3MTZVzliemnJ3loApyxNyqzUGX2RRsa1qFkgXORj/EP0DUEsD BBQAAAAIAAGUuEBRDgSBswAAAPMAAAAcABwAdmlkZW8tcmFjZS10ZXN0LWV4cGVjdGVkLnR4dFVU CQADEuG+TyPhvk91eAsAAQSLfAEABIgTAABVjsFqwzAQRO/6isGnBkr+oaS+tcTE7geo1jpdUHaD tIrx33dDcsllLvN4Mye6Fk1tJpToMaskNlbByvaHGydSUKYLiSFKQo6bNpuo2kHFiuZMZb9Gth8x zp8q9LYL4SiobZ6p1nc477KcUYkQPQtThS7oho9x7HBxKp7JycVtulLC74Zu6scJh+P38NVPfbcP 4U7j6vssZ9DtfmjhQulRPOeWlvM2xFLdwhVWGoXwogrhH1BLAQIeAxQAAAAIACaUuEDm4AxksQMA ACgJAAAUABgAAAAAAAEAAACkgQAAAAB2aWRlby1yYWNlLXRlc3QuaHRtbFVUBQADV+G+T3V4CwAB BIt8AQAEiBMAAFBLAQIeAxQAAAAIAAGUuEBRDgSBswAAAPMAAAAcABgAAAAAAAEAAACkgf8DAAB2 aWRlby1yYWNlLXRlc3QtZXhwZWN0ZWQudHh0VVQFAAMS4b5PdXgLAAEEi3wBAASIEwAAUEsFBgAA AAACAAIAvAAAAAgFAAAAAA== 144096 2012-05-25 10:24:02 -0700 2012-05-25 10:24:02 -0700 Revised test case showing onload handler is not called video-race-test.zip application/octet-stream 1519 kbr UEsDBBQAAAAIAJpSuUBxCW5UuwMAAEsJAAAUABwAdmlkZW8tcmFjZS10ZXN0Lmh0bWxVVAkAA3S/ v094v79PdXgLAAEEi3wBAASIEwAAlVbfb9s2EH7XX3Hhi53CllIvGALEDrAl3lBg2IrOe9gjLZ4s tjQpkJQdo8j/viMpxZa3pp5gQBDv7rtf3x09v3r643H198cl1H6rHrJ5/0Iu6LVFz6GsuXXoF6z1 1fSO0bGS+gtYVAvm/EGhqxE9g9pitWB5XtDvsyssOtPaEh19TD06P43KeekcKwjElVY2Hpwt3zRq LOafHXuYF8ng1fIhKwpY1dLBWpnyC5gKSiNwAvsaNTSKlyigRksnJW8dOvA1QsAEb8C2OmQg+Vod 8oD0JyJw5QxsUKPlHlekOb6ewBqV2ZPKu0xWMN5LLehT8YNpfVB5NNpboxTaa/iaAT3/JctFu21+ cit8Jsz7b6vtufR/aS/Vk9EYNF+yd0WWVa0uvTQaKqmlq1Nonbsdt4CNVGbTIixAmLLdovZ5aZGy WCoMX2OWisY6571BbrQyXJBd7+IVNzzfy/hV8ZsJaeNldeizCWovZxEQAcj9mxQwzgcOJMPXBNdG HHLeNKjFYy2VGPeQsWzHmg0bmqXsBKaChIxHn7CxRrQlgiXWEI20kNF0L30NOynQAKZCAtfiotaN KIroibj1obrIBIjLJSeJgMqabeRr6k8PVJN3MpxEEU2GQ03xEvPDd4rT803P9yfi3CeqDtqVJXYT 61vXEv6hh8Nn6YnflbEYBkJLvTlx2nvLs5TIhfT/HyNw+RhE4nRxBMLTGPgBaaPkGEDgzUfuHIox +9V40qfsg9H4mvWN6bFS3U4mZ4O+G5ufDx8IgBTYScShDlfR6DTl3usvXKrg9XdzbMipdXhOp3go sehbq49nL8dIA1jOhVjuKLDfpPOB1uOBNaOtd6AmsslgnENvo7MU9D28EIFsnJMhujKmoUIE2bko IJ80ImbRD9gQ/o1OdOEBhhSoChYHhf13WTpPqSqxf2G0T66Coruowi7oaLsYDQeeRpEUSq533IEU C4bPfNsoZDTdwtcL9sOseabbC+Wm9t0X3TbJgCyF3EWzk40R5HR8IqSV4Qxh9oJsfjWdwqPZBhaF lInjZ0Ma75V05XznfkoFGltsjPVpRvk5WmlaJYC2LeFCZVotrnOYTikSiiWpden+eHtzzHY2u2Mx gcDxsPjCBFLWAPO0hdP9fNzJ1LLphraJzrfNLaP2HhpcjKKDgk7u4x1cugXju/J9fjtb3rxfToAk PL+9yWdsBMVF6Htcb3fNXXyzgZdwcnRDOhPYGbuW7mJsqpyxPDeb3VkCZrM5IietIfi8iIqpqkUg XeRg/M/0D1BLAwQUAAAACACSUrlAyx0k9b4AAAAIAQAAHAAcAHZpZGVvLXJhY2UtdGVzdC1leHBl Y3RlZC50eHRVVAkAA2S/v094v79PdXgLAAEEi3wBAASIEwAAVY5BTsNADEX3c4qvrEBCvQMqERtQ oyY9wJBxiqWpXc14GuX2dYENm7/4fnr+R7oWTW0mlOgxqyQ2VsHK9o0bJ1JQpguJIUpCjps2m6ja XsWK5kxlt0a2kxjnNxV6eg7hIKhtnqnWFzjvspxRiRA9C1OFLuiG13HscHEqnsnJxW26UsLXhm7q xwn7w+fw0U99twvhQeNdDSymHmz+6ae8+iiWM+j2WLlwofR7+NuwtJy3IZbqaq6w0iiEf/4Q7lBL AQIeAxQAAAAIAJpSuUBxCW5UuwMAAEsJAAAUABgAAAAAAAEAAACkgQAAAAB2aWRlby1yYWNlLXRl c3QuaHRtbFVUBQADdL+/T3V4CwABBIt8AQAEiBMAAFBLAQIeAxQAAAAIAJJSuUDLHST1vgAAAAgB AAAcABgAAAAAAAEAAACkgQkEAAB2aWRlby1yYWNlLXRlc3QtZXhwZWN0ZWQudHh0VVQFAANkv79P dXgLAAEEi3wBAASIEwAAUEsFBgAAAAACAAIAvAAAAB0FAAAAAA==