87447 2012-05-24 18:38:14 -0700 Change RenderBoxModelObject to compute relativePositionOffset as size 2012-05-25 12:41:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae eric jchaffraix simon.fraser webkit.review.bot oldest_to_newest 633446 0 eae 2012-05-24 18:38:14 -0700 Change RenderBoxModelObject to compute relativePositionOffset as size. 634074 1 144101 eae 2012-05-25 11:02:35 -0700 Created attachment 144101 Patch 634160 2 144101 eric 2012-05-25 12:16:45 -0700 Comment on attachment 144101 Patch Fantastic! 634196 3 144101 webkit.review.bot 2012-05-25 12:41:20 -0700 Comment on attachment 144101 Patch Clearing flags on attachment: 144101 Committed r118551: <http://trac.webkit.org/changeset/118551> 634197 4 webkit.review.bot 2012-05-25 12:41:24 -0700 All reviewed patches have been landed. Closing bug. 144101 2012-05-25 11:02:35 -0700 2012-05-25 12:41:20 -0700 Patch bug-87447-20120525110234.patch text/plain 7295 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODQ1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA1LTI0ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2UgUmVuZGVyQm94TW9k ZWxPYmplY3QgdG8gY29tcHV0ZSByZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0IGFzIHNpemUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NDQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcHV0ZSByZWxhdGl2 ZVBvc2l0aW9uT2Zmc2V0IGFzIHNpemUgaW5zdGVhZCBvZiBkb2luZyBvbmUgYXhpcyBhdCBhCisg ICAgICAgIHRpbWUgYXMgYWxsIGNhbGwgc2l0ZXMgdXNlcyB0aGUgc2l6ZSB2ZXJzaW9uIG9mIHRo ZSBtZXRob2QuIFRoaXMgYXZvaWRzCisgICAgICAgIGhhdmluZyB0byB3YWxrIHRoZSBET00gdHdp Y2UgdG8gYWNjdW11bGF0ZSB0aGUgb2Zmc2V0cy4KKworICAgICAgICBBbHNvIHJlbW92ZSB0aGUg cmVsYXRpdmVQb3NpdGlvbk9mZnNldFggYW5kIFkgbWV0aG9kcyBhcyB0aGV5IGFyZSBubworICAg ICAgICBsb25nZXIgdXNlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckJveDo6bGF5b3V0T3ZlcmZsb3dSZWN0Rm9yUHJvcGFnYXRpb24p OgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjphY2N1bXVsYXRlUmVsYXRpdmVQb3NpdGlvbk9mZnNldHMpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OnJlbGF0aXZlUG9zaXRpb25PZmZzZXQpOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oOgorICAgICAgICAoUmVu ZGVyQm94TW9kZWxPYmplY3QpOgorCiAyMDEyLTA1LTI0ICBLZXZpbiBPbGxpdmllciAgPGtldmlu b0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFt3eF0gVW5yZXZpZXdlZCBidWlsZCBmaXgu IEFkZCBjb250ZXh0TWVudUl0ZW1WZWN0b3Igc3R1Yi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCb3guY3BwCShyZXZpc2lvbiAxMTg0MTEpCisrKyBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc2Niw3ICszNzY2LDcg QEAgTGF5b3V0UmVjdCBSZW5kZXJCb3g6OmxheW91dE92ZXJmbG93UmVjdAogICAgICAgICAgICAg cmVjdCA9IGxheWVyKCktPmN1cnJlbnRUcmFuc2Zvcm0oKS5tYXBSZWN0KHJlY3QpOwogCiAgICAg ICAgIGlmIChpc1JlbFBvc2l0aW9uZWQoKSkKLSAgICAgICAgICAgIHJlY3QubW92ZShyZWxhdGl2 ZVBvc2l0aW9uT2Zmc2V0WCgpLCByZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0WSgpKTsKKyAgICAgICAg ICAgIHJlY3QubW92ZShyZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0KCkpOwogICAgICAgICAKICAgICAg ICAgLy8gTm93IHdlIG5lZWQgdG8gZmxpcCBiYWNrLgogICAgICAgICBmbGlwRm9yV3JpdGluZ01v ZGUocmVjdCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxP YmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC b3hNb2RlbE9iamVjdC5jcHAJKHJldmlzaW9uIDExODQxMSkKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2Myw0 OCArNDYzLDQxIEBAIHZvaWQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OnVwZGF0ZUJveE1vZGUKICAg ICBzZXRIb3Jpem9udGFsV3JpdGluZ01vZGUoc3R5bGVUb1VzZS0+aXNIb3Jpem9udGFsV3JpdGlu Z01vZGUoKSk7CiB9CiAKLWVudW0gUmVsUG9zQXhpcyB7IFJlbFBvc1gsIFJlbFBvc1kgfTsKLQot c3RhdGljIExheW91dFVuaXQgYWNjdW11bGF0ZVJlbGF0aXZlUG9zaXRpb25PZmZzZXRzKGNvbnN0 IFJlbmRlck9iamVjdCogY2hpbGQsIFJlbFBvc0F4aXMgYXhpcykKK3N0YXRpYyBMYXlvdXRTaXpl IGFjY3VtdWxhdGVSZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0cyhjb25zdCBSZW5kZXJPYmplY3QqIGNo aWxkKQogewogICAgIGlmICghY2hpbGQtPmlzQW5vbnltb3VzQmxvY2soKSB8fCAhY2hpbGQtPmlz UmVsUG9zaXRpb25lZCgpKQotICAgICAgICByZXR1cm4gMDsKLSAgICBMYXlvdXRVbml0IG9mZnNl dCA9IFpFUk9fTEFZT1VUX1VOSVQ7CisgICAgICAgIHJldHVybiBMYXlvdXRTaXplKCk7CisgICAg TGF5b3V0U2l6ZSBvZmZzZXQ7CiAgICAgUmVuZGVyT2JqZWN0KiBwID0gdG9SZW5kZXJCbG9jayhj aGlsZCktPmlubGluZUVsZW1lbnRDb250aW51YXRpb24oKTsKICAgICB3aGlsZSAocCAmJiBwLT5p c1JlbmRlcklubGluZSgpKSB7Ci0gICAgICAgIGlmIChwLT5pc1JlbFBvc2l0aW9uZWQoKSkKLSAg ICAgICAgICAgIG9mZnNldCArPSAoYXhpcyA9PSBSZWxQb3NYKSA/IHRvUmVuZGVySW5saW5lKHAp LT5yZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0WCgpIDogdG9SZW5kZXJJbmxpbmUocCktPnJlbGF0aXZl UG9zaXRpb25PZmZzZXRZKCk7CisgICAgICAgIGlmIChwLT5pc1JlbFBvc2l0aW9uZWQoKSkgewor ICAgICAgICAgICAgUmVuZGVySW5saW5lKiByZW5kZXJJbmxpbmUgPSB0b1JlbmRlcklubGluZShw KTsKKyAgICAgICAgICAgIG9mZnNldCArPSByZW5kZXJJbmxpbmUtPnJlbGF0aXZlUG9zaXRpb25P ZmZzZXQoKTsKKyAgICAgICAgfQogICAgICAgICBwID0gcC0+cGFyZW50KCk7CiAgICAgfQogICAg IHJldHVybiBvZmZzZXQ7CiB9CiAKLUxheW91dFVuaXQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OnJl bGF0aXZlUG9zaXRpb25PZmZzZXRYKCkgY29uc3QKK0xheW91dFNpemUgUmVuZGVyQm94TW9kZWxP YmplY3Q6OnJlbGF0aXZlUG9zaXRpb25PZmZzZXQoKSBjb25zdAogewotICAgIExheW91dFVuaXQg b2Zmc2V0ID0gYWNjdW11bGF0ZVJlbGF0aXZlUG9zaXRpb25PZmZzZXRzKHRoaXMsIFJlbFBvc1gp OworICAgIExheW91dFNpemUgb2Zmc2V0ID0gYWNjdW11bGF0ZVJlbGF0aXZlUG9zaXRpb25PZmZz ZXRzKHRoaXMpOworCisgICAgUmVuZGVyQmxvY2sqIGNvbnRhaW5pbmdCbG9jayA9IHRoaXMtPmNv bnRhaW5pbmdCbG9jaygpOwogCiAgICAgLy8gT2JqZWN0cyB0aGF0IHNocmluayB0byBhdm9pZCBm bG9hdHMgbm9ybWFsbHkgdXNlIGF2YWlsYWJsZSBsaW5lIHdpZHRoIHdoZW4gY29tcHV0aW5nIGNv bnRhaW5pbmcgYmxvY2sgd2lkdGguICBIb3dldmVyCiAgICAgLy8gaW4gdGhlIGNhc2Ugb2YgcmVs YXRpdmUgcG9zaXRpb25pbmcgdXNpbmcgcGVyY2VudGFnZXMsIHdlIGNhbid0IGRvIHRoaXMuICBU aGUgb2Zmc2V0IHNob3VsZCBhbHdheXMgYmUgcmVzb2x2ZWQgdXNpbmcgdGhlCiAgICAgLy8gYXZh aWxhYmxlIHdpZHRoIG9mIHRoZSBjb250YWluaW5nIGJsb2NrLiAgVGhlcmVmb3JlIHdlIGRvbid0 IHVzZSBjb250YWluaW5nQmxvY2tMb2dpY2FsV2lkdGhGb3JDb250ZW50KCkgaGVyZSwgYnV0IGlu c3RlYWQgZXhwbGljaXRseQogICAgIC8vIGNhbGwgYXZhaWxhYmxlV2lkdGggb24gb3VyIGNvbnRh aW5pbmcgYmxvY2suCiAgICAgaWYgKCFzdHlsZSgpLT5sZWZ0KCkuaXNBdXRvKCkpIHsKLSAgICAg ICAgUmVuZGVyQmxvY2sqIGNiID0gY29udGFpbmluZ0Jsb2NrKCk7Ci0gICAgICAgIGlmICghc3R5 bGUoKS0+cmlnaHQoKS5pc0F1dG8oKSAmJiAhY2ItPnN0eWxlKCktPmlzTGVmdFRvUmlnaHREaXJl Y3Rpb24oKSkKLSAgICAgICAgICAgIHJldHVybiAtdmFsdWVGb3JMZW5ndGgoc3R5bGUoKS0+cmln aHQoKSwgY2ItPmF2YWlsYWJsZVdpZHRoKCksIHZpZXcoKSk7Ci0gICAgICAgIHJldHVybiBvZmZz ZXQgKyB2YWx1ZUZvckxlbmd0aChzdHlsZSgpLT5sZWZ0KCksIGNiLT5hdmFpbGFibGVXaWR0aCgp LCB2aWV3KCkpOwotICAgIH0KLSAgICBpZiAoIXN0eWxlKCktPnJpZ2h0KCkuaXNBdXRvKCkpIHsK LSAgICAgICAgUmVuZGVyQmxvY2sqIGNiID0gY29udGFpbmluZ0Jsb2NrKCk7Ci0gICAgICAgIHJl dHVybiBvZmZzZXQgKyAtdmFsdWVGb3JMZW5ndGgoc3R5bGUoKS0+cmlnaHQoKSwgY2ItPmF2YWls YWJsZVdpZHRoKCksIHZpZXcoKSk7CisgICAgICAgIGlmICghc3R5bGUoKS0+cmlnaHQoKS5pc0F1 dG8oKSAmJiAhY29udGFpbmluZ0Jsb2NrLT5zdHlsZSgpLT5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9u KCkpCisgICAgICAgICAgICBvZmZzZXQuc2V0V2lkdGgoLXZhbHVlRm9yTGVuZ3RoKHN0eWxlKCkt PnJpZ2h0KCksIGNvbnRhaW5pbmdCbG9jay0+YXZhaWxhYmxlV2lkdGgoKSwgdmlldygpKSk7Cisg ICAgICAgIGVsc2UKKyAgICAgICAgICAgIG9mZnNldC5leHBhbmQodmFsdWVGb3JMZW5ndGgoc3R5 bGUoKS0+bGVmdCgpLCBjb250YWluaW5nQmxvY2stPmF2YWlsYWJsZVdpZHRoKCksIHZpZXcoKSks IDApOworICAgIH0gZWxzZSBpZiAoIXN0eWxlKCktPnJpZ2h0KCkuaXNBdXRvKCkpIHsKKyAgICAg ICAgb2Zmc2V0LmV4cGFuZCgtdmFsdWVGb3JMZW5ndGgoc3R5bGUoKS0+cmlnaHQoKSwgY29udGFp bmluZ0Jsb2NrLT5hdmFpbGFibGVXaWR0aCgpLCB2aWV3KCkpLCAwKTsKICAgICB9Ci0gICAgcmV0 dXJuIG9mZnNldDsKLX0KIAotTGF5b3V0VW5pdCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6cmVsYXRp dmVQb3NpdGlvbk9mZnNldFkoKSBjb25zdAotewotICAgIExheW91dFVuaXQgb2Zmc2V0ID0gYWNj dW11bGF0ZVJlbGF0aXZlUG9zaXRpb25PZmZzZXRzKHRoaXMsIFJlbFBvc1kpOwotICAgIAotICAg IFJlbmRlckJsb2NrKiBjb250YWluaW5nQmxvY2sgPSB0aGlzLT5jb250YWluaW5nQmxvY2soKTsK ICAgICAvLyBJZiB0aGUgY29udGFpbmluZyBibG9jayBvZiBhIHJlbGF0aXZlbHkgcG9zaXRpb25l ZCBlbGVtZW50IGRvZXMgbm90CiAgICAgLy8gc3BlY2lmeSBhIGhlaWdodCwgYSBwZXJjZW50YWdl IHRvcCBvciBib3R0b20gb2Zmc2V0IHNob3VsZCBiZSByZXNvbHZlZCBhcwogICAgIC8vIGF1dG8u IEFuIGV4Y2VwdGlvbiB0byB0aGlzIGlzIGlmIHRoZSBjb250YWluaW5nIGJsb2NrIGhhcyB0aGUg V2luSUUgcXVpcmsKQEAgLTUxNSwxMyArNTA4LDEzIEBAIExheW91dFVuaXQgUmVuZGVyQm94TW9k ZWxPYmplY3Q6OnJlbGF0aXYKICAgICAgICAgJiYgKCFjb250YWluaW5nQmxvY2stPnN0eWxlKCkt PmhlaWdodCgpLmlzQXV0bygpCiAgICAgICAgICAgICB8fCAhc3R5bGUoKS0+dG9wKCkuaXNQZXJj ZW50KCkKICAgICAgICAgICAgIHx8IGNvbnRhaW5pbmdCbG9jay0+c3RyZXRjaGVzVG9WaWV3cG9y dCgpKSkKLSAgICAgICAgcmV0dXJuIG9mZnNldCArIHZhbHVlRm9yTGVuZ3RoKHN0eWxlKCktPnRv cCgpLCBjb250YWluaW5nQmxvY2stPmF2YWlsYWJsZUhlaWdodCgpLCB2aWV3KCkpOworICAgICAg ICBvZmZzZXQuZXhwYW5kKDAsIHZhbHVlRm9yTGVuZ3RoKHN0eWxlKCktPnRvcCgpLCBjb250YWlu aW5nQmxvY2stPmF2YWlsYWJsZUhlaWdodCgpLCB2aWV3KCkpKTsKIAotICAgIGlmICghc3R5bGUo KS0+Ym90dG9tKCkuaXNBdXRvKCkKKyAgICBlbHNlIGlmICghc3R5bGUoKS0+Ym90dG9tKCkuaXNB dXRvKCkKICAgICAgICAgJiYgKCFjb250YWluaW5nQmxvY2stPnN0eWxlKCktPmhlaWdodCgpLmlz QXV0bygpCiAgICAgICAgICAgICB8fCAhc3R5bGUoKS0+Ym90dG9tKCkuaXNQZXJjZW50KCkKICAg ICAgICAgICAgIHx8IGNvbnRhaW5pbmdCbG9jay0+c3RyZXRjaGVzVG9WaWV3cG9ydCgpKSkKLSAg ICAgICAgcmV0dXJuIG9mZnNldCArIC12YWx1ZUZvckxlbmd0aChzdHlsZSgpLT5ib3R0b20oKSwg Y29udGFpbmluZ0Jsb2NrLT5hdmFpbGFibGVIZWlnaHQoKSwgdmlldygpKTsKKyAgICAgICAgb2Zm c2V0LmV4cGFuZCgwLCAtdmFsdWVGb3JMZW5ndGgoc3R5bGUoKS0+Ym90dG9tKCksIGNvbnRhaW5p bmdCbG9jay0+YXZhaWxhYmxlSGVpZ2h0KCksIHZpZXcoKSkpOwogCiAgICAgcmV0dXJuIG9mZnNl dDsKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVj dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2Rl bE9iamVjdC5oCShyZXZpc2lvbiAxMTg0MTEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94TW9kZWxPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtNTgsOSArNTgsNyBAQCBw dWJsaWM6CiAgICAgUmVuZGVyQm94TW9kZWxPYmplY3QoTm9kZSopOwogICAgIHZpcnR1YWwgflJl bmRlckJveE1vZGVsT2JqZWN0KCk7CiAgICAgCi0gICAgTGF5b3V0VW5pdCByZWxhdGl2ZVBvc2l0 aW9uT2Zmc2V0WCgpIGNvbnN0OwotICAgIExheW91dFVuaXQgcmVsYXRpdmVQb3NpdGlvbk9mZnNl dFkoKSBjb25zdDsKLSAgICBMYXlvdXRTaXplIHJlbGF0aXZlUG9zaXRpb25PZmZzZXQoKSBjb25z dCB7IHJldHVybiBMYXlvdXRTaXplKHJlbGF0aXZlUG9zaXRpb25PZmZzZXRYKCksIHJlbGF0aXZl UG9zaXRpb25PZmZzZXRZKCkpOyB9CisgICAgTGF5b3V0U2l6ZSByZWxhdGl2ZVBvc2l0aW9uT2Zm c2V0KCkgY29uc3Q7CiAgICAgTGF5b3V0U2l6ZSByZWxhdGl2ZVBvc2l0aW9uTG9naWNhbE9mZnNl dCgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCktPmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkgPyBy ZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0KCkgOiByZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0KCkudHJhbnNw b3NlZFNpemUoKTsgfQogCiAgICAgLy8gSUUgZXh0ZW5zaW9ucy4gVXNlZCB0byBjYWxjdWxhdGUg b2Zmc2V0V2lkdGgvSGVpZ2h0LiAgT3ZlcnJpZGRlbiBieSBpbmxpbmVzIChSZW5kZXJGbG93KQo=