87438 2012-05-24 16:34:40 -0700 [BlackBerry] History navigation caused google.com scale not kept 2012-05-25 08:55:59 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 1 jkjiang jkjiang manyoso rwlbuis staikos tonikitoo oldest_to_newest 633352 0 jkjiang 2012-05-24 16:34:40 -0700 Steps to reproduce: 1) Open google.com. 2) navigate to poster circle (http://www.webkit.org/blog-files/3d-transforms/poster-circle.html). 3) click back button to go back to google. Expected: 4) Google renders same size as on initial load. Actual: 4) Google renders at the initial scale of poster circle (1.347). 633427 1 143941 jkjiang 2012-05-24 18:06:33 -0700 Created attachment 143941 committed, r=tonikitoo 633914 2 143941 tonikitoo 2012-05-25 07:43:33 -0700 Comment on attachment 143941 committed, r=tonikitoo View in context: https://bugs.webkit.org/attachment.cgi?id=143941&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:901 > + if (m_mainFrame && m_mainFrame->document() && !(m_mainFrame->document()->viewportArguments() == defaultViewportArguments)) we should really add a != operator to ViewportArguments. 633945 3 jkjiang 2012-05-25 08:21:49 -0700 (In reply to comment #2) > (From update of attachment 143941 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143941&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:901 > > + if (m_mainFrame && m_mainFrame->document() && !(m_mainFrame->document()->viewportArguments() == defaultViewportArguments)) > > we should really add a != operator to ViewportArguments. Opened a bug for this: 87505. 633969 4 jkjiang 2012-05-25 08:54:40 -0700 Committed r118530: <http://trac.webkit.org/changeset/118530> 143941 2012-05-24 18:06:33 -0700 2012-05-25 08:55:59 -0700 committed, r=tonikitoo bug-87438-20120524170615.patch text/plain 3379 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBjMTVhMmY2ZDBlNDgzNDc4ZWMyNmE2ZjJiZGJiN2Q1OTIyOGJhZGZhLi4yYTFlMzcxOTdj YTQ0OTIzYTdlMmM0Mzk2NGFlODIwYzk3ODNmNGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMi0wNS0yNCAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBIaXN0b3J5IG5hdmlnYXRpb24gY2F1 c2VkIGdvb2dsZS5jb20gc2NhbGUgbm90IGtlcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NDM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUFI6IDE1OTkyMworICAgICAgICBGb3IgYmFjay9mb3J3YXJk IGhpc3RvcnkgbmF2aWdhdGlvbiwgd2Ugd2VyZSB0cnlpbmcgdG8ga2VlcCB0aGUgdmFsdWVzCisg ICAgICAgIHNldCBieSBkaXNwYXRjaFZpZXdwb3J0RGF0YURpZENoYW5nZS4gSG93ZXZlciwgd2hl biB3ZSB3ZW50IGJhY2sgZnJvbQorICAgICAgICB0aGUgcHJldmlvdXMgcGFnZSwgaWYgdGhlIGN1 cnJlbnQgcGFnZSBkaWRuJ3QgY29udGFpbiB0aGUgbWV0YSB2aWV3cG9ydAorICAgICAgICB0YWcs IHRoZW4gdGhvc2UgdmFsdWVzIHNldCBieSBwcmV2aW91cyBwYWdlIHdvdWxkIG5ldmVyIGJlIHJl c2V0LgorICAgICAgICBBbHRob3VnaCB0aGUgY3VycmVudCBwYWdlIGNvdWxkIGdldCBjb3JyZWN0 IHNhdmVkIHNjYWxlIHdoZW4gcmVzdG9yaW5nCisgICAgICAgIHZpZXcgc3RhdGUsIHRoZSBzY2Fs ZSB3b3VsZCBzdGlsbCBiZSBjbGFtcGVkIGJ5IHpvb21Ub0ZpdFNjYWxlIHdoaWNoCisgICAgICAg IHdhcyBiYXNlZCBvbiB0aGUgdmlydHVhbCB2aWV3cG9ydCBvZiB0aGUgcHJldmlvdXMgcGFnZSB3 aGljaCBjb3VsZCBtYWtlCisgICAgICAgIHRoZSBzY2FsZSBpbmNvcnJlY3QuCisgICAgICAgIFNp bmNlIHdlIGtub3cgdGhlIHZpZXdwb3J0IGFyZ3VtZW50cyBvZiB0aGUgY3VycmVudCBkb2N1bWVu dCBiZWZvcmUKKyAgICAgICAgc2V0TG9hZFN0YXRlIG9uIGJhY2svZm9yd2FyZCBoaXN0b3J5IG5h dmlnYXRpb24sIHdlIGNhbiByZXNldCB0aGVzZQorICAgICAgICBwcmV2aW91cyB2YWx1ZXMgaWYg dGhlIGRvY3VtZW50IGRvZXNuJ3QgaGF2ZSB2aWV3cG9ydCBhcmd1bWVudHMgZHVyaW5nCisgICAg ICAgIHNldExvYWRTdGF0ZS4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAg KEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OnNldExvYWRTdGF0ZSk6CisKIDIw MTItMDUtMjMgIEdlbmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CiAKICAgICAgICAgUmVtb3Zl IG1pbmltdW0gYW5kIG1heGltdW0gc2Nyb2xsIHBvc2l0aW9uIGFzIHRoZXkgYXJlIG5vCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCBjODU2NmQ0MTk3NDM1ZTE3 Y2Y2MzgwZWI1MjhjOGM5ZTkwNjhkZjRiLi5kNzk1MGMyZDVhYmU1YzBhMDYxMGUwYWQ0ZmEyNjE1 NGQwODhkMDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBh Z2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAg LTg5MiwxMSArODkyLDE3IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OnNldExvYWRTdGF0ZShMb2Fk U3RhdGUgc3RhdGUpCiAgICAgICAgICAgICAgICAgbV92aXJ0dWFsVmlld3BvcnRIZWlnaHQgPSBt X2RlZmF1bHRMYXlvdXRTaXplLmhlaWdodCgpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAg Ly8gQ2hlY2sgaWYgd2UgaGF2ZSBhbHJlYWR5IHByb2Nlc3MgdGhlIG1ldGEgdmlld3BvcnQgdGFn LCB0aGlzIG9ubHkgaGFwcGVucyBvbiBoaXN0b3J5IG5hdmlnYXRpb24uCisgICAgICAgICAgICAv LyBGb3IgYmFjay9mb3J3YXJkIGhpc3RvcnkgbmF2aWdhdGlvbiwgd2Ugc2hvdWxkIG9ubHkga2Vl cCB0aGVzZSBwcmV2aW91cyB2YWx1ZXMgaWYgdGhlIGRvY3VtZW50CisgICAgICAgICAgICAvLyBo YXMgdGhlIG1ldGEgdmlld3BvcnQgdGFnIHdoZW4gdGhlIHN0YXRlIGlzIENvbW1pdHRlZCBpbiBz ZXRMb2FkU3RhdGUuCiAgICAgICAgICAgICAvLyBSZWZyZXNoaW5nIHNob3VsZCBrZWVwIHRoZXNl IHByZXZpb3VzIHZhbHVlcyBhcyB3ZWxsLgorICAgICAgICAgICAgc3RhdGljIFZpZXdwb3J0QXJn dW1lbnRzIGRlZmF1bHRWaWV3cG9ydEFyZ3VtZW50czsKKyAgICAgICAgICAgIGJvb2wgZG9jdW1l bnRIYXNWaWV3cG9ydEFyZ3VtZW50cyA9IGZhbHNlOwogICAgICAgICAgICAgRnJhbWVMb2FkVHlw ZSBmcmFtZUxvYWRUeXBlID0gRnJhbWVMb2FkVHlwZVN0YW5kYXJkOworICAgICAgICAgICAgaWYg KG1fbWFpbkZyYW1lICYmIG1fbWFpbkZyYW1lLT5kb2N1bWVudCgpICYmICEobV9tYWluRnJhbWUt PmRvY3VtZW50KCktPnZpZXdwb3J0QXJndW1lbnRzKCkgPT0gZGVmYXVsdFZpZXdwb3J0QXJndW1l bnRzKSkKKyAgICAgICAgICAgICAgICBkb2N1bWVudEhhc1ZpZXdwb3J0QXJndW1lbnRzID0gdHJ1 ZTsKICAgICAgICAgICAgIGlmIChtX21haW5GcmFtZSAmJiBtX21haW5GcmFtZS0+bG9hZGVyKCkp CiAgICAgICAgICAgICAgICAgZnJhbWVMb2FkVHlwZSA9IG1fbWFpbkZyYW1lLT5sb2FkZXIoKS0+ bG9hZFR5cGUoKTsKLSAgICAgICAgICAgIGlmICghbV9kaWRSZXN0b3JlRnJvbVBhZ2VDYWNoZSAm JiAhKGZyYW1lTG9hZFR5cGUgPT0gRnJhbWVMb2FkVHlwZVJlbG9hZCB8fCBmcmFtZUxvYWRUeXBl ID09IEZyYW1lTG9hZFR5cGVSZWxvYWRGcm9tT3JpZ2luKSkgeworICAgICAgICAgICAgaWYgKCEo KG1fZGlkUmVzdG9yZUZyb21QYWdlQ2FjaGUgJiYgZG9jdW1lbnRIYXNWaWV3cG9ydEFyZ3VtZW50 cykgfHwgKGZyYW1lTG9hZFR5cGUgPT0gRnJhbWVMb2FkVHlwZVJlbG9hZCB8fCBmcmFtZUxvYWRU eXBlID09IEZyYW1lTG9hZFR5cGVSZWxvYWRGcm9tT3JpZ2luKSkpIHsKICAgICAgICAgICAgICAg ICBtX3ZpZXdwb3J0QXJndW1lbnRzID0gVmlld3BvcnRBcmd1bWVudHMoKTsKIAogICAgICAgICAg ICAgICAgIC8vIEF0IHRoZSBtb21lbnQgd2UgY29tbWl0IGEgbmV3IGxvYWQsIHNldCB0aGUgdmll d3BvcnQgYXJndW1lbnRzCg==