87430 2012-05-24 14:33:20 -0700 Use 32-byte alignment in AudioArray if using WEBAUDIO_FFMPEG 2012-05-24 18:07:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rtoy rtoy eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 633235 0 rtoy 2012-05-24 14:33:20 -0700 Use 32-byte alignment in AudioArray 633237 1 143898 rtoy 2012-05-24 14:34:43 -0700 Created attachment 143898 Patch 633244 2 rtoy 2012-05-24 14:37:33 -0700 See also http://code.google.com/p/chromium/issues/detail?id=119374 633311 3 143898 crogers 2012-05-24 15:43:42 -0700 Comment on attachment 143898 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143898&action=review > Source/WebCore/platform/audio/AudioArray.h:63 > + // 32-byte alignment for 256-bit SIMD. But Darwin (without FFMPEG) only needs 16-byte Sorry Ray, I think it's best to simply remove this comment WebKit style guidelines are to avoid obvious comments which reading the code can better answer > Source/WebCore/platform/audio/AudioArray.h:65 > +#if OS(DARWIN) && !USE(WEBAUDIO_FFMPEG) Please remove the OS(DARWIN) part. Also I would reverse the #if and have 32 appear first (checking USE(WEBAUDIO_FFMPEG) I think it reads better that way 633334 4 143915 rtoy 2012-05-24 16:11:43 -0700 Created attachment 143915 Patch 633336 5 143898 rtoy 2012-05-24 16:14:16 -0700 Comment on attachment 143898 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143898&action=review >> Source/WebCore/platform/audio/AudioArray.h:63 >> + // 32-byte alignment for 256-bit SIMD. But Darwin (without FFMPEG) only needs 16-byte > > Sorry Ray, I think it's best to simply remove this comment > WebKit style guidelines are to avoid obvious comments which reading the code can better answer Comments removed. Reading the code now just says ffmpeg uses 32 bytes instead of 16. For some unknown reason. >> Source/WebCore/platform/audio/AudioArray.h:65 >> +#if OS(DARWIN) && !USE(WEBAUDIO_FFMPEG) > > Please remove the OS(DARWIN) part. Also I would reverse the #if and have 32 appear first (checking USE(WEBAUDIO_FFMPEG) > > I think it reads better that way Yes, that's better. Done. 633337 6 143915 crogers 2012-05-24 16:16:12 -0700 Comment on attachment 143915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143915&action=review > Source/WebCore/ChangeLog:3 > + Use 32-byte alignment in AudioArray ... if using WEBAUDIO_FFMPEG > Source/WebCore/ChangeLog:8 > + No new tests. No new tests -> Covered by existing tests. 633342 7 143915 rtoy 2012-05-24 16:23:38 -0700 Comment on attachment 143915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143915&action=review >> Source/WebCore/ChangeLog:3 >> + Use 32-byte alignment in AudioArray > > ... if using WEBAUDIO_FFMPEG Fixed. Will fix bug title too. >> Source/WebCore/ChangeLog:8 >> + No new tests. > > No new tests -> Covered by existing tests. Fixed. 633343 8 143917 rtoy 2012-05-24 16:24:20 -0700 Created attachment 143917 Patch 633365 9 143917 crogers 2012-05-24 16:44:03 -0700 Comment on attachment 143917 Patch Thanks Ray 633429 10 143917 webkit.review.bot 2012-05-24 18:07:29 -0700 Comment on attachment 143917 Patch Clearing flags on attachment: 143917 Committed r118455: <http://trac.webkit.org/changeset/118455> 633430 11 webkit.review.bot 2012-05-24 18:07:34 -0700 All reviewed patches have been landed. Closing bug. 143898 2012-05-24 14:34:43 -0700 2012-05-24 16:14:15 -0700 Patch bug-87430-20120524143442.patch text/plain 1424 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM0M2FmYzg4NjlmZjll NmQxNmI2YTNjZWUxMDg0YjQ5ZjNkNzQ3OC4uNWViYmFiYmQzYmEwM2Y3OTdmYWYwZWZjMTUzMTBl YzUwZTY3MzlhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI0ICBSYXlt b25kIFRveSAgPHJ0b3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBVc2UgMzItYnl0ZSBhbGlnbm1l bnQgaW4gQXVkaW9BcnJheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODc0MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9BdWRpb0Fy cmF5Lmg6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0FycmF5OjphbGxvY2F0ZSk6CisKIDIwMTIt MDUtMTggIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04gKHIxMDI1NTMpOiBTbWFydCBsaW5rcyBkbyBub3Qgd29yawpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9BcnJheS5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vQXVkaW9BcnJheS5oCmluZGV4IDdhMjI1MWIzOGIyZjQyZTA1YzhlNDBhMTBi YjczNDJjNGIyZTY0ZDAuLjNjOTAyMmVjNGNjNjk3YTkyY2Q0OWMxNGMyN2MxNTUyNzEzMWUzMjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0FycmF5LmgKQEAgLTYwLDgg KzYwLDEzIEBAIHB1YmxpYzoKICAgICAgIAogICAgICAgICB1bnNpZ25lZCBpbml0aWFsU2l6ZSA9 IHNpemVvZihUKSAqIG47CiAKLSAgICAgICAgLy8gMTYtYnl0ZSBhbGlnbm1lbnQgZm9yIDEyOGJp dCBTSU1ELgorICAgICAgICAvLyAzMi1ieXRlIGFsaWdubWVudCBmb3IgMjU2LWJpdCBTSU1ELiBC dXQgRGFyd2luICh3aXRob3V0IEZGTVBFRykgb25seSBuZWVkcyAxNi1ieXRlCisgICAgICAgIC8v IGFsaWdubWVudCBmb3IgMTI4LWJpdCBTSU1ELgorI2lmIE9TKERBUldJTikgJiYgIVVTRShXRUJB VURJT19GRk1QRUcpCiAgICAgICAgIGNvbnN0IHNpemVfdCBhbGlnbm1lbnQgPSAxNjsKKyNlbHNl CisgICAgICAgIGNvbnN0IHNpemVfdCBhbGlnbm1lbnQgPSAzMjsKKyNlbmRpZgogCiAgICAgICAg IGlmIChtX2FsbG9jYXRpb24pCiAgICAgICAgICAgICBmYXN0RnJlZShtX2FsbG9jYXRpb24pOwo= 143915 2012-05-24 16:11:43 -0700 2012-05-24 16:24:14 -0700 Patch bug-87430-20120524161142.patch text/plain 1274 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM0M2FmYzg4NjlmZjll NmQxNmI2YTNjZWUxMDg0YjQ5ZjNkNzQ3OC4uNWViYmFiYmQzYmEwM2Y3OTdmYWYwZWZjMTUzMTBl YzUwZTY3MzlhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI0ICBSYXlt b25kIFRveSAgPHJ0b3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBVc2UgMzItYnl0ZSBhbGlnbm1l bnQgaW4gQXVkaW9BcnJheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODc0MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9BdWRpb0Fy cmF5Lmg6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0FycmF5OjphbGxvY2F0ZSk6CisKIDIwMTIt MDUtMTggIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04gKHIxMDI1NTMpOiBTbWFydCBsaW5rcyBkbyBub3Qgd29yawpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9BcnJheS5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vQXVkaW9BcnJheS5oCmluZGV4IDdhMjI1MWIzOGIyZjQyZTA1YzhlNDBhMTBi YjczNDJjNGIyZTY0ZDAuLmQyZDk5ZTE4MzEzNWI5MGE3ZTk1NGRmYTdkYTZmMzE3ODhiODVjYzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0FycmF5LmgKQEAgLTYwLDgg KzYwLDExIEBAIHB1YmxpYzoKICAgICAgIAogICAgICAgICB1bnNpZ25lZCBpbml0aWFsU2l6ZSA9 IHNpemVvZihUKSAqIG47CiAKLSAgICAgICAgLy8gMTYtYnl0ZSBhbGlnbm1lbnQgZm9yIDEyOGJp dCBTSU1ELgorI2lmIFVTRShXRUJBVURJT19GRk1QRUcpCisgICAgICAgIGNvbnN0IHNpemVfdCBh bGlnbm1lbnQgPSAzMjsKKyNlbHNlCiAgICAgICAgIGNvbnN0IHNpemVfdCBhbGlnbm1lbnQgPSAx NjsKKyNlbmRpZgogCiAgICAgICAgIGlmIChtX2FsbG9jYXRpb24pCiAgICAgICAgICAgICBmYXN0 RnJlZShtX2FsbG9jYXRpb24pOwo= 143917 2012-05-24 16:24:20 -0700 2012-05-24 18:07:29 -0700 Patch bug-87430-20120524162419.patch text/plain 1312 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM0M2FmYzg4NjlmZjll NmQxNmI2YTNjZWUxMDg0YjQ5ZjNkNzQ3OC4uODdiY2I1NWViYWRmYWU1YWE2Y2FkZjQ4ZDY2Njk5 YTllNTQ5NGJmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTI0ICBSYXlt b25kIFRveSAgPHJ0b3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBVc2UgMzItYnl0ZSBhbGlnbm1l bnQgaW4gQXVkaW9BcnJheSBpZiB1c2luZyBXRUJBVURJT19GRk1QRUcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NDMwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0 cy4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaDoKKyAgICAgICAgKFdl YkNvcmU6OkF1ZGlvQXJyYXk6OmFsbG9jYXRlKToKKwogMjAxMi0wNS0xOCAgWWkgU2hlbiAgPHlp LjQuc2hlbkBub2tpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjEwMjU1Myk6IFNtYXJ0 IGxpbmtzIGRvIG5vdCB3b3JrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h dWRpby9BdWRpb0FycmF5LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0Fy cmF5LmgKaW5kZXggN2EyMjUxYjM4YjJmNDJlMDVjOGU0MGExMGJiNzM0MmM0YjJlNjRkMC4uZDJk OTllMTgzMTM1YjkwYTdlOTU0ZGZhN2RhNmYzMTc4OGI4NWNjNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9BcnJheS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaApAQCAtNjAsOCArNjAsMTEgQEAgcHVibGljOgog ICAgICAgCiAgICAgICAgIHVuc2lnbmVkIGluaXRpYWxTaXplID0gc2l6ZW9mKFQpICogbjsKIAot ICAgICAgICAvLyAxNi1ieXRlIGFsaWdubWVudCBmb3IgMTI4Yml0IFNJTUQuCisjaWYgVVNFKFdF QkFVRElPX0ZGTVBFRykKKyAgICAgICAgY29uc3Qgc2l6ZV90IGFsaWdubWVudCA9IDMyOworI2Vs c2UKICAgICAgICAgY29uc3Qgc2l6ZV90IGFsaWdubWVudCA9IDE2OworI2VuZGlmCiAKICAgICAg ICAgaWYgKG1fYWxsb2NhdGlvbikKICAgICAgICAgICAgIGZhc3RGcmVlKG1fYWxsb2NhdGlvbik7 Cg==