8743 2006-05-04 15:19:56 -0700 REGRESSION: focus() on input field selects all text within it (was: cannot select cities on British Rail reservation site) 2006-05-11 10:42:35 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED http://www.britishrail.com/timetable_tickets.html EasyFix, Regression P1 Normal --- 1 Hanspeterschaub darin adele darin oldest_to_newest 41278 0 Hanspeterschaub 2006-05-04 15:19:56 -0700 REGRESSION On the British Rail reservation system I can no longer select cities in the departure/arrival text fields. As you start typing a city name there, the web page provides you with all possible cities that match your letters types. However, with the latest safari build (5/4/06) the latest letter typed is always used as the first letter? In the regular version of Safari that comes with 10.4.6 this does not occur. Here if you start typing a city, after each letter your possible selections are reduced until you select a specific city. 41346 1 8126 jonathanjohnsson 2006-05-05 11:33:57 -0700 Created attachment 8126 Test case When the Javascript function focus() is run on an input field, it not only focuses the field, but selects all the text. This regression happened between nightlies r13568 and r13574. 41401 2 darin 2006-05-06 12:00:29 -0700 What is focus() supposed to do, selection-wise? What does it do in other browsers? Is the selection supposed to go at the end of the field? 41613 3 darin 2006-05-09 09:15:14 -0700 I think the issue is only when focus() is called on a field that's already focused. I'm guessing the behavior of selecting all is fine when the field doesn't already have focus. The problem is in HTMLInputElement::focus, which calls select() unconditionally and instead should call it only if the focus node is not already set. 41817 4 8198 darin 2006-05-09 22:54:30 -0700 Created attachment 8198 patch 41836 5 8198 adele 2006-05-10 00:41:41 -0700 Comment on attachment 8198 patch I think the AppKit controls maintain some state for their selection. In the future, we want to restore some of that state when we focus. 42012 6 darin 2006-05-11 10:42:35 -0700 Committed revision 14301. 8126 2006-05-05 11:33:57 -0700 2006-05-05 11:33:57 -0700 Test case bug8743.html text/html 602 jonathanjohnsson PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPgo8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+Cgk8aGVh ZD4KCQk8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsg Y2hhcnNldD1pc28tODg1OS0xIj4KCQk8dGl0bGU+CgkJCUZhcmVzIGFuZCBTY2hlZHVsZXMgU2Vh cmNoCgkJPC90aXRsZT4KCQk8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+Cg0KbWFpbkxv b3A9ZnVuY3Rpb24oKXsKICBpbnB1dEZpZWxkPWRvY3VtZW50LmZvcm0xLkYwOw0KICBpbnB1dEZp ZWxkLmZvY3VzKCkKICBzZXRUaW1lb3V0KCJtYWluTG9vcCgpIiwyMDAwKTsNCiAgcmV0dXJuIHRy dWUKfQo7Cg0Kc2V0VGltZW91dCgibWFpbkxvb3AoKSIsMTApOwoNCiAgICAgICAgPC9zY3JpcHQ+ Cgk8L2hlYWQ+Cgk8Ym9keT4KCQk8Zm9ybSBuYW1lPSJmb3JtMSIgPgoJCQk8aW5wdXQgbmFtZT0i RjAiPgoJCTwvZm9ybT4KCTwvYm9keT4KPC9odG1sPgo= 8198 2006-05-09 22:54:30 -0700 2006-05-10 00:41:41 -0700 patch InputFocusPatch.txt text/plain 937 darin SW5kZXg6IGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaHRtbC9IVE1M SW5wdXRFbGVtZW50LmNwcAkocmV2aXNpb24gMTQyNzMpCisrKyBodG1sL0hUTUxJbnB1dEVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjgsMTYgKzE2OCwxOSBAQAogdm9pZCBIVE1MSW5w dXRFbGVtZW50Ojpmb2N1cygpCiB7CiAgICAgaWYgKGlzTm9uV2lkZ2V0VGV4dEZpZWxkKCkpIHsK KyAgICAgICAgaWYgKCFpc0ZvY3VzYWJsZSgpKQorICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICBEb2N1bWVudCogZG9jID0gZG9jdW1lbnQoKTsKKyAgICAgICAgaWYgKGRvYy0+Zm9jdXNOb2Rl KCkgPT0gdGhpcykKKyAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgZG9jLT51cGRhdGVMYXlv dXQoKTsKLSAgICAgICAgaWYgKGlzRm9jdXNhYmxlKCkpIHsKLSAgICAgICAgICAgIGRvYy0+c2V0 Rm9jdXNOb2RlKHRoaXMpOwotICAgICAgICAgICAgc2VsZWN0KCk7Ci0gICAgICAgICAgICBpZiAo ZG9jLT5mcmFtZSgpKQotICAgICAgICAgICAgICAgIGRvYy0+ZnJhbWUoKS0+cmV2ZWFsU2VsZWN0 aW9uKCk7Ci0gICAgICAgIH0KLSAgICB9IGVsc2UKLSAgICAgICAgSFRNTEdlbmVyaWNGb3JtRWxl bWVudDo6Zm9jdXMoKTsKKyAgICAgICAgZG9jLT5zZXRGb2N1c05vZGUodGhpcyk7CisgICAgICAg IHNlbGVjdCgpOworICAgICAgICBpZiAoZG9jLT5mcmFtZSgpKQorICAgICAgICAgICAgZG9jLT5m cmFtZSgpLT5yZXZlYWxTZWxlY3Rpb24oKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBI VE1MR2VuZXJpY0Zvcm1FbGVtZW50Ojpmb2N1cygpOwogfQogCiB2b2lkIEhUTUxJbnB1dEVsZW1l bnQ6OmRpc3BhdGNoRm9jdXNFdmVudCgpCg==