87424 2012-05-24 13:46:30 -0700 Web Inspector: Resource object has no methods getContent and setContent 2012-05-25 01:31:10 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://code.google.com/chrome/extensions/devtools.inspectedWindow.html#type-Resource P2 Normal --- 1 janx janx apavlov bweinstein caseq janx joepeck keishi loislo pfeldman pmuellr rik timothy vsevik yurys oldest_to_newest 633166 0 janx 2012-05-24 13:46:30 -0700 DOCUMENTATION: - http://code.google.com/chrome/extensions/devtools.panels.html#method-setOpenResourceHandler - http://code.google.com/chrome/extensions/devtools.inspectedWindow.html#type-Resource STEPS TO REPRODUCE: - Write a devtools extension using `chrome.devtools.panels.setOpenResourceHandler(function callback)`. - The handler callback `function(object Resource) {...};` receives a `Resource` object whenever the user clicks on a resource link. EVENT: User clicks on a valid resource link. EXPECTED: Handler called with `Resource` object, having attributes `type` and `url`, and methods `getContent` and `setContent`. OBSERVED: Handler called with `Resource` object, having attributes `type` and `url, but no methods. 633169 1 janx 2012-05-24 13:47:49 -0700 I am writing a patch to fix this, and a test to assert correct behavior. 633322 2 143911 janx 2012-05-24 15:54:37 -0700 Created attachment 143911 Patch 633648 3 143911 caseq 2012-05-25 00:34:16 -0700 Comment on attachment 143911 Patch LGTM. Thanks for fixing this and welcome to WebKit! 633650 4 caseq 2012-05-25 00:35:22 -0700 Vsevolod, could you please stamp this. 633670 5 caseq 2012-05-25 01:10:23 -0700 Committed r118492: <http://trac.webkit.org/changeset/118492> 633682 6 janx 2012-05-25 01:23:11 -0700 Thanks Andrey! 143911 2012-05-24 15:54:37 -0700 2012-05-25 01:31:10 -0700 Patch bug-87424-20120524155436.patch text/plain 3345 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg4M2U1OTI3MWIzODNl MTM1ZmVlYmMwMjI1ODFkNzUyYjM2Y2MwNi4uOWJkMTllNTQ3NmViZGMxY2Q2NGU2OTIwZmExN2Iw NDhiYjFlMGEwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTI0ICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZXNv dXJjZSBvYmplY3QgaGFzIG5vIG1ldGhvZHMgZ2V0Q29udGVudCBhbmQgc2V0Q29udGVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc0MjQKKworICAg ICAgICBUaGlzIGZpeGVzIHRoZSBleHRlbnNpb24gQVBJIHNvIHRoYXQgaXQgdXNlcyB0aGUgYG5l dyBSZXNvdXJjZSgpYAorICAgICAgICBjb25zdHJ1Y3Rvciwgd2hpY2ggYWRkcyB0aGUgbWlzc2lu ZyBgZ2V0Q29udGVudGAgYW5kIGBzZXRDb250ZW50YAorICAgICAgICBtZXRob2RzIHRvIGEgYFJl c291cmNlYCBvYmplY3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIHRlc3RzIHdlcmUgZml4ZWQgYWNjb3JkaW5nbHkgaW46CisgICAgICAgIExh eW91dFRlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zL2V4dGVuc2lvbnMtcmVzb3VyY2VzLWV4cGVj dGVkLnR4dAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanM6 CisgICAgICAgIChpbmplY3RlZEV4dGVuc2lvbkFQSS5QYW5lbHMucHJvdG90eXBlLnNldE9wZW5S ZXNvdXJjZUhhbmRsZXIuZWxzZS5jYWxsYmFja1dyYXBwZXIpOgorICAgICAgICAoaW5qZWN0ZWRF eHRlbnNpb25BUEkuUGFuZWxzLnByb3RvdHlwZS5zZXRPcGVuUmVzb3VyY2VIYW5kbGVyKToKKwog MjAxMi0wNS0yNCAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgQXZvaWQgY3JlYXRpbmcgSW5saW5lQm94ZXMgZm9yIGZsb2F0aW5nIGFuZCBwb3NpdGlvbmVk IG9iamVjdHMgaW4gaXNvbGF0ZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRXh0ZW5zaW9uQVBJLmpzCmluZGV4IGQyZDUwYzE3OTkyNzQxMWQxNDJkZGU2Mjc5 Nzg3NWU0MjliZDQ5MDEuLjg4MmZiOWM5NjdkOGUwNDVmM2Y0NDYyYjZjMzE5YzdiMjA5NjM1YWIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9u QVBJLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9u QVBJLmpzCkBAIC0zMDUsNyArMzA1LDcgQEAgUGFuZWxzLnByb3RvdHlwZSA9IHsKICAgICAgICAg ZWxzZSB7CiAgICAgICAgICAgICBmdW5jdGlvbiBjYWxsYmFja1dyYXBwZXIobWVzc2FnZSkKICAg ICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBjYWxsYmFjay5jYWxsKG51bGwsIG1lc3NhZ2Uu cmVzb3VyY2UsIG1lc3NhZ2UubGluZU51bWJlcik7CisgICAgICAgICAgICAgICAgY2FsbGJhY2su Y2FsbChudWxsLCBuZXcgUmVzb3VyY2UobWVzc2FnZS5yZXNvdXJjZSksIG1lc3NhZ2UubGluZU51 bWJlcik7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBleHRlbnNpb25TZXJ2ZXIucmVnaXN0 ZXJIYW5kbGVyKGV2ZW50cy5PcGVuUmVzb3VyY2UsIGNhbGxiYWNrV3JhcHBlcik7CiAgICAgICAg IH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA1YmFlNWY5Y2RmZjQ2Mjc2MmNlOGZjNDI1YzQ1OWFkYWVhMGQxNGFjLi4wMzk2 MzI3NGRjOTM2Y2M3NDQ2MDc2NmYzMzljMWQwNTUzYjJhNDUyIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDUtMjQgIEphbiBLZXJvbW5lcyAgPGphbnhAbGludXguY29tPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IFJlc291cmNlIG9iamVjdCBoYXMgbm8gbWV0aG9kcyBnZXRDb250ZW50 IGFuZCBzZXRDb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NzQyNAorCisgICAgICAgIFRoaXMgZml4ZXMgdGhlIGV4cGVjdGVkIHRlc3QgcmVz dWx0IGZvciBgaGFuZGxlT3BlblJlc291cmNlKClgLCBzZWUgZml4CisgICAgICAgIGZvciBidWcg Izg3NDI0IGluIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJ LmpzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL2V4dGVuc2lvbnMvZXh0ZW5zaW9ucy1yZXNvdXJjZXMtZXhwZWN0ZWQudHh0Ogor CiAyMDEyLTA1LTI0ICBMZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBBdm9pZCBjcmVhdGluZyBJbmxpbmVCb3hlcyBmb3IgZmxvYXRpbmcgYW5kIHBvc2l0aW9u ZWQgb2JqZWN0cyBpbiBpc29sYXRlcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rv ci9leHRlbnNpb25zL2V4dGVuc2lvbnMtcmVzb3VyY2VzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2luc3BlY3Rvci9leHRlbnNpb25zL2V4dGVuc2lvbnMtcmVzb3VyY2VzLWV4cGVjdGVkLnR4 dAppbmRleCBhZDMyZGRlNTAyOTVmNmYzMzE0Njk5M2QyMjQ0NjVjNDRjZTBiZjBkLi45MjY3ZDIy MjVlMjBlM2I3YjU4NjU2OGZhYzIwNDQyZGZiODQ4MWVlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNpb25zLXJlc291cmNlcy1leHBlY3RlZC50eHQK KysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMvZXh0ZW5zaW9ucy1yZXNvdXJj ZXMtZXhwZWN0ZWQudHh0CkBAIC03NCw2ICs3NCw4IEBAIGhhbmRsZU9wZW5SZXNvdXJjZSgpIGlu dm9rZWQgW3RoaXMgc2hvdWxkIG9ubHkgYXBwZWFyIG9uY2UhXToKICAgICAwIDogewogICAgICAg ICB1cmwgOiAuLi4vZXh0ZW5zaW9ucy1yZXNvdXJjZXMuaHRtbAogICAgICAgICB0eXBlIDogImRv Y3VtZW50IgorICAgICAgICBnZXRDb250ZW50IDogPGZ1bmN0aW9uPgorICAgICAgICBzZXRDb250 ZW50IDogPGZ1bmN0aW9uPgogICAgIH0KICAgICAxIDogMTEKIH0K