87412 2012-05-24 11:55:10 -0700 [BlackBerry] InputHandler can hold a ref on an object when document is cleared. 2012-05-24 15:38:07 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 633022 0 mifenton 2012-05-24 11:55:10 -0700 InputHandler can hold onto a Refptr for an element within a document after the document is cleared. We need to notify InputHandler of a frame removal to clear state when WebPage::clearDocumentData is called. 633024 1 143866 mifenton 2012-05-24 11:58:32 -0700 Created attachment 143866 Patch 633028 2 143866 rwlbuis 2012-05-24 12:01:39 -0700 Comment on attachment 143866 Patch Looks good. 633073 3 143866 webkit.review.bot 2012-05-24 12:49:51 -0700 Comment on attachment 143866 Patch Rejecting attachment 143866 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 37 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 37. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12791290 633102 4 143866 webkit.review.bot 2012-05-24 13:13:45 -0700 Comment on attachment 143866 Patch Rejecting attachment 143866 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: '--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp patching file Source/WebKit/blackberry/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12791296 633105 5 143875 mifenton 2012-05-24 13:17:40 -0700 Created attachment 143875 Updated Patch 633305 6 143875 webkit.review.bot 2012-05-24 15:38:03 -0700 Comment on attachment 143875 Updated Patch Clearing flags on attachment: 143875 Committed r118438: <http://trac.webkit.org/changeset/118438> 633306 7 webkit.review.bot 2012-05-24 15:38:07 -0700 All reviewed patches have been landed. Closing bug. 143866 2012-05-24 11:58:32 -0700 2012-05-24 13:17:40 -0700 Patch 0001-2012-05-24-Mike-Fenton-mifenton-rim.com.patch text/plain 2374 mifenton RnJvbSAyYzJhMDQ3ODNmODVmNTNjMzY4YTAxMDRhZjYxNjY1Y2RmNDM4MTA4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAyNCBNYXkgMjAxMiAxNDo1MTozMSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDUt MjQgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMTQ1MjM0LgoK ICAgICAgICBXaGVuIHRoZSBkb2N1bWVudCBkYXRhIGlzIGNsZWFyZWQsIG5vdGlmeSB0aGUgSW5w dXRIYW5kbGVyCiAgICAgICAgb2YgdGhlIGFzc29jaWF0ZWQgZnJhbWUgYmVpbmcgdW5sb2FkZWQu CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIEFwaS9XZWJQ YWdlLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6Y2xl YXJEb2N1bWVudERhdGEpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFn ZS5jcHAgfCAgICAzICsrKwogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAg ICB8ICAgMTggKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlv bnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2Uu Y3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCA2NzI5 YTU1Li5iNjNlMDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAK QEAgLTIzODUsNiArMjM4NSw5IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OmNsZWFyRG9jdW1lbnRE YXRhKGNvbnN0IERvY3VtZW50KiBkb2N1bWVudEdvaW5nQXdheSkKICAgICBpZiAobV9pblJlZ2lv blNjcm9sbFN0YXJ0aW5nTm9kZSAmJiBtX2luUmVnaW9uU2Nyb2xsU3RhcnRpbmdOb2RlLT5kb2N1 bWVudCgpID09IGRvY3VtZW50R29pbmdBd2F5KQogICAgICAgICBtX2luUmVnaW9uU2Nyb2xsU3Rh cnRpbmdOb2RlID0gMDsKIAorICAgIGlmIChkb2N1bWVudEdvaW5nQXdheS0+ZnJhbWUoKSkKKyAg ICAgICAgbV9pbnB1dEhhbmRsZXItPmZyYW1lVW5sb2FkZWQoZG9jdW1lbnRHb2luZ0F3YXktPmZy YW1lKCkpOworCiAgICAgTm9kZSogbm9kZVVuZGVyRmF0RmluZ2VyID0gbV90b3VjaEV2ZW50SGFu ZGxlci0+bGFzdEZhdEZpbmdlcnNSZXN1bHQoKS5ub2RlKCk7CiAgICAgaWYgKG5vZGVVbmRlckZh dEZpbmdlciAmJiBub2RlVW5kZXJGYXRGaW5nZXItPmRvY3VtZW50KCkgPT0gZG9jdW1lbnRHb2lu Z0F3YXkpCiAgICAgICAgIG1fdG91Y2hFdmVudEhhbmRsZXItPnJlc2V0TGFzdEZhdEZpbmdlcnNS ZXN1bHQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDdhYTE4ZDAuLmFjOGQ2 ZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEy LTA1LTI0ICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CiAKKyAgICAgICAgW0JsYWNr QmVycnldIElucHV0SGFuZGxlciBjYW4gaG9sZCBhIHJlZiBvbiBhbiBvYmplY3Qgd2hlbiBkb2N1 bWVudCBpcyBjbGVhcmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODc0MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBQUiAxNDUyMzQuCisKKyAgICAgICAgV2hlbiB0aGUgZG9jdW1lbnQgZGF0YSBpcyBj bGVhcmVkLCBub3RpZnkgdGhlIElucHV0SGFuZGxlcgorICAgICAgICBvZiB0aGUgYXNzb2NpYXRl ZCBmcmFtZSBiZWluZyB1bmxvYWRlZC4KKworICAgICAgICBSZXZpZXdlZCBJbnRlcm5hbGx5IGJ5 IE5pbWEgR2hhbmF2YXRpYW4uCisKKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAg ICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmNsZWFyRG9jdW1lbnREYXRh KToKKworMjAxMi0wNS0yNCAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgorCiAgICAg ICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgdW51c2VkIEFQSSBmdW5jdGlvbiB0b3VjaEV2ZW50Q2Fu Y2VsQW5kQ2xlYXJGb2N1c2VkTm9kZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg3Mzc5CiAKLS0gCjEuNy45LjUKCg== 143875 2012-05-24 13:17:40 -0700 2012-05-24 15:38:03 -0700 Updated Patch 0001-2012-05-24-Mike-Fenton-mifenton-rim.com.patch text/plain 2288 mifenton RnJvbSBjMjZmZDNlM2Q1ZmYwY2Q2ZWNkOGQzYWMxOGQ5MjY0Y2M4Y2UwN2Q1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAyNCBNYXkgMjAxMiAxNDo1MTozMSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDUt MjQgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMTQ1MjM0LgoK ICAgICAgICBXaGVuIHRoZSBkb2N1bWVudCBkYXRhIGlzIGNsZWFyZWQsIG5vdGlmeSB0aGUgSW5w dXRIYW5kbGVyCiAgICAgICAgb2YgdGhlIGFzc29jaWF0ZWQgZnJhbWUgYmVpbmcgdW5sb2FkZWQu CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIEFwaS9XZWJQ YWdlLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6Y2xl YXJEb2N1bWVudERhdGEpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFn ZS5jcHAgfCAgICAzICsrKwogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAg ICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDJjMDhm YmYuLjVmODg5NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApA QCAtMjM4NSw2ICsyMzg1LDkgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6Y2xlYXJEb2N1bWVudERh dGEoY29uc3QgRG9jdW1lbnQqIGRvY3VtZW50R29pbmdBd2F5KQogICAgIGlmIChtX2luUmVnaW9u U2Nyb2xsU3RhcnRpbmdOb2RlICYmIG1faW5SZWdpb25TY3JvbGxTdGFydGluZ05vZGUtPmRvY3Vt ZW50KCkgPT0gZG9jdW1lbnRHb2luZ0F3YXkpCiAgICAgICAgIG1faW5SZWdpb25TY3JvbGxTdGFy dGluZ05vZGUgPSAwOwogCisgICAgaWYgKGRvY3VtZW50R29pbmdBd2F5LT5mcmFtZSgpKQorICAg ICAgICBtX2lucHV0SGFuZGxlci0+ZnJhbWVVbmxvYWRlZChkb2N1bWVudEdvaW5nQXdheS0+ZnJh bWUoKSk7CisKICAgICBOb2RlKiBub2RlVW5kZXJGYXRGaW5nZXIgPSBtX3RvdWNoRXZlbnRIYW5k bGVyLT5sYXN0RmF0RmluZ2Vyc1Jlc3VsdCgpLm5vZGUoKTsKICAgICBpZiAobm9kZVVuZGVyRmF0 RmluZ2VyICYmIG5vZGVVbmRlckZhdEZpbmdlci0+ZG9jdW1lbnQoKSA9PSBkb2N1bWVudEdvaW5n QXdheSkKICAgICAgICAgbV90b3VjaEV2ZW50SGFuZGxlci0+cmVzZXRMYXN0RmF0RmluZ2Vyc1Jl c3VsdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggYjdlNmEzMi4uNjNmMDdh NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTIt MDUtMjQgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tC ZXJyeV0gSW5wdXRIYW5kbGVyIGNhbiBob2xkIGEgcmVmIG9uIGFuIG9iamVjdCB3aGVuIGRvY3Vt ZW50IGlzIGNsZWFyZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NzQxMgorCisgICAgICAgIFJldmlld2VkIGJ5IFJvYiBCdWlzLgorCisgICAgICAg IFBSIDE0NTIzNC4KKworICAgICAgICBXaGVuIHRoZSBkb2N1bWVudCBkYXRhIGlzIGNsZWFyZWQs IG5vdGlmeSB0aGUgSW5wdXRIYW5kbGVyCisgICAgICAgIG9mIHRoZSBhc3NvY2lhdGVkIGZyYW1l IGJlaW5nIHVubG9hZGVkLgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkgYnkgTmltYSBH aGFuYXZhdGlhbi4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmNsZWFyRG9jdW1lbnREYXRhKToKKwogMjAx Mi0wNS0yNCAgQW50b25pbyBHb21lcyAgPGFnb21lc0ByaW0uY29tPgogCiAgICAgICAgIFBvc3Np YmxlIG1pc3NpbmcgbGF5b3V0IGluIElyaXMgYnJvd3NlciBhZnRlciBoaWRpbmcgVktCCi0tIAox LjcuOS41Cgo=