87410 2012-05-24 11:41:01 -0700 REGRESSION(r109663) All the the dom/html/level2/html/HTMLFrameElement* tests crash on Windows 2012-05-24 12:41:41 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All Windows 7 RESOLVED FIXED InRadar P2 Normal --- 1 jberlin jberlin andersca jberlin jhoneycutt sfalken webkit-bug-importer oldest_to_newest 633007 0 jberlin 2012-05-24 11:41:01 -0700 http://trac.webkit.org/changeset/109663 explicitly ignored the comment in LocalizedStrings.cpp: // Note that because |format| is used as the second parameter to va_start, it cannot be a reference // type according to section 18.7/3 of the C++ N1905 standard. and changed the parameter to a const reference. This caused crashes under CFStringCreateWithFormatAndArguments on Windows. 633012 1 143863 jberlin 2012-05-24 11:44:36 -0700 Created attachment 143863 Patch 633027 2 143863 jberlin 2012-05-24 12:00:25 -0700 Comment on attachment 143863 Patch Committed in http://trac.webkit.org/changeset/118399 633069 3 webkit-bug-importer 2012-05-24 12:41:40 -0700 <rdar://problem/11527190> 143863 2012-05-24 11:44:36 -0700 2012-05-24 12:00:25 -0700 Patch fixWindowsCrashes.patch text/plain 1389 jberlin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MTJiYTkxLi5mYTNkNmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDUtMjQgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OKHIxMDk2NjMpIEFsbCB0aGUgdGhlIGRvbS9odG1sL2xldmVsMi9odG1s L0hUTUxGcmFtZUVsZW1lbnQqIHRlc3RzIGNyYXNoIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NDEwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IHBhc3MgYSByZWZlcmVuY2Ug dHlwZSB0byB2YV9zdGFydCAoc2VlIHI3NTQzNSkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2Nh bGl6ZWRTdHJpbmdzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmZvcm1hdExvY2FsaXplZFN0cmlu Zyk6CisKIDIwMTItMDUtMjQgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJha3Vjb0B3ZWJraXQu b3JnPgogCiAgICAgICAgIFtFRkxdIE1vZGlmeSBrZXljb2RlIGNvbnZlcnNpb24gZnVuY3Rpb25z IHRvIHJldHVybiBrZXljb2RlcyB3aXRoIGxvY2F0aW9uIGluZm9ybWF0aW9uIGFmdGVyIHIxMTgw MDEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdz LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvY2FsaXplZFN0cmluZ3MuY3BwCmluZGV4 IDNjYjUxOWMuLjIxYmI1OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xv Y2FsaXplZFN0cmluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvY2FsaXpl ZFN0cmluZ3MuY3BwCkBAIC00OCw3ICs0OCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIC8vICAy KSBJdCBkb2Vzbid0IGhhbmRsZSB0aGUgJTIkZCBzeW50YXguCiAvLyBOb3RlIHRoYXQgYmVjYXVz ZSB8Zm9ybWF0fCBpcyB1c2VkIGFzIHRoZSBzZWNvbmQgcGFyYW1ldGVyIHRvIHZhX3N0YXJ0LCBp dCBjYW5ub3QgYmUgYSByZWZlcmVuY2UKIC8vIHR5cGUgYWNjb3JkaW5nIHRvIHNlY3Rpb24gMTgu Ny8zIG9mIHRoZSBDKysgTjE5MDUgc3RhbmRhcmQuCi1zdGF0aWMgU3RyaW5nIGZvcm1hdExvY2Fs aXplZFN0cmluZyhjb25zdCBTdHJpbmcmIGZvcm1hdCwgLi4uKQorc3RhdGljIFN0cmluZyBmb3Jt YXRMb2NhbGl6ZWRTdHJpbmcoU3RyaW5nIGZvcm1hdCwgLi4uKQogewogI2lmIFVTRShDRikKICAg ICB2YV9saXN0IGFyZ3VtZW50czsK