87404 2012-05-24 11:02:49 -0700 [BlackBerry] Padding adjustment for determining the relative distance for a point was backwards. 2012-05-24 12:28:40 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 632951 0 mifenton 2012-05-24 11:02:49 -0700 Padding is added for y axis instead of subtracted in directionOfPointRelativeToRect. 632985 1 143860 mifenton 2012-05-24 11:26:21 -0700 Created attachment 143860 Patch 632990 2 143860 rwlbuis 2012-05-24 11:29:10 -0700 Comment on attachment 143860 Patch LGTM. 633051 3 143860 webkit.review.bot 2012-05-24 12:28:36 -0700 Comment on attachment 143860 Patch Clearing flags on attachment: 143860 Committed r118403: <http://trac.webkit.org/changeset/118403> 633052 4 webkit.review.bot 2012-05-24 12:28:40 -0700 All reviewed patches have been landed. Closing bug. 143860 2012-05-24 11:26:21 -0700 2012-05-24 12:28:36 -0700 Patch 0001-2012-05-24-Mike-Fenton-mifenton-rim.com.patch text/plain 2321 mifenton RnJvbSBjMDA4NDUzMTJjYmVhNDBkYjQyNTI2MWNjMzczMDQ2NGRhZjliMmQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAyNCBNYXkgMjAxMiAxMzowMzowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDUt MjQgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgRml4IHBhZGRpbmcg Y2FsY3VsYXRpb24gZm9yIGhhbmRsZSBhZGp1c3RtZW50LgoKICAgICAgICBSZXZpZXdlZCBJbnRl cm5hbGx5IGJ5IE1pa2UgTGF0dGFuemlvLgoKICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0 aW9uSGFuZGxlci5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6ZGlyZWN0aW9uT2ZQ b2ludFJlbGF0aXZlVG9SZWN0KToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIC4uLi9ibGFja2JlcnJ5 L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgIHwgICAgMiArLQogMiBmaWxlcyBj aGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9DaGFuZ2VMb2cKaW5kZXggN2FhMThkMC4uNzM4Yzg4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTItMDUtMjQgIE1pa2UgRmVudG9uICA8bWlm ZW50b25AcmltLmNvbT4KIAorICAgICAgICBbQmxhY2tCZXJyeV0gUGFkZGluZyBhZGp1c3RtZW50 IGZvciBkZXRlcm1pbmluZyB0aGUgcmVsYXRpdmUgZGlzdGFuY2UgZm9yIGEgcG9pbnQgd2FzIGJh Y2t3YXJkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg3NDA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IHBhZGRpbmcgY2FsY3VsYXRpb24gZm9yIGhhbmRsZSBhZGp1c3RtZW50LgorCisgICAgICAg IFJldmlld2VkIEludGVybmFsbHkgYnkgTWlrZSBMYXR0YW56aW8uCisKKyAgICAgICAgKiBXZWJL aXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2Vi S2l0OjpkaXJlY3Rpb25PZlBvaW50UmVsYXRpdmVUb1JlY3QpOgorCisyMDEyLTA1LTI0ICBNaWtl IEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CisKICAgICAgICAgW0JsYWNrQmVycnldIFJlbW92 ZSB1bnVzZWQgQVBJIGZ1bmN0aW9uIHRvdWNoRXZlbnRDYW5jZWxBbmRDbGVhckZvY3VzZWROb2Rl LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODczNzkK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2Vs ZWN0aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9TZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRleCAzNTFmNTI3Li5kYTQzZjJjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rp b25IYW5kbGVyLmNwcApAQCAtMTc3LDcgKzE3Nyw3IEBAIHN0YXRpYyB1bnNpZ25lZCBzaG9ydCBk aXJlY3Rpb25PZlBvaW50UmVsYXRpdmVUb1JlY3QoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIHBv CiAKICAgICAvLyBEbyBoZWlnaHQgbW92ZW1lbnQgY2hlY2sgZmlyc3QgYnV0IGFkZCBwYWRkaW5n LiBXZSBtYXkgYmUgb2ZmIG9uIGJvdGggeCAmIHkgYXhpcyBhbmQgb25seQogICAgIC8vIHdhbnQg dG8gbW92ZSBpbiBvbmUgZGlyZWN0aW9uIGF0IGEgdGltZS4KLSAgICBpZiAocG9pbnQueSgpICsg KHVzZVRvcFBhZGRpbmcgPyB2ZXJ0aWNhbFBhZGRpbmcgOiAwKSA8IHJlY3QueSgpKQorICAgIGlm IChwb2ludC55KCkgLSAodXNlVG9wUGFkZGluZyA/IHZlcnRpY2FsUGFkZGluZyA6IDApIDwgcmVj dC55KCkpCiAgICAgICAgIHJldHVybiBLRVlDT0RFX1VQOwogICAgIGlmIChwb2ludC55KCkgPiBy ZWN0Lm1heFkoKSArICh1c2VCb3R0b21QYWRkaW5nID8gdmVydGljYWxQYWRkaW5nIDogMCkpCiAg ICAgICAgIHJldHVybiBLRVlDT0RFX0RPV047Ci0tIAoxLjcuOS41Cgo=