8740 2006-05-04 13:43:37 -0700 REGRESSION: benchjs test 1 has slowed by over 150% 2007-03-01 02:34:50 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED WONTFIX http://www.24fun.com/downloadcenter/benchjs/benchjs.html HasReduction, InRadar, Regression P1 Major --- 1 jon mjs ap c.petersen87 darin mrowe oldest_to_newest 41270 0 jon 2006-05-04 13:43:37 -0700 Between r13721 and r13738, the speed of the 24fun (benchjs) math test slowed byover 150% on my quad, from ~1.3s to ~3.3s. Most likely this has something to do with WebKit's coalesced updating changes, though I am far from knowing what I'm talking about. 41283 1 hyatt 2006-05-04 16:45:26 -0700 This regression only occurs with the status bar showing, and is a bug in WebBrowser... not WebKit or Core. 41285 2 hyatt 2006-05-04 17:05:59 -0700 Jon, can you add your hardware information? We are not seeing this on all machines. 41402 3 darin 2006-05-06 12:02:49 -0700 We've figured out what's going on here and we're trying to decide what to do to fix it. The slowness is due to interaction between the constant repainting in the web view, constant repainting in the status bar, the way AppKit decides when to do a display, and the way that the graphics system blocks the process if you start painting after a window flush but before it can write the data from that flush into the display's frame buffer. 41657 4 harrison 2006-05-09 17:15:00 -0700 Radar #4542808 42976 5 timo 2006-05-20 00:27:58 -0700 I landed a fix for this on TOT a while back. 46765 6 jon 2006-06-22 22:26:31 -0700 I'm reopening this because this test is still 30% slower in ToT than shipping WebKit. Also, the two keys added (WebKitThrottleWindowDisplayPreferenceKey and WebKitEnableDeferredUpdatesPreferenceKey) don't seem to have an effect anymore. The test had the same time no matter their settings. Also, the status bar doesn't seem to have an effect either. As an aside, test 7 of the benchjs suite is 50% slower than shipping. 46884 7 timo 2006-06-23 09:25:32 -0700 Jon, can you provide some more details? Performance testing can be a tricky thing to get right; I'd like to hear about your methodology. - Did you do a Debug or a Release build? Debug builds are much slower than Release. - What OS version are you on? - What kind of machine? How much RAM, etc? - How many times did you run the test? - How much variance was there between multiple runs of each test? - What were the actual numbers you recorded? 46902 8 jon 2006-06-23 14:59:15 -0700 Sorry. My setup is a quad G5 with 1GB RAM and 10.4.6. I tested a Release build. Shipping WebKit averaged 1.19s (repeated 3 times) on the first test, while ToT averaged 1.65 (over 6 times). The settings of the preference keys didn't affect that average. High/low distance on ToT was .06s (1.63 -> 1.69) and .04s (1.18 -> 1.22) on shipping. 46652 9 timo 2006-11-06 21:40:26 -0800 Mass-unassigning my bugs (I'm working on another team right now) 41957 10 hyatt 2006-12-14 23:02:53 -0800 Retest? I think this is fixed now. 41915 11 jon 2006-12-15 08:12:59 -0800 No, no improvement. It's still 100% slower in ToT/Safari2.0.4 than 419.3/Safari2.0.4. This is 10.4.8 on a Quad G5. .75s for 419.3 and 1.6s for ToT. Having the WebKitEnableDeferredUpdatesPreferenceKey or WebKitEnableDeferredUpdatesPreferenceKey key set doesn't affect the result and neither does having the status bar visible. 41916 12 jon 2006-12-15 08:14:26 -0800 Damnit, I forgot to say that I'm using a Release build of r18232. 34028 13 ap 2007-01-21 01:58:37 -0800 I also see a speed regression on my G4/1.25DP (1.6 sec with shipping Safari, 2.1 sec with a r18640 nightly). Mac OS X 10.4.8, 1 Gb RAM. Hiding the status bar doesn't significantly reduce the times. 26518 14 mrowe 2007-02-06 22:22:47 -0800 Re-adding NeedsRadar as radar referenced here was resolved. 26126 15 mjs 2007-02-06 23:24:47 -0800 <rdar://problem/4980995> 24955 16 jon 2007-02-07 15:49:45 -0800 http://www.jonshier.com/8740TraceWithBar.zip Above is a link to a trace of ToT running the count test with the status bar visible and the number of iterations set to 10000 instead of 1000. From my brief analysis it looks like WebChromeClient::setStatusBarText is being called twice. Once by KJS::Window::put and once by WebCore::Chrome:setStatusBarText. Both of those together seem to take about 29% of work. I'm going to test again with the status bar hidden and see what that shows. Here are the results (averaged over 3 runs) for my expanded test (to be posted later once I get it fully reduced). 2.0.4/419.3 with status bar: 7.09s 2.0.4/419.3 without status bar: 6.81s 2.0.4/ToT with status bar: 33.38s 2.0.4/ToT without status bar: 16.78s Quad G5, 1GB RAM, 10.4.8 24445 17 13111 jon 2007-02-10 14:37:02 -0800 Created attachment 13111 Reduction based on original BenchJS test. Okay, I've reduced the BenchJS test as far as I'm comfortable with. Index.html loads the button, hit the button to run the test. Test will automatically run again 2 seconds after it completes. Note the time in the left can side. From my basic analysis of the code, I think both the page and frame containing the text are both trying to set the status bar text, resulting in a duplication of work. It seems both Chrome::setStatusbarText and WebChromeClient::setStatusbarText are getting called. One by Safari and one by WebCore internally perhaps? JavaScriptCore may also be setting it, though I haven't been able to find that (though I would think it would go through Frame::setJSStatusBarText (also note the 'B's in those bars are variably capitalized)). 24315 18 zimmermann 2007-02-11 03:31:01 -0800 I can also confirm this performance regression - on a MacBook Pro. 22007 19 mjs 2007-02-23 00:35:48 -0800 I see this too. Now working on it. Tests 6 and 7 are also regressed. 22004 20 mjs 2007-02-23 01:51:37 -0800 TOT WebKit + TOT Safari spends 80% of its time on this test idle - I think this is the 10ms minimum timer threshold kicking in. There may have been a regression from coalesced updates or the status bar at some point but I think those are long gone. 21993 21 mjs 2007-02-23 02:28:45 -0800 It's definitely our new timer limiting. When I remove the timer clamping, we complete the test in .275s, less than half the time Safari 2 takes. There is no way to fix the regression without reverting the timer change - we spend more time waiting on the timer (.899s) than our old total score (.674s) 21994 22 mjs 2007-02-23 02:37:30 -0800 This is caused by the fix to http://bugs.webkit.org/show_bug.cgi?id=6998 21996 23 mjs 2007-02-23 02:40:36 -0800 See also related bug 12866 and bug 12867 21332 24 mjs 2007-02-26 12:00:01 -0800 This prety much can't be fixed. The 10ms timer limit forces a slowdown that we can't avoid. 20771 25 jon 2007-02-28 22:21:19 -0800 Okay, forgive me if these are stupid questions. If the problem is due to the minimum 10ms timer, and the progress display and statusbar text have to refresh 1000 times, shouldn't the test take 10s + a bit? And doesn't the fact that hiding the status bar cuts the time roughly in half seem to indicate an entirely different problem? If I'm entirely off base I'd still like a more complete explanation, if possible. 20775 26 mjs 2007-03-01 02:34:50 -0800 1) The status bar problem is actually a bug in Safari, not WebKit. Can't talk about the details though. 2) The reduced version actually runs the test 10 times as long as the real version - the timer fires only 100 times on the real test, at 10ms each, that should take 1 second plus a little bit, which is approximately true in all browsers. 13111 2007-02-10 14:37:02 -0800 2007-02-10 14:37:02 -0800 Reduction based on original BenchJS test. benchjsreduction.zip application/zip 3848 jon UEsDBAoAAAAAAOqISDYAAAAAAAAAAAAAAAARABAAYmVuY2hqc3JlZHVjdGlvbi9VWAwAGVLKRSit y0X1AfUBUEsDBBQACAAIANZ8SjYAAAAAAAAAAAAAAAAaABAAYmVuY2hqc3JlZHVjdGlvbi8uRFNf U3RvcmVVWAwAWkPORWQ7zkX1AfUB7ZjNasJAFIXPTbMItcgsuxxfoNA3GMQuXHfXlfUHWkgNtApu hLx5nZ+jBqOCK6W9HwxfIHMydzaZ3ACQ/nL6DBgABZIlXByh4GiR0XkIx2d8o0KJJ3xgcfxZN0eo /QETX/fc19ys/wvlsKwm47IaI25Out6930jM3uPTp6aYYXUqg7dW5sfPe/crLc5m1o1M18+axVyo cxkrPVdjM6soiqIoh0hS0bluGYqi3CDh/WBpR9fJwvsZnTcyhra0o+tk4byMzumCNrSlHV0n86Ul bD6EK2+bFzG0pd1FW1aUf8Ndkgnn/8vp/l9RlD+M5IPXQR+7hqBFOGutH6NtADzN0f4IyNLPwkfs 71va0XWyfggoyrXYAFBLBwjwaslVFQEAAAQYAABQSwMECgAAAAAAlYFKNgAAAAAAAAAAAAAAAAkA EABfX01BQ09TWC9VWAwAWkPORVpDzkX1AfUBUEsDBAoAAAAAAJWBSjYAAAAAAAAAAAAAAAAaABAA X19NQUNPU1gvYmVuY2hqc3JlZHVjdGlvbi9VWAwAWkPORVpDzkX1AfUBUEsDBBQACAAIANZ8SjYA AAAAAAAAAAAAAAAlABAAX19NQUNPU1gvYmVuY2hqc3JlZHVjdGlvbi8uXy5EU19TdG9yZVVYDABa Q85FZDvORfUB9QFjYBVjZ2BiwAQgMU4gNgJiBSg/CFmBAxZNIAAAUEsHCA2OI3ccAAAAUgAAAFBL AwQUAAgACAARgUo2AAAAAAAAAAAAAAAAHQAQAGJlbmNoanNyZWR1Y3Rpb24vY29udHJvbC5odG1s VVgMAFpDzkVhQs5F9QH1Ad2VUW/TMBDHn8mnMH6YNhWSZhIT6uIgBpU2NF7WwgviwYmdxuDake2s DLTvzp3bdN3QtO0JhKVG59T3P9/9LnZxOv94XibF6fTt+zJJivnZ/HxankhTtx9mEzKXPryzvQnk Qoq+DsqaIluvgcW+dqoLZXLJHTH+iAlb90tpQrqQYaolmidXZ2Jv7/n2H671m3wyJkkSvYJaymAD 12wc5y4HI0ma3sRYJEB8J32vw35olcepEi+iCZ4H5FdCYKBnbU2AAIwWgVdakso6IR0bk1pq3XEh lFmwwzjzHa9xNi6L4OAnShplNhIj0GjAJF79lCwnDa8l+yyd4IbDGm0dqzSvv5dFVc6nszmho5u9 jWiRVWWRoUBJnqrrpCgxscmgCfaIEi/rdCP5h2IG24eHwwcmDiu2NVm1POC2GEUHZzVOdnebPLsH 2f7gepAqY6TDLmGbqGt91ZAdJIzlAwwcEeMw2YZorFv6L+Ov6ZpoyNNLrnvJhkx33Ee3X14n13ea wgceen+3KZbSe774P/tirbbJEOUe3Q+Pb4dbuJ7QEbt0arvsOBC+AfTPULmYzj6dz2d/l8R99R2g bOpHH6ozFNhFIFCcfagtieroCtpLrky6jaRtzdEnbZ1sGEWnGg/1tA1LTUG1yIajHMxWcoFGZcUV qRbrvKdx4GuhLgl88Ls9lMMRFa60ZLSzXmGkCa+81X2Qx1o2YZKPux/HwXaT12hQuG8ej52slAgt O8xfoZvDB2zvIU5HcWw/xXyHeRLJJBFNMrABAxLD/PCUIjzWmNE2hG6SZavVKm2clMIamQKgrF6o l5UyWYUX5TefdpoSuMlaK2INAiVABwAziiQwYWW6PpBw1UGVWiWENJQYvoTZcBpSsj4OKS7PcBsR B2LAF8iqTH4DUEsHCOxjHtOlAgAAsAcAAFBLAwQUAAgACAD6i0g2AAAAAAAAAAAAAAAAGwAQAGJl bmNoanNyZWR1Y3Rpb24vaW5kZXguaHRtbFVYDABaQ85F6LLLRfUB9QGtkUFLxDAQhe/9FSFHEds9 CCJJQd2FVdaL9g/EdGwC7YwkUxb89Q5N68mTOoeQ93gzfPDMsXs+tZU5Hu72bVWZ7rE7Hdp7QB+e Xm9VB5kfaEZWL9DPniOhqUtGwvW29Z7cBBlYeRqz1bub5vJCq+J+OB9xsLpZjTdKPaRFl6/skOhz iAybZzWSbislU44rlMdqT8iJRq1y8t/qKvAk1uTSEPEcew6C0GxGgDgEtvpalrykx4VGzv+JD0kh JcjxE37AnFzElTGzS/wbQjfzfzKaeiupNLfUvs4XUEsHCOB40pzZAAAABQIAAFBLAwQUAAgACAAl ikg2AAAAAAAAAAAAAAAAGwAQAGJlbmNoanNyZWR1Y3Rpb24vc3RhcnQuaHRtbFVYDABaQ85Fdq/L RfUB9QElT0FOxDAMvPcVVk5wYIvEBbptJVgqLWi5QD+QJqYbCHaUuBXl9aRdH+yxNB7P1Mf+7dQW 9bF7fG6Lou5f+lPXPiGZ8+tHBT0mOfBEAu9oJyOOqS4vnEwuz6jtCga2yzolZimxoL0bqTFIghEM +xQ0NXcwjBlzbLqtMtVRmARkCdioYRJhUjBrP+U1iY4CX3rWyUQXBFJAtCDZkAKmg3fmu1FBx/xk Z5gkst9tRyvF0Xh1rSDJ4rNW4ORW61VEr8XNuP/MBzfJ/WH1EGQvHKr72/C7V209rBFKsVuPW8pL upxWfnxb/ANQSwcIHlVtfOcAAAAyAQAAUEsDBBQACAAIAECBSjYAAAAAAAAAAAAAAAAfABAAYmVu Y2hqc3JlZHVjdGlvbi90ZXN0Y291bnQuaHRtbFVYDABaQ85Ft0LORfUB9QGNVVtv2zYUftev4PSQ ynMm20HTLrEkoF0DtEP7shl7LSiRtggwpEBSdb0h/32HF1Gya6cRIOmI5/6di4qPmy+fq6T4+PDu Q5UkxebT5vND9Z6Kpv3z73u0odr8IXth0F+U9I1hUhQLL5MguJJCN4p1BlS/YYWoIF8bK16ulsul OxJyH478t5EG869cyk6HE8J0x/GhkcJQcOTOFNU9N+HI67FHqhylDVbGfg72I60paBDtYxH6TUlk 0z+ChXxHzQOnlnx/+ESurn6JHMx5knRYWdr6U5LnBrIGL6bXWbpKr1HKJSZM7FCe5+ksSba9cFAg 3cq9C6eW37MZ+s9h8jNjimJyADNW1mVVamo2QMjeZGnMLpul1xbFWfI09TiyX+iOCdQpuQNEdXAa bZSC7tEHbMDYCSNSFrmNczdKuHICHNmZ0EZeCI9tURZ7oIgNMrDttZUKZaxcrllR3t2t2Xw+5TqY xqaZz484eyaI3Oc+43IiF6WeIhXDmNgA6EOXhQztdaFtsldOG2r9apYzIaiyw1Me9280cqG0I0Dp 9dK79BFSrukk7YZTrAZVZ2uMTxvZmbEoTydlGJjBWpiQ02LHY/8+KfTAzQLxW+yI2cLN9oXW84Pr Wi9oXmp0O1OCfjdWy4Jx80OvH0uEbGJtuGywFctbRbdlaoUctnlrHnl6DMmkyMGMWym45nTPiGnL /PXbm19jf3hHR2Ut08KJIy+fzkfleYpaynatXXqolopAokvUUM47TOzaCF+6w437qgqj4Cao3jWS S1UqSqr0jNN5mV6JWnfrC8xiYUgFD2UfNp7K5R1mQgoLYDndUUmxGPa1396LFpaR3fu1JAf7Juwb YgTgZIZT0Eihnw6clmknNbNg3uNaS94buuZ0a+5XyzX0G7xS+Il4hM5CcHMMQYARULdqyj5GOB7c VRVbSBRp9i8tV2iLG1r+QxXBAldFXdkfE1rdo2GcYEUg25fLYlEDGla1cvAkDp/o5Bmr3qS3qK09 7C0iLMiAPZy3FG3ZrodGR0xoRqg78gsI1Vjl6J3xR/iRur5HzIz6GP5tJG5kp3AU7hBvKCgQUJJp ZXSDOX55ZX7/WWVOm3Osh6/R6vbN86U4AzkoY852omygUamKlt4+b+n2fAGnoQS7ys7b88Zc7S62 w0V4hxX/Qnjvbkd4Q5DDNriJg175KR7H9Uf/QPgRhJGE/VUl/wNQSwcIXNq6fIoDAACZCQAAUEsB AhUDCgAAAAAA6ohINgAAAAAAAAAAAAAAABEADAAAAAAAAAAAQO1BAAAAAGJlbmNoanNyZWR1Y3Rp b24vVVgIABlSykUorctFUEsBAhUDFAAIAAgA1nxKNvBqyVUVAQAABBgAABoADAAAAAAAAAAAQKSB PwAAAGJlbmNoanNyZWR1Y3Rpb24vLkRTX1N0b3JlVVgIAFpDzkVkO85FUEsBAhUDCgAAAAAAlYFK NgAAAAAAAAAAAAAAAAkADAAAAAAAAAAAQP1BrAEAAF9fTUFDT1NYL1VYCABaQ85FWkPORVBLAQIV AwoAAAAAAJWBSjYAAAAAAAAAAAAAAAAaAAwAAAAAAAAAAED9QeMBAABfX01BQ09TWC9iZW5jaGpz cmVkdWN0aW9uL1VYCABaQ85FWkPORVBLAQIVAxQACAAIANZ8SjYNjiN3HAAAAFIAAAAlAAwAAAAA AAAAAECkgSsCAABfX01BQ09TWC9iZW5jaGpzcmVkdWN0aW9uLy5fLkRTX1N0b3JlVVgIAFpDzkVk O85FUEsBAhUDFAAIAAgAEYFKNuxjHtOlAgAAsAcAAB0ADAAAAAAAAAAAQKSBqgIAAGJlbmNoanNy ZWR1Y3Rpb24vY29udHJvbC5odG1sVVgIAFpDzkVhQs5FUEsBAhUDFAAIAAgA+otINuB40pzZAAAA BQIAABsADAAAAAAAAAAAQKSBqgUAAGJlbmNoanNyZWR1Y3Rpb24vaW5kZXguaHRtbFVYCABaQ85F 6LLLRVBLAQIVAxQACAAIACWKSDYeVW185wAAADIBAAAbAAwAAAAAAAAAAECkgdwGAABiZW5jaGpz cmVkdWN0aW9uL3N0YXJ0Lmh0bWxVWAgAWkPORXavy0VQSwECFQMUAAgACABAgUo2XNq6fIoDAACZ CQAAHwAMAAAAAAAAAABApIEcCAAAYmVuY2hqc3JlZHVjdGlvbi90ZXN0Y291bnQuaHRtbFVYCABa Q85Ft0LORVBLBQYAAAAACQAJAO8CAAADDAAAAAA=