<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>8739</bug_id>
          
          <creation_ts>2006-05-04 13:30:14 -0700</creation_ts>
          <short_desc>Crash in RenderTableSection::paint due to manipulating DOM on resize</short_desc>
          <delta_ts>2006-05-15 01:34:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://dgl.cx/dump/2005/04/safari-crash.html or http://dgl.cx/dump/2006/05/safari-crash-on-load.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Leadbeater">dgl</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>c.petersen87</cc>
    
    <cc>darin</cc>
    
    <cc>mitz</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>41267</commentid>
    <comment_count>0</comment_count>
    <who name="David Leadbeater">dgl</who>
    <bug_when>2006-05-04 13:30:14 -0700</bug_when>
    <thetext>See referenced URLs.

Safari from 1.3 up to latest nightly webkit build crash on the above URLs which maniuplate the DOM on resize.

This test case was developed from a real application.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41271</commentid>
    <comment_count>1</comment_count>
      <attachid>8113</attachid>
    <who name="">mitz</who>
    <bug_when>2006-05-04 13:47:33 -0700</bug_when>
    <thetext>Created attachment 8113
Backtrace</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42138</commentid>
    <comment_count>2</comment_count>
      <attachid>8272</attachid>
    <who name="">mitz</who>
    <bug_when>2006-05-12 15:05:37 -0700</bug_when>
    <thetext>Created attachment 8272
Patch, including change log and manual test</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42140</commentid>
    <comment_count>3</comment_count>
      <attachid>8272</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2006-05-12 15:21:29 -0700</bug_when>
    <thetext>Comment on attachment 8272
Patch, including change log and manual test

Darin shoudl take a look at this.

This is great news though!  This is the same backtrace as our most common (yet non-reproducible) crasher!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42154</commentid>
    <comment_count>4</comment_count>
      <attachid>8272</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-05-12 20:51:38 -0700</bug_when>
    <thetext>Comment on attachment 8272
Patch, including change log and manual test

I&apos;m not sure this is the best fix. What code is relying on a layout having been done? Why doesn&apos;t that code trigger a layout if it&apos;s pending? An explicit layout here seems to just cover over the real problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42159</commentid>
    <comment_count>5</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-05-13 01:02:35 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; IWhat code is relying on a layout having been
&gt; done?

The painting code is invoked by -[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:] after it calls -[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:].

&gt; Why doesn&apos;t that code trigger a layout if it&apos;s pending?

Calling _web_layoutIfNeededRecursive:testDirtyRect: is doing just that.

&gt; An explicit
&gt; layout here seems to just cover over the real problem.

I think &quot;the real problem&quot; here is that there is a method that promises to do layout but fails to deliver. That method is -[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:], and the proposed patch ensures that it will always do what it says it does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42162</commentid>
    <comment_count>6</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2006-05-13 01:45:04 -0700</bug_when>
    <thetext>layoutToMinimumPageWidth calls layout though (through the forceLayout functions).  Then it sends the resize event (which may schedule another layout).  I guess I need a better understanding of why forceLayout didn&apos;t deliver.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42164</commentid>
    <comment_count>7</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-05-13 01:53:03 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; layoutToMinimumPageWidth calls layout though (through the forceLayout
&gt; functions).  Then it sends the resize event (which may schedule another
&gt; layout).  I guess I need a better understanding of why forceLayout didn&apos;t
&gt; deliver.

As you said, it schedules another layout, but that doesn&apos;t happen until it&apos;s too late, since _recursiveDisplayAllDirtyWithLockFocus:visRect proceeds with painting right after it asks for layout. I really don&apos;t see what the mystery is :-\</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42165</commentid>
    <comment_count>8</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-05-13 01:55:38 -0700</bug_when>
    <thetext>Perhaps I should clarify that the objects that don&apos;t have layout are those added by the resize event handler.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42166</commentid>
    <comment_count>9</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2006-05-13 01:59:01 -0700</bug_when>
    <thetext>Ah, ok, yes, that was the clarification I needed.

With your patch, though, we do one layout, resize, and then do another layout.  Couldn&apos;t we do the resize check at the top of the function, and then just let the remaining code do the single layout?
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42169</commentid>
    <comment_count>10</comment_count>
    <who name="">mitz</who>
    <bug_when>2006-05-13 03:25:30 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; With your patch, though, we do one layout, resize, and then do another layout. 
&gt; Couldn&apos;t we do the resize check at the top of the function, and then just let
&gt; the remaining code do the single layout?

So we talked about this on IRC. It&apos;s true that this fix add a layout, but only in the resize-handler-that-manupulates-the-DOM case.

If you want to do just one layout, you need to go deep into Frame::forceLayoutWithPageWidthRange and separate it into a function that sets the width and marks as needing layout (which you will call into before sending the resize event) and a function that forces layout (possibly twice for printing?) (which you will call into after sending the resize event). I&apos;m not sure it&apos;s worth it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42196</commentid>
    <comment_count>11</comment_count>
      <attachid>8272</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-05-13 08:46:41 -0700</bug_when>
    <thetext>Comment on attachment 8272
Patch, including change log and manual test

OK. With the new explanation I think this is an acceptable way to fix the bug. The change log is not good, though. prepare-ChangeLog used the wrong class name!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42335</commentid>
    <comment_count>12</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-05-14 21:32:56 -0700</bug_when>
    <thetext>Committed revision 14371.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42354</commentid>
    <comment_count>13</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2006-05-15 01:34:30 -0700</bug_when>
    <thetext>I&apos;m hopeful this fixed:
&lt;rdar://problem/4018768&gt; unrepro but oft-reported Safari crash in khtml::RenderTableSection::paint</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>8113</attachid>
            <date>2006-05-04 13:47:33 -0700</date>
            <delta_ts>2006-05-04 13:47:33 -0700</delta_ts>
            <desc>Backtrace</desc>
            <filename>8739 backtrace.txt</filename>
            <type>text/plain</type>
            <size>5822</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">MCAgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAJMHgwMWEwYTBjYyBXZWJDb3JlOjpSZW5kZXJU
YWJsZVNlY3Rpb246OnBhaW50KFdlYkNvcmU6OlJlbmRlck9iamVjdDo6UGFpbnRJbmZvJiwgaW50
LCBpbnQpICsgMzA4IChSZW5kZXJUYWJsZVNlY3Rpb24uY3BwOjYzMCkKMSAgIGNvbS5hcHBsZS5X
ZWJDb3JlICAgICAgICAJMHgwMWEwODA0YyBXZWJDb3JlOjpSZW5kZXJUYWJsZTo6cGFpbnQoV2Vi
Q29yZTo6UmVuZGVyT2JqZWN0OjpQYWludEluZm8mLCBpbnQsIGludCkgKyAxMDA0IChSZW5kZXJU
YWJsZS5jcHA6Mzk4KQoyICAgY29tLmFwcGxlLldlYkNvcmUgICAgICAgIAkweDAxOTdiNTEwIFdl
YkNvcmU6OlJlbmRlckJsb2NrOjpwYWludENoaWxkcmVuKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6
UGFpbnRJbmZvJiwgaW50LCBpbnQpICsgODIwIChSZW5kZXJCbG9jay5jcHA6MTI3OSkKMyAgIGNv
bS5hcHBsZS5XZWJDb3JlICAgICAgICAJMHgwMTk4NTk3OCBXZWJDb3JlOjpSZW5kZXJCbG9jazo6
cGFpbnRPYmplY3QoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpQYWludEluZm8mLCBpbnQsIGludCkg
KyA0ODAgKFJlbmRlckJsb2NrLmNwcDoxMzM1KQo0ICAgY29tLmFwcGxlLldlYkNvcmUgICAgICAg
IAkweDAxOTdiMDc0IFdlYkNvcmU6OlJlbmRlckJsb2NrOjpwYWludChXZWJDb3JlOjpSZW5kZXJP
YmplY3Q6OlBhaW50SW5mbyYsIGludCwgaW50KSArIDYxNiAoUmVuZGVyQmxvY2suY3BwOjEyNTQp
CjUgICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgCTB4MDE5N2I1MTAgV2ViQ29yZTo6UmVuZGVy
QmxvY2s6OnBhaW50Q2hpbGRyZW4oV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpQYWludEluZm8mLCBp
bnQsIGludCkgKyA4MjAgKFJlbmRlckJsb2NrLmNwcDoxMjc5KQo2ICAgY29tLmFwcGxlLldlYkNv
cmUgICAgICAgIAkweDAxOTg1OTc4IFdlYkNvcmU6OlJlbmRlckJsb2NrOjpwYWludE9iamVjdChX
ZWJDb3JlOjpSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYsIGludCwgaW50KSArIDQ4MCAoUmVuZGVy
QmxvY2suY3BwOjEzMzUpCjcgICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgCTB4MDE5N2IwNzQg
V2ViQ29yZTo6UmVuZGVyQmxvY2s6OnBhaW50KFdlYkNvcmU6OlJlbmRlck9iamVjdDo6UGFpbnRJ
bmZvJiwgaW50LCBpbnQpICsgNjE2IChSZW5kZXJCbG9jay5jcHA6MTI1NCkKOCAgIGNvbS5hcHBs
ZS5XZWJDb3JlICAgICAgICAJMHgwMTljMzE1NCBXZWJDb3JlOjpSZW5kZXJMYXllcjo6cGFpbnRM
YXllcihXZWJDb3JlOjpSZW5kZXJMYXllciosIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCosIFdl
YkNvcmU6OkludFJlY3QgY29uc3QmLCBib29sLCBib29sLCBXZWJDb3JlOjpSZW5kZXJPYmplY3Qq
KSArIDEyMjQgKFJlbmRlckxheWVyLmNwcDoxMTU3KQo5ICAgY29tLmFwcGxlLldlYkNvcmUgICAg
ICAgIAkweDAxOWMzM2Q0IFdlYkNvcmU6OlJlbmRlckxheWVyOjpwYWludExheWVyKFdlYkNvcmU6
OlJlbmRlckxheWVyKiwgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0KiwgV2ViQ29yZTo6SW50UmVj
dCBjb25zdCYsIGJvb2wsIGJvb2wsIFdlYkNvcmU6OlJlbmRlck9iamVjdCopICsgMTg2NCAoUmVu
ZGVyTGF5ZXIuY3BwOjExODUpCjEwICBjb20uYXBwbGUuV2ViQ29yZSAgICAgICAgCTB4MDE5YzM0
ZTQgV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnBhaW50KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCos
IFdlYkNvcmU6OkludFJlY3QgY29uc3QmLCBib29sLCBXZWJDb3JlOjpSZW5kZXJPYmplY3QqKSAr
IDcyIChSZW5kZXJMYXllci5jcHA6MTA2OCkKMTEgIGNvbS5hcHBsZS5XZWJDb3JlICAgICAgICAJ
MHgwMTg5ZTI2NCBXZWJDb3JlOjpGcmFtZTo6cGFpbnQoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0
KiwgV2ViQ29yZTo6SW50UmVjdCBjb25zdCYpICsgNzI0IChGcmFtZS5jcHA6Mjc2OSkKMTIgIGNv
bS5hcHBsZS5XZWJDb3JlICAgICAgICAJMHgwMThlMmUyMCAtW1dlYkNvcmVGcmFtZUJyaWRnZSBk
cmF3UmVjdDpdICsgNjU2IChXZWJDb3JlRnJhbWVCcmlkZ2UubW06ODUxKQoxMyAgY29tLmFwcGxl
LldlYktpdCAgICAgICAgIAkweDAwMzZlZmMwIC1bV2ViSFRNTFZpZXcgZHJhd1NpbmdsZVJlY3Q6
XSArIDYwMCAoV2ViSFRNTFZpZXcubToyNTUzKQoxNCAgY29tLmFwcGxlLldlYktpdCAgICAgICAg
IAkweDAwMzZmMzIwIC1bV2ViSFRNTFZpZXcgZHJhd1JlY3Q6XSArIDUzNiAoV2ViSFRNTFZpZXcu
bToyNjAxKQoxNSAgY29tLmFwcGxlLkFwcEtpdCAgICAgICAgIAkweDkzNzY1YmY4IC1bTlNWaWV3
IF9kcmF3UmVjdDpjbGlwOl0gKyAyMTI4CjE2ICBjb20uYXBwbGUuQXBwS2l0ICAgICAgICAgCTB4
OTM3NjUxYjggLVtOU1ZpZXcgX3JlY3Vyc2l2ZURpc3BsYXlBbGxEaXJ0eVdpdGhMb2NrRm9jdXM6
dmlzUmVjdDpdICsgNDA0CjE3ICBjb20uYXBwbGUuV2ViS2l0ICAgICAgICAgCTB4MDAzNjQxMGMg
LVtXZWJIVE1MVmlldyhXZWJQcml2YXRlKSBfcmVjdXJzaXZlRGlzcGxheUFsbERpcnR5V2l0aExv
Y2tGb2N1czp2aXNSZWN0Ol0gKyA2OTIgKFdlYkhUTUxWaWV3Lm06ODYxKQoxOCAgY29tLmFwcGxl
LkFwcEtpdCAgICAgICAgIAkweDkzNzY3ZjAwIF9yZWN1cnNpdmVEaXNwbGF5SW5SZWN0MiArIDg0
CjE5ICBjb20uYXBwbGUuQ29yZUZvdW5kYXRpb24gCTB4OTA3ZjMzYzQgQ0ZBcnJheUFwcGx5RnVu
Y3Rpb24gKyA0MTYKMjAgIGNvbS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc2NTJjYyAtW05T
VmlldyBfcmVjdXJzaXZlRGlzcGxheUFsbERpcnR5V2l0aExvY2tGb2N1czp2aXNSZWN0Ol0gKyA2
ODAKMjEgIGNvbS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc2N2YwMCBfcmVjdXJzaXZlRGlz
cGxheUluUmVjdDIgKyA4NAoyMiAgY29tLmFwcGxlLkNvcmVGb3VuZGF0aW9uIAkweDkwN2YzM2M0
IENGQXJyYXlBcHBseUZ1bmN0aW9uICsgNDE2CjIzICBjb20uYXBwbGUuQXBwS2l0ICAgICAgICAg
CTB4OTM3NjUyY2MgLVtOU1ZpZXcgX3JlY3Vyc2l2ZURpc3BsYXlBbGxEaXJ0eVdpdGhMb2NrRm9j
dXM6dmlzUmVjdDpdICsgNjgwCjI0ICBjb20uYXBwbGUuQXBwS2l0ICAgICAgICAgCTB4OTM3Njdm
MDAgX3JlY3Vyc2l2ZURpc3BsYXlJblJlY3QyICsgODQKMjUgIGNvbS5hcHBsZS5Db3JlRm91bmRh
dGlvbiAJMHg5MDdmMzNjNCBDRkFycmF5QXBwbHlGdW5jdGlvbiArIDQxNgoyNiAgY29tLmFwcGxl
LkFwcEtpdCAgICAgICAgIAkweDkzNzY1MmNjIC1bTlNWaWV3IF9yZWN1cnNpdmVEaXNwbGF5QWxs
RGlydHlXaXRoTG9ja0ZvY3VzOnZpc1JlY3Q6XSArIDY4MAoyNyAgY29tLmFwcGxlLkFwcEtpdCAg
ICAgICAgIAkweDkzNzY3ZjAwIF9yZWN1cnNpdmVEaXNwbGF5SW5SZWN0MiArIDg0CjI4ICBjb20u
YXBwbGUuQ29yZUZvdW5kYXRpb24gCTB4OTA3ZjMzYzQgQ0ZBcnJheUFwcGx5RnVuY3Rpb24gKyA0
MTYKMjkgIGNvbS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc2NTJjYyAtW05TVmlldyBfcmVj
dXJzaXZlRGlzcGxheUFsbERpcnR5V2l0aExvY2tGb2N1czp2aXNSZWN0Ol0gKyA2ODAKMzAgIGNv
bS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc2N2YwMCBfcmVjdXJzaXZlRGlzcGxheUluUmVj
dDIgKyA4NAozMSAgY29tLmFwcGxlLkNvcmVGb3VuZGF0aW9uIAkweDkwN2YzM2M0IENGQXJyYXlB
cHBseUZ1bmN0aW9uICsgNDE2CjMyICBjb20uYXBwbGUuQXBwS2l0ICAgICAgICAgCTB4OTM3NjUy
Y2MgLVtOU1ZpZXcgX3JlY3Vyc2l2ZURpc3BsYXlBbGxEaXJ0eVdpdGhMb2NrRm9jdXM6dmlzUmVj
dDpdICsgNjgwCjMzICBjb20uYXBwbGUuQXBwS2l0ICAgICAgICAgCTB4OTM3NjdmMDAgX3JlY3Vy
c2l2ZURpc3BsYXlJblJlY3QyICsgODQKMzQgIGNvbS5hcHBsZS5Db3JlRm91bmRhdGlvbiAJMHg5
MDdmMzNjNCBDRkFycmF5QXBwbHlGdW5jdGlvbiArIDQxNgozNSAgY29tLmFwcGxlLkFwcEtpdCAg
ICAgICAgIAkweDkzNzY1MmNjIC1bTlNWaWV3IF9yZWN1cnNpdmVEaXNwbGF5QWxsRGlydHlXaXRo
TG9ja0ZvY3VzOnZpc1JlY3Q6XSArIDY4MAozNiAgY29tLmFwcGxlLkFwcEtpdCAgICAgICAgIAkw
eDkzNzY3ZjAwIF9yZWN1cnNpdmVEaXNwbGF5SW5SZWN0MiArIDg0CjM3ICBjb20uYXBwbGUuQ29y
ZUZvdW5kYXRpb24gCTB4OTA3ZjMzYzQgQ0ZBcnJheUFwcGx5RnVuY3Rpb24gKyA0MTYKMzggIGNv
bS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc2NTJjYyAtW05TVmlldyBfcmVjdXJzaXZlRGlz
cGxheUFsbERpcnR5V2l0aExvY2tGb2N1czp2aXNSZWN0Ol0gKyA2ODAKMzkgIGNvbS5hcHBsZS5B
cHBLaXQgICAgICAgICAJMHg5Mzc2NDc4MCAtW05TVmlldyBfcmVjdXJzaXZlRGlzcGxheVJlY3RJ
Zk5lZWRlZElnbm9yaW5nT3BhY2l0eTppc1Zpc2libGVSZWN0OnJlY3RJc1Zpc2libGVSZWN0Rm9y
Vmlldzp0b3BWaWV3Ol0gKyAxOTYKNDAgIGNvbS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc4
NTNlNCAtW05TVGhlbWVGcmFtZSBfcmVjdXJzaXZlRGlzcGxheVJlY3RJZk5lZWRlZElnbm9yaW5n
T3BhY2l0eTppc1Zpc2libGVSZWN0OnJlY3RJc1Zpc2libGVSZWN0Rm9yVmlldzp0b3BWaWV3Ol0g
KyAxOTIKNDEgIGNvbS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc1ZTNmNCAtW05TVmlldyBf
ZGlzcGxheVJlY3RJZ25vcmluZ09wYWNpdHk6aXNWaXNpYmxlUmVjdDpyZWN0SXNWaXNpYmxlUmVj
dEZvclZpZXc6XSArIDM4NAo0MiAgY29tLmFwcGxlLkFwcEtpdCAgICAgICAgIAkweDkzNzUzNmU4
IC1bTlNWaWV3IGRpc3BsYXlJZk5lZWRlZF0gKyAyNDgKNDMgIGNvbS5hcHBsZS5BcHBLaXQgICAg
ICAgICAJMHg5MzgxNGM0NCAtW05TVGhlbWVGcmFtZSBoYW5kbGVTZXRGcmFtZUNvbW1vblJlZGlz
cGxheV0gKyAyNTYKNDQgIGNvbS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc2MTM4NCAtW05T
V2luZG93IF9zZXRGcmFtZUNvbW1vbjpkaXNwbGF5OnN0YXNoU2l6ZTpdICsgNzA4CjQ1ICBjb20u
YXBwbGUuQXBwS2l0ICAgICAgICAgCTB4OTM3NjEwYWMgLVtOU1dpbmRvdyBzZXRGcmFtZTpkaXNw
bGF5Ol0gKyA0MAo0NiAgY29tLmFwcGxlLlNhZmFyaSAgICAgICAgIAkweDAwMDBmZGUwIDB4MTAw
MCArIDYwODk2CjQ3ICBjb20uYXBwbGUuQXBwS2l0ICAgICAgICAgCTB4OTM4NmI5ZTQgLVtOU1Rp
dGxlZEZyYW1lIHJlc2l6ZVdpdGhFdmVudDpdICsgOTcyCjQ4ICBjb20uYXBwbGUuQXBwS2l0ICAg
ICAgICAgCTB4OTM4NmIwYjggLVtOU1RpdGxlZEZyYW1lIG1vdXNlRG93bjpdICsgMTQwCjQ5ICBj
b20uYXBwbGUuQXBwS2l0ICAgICAgICAgCTB4OTM4NmIwMTggLVtOU1RoZW1lRnJhbWUgbW91c2VE
b3duOl0gKyAxODgKNTAgIGNvbS5hcHBsZS5BcHBLaXQgICAgICAgICAJMHg5Mzc3YmMzMCAtW05T
V2luZG93IHNlbmRFdmVudDpdICsgNDYxNgo1MSAgY29tLmFwcGxlLlNhZmFyaSAgICAgICAgIAkw
eDAwMDIxY2E0IDB4MTAwMCArIDEzNDMwOAo1MiAgY29tLmFwcGxlLkFwcEtpdCAgICAgICAgIAkw
eDkzNzI0Yzc0IC1bTlNBcHBsaWNhdGlvbiBzZW5kRXZlbnQ6XSArIDQxNzIKNTMgIGNvbS5hcHBs
ZS5TYWZhcmkgICAgICAgICAJMHgwMDAyMTdhOCAweDEwMDAgKyAxMzMwMzIKNTQgIGNvbS5hcHBs
ZS5BcHBLaXQgICAgICAgICAJMHg5MzcxYzBiMCAtW05TQXBwbGljYXRpb24gcnVuXSArIDUwOAo1
NSAgY29tLmFwcGxlLkFwcEtpdCAgICAgICAgIAkweDkzODBjYmZjIE5TQXBwbGljYXRpb25NYWlu
ICsgNDUyCjU2ICBjb20uYXBwbGUuU2FmYXJpICAgICAgICAgCTB4MDAwNWNiOTggMHgxMDAwICsg
Mzc1NzA0CjU3ICBjb20uYXBwbGUuU2FmYXJpICAgICAgICAgCTB4MDAwNWNhNDAgMHgxMDAwICsg
Mzc1MzYwCgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>8272</attachid>
            <date>2006-05-12 15:05:37 -0700</date>
            <delta_ts>2006-05-13 08:46:41 -0700</delta_ts>
            <desc>Patch, including change log and manual test</desc>
            <filename>8739_r1.patch</filename>
            <type>text/plain</type>
            <size>3229</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAxNDMzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTIgQEAKKzIwMDYtMDUtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA
bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgLSB0ZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19i
dWcuY2dpP2lkPTg3MzkKKyAgICAgICAgICBDcmFzaCBpbiBSZW5kZXJUYWJsZVNlY3Rpb246OnBh
aW50IGR1ZSB0byBtYW5pcHVsYXRpbmcgRE9NIG9uIHJlc2l6ZQorCisgICAgICAgICogbWFudWFs
LXRlc3RzL2RvbS1tYW5pcHVsYXRpb24tb24tcmVzaXplLmh0bWw6IEFkZGVkLgorCiAyMDA2LTA1
LTEyICBFcmljIFNlaWRlbCAgPGVzZWlkZWxAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk
IGJ5IGJldGguCkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9kb20tbWFuaXB1bGF0aW9uLW9u
LXJlc2l6ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbWFudWFsLXRlc3RzL2RvbS1tYW5p
cHVsYXRpb24tb24tcmVzaXplLmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL21hbnVhbC10
ZXN0cy9kb20tbWFuaXB1bGF0aW9uLW9uLXJlc2l6ZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww
ICsxLDI4IEBACis8aHRtbD4KKzxoZWFkPjxzdHlsZT4KK2JvZHkgeyBvdmVyZmxvdzogaGlkZGVu
OyB9Cis8L3N0eWxlPgorPHNjcmlwdD4KK3dpbmRvdy5vbnJlc2l6ZSA9IGZ1bmN0aW9uKCkgewor
CXZhciB0Ym9keSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoIlRCT0RZIikKKworCXZhciBtID0g
KGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJUQUJMRSIpKVswXQorCWlmKG0uaGFzQ2hp
bGROb2RlcygpKSBtLnJlbW92ZUNoaWxkKG0ubGFzdENoaWxkKQorCisJdmFyIHRyID0gdGJvZHku
YXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiVFIiKSkKKworCW0uYXBwZW5kQ2hp
bGQodGJvZHkpCit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0ic2V0VGltZW91
dCgnd2luZG93LnJlc2l6ZVRvKDUwMCw1MDApJywgMCkiPgorPHRhYmxlPjwvdGFibGU+Cis8cD4K
KzxiPkJVRyBJRDogPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3df
YnVnLmNnaT9pZD04NzM5Ij5CdWd6aWxsYSBidWcgODczOTwvYT48L2I+CitDcmFzaCBpbiBSZW5k
ZXJUYWJsZVNlY3Rpb246OnBhaW50IGR1ZSB0byBtYW5pcHVsYXRpbmcgRE9NIG9uIHJlc2l6ZQor
PC9wPgorPHAgaWQ9InN1Y2Nlc3MiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOnBhbGVncmVlbjsg
cGFkZGluZzozcHg7Ij4KKz48Yj5URVNUIFBBU1M6PC9iPiBZb3UgZ290IGhlcmUgd2l0aG91dCBj
cmFzaGluZywgd2hpY2ggbWVhbnMgdGVzdCBQQVNTLiBJdCBpcyBub3JtYWwgZm9yIHRoZQord2lu
ZG93IHRvIGhhdmUgcmVzaXplZC4KKzwvcD4KKzwvYm9keT48L2h0bWw+CkluZGV4OiBXZWJLaXQv
Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzMy
KQorKysgV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisy
MDA2LTA1LSMjICBNaXR6IFBldHRlbCAgPG9wZW5kYXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0
dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODczOQorICAgICAg
ICAgIENyYXNoIGluIFJlbmRlclRhYmxlU2VjdGlvbjo6cGFpbnQgZHVlIHRvIG1hbmlwdWxhdGlu
ZyBET00gb24gcmVzaXplCisKKyAgICAgICAgTWFudWFsIHRlc3Q6IG1hbnVhbC10ZXN0cy9kb20t
bWFuaXB1bGF0aW9uLW9uLXJlc2l6ZS5odG1sCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhUTUxW
aWV3Lm06CisgICAgICAgICgtW05TQXJyYXkgbGF5b3V0VG9NaW5pbXVtUGFnZVdpZHRoOm1heGlt
dW1QYWdlV2lkdGg6YWRqdXN0aW5nVmlld1NpemU6XSk6IFJlbGF5b3V0IGlmIG5lY2Vzc2FyeQor
ICAgICAgICBhZnRlciBzZW5kaW5nIHRoZSByZXNpemUgZXZlbnQuCisKIDIwMDYtMDUtMTIgIFRp
bSBPbWVybmljayAgPHRpbW9AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4g
U3VsbGl2YW4uCkluZGV4OiBXZWJLaXQvV2ViVmlldy9XZWJIVE1MVmlldy5tCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFdlYktpdC9XZWJWaWV3L1dlYkhUTUxWaWV3Lm0JKHJldmlzaW9uIDE0MzMyKQorKysgV2Vi
S2l0L1dlYlZpZXcvV2ViSFRNTFZpZXcubQkod29ya2luZyBjb3B5KQpAQCAtMjQxNCw2ICsyNDE0
LDggQEAgc3RhdGljIFdlYkhUTUxWaWV3ICpsYXN0SGl0VmlldyA9IG5pbDsKICAgICAgICAgTlNT
aXplIG5ld0xheW91dEZyYW1lU2l6ZSA9IFtbW3NlbGYgc3VwZXJ2aWV3XSBzdXBlcnZpZXddIGZy
YW1lXS5zaXplOwogICAgICAgICBpZiAoX3ByaXZhdGUtPmxhaWRPdXRBdExlYXN0T25jZSAmJiAh
TlNFcXVhbFNpemVzKF9wcml2YXRlLT5sYXN0TGF5b3V0RnJhbWVTaXplLCBuZXdMYXlvdXRGcmFt
ZVNpemUpKSB7CiAgICAgICAgICAgICBbW3NlbGYgX2JyaWRnZV0gc2VuZFJlc2l6ZUV2ZW50XTsK
KyAgICAgICAgICAgIGlmIChbW3NlbGYgX2JyaWRnZV0gbmVlZHNMYXlvdXRdKQorICAgICAgICAg
ICAgICAgIFtbc2VsZiBfYnJpZGdlXSBmb3JjZUxheW91dEFkanVzdGluZ1ZpZXdTaXplOk5PXTsK
ICAgICAgICAgfQogICAgICAgICBfcHJpdmF0ZS0+bGFpZE91dEF0TGVhc3RPbmNlID0gWUVTOwog
ICAgICAgICBfcHJpdmF0ZS0+bGFzdExheW91dFNpemUgPSBbKE5TQ2xpcFZpZXcgKilbc2VsZiBz
dXBlcnZpZXddIGRvY3VtZW50VmlzaWJsZVJlY3RdLnNpemU7Cg==
</data>
<flag name="review"
          id="2324"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>