87374 2012-05-24 05:02:37 -0700 Reorder arguments to compare() in the QML WebView tests 2012-05-24 05:51:43 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf cmarcelo kenneth menard webkit.review.bot zoltan oldest_to_newest 632630 0 ahf 2012-05-24 05:02:37 -0700 SSIA. 632635 1 143789 ahf 2012-05-24 05:07:07 -0700 Created attachment 143789 Patch 632639 2 143789 cmarcelo 2012-05-24 05:12:49 -0700 Comment on attachment 143789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143789&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:-56 > - // Delayed windowShown to workaround problems with Qt5 in debug mode. > - when: false > - Timer { > - running: parent.windowShown > - repeat: false > - interval: 1 > - onTriggered: parent.when = true > - } ChangeLog doesn't talk about this, that is the most significant change. If you don't mention feels like it was an accident. Do other files still have this workaround? If so, can it be removed from them too? 632641 3 143789 hausmann 2012-05-24 05:13:48 -0700 Comment on attachment 143789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143789&action=review > Source/WebKit2/ChangeLog:7 > + Reorder arguments to compare() in the QML WebView tests > + https://bugs.webkit.org/show_bug.cgi?id=87374 > + > + Reviewed by NOBODY (OOPS!). > + I'm missing a _why_ here, i.e. why do you re-order the arguments? I can make an guess myself, but it would be nicer without me and potentially others guessing :) > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:-57 > - // Delayed windowShown to workaround problems with Qt5 in debug mode. > - when: false > - Timer { > - running: parent.windowShown > - repeat: false > - interval: 1 > - onTriggered: parent.when = true > - } > - I suggest to mention in the ChangeLog that you removed this workaround because it's not necessary anymore. (Is that correct?) 632649 4 143794 ahf 2012-05-24 05:25:45 -0700 Created attachment 143794 Patch 632682 5 ahf 2012-05-24 05:51:43 -0700 Committed r118355: <http://trac.webkit.org/changeset/118355> 143789 2012-05-24 05:07:07 -0700 2012-05-24 05:25:38 -0700 Patch bug-87374-20120524141732.patch text/plain 2297 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQxOTFjYzkxZDhlYjY5 YzgyOTJjMjllZmEzOTU4NjcyOTI1NjM2OC4uNTNhODMzNmJiYzJjNGI4NmU3N2RkZGYzNjYxNjAy MmVkODIxN2Y5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTI0ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgorCisgICAgICAgIFJl b3JkZXIgYXJndW1lbnRzIHRvIGNvbXBhcmUoKSBpbiB0aGUgUU1MIFdlYlZpZXcgdGVzdHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3Mzc0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzZWQgb24gcGF0 Y2ggYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2RvdWJsZVRhcFRvWm9vbS5xbWw6CisK IDIwMTItMDUtMjQgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5j b20+CiAKICAgICAgICAgW1F0XSBUaWxlcyBub3QgcGFpbnRlZCBhZnRlciB3aGVlbCBvciBrZXli b2FyZCBzY3JvbGwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2RvdWJsZVRhcFRvWm9vbS5xbWwgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2RvdWJs ZVRhcFRvWm9vbS5xbWwKaW5kZXggOTA0ZjYwZmViMTE3YzZmZDNlYzBkOThhMzk2ZDI3ODNmNGQz YjRiNC4uYjJhODYwZTczYmE2ZjIzNjhiZGM1M2QwNzFkMmU5YWM3NGFiZjY5NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3 L3RzdF9kb3VibGVUYXBUb1pvb20ucW1sCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfZG91YmxlVGFwVG9ab29tLnFtbApAQCAt NDYsMTUgKzQ2LDYgQEAgSXRlbSB7CiAKICAgICAgICAgcHJvcGVydHkgdmFyaWFudCB0ZXN0OiB3 ZWJWaWV3LmV4cGVyaW1lbnRhbC50ZXN0CiAKLSAgICAgICAgLy8gRGVsYXllZCB3aW5kb3dTaG93 biB0byB3b3JrYXJvdW5kIHByb2JsZW1zIHdpdGggUXQ1IGluIGRlYnVnIG1vZGUuCi0gICAgICAg IHdoZW46IGZhbHNlCi0gICAgICAgIFRpbWVyIHsKLSAgICAgICAgICAgIHJ1bm5pbmc6IHBhcmVu dC53aW5kb3dTaG93bgotICAgICAgICAgICAgcmVwZWF0OiBmYWxzZQotICAgICAgICAgICAgaW50 ZXJ2YWw6IDEKLSAgICAgICAgICAgIG9uVHJpZ2dlcmVkOiBwYXJlbnQud2hlbiA9IHRydWUKLSAg ICAgICAgfQotCiAgICAgICAgIGZ1bmN0aW9uIGluaXQoKSB7CiAgICAgICAgICAgICByZXN1bHRT cHkuY2xlYXIoKQogICAgICAgICAgICAgc2NhbGVTcHkuY2xlYXIoKQpAQCAtOTIsMTUgKzgzLDE1 IEBAIEl0ZW0gewogICAgICAgICAgICAgd2ViVmlldy51cmwgPSB3ZWJWaWV3LmNvbnRlbnQKICAg ICAgICAgICAgIHZlcmlmeSh3ZWJWaWV3LndhaXRGb3JMb2FkU3VjY2VlZGVkKCkpCiAKLSAgICAg ICAgICAgIGNvbXBhcmUoIjQ4MHg3MjAiLCBkb2N1bWVudFNpemUoKSkKKyAgICAgICAgICAgIGNv bXBhcmUoZG9jdW1lbnRTaXplKCksICI0ODB4NzIwIikKIAotICAgICAgICAgICAgY29tcGFyZSgx LjAsIHRlc3QuY29udGVudHNTY2FsZSkKKyAgICAgICAgICAgIGNvbXBhcmUodGVzdC5jb250ZW50 c1NjYWxlLCAxLjApCiAKICAgICAgICAgICAgIHZhciByZWN0ID0gZWxlbWVudFJlY3QoInRhcmdl dCIpOwogICAgICAgICAgICAgdmFyIG5ld1NjYWxlID0gd2ViVmlldy53aWR0aCAvIChyZWN0Lndp ZHRoICsgMiAqIDEwKSAvLyBpbmZsYXRlZCBieSAxMHB4CiAgICAgICAgICAgICBkb3VibGVUYXBB dFBvaW50KHJlY3QubGVmdCArIHJlY3QuaGVpZ2h0IC8gMiwgcmVjdC50b3AgKyByZWN0LndpZHRo IC8gMikKIAotICAgICAgICAgICAgY29tcGFyZShuZXdTY2FsZSwgdGVzdC5jb250ZW50c1NjYWxl KQorICAgICAgICAgICAgY29tcGFyZSh0ZXN0LmNvbnRlbnRzU2NhbGUsIG5ld1NjYWxlKQogICAg ICAgICB9CiAgICAgfQogfQo= 143794 2012-05-24 05:25:45 -0700 2012-05-24 05:45:49 -0700 Patch bug-87374-20120524143610.patch text/plain 2666 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQxOTFjYzkxZDhlYjY5 YzgyOTJjMjllZmEzOTU4NjcyOTI1NjM2OC4uZGY5MzQzZjA3Yzc4NjVkMTExNDY1NGE1MjhhY2Vl YmI2YWJiZjM0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTI0ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgorCisgICAgICAgIFJl b3JkZXIgYXJndW1lbnRzIHRvIGNvbXBhcmUoKSBpbiB0aGUgUU1MIFdlYlZpZXcgdGVzdHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3Mzc0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzZWQgb24gcGF0 Y2ggYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgVGhlIHJlb3JkZXJp bmcgaXMgbmVjZXNzYXJ5IHRvIGdldCBjb3JyZWN0IGluZm9ybWF0aW9uIHByaW50ZWQgd2hlbgor ICAgICAgICB0aGUgdGVzdHMgZmFpbHMuIFdpdGhvdXQgdGhpcywgdGhlIHRlc3Qgc3VpdGUgd2ls bCBkaXNwbGF5IHRoZSBib2d1cworICAgICAgICB2YWx1ZSBhbmQgbm90IHRoZSBleHBlY3RlZCB2 YWx1ZS4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gcmVtb3ZlcyB0aGUgZGVsYXllZCB3aW5k b3dTaG93biBzaW5jZSB0aGlzIGlzIG5vdAorICAgICAgICBuZWVkZWQgYW55bW9yZSwgZHVlIHRv IHVzIHVzaW5nIHRoZSB0b3VjaCBldmVudHMgaW5zdGVhZCBvZiBtb3VzZQorICAgICAgICBldmVu dHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcv dHN0X2RvdWJsZVRhcFRvWm9vbS5xbWw6CisKIDIwMTItMDUtMjQgIEFsbGFuIFNhbmRmZWxkIEpl bnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBUaWxlcyBub3Qg cGFpbnRlZCBhZnRlciB3aGVlbCBvciBrZXlib2FyZCBzY3JvbGwuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2Rv dWJsZVRhcFRvWm9vbS5xbWwgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3Rz L3FtbHRlc3RzL1dlYlZpZXcvdHN0X2RvdWJsZVRhcFRvWm9vbS5xbWwKaW5kZXggOTA0ZjYwZmVi MTE3YzZmZDNlYzBkOThhMzk2ZDI3ODNmNGQzYjRiNC4uYjJhODYwZTczYmE2ZjIzNjhiZGM1M2Qw NzFkMmU5YWM3NGFiZjY5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9kb3VibGVUYXBUb1pvb20ucW1sCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90 c3RfZG91YmxlVGFwVG9ab29tLnFtbApAQCAtNDYsMTUgKzQ2LDYgQEAgSXRlbSB7CiAKICAgICAg ICAgcHJvcGVydHkgdmFyaWFudCB0ZXN0OiB3ZWJWaWV3LmV4cGVyaW1lbnRhbC50ZXN0CiAKLSAg ICAgICAgLy8gRGVsYXllZCB3aW5kb3dTaG93biB0byB3b3JrYXJvdW5kIHByb2JsZW1zIHdpdGgg UXQ1IGluIGRlYnVnIG1vZGUuCi0gICAgICAgIHdoZW46IGZhbHNlCi0gICAgICAgIFRpbWVyIHsK LSAgICAgICAgICAgIHJ1bm5pbmc6IHBhcmVudC53aW5kb3dTaG93bgotICAgICAgICAgICAgcmVw ZWF0OiBmYWxzZQotICAgICAgICAgICAgaW50ZXJ2YWw6IDEKLSAgICAgICAgICAgIG9uVHJpZ2dl cmVkOiBwYXJlbnQud2hlbiA9IHRydWUKLSAgICAgICAgfQotCiAgICAgICAgIGZ1bmN0aW9uIGlu aXQoKSB7CiAgICAgICAgICAgICByZXN1bHRTcHkuY2xlYXIoKQogICAgICAgICAgICAgc2NhbGVT cHkuY2xlYXIoKQpAQCAtOTIsMTUgKzgzLDE1IEBAIEl0ZW0gewogICAgICAgICAgICAgd2ViVmll dy51cmwgPSB3ZWJWaWV3LmNvbnRlbnQKICAgICAgICAgICAgIHZlcmlmeSh3ZWJWaWV3LndhaXRG b3JMb2FkU3VjY2VlZGVkKCkpCiAKLSAgICAgICAgICAgIGNvbXBhcmUoIjQ4MHg3MjAiLCBkb2N1 bWVudFNpemUoKSkKKyAgICAgICAgICAgIGNvbXBhcmUoZG9jdW1lbnRTaXplKCksICI0ODB4NzIw IikKIAotICAgICAgICAgICAgY29tcGFyZSgxLjAsIHRlc3QuY29udGVudHNTY2FsZSkKKyAgICAg ICAgICAgIGNvbXBhcmUodGVzdC5jb250ZW50c1NjYWxlLCAxLjApCiAKICAgICAgICAgICAgIHZh ciByZWN0ID0gZWxlbWVudFJlY3QoInRhcmdldCIpOwogICAgICAgICAgICAgdmFyIG5ld1NjYWxl ID0gd2ViVmlldy53aWR0aCAvIChyZWN0LndpZHRoICsgMiAqIDEwKSAvLyBpbmZsYXRlZCBieSAx MHB4CiAgICAgICAgICAgICBkb3VibGVUYXBBdFBvaW50KHJlY3QubGVmdCArIHJlY3QuaGVpZ2h0 IC8gMiwgcmVjdC50b3AgKyByZWN0LndpZHRoIC8gMikKIAotICAgICAgICAgICAgY29tcGFyZShu ZXdTY2FsZSwgdGVzdC5jb250ZW50c1NjYWxlKQorICAgICAgICAgICAgY29tcGFyZSh0ZXN0LmNv bnRlbnRzU2NhbGUsIG5ld1NjYWxlKQogICAgICAgICB9CiAgICAgfQogfQo=