87365 2012-05-24 03:18:40 -0700 ProgressEvent JSC binding should have no static table 2012-05-28 20:25:03 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82156 1 leo.yang leo.yang abarth charles.wei ericu eric levin ojan rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 632579 0 leo.yang 2012-05-24 03:18:40 -0700 ProgressEvent could be used in filesystem FileWriter in worker thread, so we should add ProgressEvent in idl file. 632580 1 143776 leo.yang 2012-05-24 03:20:58 -0700 Created attachment 143776 Patch 632973 2 143776 levin 2012-05-24 11:15:45 -0700 Comment on attachment 143776 Patch Is it possible to write a test for this? It seems like there should be some thing that is noticeably failing. 635069 3 144316 leo.yang 2012-05-28 03:06:46 -0700 Created attachment 144316 Patch v2 It's covered by existing test actually. 635320 4 144316 staikos 2012-05-28 10:41:10 -0700 Comment on attachment 144316 Patch v2 Covered by existing tests, no regressions on any platform according to bots. reasonable change. r+ 635327 5 144316 webkit.review.bot 2012-05-28 11:17:47 -0700 Comment on attachment 144316 Patch v2 Clearing flags on attachment: 144316 Committed r118698: <http://trac.webkit.org/changeset/118698> 635328 6 webkit.review.bot 2012-05-28 11:17:53 -0700 All reviewed patches have been landed. Closing bug. 635349 7 levin 2012-05-28 11:56:09 -0700 (In reply to comment #3) > Created an attachment (id=144316) [details] > Patch v2 > > It's covered by existing test actually. Was fast/filesystem/workers/file-writer-events.html failing before this? If so, why wasn't it removed from any skipped files? 635496 8 leo.yang 2012-05-28 18:40:29 -0700 (In reply to comment #7) > (In reply to comment #3) > > Created an attachment (id=144316) [details] [details] > > Patch v2 > > > > It's covered by existing test actually. > > Was fast/filesystem/workers/file-writer-events.html failing before this? > > If so, why wasn't it removed from any skipped files? It seems that all platforms(except for chromium) don't support FileSystem API in upstreaming. Chromium is using v8 so it's not affected by this. We are implementing FileSystem API for blackberry porting and found this problem. Blackberry implement of FileSystem API will be upstreaming and you will see we don't skip fast/filesystem. 635535 9 levin 2012-05-28 20:25:03 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #3) > > > Created an attachment (id=144316) [details] [details] [details] > > > Patch v2 > > > > > > It's covered by existing test actually. > > > > Was fast/filesystem/workers/file-writer-events.html failing before this? > > > > If so, why wasn't it removed from any skipped files? > > It seems that all platforms(except for chromium) don't support FileSystem API in upstreaming. Chromium is using v8 so it's not affected by this. We are implementing FileSystem API for blackberry porting and found this problem. Blackberry implement of FileSystem API will be upstreaming and you will see we don't skip fast/filesystem. Thanks! 143776 2012-05-24 03:20:58 -0700 2012-05-28 03:06:46 -0700 Patch 0001-ProgressEvent-JSC-binding-should-have-no-static-tabl.patch text/plain 1823 leo.yang RnJvbSA5YjllNzQyMmMxODU0NTg5OWZhNWE3OWRiYzFjODAzNGNhOTBlNzQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUaHUsIDI0IE1heSAyMDEyIDE4OjIwOjIyICswODAwClN1YmplY3Q6IFtQQVRDSF0g UHJvZ3Jlc3NFdmVudCBKU0MgYmluZGluZyBzaG91bGQgaGF2ZSBubyBzdGF0aWMgdGFibGUKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzM2NQoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgpQcm9ncmVzc0V2ZW50IGNvdWxkIGJlIHVzZWQgaW4gZmlsZXN5c3Rl bSBGaWxlV3JpdGVyIGluIHdvcmtlciB0aHJlYWQsIHNvIHdlIHNob3VsZCBhZGQgUHJvZ3Jlc3NF dmVudCBpbiBpZGwgZmlsZS4KCiogZG9tL1Byb2dyZXNzRXZlbnQuaWRsOgotLS0KIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIFNvdXJjZS9X ZWJDb3JlL2RvbS9Qcm9ncmVzc0V2ZW50LmlkbCB8ICAgIDMgKystCiAyIGZpbGVzIGNoYW5nZWQs IDEzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWIyYjE2ZC4u OTZlMzhhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTI0ICBMZW8gWWFu ZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBQcm9ncmVzc0V2ZW50 IEpTQyBiaW5kaW5nIHNob3VsZCBoYXZlIG5vIHN0YXRpYyB0YWJsZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODczNjUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9ncmVzc0V2ZW50IGNvdWxkIGJlIHVz ZWQgaW4gZmlsZXN5c3RlbSBGaWxlV3JpdGVyIGluIHdvcmtlciB0aHJlYWQsIHNvIHdlIHNob3Vs ZCBhZGQgUHJvZ3Jlc3NFdmVudCBpbiBpZGwgZmlsZS4KKworICAgICAgICAqIGRvbS9Qcm9ncmVz c0V2ZW50LmlkbDoKKwogMjAxMi0wNS0yMyAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIGFkZCBiYWNrIHRoZSBhYmlsaXR5IHRvIGRpc2FibGUgZmxleGJveApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1Byb2dyZXNzRXZlbnQuaWRsIGIvU291cmNlL1dl YkNvcmUvZG9tL1Byb2dyZXNzRXZlbnQuaWRsCmluZGV4IGY4ZDBiNWIuLjUyNWZhNGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qcm9ncmVzc0V2ZW50LmlkbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vUHJvZ3Jlc3NFdmVudC5pZGwKQEAgLTI2LDcgKzI2LDggQEAKIG1vZHVsZSBl dmVudHMgewogCiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgQ29uc3RydWN0b3JUZW1wbGF0ZT1F dmVudAorICAgICAgICBDb25zdHJ1Y3RvclRlbXBsYXRlPUV2ZW50LAorICAgICAgICBKU05vU3Rh dGljVGFibGVzCiAgICAgXSBQcm9ncmVzc0V2ZW50IDogRXZlbnQgewogICAgICAgICByZWFkb25s eSBhdHRyaWJ1dGUgW0luaXRpYWxpemVkQnlFdmVudENvbnN0cnVjdG9yXSBib29sZWFuIGxlbmd0 aENvbXB1dGFibGU7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbSW5pdGlhbGl6ZWRCeUV2 ZW50Q29uc3RydWN0b3JdIHVuc2lnbmVkIGxvbmcgbG9uZyBsb2FkZWQ7Ci0tIAoxLjcuOS41Cgo= 144316 2012-05-28 03:06:46 -0700 2012-05-28 11:17:47 -0700 Patch v2 0001-ProgressEvent-JSC-binding-should-have-no-static-tabl.patch text/plain 1987 leo.yang RnJvbSA0ZTQ4YjNiNTAzY2NhZDEwYjY5NWExNWJhYjI0Y2YyOTc4M2FjM2NlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBNb24sIDI4IE1heSAyMDEyIDE4OjA1OjIwICswODAwClN1YmplY3Q6IFtQQVRDSF0g UHJvZ3Jlc3NFdmVudCBKU0MgYmluZGluZyBzaG91bGQgaGF2ZSBubyBzdGF0aWMgdGFibGUKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzM2NQoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgpQcm9ncmVzc0V2ZW50IGNvdWxkIGJlIHVzZWQgaW4gZmlsZXN5c3Rl bSBGaWxlV3JpdGVyIGluIHdvcmtlciB0aHJlYWQsIHNvIHdlIHNob3VsZCBhZGQgUHJvZ3Jlc3NF dmVudCBpbiBpZGwgZmlsZS4KCkNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdDogZmFzdC9maWxlc3lz dGVtL3dvcmtlcnMvZmlsZS13cml0ZXItZXZlbnRzLmh0bWwuCgoqIGRvbS9Qcm9ncmVzc0V2ZW50 LmlkbDoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgfCAgIDEzICsr KysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2RvbS9Qcm9ncmVzc0V2ZW50LmlkbCB8ICAgIDMg KystCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNWIyYjE2ZC4uN2ZkMTEzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA1LTI0ICBMZW8gWWFuZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KKwor ICAgICAgICBQcm9ncmVzc0V2ZW50IEpTQyBiaW5kaW5nIHNob3VsZCBoYXZlIG5vIHN0YXRpYyB0 YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcz NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9n cmVzc0V2ZW50IGNvdWxkIGJlIHVzZWQgaW4gZmlsZXN5c3RlbSBGaWxlV3JpdGVyIGluIHdvcmtl ciB0aHJlYWQsIHNvIHdlIHNob3VsZCBhZGQgUHJvZ3Jlc3NFdmVudCBpbiBpZGwgZmlsZS4KKwor ICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Q6IGZhc3QvZmlsZXN5c3RlbS93b3JrZXJz L2ZpbGUtd3JpdGVyLWV2ZW50cy5odG1sLgorCisgICAgICAgICogZG9tL1Byb2dyZXNzRXZlbnQu aWRsOgorCiAyMDEyLTA1LTIzICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgYWRkIGJhY2sgdGhlIGFiaWxpdHkgdG8gZGlzYWJsZSBmbGV4Ym94CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kb20vUHJvZ3Jlc3NFdmVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9k b20vUHJvZ3Jlc3NFdmVudC5pZGwKaW5kZXggZjhkMGI1Yi4uNTI1ZmE0YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL1Byb2dyZXNzRXZlbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Qcm9ncmVzc0V2ZW50LmlkbApAQCAtMjYsNyArMjYsOCBAQAogbW9kdWxlIGV2ZW50cyB7 CiAKICAgICBpbnRlcmZhY2UgWwotICAgICAgICBDb25zdHJ1Y3RvclRlbXBsYXRlPUV2ZW50Cisg ICAgICAgIENvbnN0cnVjdG9yVGVtcGxhdGU9RXZlbnQsCisgICAgICAgIEpTTm9TdGF0aWNUYWJs ZXMKICAgICBdIFByb2dyZXNzRXZlbnQgOiBFdmVudCB7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBbSW5pdGlhbGl6ZWRCeUV2ZW50Q29uc3RydWN0b3JdIGJvb2xlYW4gbGVuZ3RoQ29tcHV0 YWJsZTsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtJbml0aWFsaXplZEJ5RXZlbnRDb25z dHJ1Y3Rvcl0gdW5zaWduZWQgbG9uZyBsb25nIGxvYWRlZDsKLS0gCjEuNy45LjUKCg==