87364 2012-05-24 02:54:05 -0700 Shadow DOM drop event tests are very flaky. 2012-07-18 22:05:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vsevik webkit-unassigned dglazkov shinyak webkit.review.bot oldest_to_newest 632569 0 vsevik 2012-05-24 02:54:05 -0700 The following layout test is failing on chromium in debug. fast/dom/shadow/drop-event-for-input-in-shadow.html fast/dom/shadow/drop-event-in-shadow.html * fast/dom/shadow/drop-event-for-input-in-shadow.html: Added. * fast/dom/shadow/drop-event-in-shadow.html: Added. Probable cause: These tests were flaking since creation. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2Fshadow%2Fdrop-event-for-input-in-shadow.html%20fast%2Fdom%2Fshadow%2Fdrop-event-in-shadow.html%20 632587 1 shinyak 2012-05-24 03:40:21 -0700 Thanks for reporting. I'll investigate this soon 632600 2 vsevik 2012-05-24 04:10:28 -0700 Skipped in: Committed r118340: <http://trac.webkit.org/changeset/118340> 632864 3 dglazkov 2012-05-24 09:17:31 -0700 This is odd. The test seems fine at a glance. beginDragWithFiles is all synchronous... hmm. 665416 4 151387 tasak 2012-07-09 19:14:59 -0700 Created attachment 151387 Patch 673093 5 151387 morrita 2012-07-18 19:28:42 -0700 Comment on attachment 151387 Patch Let's give a shot. 673162 6 151387 webkit.review.bot 2012-07-18 22:05:20 -0700 Comment on attachment 151387 Patch Clearing flags on attachment: 151387 Committed r123070: <http://trac.webkit.org/changeset/123070> 673163 7 webkit.review.bot 2012-07-18 22:05:25 -0700 All reviewed patches have been landed. Closing bug. 151387 2012-07-09 19:14:59 -0700 2012-07-18 22:05:20 -0700 Patch bug-87364-20120710111458.patch text/plain 4872 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMTc1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWY5N2NmODEwYTA1MzQxZmM1MzM1 MjJlZDUxNTdjMzM0ZTUxNTU2OC4uYzc3NDk5YzA3ZTQxOTljN2QzNzdjMzkwYjFmYjAyNDY2MjJi ZTRhMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTA5ICBUYWthc2hpIFNha2Ftb3Rv ICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBTaGFkb3cgRE9NIGRyb3AgZXZlbnQgdGVz dHMgYXJlIHZlcnkgZmxha3kuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NzM2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1vZGlmaWVkIHRoZXNlIHRlc3RzIHRvIHJ1biB0ZXN0IGZ1bmN0aW9ucyBpbiBv bmxvYWQuIFByb2JhYmx5CisgICAgICAgIGV4ZWN1dGluZyBldmVudCB0ZXN0cyB3aGlsZSBwYXJz aW5nIGh0bWwgZG9jdW1lbnQgY2F1c2VzIGZsYWt5bmVzcy4KKworICAgICAgICAqIGZhc3QvZG9t L3NoYWRvdy9kcm9wLWV2ZW50LWZvci1pbnB1dC1pbi1zaGFkb3cuaHRtbDoKKyAgICAgICAgKiBm YXN0L2RvbS9zaGFkb3cvZHJvcC1ldmVudC1pbi1zaGFkb3cuaHRtbDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA3LTA5ICBZb25nanVuIFpo YW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQ29uc2lkZXIgY2xvc2lu ZyB1bnVzZWQgbG9jYWxTdG9yYWdlIGRhdGFiYXNlIGFmdGVyIGEgdGltZW91dC4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9kcm9wLWV2ZW50LWZvci1pbnB1dC1pbi1z aGFkb3cuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9kcm9wLWV2ZW50LWZvci1p bnB1dC1pbi1zaGFkb3cuaHRtbAppbmRleCA5MDUyNDlkOTAyNzkzZmExMjI5MzAyMWM0MzEyZDRh OTI4OGUzNTU3Li5lMDdjOTYwMmYxNjE4MGZjMWE4MWU4YjdlNTg5MmU2NjU1NTc5NGVmIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvZHJvcC1ldmVudC1mb3ItaW5wdXQt aW4tc2hhZG93Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2Ryb3AtZXZl bnQtZm9yLWlucHV0LWluLXNoYWRvdy5odG1sCkBAIC00LDEyICs0LDYgQEAKIDxzY3JpcHQgc3Jj PSJyZXNvdXJjZXMvcG9seWZpbGwuanMiPjwvc2NyaXB0PgogPHNjcmlwdCBzcmM9Ii4uL3Jlc291 cmNlcy9ldmVudC1zZW5kZXItdXRpbC5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0iLi4vLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KLTwvaGVhZD4KLTxib2R5Pgot Ci08ZGl2IGlkPSJob3N0Ij48L2Rpdj4KLTxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJlPgotCiA8c2Ny aXB0PgogZnVuY3Rpb24gY3JlYXRlSW5wdXQobmFtZSkgewogICAgIHZhciBkaXYgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCdpbnB1dCcpOwpAQCAtMjMsMTcgKzE3LDIwIEBAIGZ1bmN0aW9uIGNy ZWF0ZUlucHV0KG5hbWUpIHsKICAgICByZXR1cm4gZGl2OwogfQogCi12YXIgc2hhZG93Um9vdCA9 IG5ldyBXZWJLaXRTaGFkb3dSb290KGhvc3QpOwotdmFyIHNoYWRvd0lucHV0ID0gY3JlYXRlSW5w dXQoJ3NoYWRvdycpOwotc2hhZG93Um9vdC5hcHBlbmRDaGlsZChzaGFkb3dJbnB1dCk7CitmdW5j dGlvbiBydW5UZXN0KCkgeworICAgIHZhciBzaGFkb3dSb290ID0gbmV3IFdlYktpdFNoYWRvd1Jv b3QoaG9zdCk7CisgICAgdmFyIHNoYWRvd0lucHV0ID0gY3JlYXRlSW5wdXQoJ3NoYWRvdycpOwor ICAgIHNoYWRvd1Jvb3QuYXBwZW5kQ2hpbGQoc2hhZG93SW5wdXQpOwogCi1ldmVudFNlbmRlci5i ZWdpbkRyYWdXaXRoRmlsZXMoWyIuLi9yZXNvdXJjZXMvYXBwbGUuZ2lmIl0pOwotbW91c2VNb3Zl VG9FbGVtKHNoYWRvd0lucHV0KTsKLWV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKLQotdmFyIHN1Y2Nl c3NmdWxseVBhcnNlZCA9IHRydWU7CisgICAgZXZlbnRTZW5kZXIuYmVnaW5EcmFnV2l0aEZpbGVz KFsiLi4vcmVzb3VyY2VzL2FwcGxlLmdpZiJdKTsKKyAgICBtb3VzZU1vdmVUb0VsZW0oc2hhZG93 SW5wdXQpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKK30KIDwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgogCi08c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8ZGl2IGlkPSJob3N0Ij48L2Rpdj4K KzxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJlPgogPC9ib2R5PgogPC9odG1sPgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2Ryb3AtZXZlbnQtaW4tc2hhZG93Lmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvZHJvcC1ldmVudC1pbi1zaGFkb3cuaHRtbAppbmRl eCA4NWY4M2E1NTg1YzMzNGFiNzI4Y2NhZjhlNTNjYTFjNTM0YzNlODhjLi4xZDUyMzQ2ZjZjMTU0 Njg3YzJmMzAzYTZkNWY3MDU0YWZjODYxMjM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9zaGFkb3cvZHJvcC1ldmVudC1pbi1zaGFkb3cuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2RvbS9zaGFkb3cvZHJvcC1ldmVudC1pbi1zaGFkb3cuaHRtbApAQCAtNCwxMiArNCw2IEBA CiA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3BvbHlmaWxsLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQg c3JjPSIuLi9yZXNvdXJjZXMvZXZlbnQtc2VuZGVyLXV0aWwuanMiPjwvc2NyaXB0PgogPHNjcmlw dCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Ci08L2hl YWQ+Ci08Ym9keT4KLQotPGRpdiBpZD0iaG9zdCI+PC9kaXY+Ci08cHJlIGlkPSJjb25zb2xlIj48 L3ByZT4KLQogPHNjcmlwdD4KIGZ1bmN0aW9uIGNyZWF0ZUJveChuYW1lKSB7CiAgICAgdmFyIGRp diA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwpAQCAtMjMsMTcgKzE3LDIwIEBAIGZ1 bmN0aW9uIGNyZWF0ZUJveChuYW1lKSB7CiAgICAgcmV0dXJuIGRpdjsKIH0KIAotdmFyIHNoYWRv d1Jvb3QgPSBuZXcgV2ViS2l0U2hhZG93Um9vdChob3N0KTsKLXZhciBzaGFkb3dEaXYgPSBjcmVh dGVCb3goJ3NoYWRvdycpOwotc2hhZG93Um9vdC5hcHBlbmRDaGlsZChzaGFkb3dEaXYpOworZnVu Y3Rpb24gcnVuVGVzdCgpIHsKKyAgICB2YXIgc2hhZG93Um9vdCA9IG5ldyBXZWJLaXRTaGFkb3dS b290KGhvc3QpOworICAgIHZhciBzaGFkb3dEaXYgPSBjcmVhdGVCb3goJ3NoYWRvdycpOworICAg IHNoYWRvd1Jvb3QuYXBwZW5kQ2hpbGQoc2hhZG93RGl2KTsKIAotZXZlbnRTZW5kZXIuYmVnaW5E cmFnV2l0aEZpbGVzKFsiLi4vcmVzb3VyY2VzL2FwcGxlLmdpZiJdKTsKLW1vdXNlTW92ZVRvRWxl bShzaGFkb3dEaXYpOwotZXZlbnRTZW5kZXIubW91c2VVcCgpOwotCi12YXIgc3VjY2Vzc2Z1bGx5 UGFyc2VkID0gdHJ1ZTsKKyAgICBldmVudFNlbmRlci5iZWdpbkRyYWdXaXRoRmlsZXMoWyIuLi9y ZXNvdXJjZXMvYXBwbGUuZ2lmIl0pOworICAgIG1vdXNlTW92ZVRvRWxlbShzaGFkb3dEaXYpOwor ICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKK30KIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkg b25sb2FkPSJydW5UZXN0KCkiPgogCi08c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8ZGl2IGlkPSJob3N0Ij48L2Rpdj4KKzxwcmUgaWQ9 ImNvbnNvbGUiPjwvcHJlPgogPC9ib2R5PgogPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYWFiOTZjNzJhMzIxM2E3ZWNkYTQw Zjg1ZWM2NGY2OTVlOGUzNmU2Yy4uN2I0MDcxOTlmYzY3NzJlZTQwMzkwNTA5NGNjNjVjN2JjMjI2 MWFjYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVj dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRp b25zCkBAIC0zNTk1LDEwICszNTk1LDYgQEAgQlVHV0s4NzMyMSBYUCA6IGZhc3QvaGlzdG9yeS9o aXN0b3J5LXRyYXZlcnNhbC1pcy1hc3luY2hyb25vdXMuaHRtbCA9IFRFWFQgUEFTUwogQlVHV0s3 OTU0MCBERUJVRyA6IGZhc3QvZmlsZXMvd29ya2Vycy93b3JrZXItcmVhZC1ibG9iLWFzeW5jLmh0 bWwgPSBQQVNTIENSQVNICiBCVUdXSzc5NTQwIERFQlVHIDogZmFzdC9maWxlcy93b3JrZXJzL3dv cmtlci1yZWFkLWJsb2Itc3luYy5odG1sID0gUEFTUyBDUkFTSAogCi0vLyBTaGFkb3cgRE9NIGRy b3AgZXZlbnQgdGVzdHMgYXJlIHZlcnkgZmxha3kgc2luY2UgY3JlYXRpb24KLUJVR1dLODczNjQg REVCVUcgOiBmYXN0L2RvbS9zaGFkb3cvZHJvcC1ldmVudC1mb3ItaW5wdXQtaW4tc2hhZG93Lmh0 bWwgPSBURVhUIFBBU1MKLUJVR1dLODczNjQgREVCVUcgOiBmYXN0L2RvbS9zaGFkb3cvZHJvcC1l dmVudC1pbi1zaGFkb3cuaHRtbCA9IFRFWFQgUEFTUwotCiAvLyBSZXF1aXJlcyBzZXRVc2VEZWZl cnJlZEZyYW1lTG9hZGluZygpIEFQSSBmcm9tIExheW91dFRlc3RDb250cm9sbGVyLgogQlVHV0s4 NzY1MiBTS0lQIDogaHR0cC90ZXN0cy9hcHBjYWNoZS9sb2FkLWZyb20tYXBwY2FjaGUtZGVmZXIt cmVzdW1lLWNyYXNoLmh0bWwgPSBQQVNTCiAK