87340 2012-05-23 22:12:49 -0700 Web Inspector: Breakpoints Pane should not show context menu with no breakpoints 2012-05-24 07:49:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vivekgalatage vivekgalatage apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 632415 0 vivekgalatage 2012-05-23 22:12:49 -0700 Breakpoints Pane should not show context menu with no breakpoints 632425 1 143730 vivekgalatage 2012-05-23 22:30:04 -0700 Created attachment 143730 Patch 632602 2 143730 pfeldman 2012-05-24 04:16:33 -0700 Comment on attachment 143730 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143730&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:141 > + breakpointsCount: function() Nit: I would call it breakpointCount, but this is also ok. Also, you really want hasBreakpoints() here! 632683 3 143805 vivekgalatage 2012-05-24 05:53:05 -0700 Created attachment 143805 Patch 632790 4 143805 webkit.review.bot 2012-05-24 07:49:26 -0700 Comment on attachment 143805 Patch Clearing flags on attachment: 143805 Committed r118371: <http://trac.webkit.org/changeset/118371> 632791 5 webkit.review.bot 2012-05-24 07:49:34 -0700 All reviewed patches have been landed. Closing bug. 143730 2012-05-23 22:30:04 -0700 2012-05-24 05:52:56 -0700 Patch bug-87340-20120524105957.patch text/plain 2381 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODMyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTIzICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEJyZWFrcG9pbnRzIFBhbmUgc2hvdWxkIG5vdCBzaG93IGNvbnRleHQgbWVudSB3aXRoIG5v IGJyZWFrcG9pbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzM0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZGVkIGJyZWFrcG9pbnRzQ291bnQgdG8gQnJlYWtwb2ludE1hbmFnZXIgbWV0aG9kIHRv IGNoZWNrIGFuZAorICAgICAgICBwb3B1bGF0ZSB0aGUgY29udGV4dCBtZW51LgorCisgICAgICAg IFVJIEZlYXR1cmUgbm8gdGVzdHMgcmVxdWlyZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL0JyZWFrcG9pbnRNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkJyZWFr cG9pbnRNYW5hZ2VyLnByb3RvdHlwZS5icmVha3BvaW50c0NvdW50KToKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRzU2lkZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuSmF2YVNjcmlwdEJyZWFrcG9pbnRzU2lkZWJhclBhbmUucHJvdG90eXBlLl9jb250 ZXh0TWVudSk6CisKIDIwMTItMDUtMjMgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIERvY3VtZW50LmVsZW1lbnRGcm9tUG9pbnQgZXhwb3NlcyBpbm5l ciBlbGVtZW50IG9mIFNoYWRvdyBET00uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0JyZWFrcG9pbnRNYW5hZ2VyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludE1hbmFnZXIuanMJKHJldmlzaW9uIDEx ODMxOSkKKysrIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludE1h bmFnZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTEzNyw2ICsxMzcsMTEgQEAgV2ViSW5zcGVjdG9y LkJyZWFrcG9pbnRNYW5hZ2VyLnByb3RvdHlwZQogICAgICAgICB9CiAgICAgICAgIHJldHVybiBy ZXN1bHQ7CiAgICAgfSwKKyAgICAKKyAgICBicmVha3BvaW50c0NvdW50OiBmdW5jdGlvbigpIAor ICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMuX2JyZWFrcG9pbnRzLmxlbmd0aDsKKyAgICB9LAog CiAgICAgcmVtb3ZlQWxsQnJlYWtwb2ludHM6IGZ1bmN0aW9uKCkKICAgICB7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRzU2lkZWJhclBhbmUuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3Bv aW50c1NpZGViYXJQYW5lLmpzCShyZXZpc2lvbiAxMTgzMTkpCisrKyBTb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRzU2lkZWJhclBhbmUuanMJKHdvcmtpbmcgY29w eSkKQEAgLTE4MCw2ICsxODAsOSBAQCBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdEJyZWFrcG9pbnRz U2lkZWJhCiAKICAgICBfY29udGV4dE1lbnU6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKKyAgICAg ICAgaWYgKHRoaXMuX2JyZWFrcG9pbnRNYW5hZ2VyLmJyZWFrcG9pbnRzQ291bnQoKSA8PSAwKQor ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgCiAgICAgICAgIHZhciBjb250ZXh0TWVu dSA9IG5ldyBXZWJJbnNwZWN0b3IuQ29udGV4dE1lbnUoKTsKICAgICAgICAgdmFyIHJlbW92ZUFs bFRpdGxlID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKFdlYkluc3BlY3Rvci51c2VMb3dlckNhc2VN ZW51VGl0bGVzKCkgPyAiUmVtb3ZlIGFsbCBKYXZhU2NyaXB0IGJyZWFrcG9pbnRzIiA6ICJSZW1v dmUgQWxsIEphdmFTY3JpcHQgQnJlYWtwb2ludHMiKTsKICAgICAgICAgY29udGV4dE1lbnUuYXBw ZW5kSXRlbShyZW1vdmVBbGxUaXRsZSwgdGhpcy5fYnJlYWtwb2ludE1hbmFnZXIucmVtb3ZlQWxs QnJlYWtwb2ludHMuYmluZCh0aGlzLl9icmVha3BvaW50TWFuYWdlcikpOwo= 143805 2012-05-24 05:53:05 -0700 2012-05-24 07:49:26 -0700 Patch bug-87340-20120524182257.patch text/plain 2348 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODM1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTI0ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEJyZWFrcG9pbnRzIFBhbmUgc2hvdWxkIG5vdCBzaG93IGNvbnRleHQgbWVudSB3aXRoIG5v IGJyZWFrcG9pbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzM0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZWQgdGhlIG1ldGhvZCBfY29udGV4dE1lbnUgYXMgdGhpcyB3b3VsZCBiZSByZWR1 bmRhbnQgY2FsbAorICAgICAgICBiZWNhdXNlIF9icmVha3BvaW50Q29udGV4dE1lbnUgd291bGQg dGFrZSBjYXJlIG9mIHNob3dpbmcgdGhlIHJlbW92ZQorICAgICAgICBhbGwgYnJlYWtwb2ludHMg b3B0aW9uLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50c1NpZGVi YXJQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRCcmVha3BvaW50c1Np ZGViYXJQYW5lKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0QnJlYWtwb2ludHNT aWRlYmFyUGFuZS5wcm90b3R5cGUuX2JyZWFrcG9pbnRDb250ZXh0TWVudSk6CisKIDIwMTItMDUt MjQgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAg U1ZHWm9vbUFuZFBhbiBjb25zdGFudHMgYXJlIG1pc3NpbmcgZnJvbSB3aW5kb3cgb2JqZWN0Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRzU2lkZWJh clBhbmUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9CcmVha3BvaW50c1NpZGViYXJQYW5lLmpzCShyZXZpc2lvbiAxMTgzMTkpCisrKyBTb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRzU2lkZWJhclBhbmUuanMJKHdv cmtpbmcgY29weSkKQEAgLTQzLDcgKzQzLDYgQEAgV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRCcmVh a3BvaW50c1NpZGViYQogICAgIHRoaXMuZW1wdHlFbGVtZW50LnRleHRDb250ZW50ID0gV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJObyBCcmVha3BvaW50cyIpOwogCiAgICAgdGhpcy5ib2R5RWxlbWVu dC5hcHBlbmRDaGlsZCh0aGlzLmVtcHR5RWxlbWVudCk7Ci0gICAgdGhpcy5ib2R5RWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIHRoaXMuX2NvbnRleHRNZW51LmJpbmQodGhp cyksIGZhbHNlKTsKIAogICAgIHRoaXMuX2l0ZW1zID0gbmV3IE1hcCgpOwogICAgIHRoaXMuX2Jy ZWFrcG9pbnRNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRN YW5hZ2VyLkV2ZW50cy5CcmVha3BvaW50QWRkZWQsIHRoaXMuX2JyZWFrcG9pbnRBZGRlZCwgdGhp cyk7CkBAIC0xNzgsMTQgKzE3Nyw2IEBAIFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0QnJlYWtwb2lu dHNTaWRlYmEKICAgICAgICAgY29udGV4dE1lbnUuc2hvdyhldmVudCk7CiAgICAgfSwKIAotICAg IF9jb250ZXh0TWVudTogZnVuY3Rpb24oZXZlbnQpCi0gICAgewotICAgICAgICB2YXIgY29udGV4 dE1lbnUgPSBuZXcgV2ViSW5zcGVjdG9yLkNvbnRleHRNZW51KCk7Ci0gICAgICAgIHZhciByZW1v dmVBbGxUaXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZyhXZWJJbnNwZWN0b3IudXNlTG93ZXJD YXNlTWVudVRpdGxlcygpID8gIlJlbW92ZSBhbGwgSmF2YVNjcmlwdCBicmVha3BvaW50cyIgOiAi UmVtb3ZlIEFsbCBKYXZhU2NyaXB0IEJyZWFrcG9pbnRzIik7Ci0gICAgICAgIGNvbnRleHRNZW51 LmFwcGVuZEl0ZW0ocmVtb3ZlQWxsVGl0bGUsIHRoaXMuX2JyZWFrcG9pbnRNYW5hZ2VyLnJlbW92 ZUFsbEJyZWFrcG9pbnRzLmJpbmQodGhpcy5fYnJlYWtwb2ludE1hbmFnZXIpKTsKLSAgICAgICAg Y29udGV4dE1lbnUuc2hvdyhldmVudCk7Ci0gICAgfSwKLQogICAgIF9hZGRMaXN0RWxlbWVudDog ZnVuY3Rpb24oZWxlbWVudCwgYmVmb3JlRWxlbWVudCkKICAgICB7CiAgICAgICAgIGlmIChiZWZv cmVFbGVtZW50KQo=