<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>8734</bug_id>
          
          <creation_ts>2006-05-04 11:02:59 -0700</creation_ts>
          <short_desc>Would like a Vector::append that takes another Vector</short_desc>
          <delta_ts>2006-05-04 13:32:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>6638</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>41250</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2006-05-04 11:02:59 -0700</bug_when>
    <thetext>The xpath implementation uses a lot of Vectors for keeping track of node sets. It&apos;d be nice to have an append function that takes another Vector as this it&apos;s something that&apos;s done commonly in the xpath code</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41251</commentid>
    <comment_count>1</comment_count>
      <attachid>8107</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2006-05-04 11:07:03 -0700</bug_when>
    <thetext>Created attachment 8107
Implement function

This function works for me, but I&apos;m not sure how correct it is. It doesn&apos;t support appending the vector to itself, but I don&apos;t know if we need that</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41264</commentid>
    <comment_count>2</comment_count>
      <attachid>8107</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2006-05-04 13:17:19 -0700</bug_when>
    <thetext>Comment on attachment 8107
Implement function

Looks good to me. A more general version that takes start and end iterator might also be handy (and could be used to implement this one.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>8107</attachid>
            <date>2006-05-04 11:07:03 -0700</date>
            <delta_ts>2006-05-04 13:17:19 -0700</delta_ts>
            <desc>Implement function</desc>
            <filename>vector-append.txt</filename>
            <type>text/plain</type>
            <size>1505</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">SW5kZXg6IGt4bWxjb3JlL1ZlY3Rvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGt4bWxjb3JlL1ZlY3Rvci5o
CShyZXZpc2lvbiAxNDE3OSkKKysrIGt4bWxjb3JlL1ZlY3Rvci5oCSh3b3JraW5nIGNvcHkpCkBA
IC0zNzgsNiArMzc4LDcgQEAgbmFtZXNwYWNlIEtYTUxDb3JlIHsKICAgICAgICAgdm9pZCBjbGVh
cigpIHsgcmVzaXplKDApOyB9CiAKICAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gdm9pZCBh
cHBlbmQoY29uc3QgVSYpOworICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiB2b2lkIGFwcGVu
ZChjb25zdCBWZWN0b3I8VT4mKTsKICAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gdm9pZCBp
bnNlcnQoc2l6ZV90IHBvc2l0aW9uLCBjb25zdCBVJik7CiAgICAgICAgIHZvaWQgcmVtb3ZlKHNp
emVfdCBwb3NpdGlvbik7CiAKQEAgLTU0NSw2ICs1NDYsMTUgQEAgbmFtZXNwYWNlIEtYTUxDb3Jl
IHsKICAgICB9CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCBzaXplX3QgaW5saW5lQ2FwYWNp
dHk+IHRlbXBsYXRlPHR5cGVuYW1lIFU+CisgICAgaW5saW5lIHZvaWQgVmVjdG9yPFQsIGlubGlu
ZUNhcGFjaXR5Pjo6YXBwZW5kKGNvbnN0IFZlY3RvcjxVPiYgdmFsKQorICAgIHsKKyAgICAgICAg
aWYgKHNpemUoKSArIHZhbC5zaXplKCkgPj0gY2FwYWNpdHkoKSkKKyAgICAgICAgICAgIGV4cGFu
ZENhcGFjaXR5KHNpemUoKSArIHZhbC5zaXplKCkpOworICAgICAgICBmb3IgKHVuc2lnbmVkIGkg
PSAwOyBpIDwgdmFsLnNpemUoKTsgaSsrKQorICAgICAgICAgICAgYXBwZW5kKHZhbFtpXSk7Cisg
ICAgfQorICAgIAorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVDYXBhY2l0
eT4gdGVtcGxhdGU8dHlwZW5hbWUgVT4KICAgICBpbmxpbmUgdm9pZCBWZWN0b3I8VCwgaW5saW5l
Q2FwYWNpdHk+OjppbnNlcnQoc2l6ZV90IHBvc2l0aW9uLCBjb25zdCBVJiB2YWwpCiAgICAgewog
ICAgICAgICBBU1NFUlQocG9zaXRpb24gPD0gc2l6ZSgpKTsKSW5kZXg6IENoYW5nZUxvZwo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTc5KQorKysgQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDYtMDUtMDQgIEFuZGVycyBDYXJsc3NvbiAg
PGFuZGVyc2NhQG1hYy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiBreG1sY29yZS9WZWN0b3IuaDoKKyAgICAgICAgKEtYTUxDb3JlOjo6OmFw
cGVuZCk6CisgICAgICAgIE5ldyBmdW5jdGlvbiB0aGF0IHRha2VzIGFub3RoZXIgYXJyYXkuCisK
IDIwMDYtMDUtMDIgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBlcmljLgo=
</data>
<flag name="review"
          id="2248"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>