87338 2012-05-23 20:39:34 -0700 REGRESSION(r118297): It caused several layout failures on Mac (Requested by sundiamonde on #webkit). 2012-05-24 14:38:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87319 1 webkit.review.bot webkit.review.bot eae eric slewis oldest_to_newest 632370 0 webkit.review.bot 2012-05-23 20:39:34 -0700 http://trac.webkit.org/changeset/118297 broke the build: It caused several layout failures on Mac (Requested by sundiamonde on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 632373 1 143717 webkit.review.bot 2012-05-23 20:40:11 -0700 Created attachment 143717 ROLLOUT of r118297 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 632376 2 slewis 2012-05-23 20:43:18 -0700 The test caused several layout test to fail on Mac. See http://build.webkit.org/results/Lion%20Release%20(WebKit2%20Tests)/r118303%20(7493)/results.html +fast/block/float/floats-with-margin-should-not-wrap.html +fast/forms/001.html +fast/frames/flattening/iframe-tiny.html expected +fast/html/details-position.html +fast/replaced/width100percent-checkbox.html +fast/replaced/width100percent-radio.html +svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm +tables/mozilla/bugs/bug1318.html +tables/mozilla/bugs/bug4527.html Example diff: --- /Volumes/Data/slave/lion-intel-release-tests-wk2/build/layout-test-results/fast/forms/001-expected.txt +++ /Volumes/Data/slave/lion-intel-release-tests-wk2/build/layout-test-results/fast/forms/001-actual.txt @@ -19,16 +19,16 @@ RenderTable {TABLE} at (0,0) size 784x24 [border: (2px outset #808080)] RenderTableSection {TBODY} at (2,2) size 780x20 RenderTableRow {TR} at (0,0) size 780x20 - RenderTableCell {TD} at (0,0) size 20x20 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1] + RenderTableCell {TD} at (0,0) size 18x20 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1] RenderBlock {INPUT} at (3,4) size 12x12 - RenderTableCell {TD} at (20,9) size 760x2 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1] + RenderTableCell {TD} at (18,9) size 762x2 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1] RenderBlock {P} at (0,200) size 784x24 RenderTable {TABLE} at (0,0) size 784x24 [border: (2px outset #808080)] RenderTableSection {TBODY} at (2,2) size 780x20 RenderTableRow {TR} at (0,0) size 780x20 - RenderTableCell {TD} at (0,0) size 20x20 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1] + RenderTableCell {TD} at (0,0) size 18x20 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1] RenderBlock {INPUT} at (3,4) size 12x12 - RenderTableCell {TD} at (20,9) size 760x2 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1] + RenderTableCell {TD} at (18,9) size 762x2 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1] RenderBlock {P} at (0,240) size 784x28 RenderTable {TABLE} at (0,0) size 784x28 [border: (2px outset #808080)] RenderTableSection {TBODY} at (2,2) size 780x24 632382 3 143717 webkit.review.bot 2012-05-23 20:47:54 -0700 Comment on attachment 143717 ROLLOUT of r118297 Clearing flags on attachment: 143717 Committed r118318: <http://trac.webkit.org/changeset/118318> 632383 4 webkit.review.bot 2012-05-23 20:48:01 -0700 All reviewed patches have been landed. Closing bug. 632917 5 eae 2012-05-24 10:31:03 -0700 (In reply to comment #2) > The test caused several layout test to fail on Mac. See http://build.webkit.org/results/Lion%20Release%20(WebKit2%20Tests)/r118303%20(7493)/results.html > > +fast/block/float/floats-with-margin-should-not-wrap.html > +fast/forms/001.html > +fast/frames/flattening/iframe-tiny.html expected > +fast/html/details-position.html > +fast/replaced/width100percent-checkbox.html > +fast/replaced/width100percent-radio.html > +svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm > +tables/mozilla/bugs/bug1318.html > +tables/mozilla/bugs/bug4527.html fast/block/float/floats-with-margin-should-not-wrap.html was caused by this change the other tests though fail without the patch as well. Will fix the new test and re-land. 633218 6 slewis 2012-05-24 14:23:45 -0700 Can you explain what you mean by the other tests are failing anyway? I verified on my personal machine that the tests starting failing with 118297. The tests stopped failing on the bots after the rollout. * +fast/frames/flattening/iframe-tiny.html This test had just became flaky and is not related. 633222 7 eae 2012-05-24 14:26:09 -0700 (In reply to comment #6) > Can you explain what you mean by the other tests are failing anyway? I verified on my personal machine that the tests starting failing with 118297. The tests stopped failing on the bots after the rollout. > > * +fast/frames/flattening/iframe-tiny.html This test had just became flaky and is not related. I fail exactly the same set of tests with and without the patch. I tried on two different (mac) machines and got the same results on both. 633238 8 eae 2012-05-24 14:35:30 -0700 Argh, ignore my previous comment. There are certain tests that will need to have the text expectations rebaselined on some versions of mac, basically having the margin rebaselines from r115573 reverted. Sadly I forgot to include those baselines in the patch, which caused this confusion. I do apologize about that. 633246 9 eae 2012-05-24 14:38:21 -0700 And just for the record, rolling the change back was the right thing to do regardless as the new test was failing. 143717 2012-05-23 20:40:11 -0700 2012-05-23 20:47:54 -0700 ROLLOUT of r118297 bug-87338-20120524034426.patch text/plain 4110 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNkZWNhNDAxMGEwYTc3 Yjk2M2U4ZTQ4MjE2N2IyNmRmMWVlYTI2Yi4uODgwZDhhZjE2NDE2ODQzMzJmYmIxZDJlZTIzZGQw NDRiZDQ3Y2NjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTIzICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTE4Mjk3LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTgyOTcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg3MzM4CisKKyAgICAgICAgSXQgY2F1c2VkIHNldmVyYWwgbGF5b3V0IGZhaWx1 cmVzIG9uIE1hYyAoUmVxdWVzdGVkIGJ5CisgICAgICAgIHN1bmRpYW1vbmRlIG9uICN3ZWJraXQp LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJsb2NrOjpjb21wdXRlSW5saW5lUHJlZmVycmVkTG9naWNhbFdpZHRocyk6CisK IDIwMTItMDUtMjMgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTjogY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8tcG9zdGVyLmh0bWwgZmFpbHMgb24g TWFjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCBlNmE3M2Q5 YTQ3OWNiMjhlNjBjMzUxYTY0ZjUzOTk4ZjA0OTQ2NDAyLi40MDhjMmJkZmIxOGE3ZTc0YWQwZmNh MjBlMTIxZmRkNzU4YmQ3NjBmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAKQEAgLTU1MjMsNyArNTUyMyw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmNvbXB1dGVJbmxp bmVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKCkKICAgICAgICAgICAgICAgICAgICAgY2hpbGQtPnNl dFByZWZlcnJlZExvZ2ljYWxXaWR0aHNEaXJ0eShmYWxzZSk7CiAgICAgICAgICAgICAgICAgfSBl bHNlIHsKICAgICAgICAgICAgICAgICAgICAgLy8gSW5saW5lIHJlcGxhY2VkIGVsdHMgYWRkIGlu IHRoZWlyIG1hcmdpbnMgdG8gdGhlaXIgbWluL21heCB2YWx1ZXMuCi0gICAgICAgICAgICAgICAg ICAgIExheW91dFVuaXQgbWFyZ2lucyA9IDA7CisgICAgICAgICAgICAgICAgICAgIGZsb2F0IG1h cmdpbnMgPSAwOwogICAgICAgICAgICAgICAgICAgICBMZW5ndGggc3RhcnRNYXJnaW4gPSBjaGls ZFN0eWxlLT5tYXJnaW5TdGFydCgpOwogICAgICAgICAgICAgICAgICAgICBMZW5ndGggZW5kTWFy Z2luID0gY2hpbGRTdHlsZS0+bWFyZ2luRW5kKCk7CiAgICAgICAgICAgICAgICAgICAgIGlmIChz dGFydE1hcmdpbi5pc0ZpeGVkKCkpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzYxNjEzZWYzNmMwYmZhN2RlOTdlNGMxYjY1 Y2VhNzQ1MmQ5NWRiNy4uZmFlZWY5NWI2ZjRkYzRmOWNhNDc2NmM3MjU5MjJmODA1NzI4YjE0NiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTIzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5y ZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MTE4Mjk3LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMTgyOTcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MzM4CisK KyAgICAgICAgSXQgY2F1c2VkIHNldmVyYWwgbGF5b3V0IGZhaWx1cmVzIG9uIE1hYyAoUmVxdWVz dGVkIGJ5CisgICAgICAgIHN1bmRpYW1vbmRlIG9uICN3ZWJraXQpLgorCisgICAgICAgICogZmFz dC9ibG9jay9mbG9hdC9mbG9hdHMtd2l0aC1tYXJnaW4tc2hvdWxkLW5vdC13cmFwLWV4cGVjdGVk Lmh0bWw6IFJlbW92ZWQuCisgICAgICAgICogZmFzdC9ibG9jay9mbG9hdC9mbG9hdHMtd2l0aC1t YXJnaW4tc2hvdWxkLW5vdC13cmFwLmh0bWw6IFJlbW92ZWQuCisKIDIwMTItMDUtMjMgIFJhcGhh ZWwgS3VibyBkYSBDb3N0YSAgPHJha3Vjb0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdIEdh cmRlbmluZyBhZnRlciByMTE4MjAzIGFuZCByMTE4MTcxLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9ibG9jay9mbG9hdC9mbG9hdHMtd2l0aC1tYXJnaW4tc2hvdWxkLW5vdC13cmFwLWV4 cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0cy13aXRoLW1h cmdpbi1zaG91bGQtbm90LXdyYXAtZXhwZWN0ZWQuaHRtbApkZWxldGVkIGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggZTZlMGE2ZjNlZTVmMWJhMzEyODMwZTZhMTQyYjVjNjM3ZWQ2ZTFmOC4uMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2Jsb2NrL2Zsb2F0L2Zsb2F0cy13aXRoLW1hcmdpbi1zaG91bGQtbm90LXdyYXAtZXhwZWN0ZWQu aHRtbAorKysgL2Rldi9udWxsCkBAIC0xLDIyICswLDAgQEAKLTwhRE9DVFlQRT4KLTxodG1sPgot PGhlYWQ+Ci08c3R5bGU+Ci0gICAgYm9keSB7IHpvb206IDE1MCU7IH0KLSAgICAuY29udGFpbmVy IHsgZmxvYXQ6IGxlZnQ7IHBvc2l0aW9uOiByZWxhdGl2ZTsgbGVmdDogLTFweDsgfQotICAgIC5j b250YWluZXIgPiBkaXYgeyBmbG9hdDogbGVmdDsgd2lkdGg6IDE5cHg7IGJhY2tncm91bmQ6IG9y YW5nZTsgfQotICAgIC5ib3R0b20geyBjbGVhcjogYm90aDsgfQotPC9zdHlsZT4KLTwvaGVhZD4K LTxib2R5PgotCi08ZGl2IGNsYXNzPSJjb250YWluZXIiPgotICAgIDxkaXY+MTwvZGl2PgotICAg IDxkaXY+MjwvZGl2PgotICAgIDxkaXYgc3R5bGU9IndpZHRoOiAyMHB4OyI+MzwvZGl2PgotPC9k aXY+Ci0KLTxkaXYgY2xhc3M9ImJvdHRvbSI+VGhlIHRocmVlIGJsb2NrcyBhYm92ZSBzaG91bGQg YWxsIGJlIG9uIHRoZSBzYW1lIGxpbmUuPC9kaXY+Ci0KLTwvYm9keT4KLTwvaHRtbD4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvZmxvYXRzLXdpdGgtbWFyZ2luLXNo b3VsZC1ub3Qtd3JhcC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9mbG9hdC9mbG9hdHMt d2l0aC1tYXJnaW4tc2hvdWxkLW5vdC13cmFwLmh0bWwKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDA1ZWFlMTIwOTUwYjc2ZmM0MDk0MzM0ODE0Mjk3MDg2MTU0NmQyYjMuLjAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9i bG9jay9mbG9hdC9mbG9hdHMtd2l0aC1tYXJnaW4tc2hvdWxkLW5vdC13cmFwLmh0bWwKKysrIC9k ZXYvbnVsbApAQCAtMSwyMiArMCwwIEBACi08IURPQ1RZUEU+Ci08aHRtbD4KLTxoZWFkPgotPHN0 eWxlPgotICAgIGJvZHkgeyB6b29tOiAxNTAlOyB9Ci0gICAgLmNvbnRhaW5lciB7IGZsb2F0OiBs ZWZ0OyB9Ci0gICAgLmNvbnRhaW5lciA+IGRpdiB7IGZsb2F0OiBsZWZ0OyB3aWR0aDogMjBweDsg bWFyZ2luLWxlZnQ6IC0xcHg7IGJhY2tncm91bmQ6IG9yYW5nZTsgfQotICAgIC5ib3R0b20geyBj bGVhcjogYm90aDsgfQotPC9zdHlsZT4KLTwvaGVhZD4KLTxib2R5PgotCi08ZGl2IGNsYXNzPSJj b250YWluZXIiPgotICAgIDxkaXY+MTwvZGl2PgotICAgIDxkaXY+MjwvZGl2PgotICAgIDxkaXY+ MzwvZGl2PgotPC9kaXY+Ci0KLTxkaXYgY2xhc3M9ImJvdHRvbSI+VGhlIHRocmVlIGJsb2NrcyBh Ym92ZSBzaG91bGQgYWxsIGJlIG9uIHRoZSBzYW1lIGxpbmUuPC9kaXY+Ci0KLTwvYm9keT4KLTwv aHRtbD4K